18360 2008-04-08 05:05:31 -0700 "missing sentinel" warnings in PluginDatabaseGtk.cpp 2008-04-08 20:23:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 chpe webkit-unassigned alp oldest_to_newest 76597 0 chpe 2008-04-08 05:05:31 -0700 ../WebCore/plugins/gtk/PluginDatabaseGtk.cpp:51: warning: missing sentinel in function call [etc.] This stems from http://bugs.webkit.org/show_bug.cgi?id=17825#c2 . Since g_build_filename is a varargs call, the sentinel should be NULL, not 0. 76599 1 20403 chpe 2008-04-08 05:16:54 -0700 Created attachment 20403 patch 76671 2 20403 alp 2008-04-08 20:22:22 -0700 Comment on attachment 20403 patch r=me Needs some massaging to apply to TOT. 76672 3 alp 2008-04-08 20:23:03 -0700 Landed in r31747. 20403 2008-04-08 05:16:54 -0700 2008-04-08 20:22:22 -0700 patch 0001-Use-NULL-not-0-as-sentinel-in-varargs-calls.patch text/plain 3334 chpe RnJvbSAwMTQ2ZTZlZGI5Y2NiOWQwZWJkNTc2NjVlZWQ5ZTZkNGJjNjNkYmU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gUGVyc2NoIDxjaHBlQGdub21lLm9yZz4KRGF0 ZTogVHVlLCA4IEFwciAyMDA4IDEzOjU3OjI2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gVXNlIE5V TEwsIG5vdCAwIGFzIHNlbnRpbmVsIGluIHZhcmFyZ3MgY2FsbHMuCgotLS0KIFdlYkNvcmUvcGx1 Z2lucy9ndGsvUGx1Z2luRGF0YWJhc2VHdGsuY3BwIHwgICAyMCArKysrKysrKysrLS0tLS0tLS0t LQogMSBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpbkRhdGFiYXNlR3RrLmNwcCBiL1dl YkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luRGF0YWJhc2VHdGsuY3BwCmluZGV4IDc4MzkzODUuLjhm ZjljNWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luRGF0YWJhc2VHdGsu Y3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luRGF0YWJhc2VHdGsuY3BwCkBAIC00 OCw3ICs0OCw3IEBAIHZvaWQgUGx1Z2luRGF0YWJhc2U6OmdldFBsdWdpblBhdGhzSW5EaXJlY3Rv cmllcyhIYXNoU2V0PFN0cmluZz4mIHBhdGhzKSBjb25zdAogICAgICAgICAgICAgaWYgKCFnX3N0 cl9oYXNfc3VmZml4KG5hbWUsICIuIiBHX01PRFVMRV9TVUZGSVgpKQogICAgICAgICAgICAgICAg IGNvbnRpbnVlOwogCi0gICAgICAgICAgICBnY2hhciogZmlsZW5hbWUgPSBnX2J1aWxkX2ZpbGVu YW1lKChpdC0+dXRmOCgpKS5kYXRhKCksIG5hbWUsIDApOworICAgICAgICAgICAgZ2NoYXIqIGZp bGVuYW1lID0gZ19idWlsZF9maWxlbmFtZSgoaXQtPnV0ZjgoKSkuZGF0YSgpLCBuYW1lLCBOVUxM KTsKICAgICAgICAgICAgIHBhdGhzLmFkZChmaWxlbmFtZSk7CiAgICAgICAgICAgICBnX2ZyZWUo ZmlsZW5hbWUpOwogICAgICAgICB9CkBAIC02MSwxMCArNjEsMTAgQEAgVmVjdG9yPFN0cmluZz4g UGx1Z2luRGF0YWJhc2U6OmRlZmF1bHRQbHVnaW5EaXJlY3RvcmllcygpCiAgICAgVmVjdG9yPFN0 cmluZz4gZGlyZWN0b3JpZXM7CiAgICAgZ2NoYXIqIGRpcmVjdG9yeTsKIAotICAgIHBhdGggPSAw OworICAgIGRpcmVjdG9yeSA9IDA7CiAKICNpZiBkZWZpbmVkKEdES19XSU5ET1dJTkdfWDExKQot ICAgIGRpcmVjdG9yeSA9IGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfaG9tZV9kaXIoKSwgIi5tb3pp bGxhIiwgInBsdWdpbnMiLCAwKTsKKyAgICBkaXJlY3RvcnkgPSBnX2J1aWxkX2ZpbGVuYW1lKGdf Z2V0X2hvbWVfZGlyKCksICIubW96aWxsYSIsICJwbHVnaW5zIiwgTlVMTCk7CiAgICAgZGlyZWN0 b3JpZXMuYXBwZW5kKGRpcmVjdG9yeSk7CiAgICAgZ19mcmVlKGRpcmVjdG9yeSk7CiAKQEAgLTc4 LDE3ICs3OCwxNyBAQCBWZWN0b3I8U3RyaW5nPiBQbHVnaW5EYXRhYmFzZTo6ZGVmYXVsdFBsdWdp bkRpcmVjdG9yaWVzKCkKICAgICAgICAgZ19zdHJmcmVldihwbHVnaW5QYXRocyk7CiAgICAgfQog Ci0gICAgZGlyZWN0b3J5ID0gZ19idWlsZF9maWxlbmFtZShHX0RJUl9TRVBBUkFUT1JfUyAidXNy IiwgImxpYiIsICJicm93c2VyIiwgInBsdWdpbnMiLCAwKTsKKyAgICBkaXJlY3RvcnkgPSBnX2J1 aWxkX2ZpbGVuYW1lKEdfRElSX1NFUEFSQVRPUl9TICJ1c3IiLCAibGliIiwgImJyb3dzZXIiLCAi cGx1Z2lucyIsIE5VTEwpOwogICAgIGRpcmVjdG9yaWVzLmFwcGVuZChkaXJlY3RvcnkpOwogICAg IGdfZnJlZShkaXJlY3RvcnkpOwotICAgIGRpcmVjdG9yeSA9IGdfYnVpbGRfZmlsZW5hbWUoR19E SVJfU0VQQVJBVE9SX1MgInVzciIsICJsb2NhbCIsICJsaWIiLCAibW96aWxsYSIsICJwbHVnaW5z IiwgMCk7CisgICAgZGlyZWN0b3J5ID0gZ19idWlsZF9maWxlbmFtZShHX0RJUl9TRVBBUkFUT1Jf UyAidXNyIiwgImxvY2FsIiwgImxpYiIsICJtb3ppbGxhIiwgInBsdWdpbnMiLCBOVUxMKTsKICAg ICBkaXJlY3Rvcmllcy5hcHBlbmQoZGlyZWN0b3J5KTsKICAgICBnX2ZyZWUgKGRpcmVjdG9yeSk7 Ci0gICAgZGlyZWN0b3J5ID0gZ19idWlsZF9maWxlbmFtZShHX0RJUl9TRVBBUkFUT1JfUyAidXNy IiwgImxpYiIsICJtb3ppbGxhIiwgInBsdWdpbnMiLCAwKTsKKyAgICBkaXJlY3RvcnkgPSBnX2J1 aWxkX2ZpbGVuYW1lKEdfRElSX1NFUEFSQVRPUl9TICJ1c3IiLCAibGliIiwgIm1vemlsbGEiLCAi cGx1Z2lucyIsIE5VTEwpOwogICAgIGRpcmVjdG9yaWVzLmFwcGVuZChkaXJlY3RvcnkpOwogICAg IGdfZnJlZSAoZGlyZWN0b3J5KTsKICNlbGlmIGRlZmluZWQoR0RLX1dJTkRPV0lOR19XSU4zMikK LSAgICBkaXJlY3RvcnkgPSBnX2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X2hvbWVfZGlyKCksICJBcHBs aWNhdGlvbiBEYXRhIiwgIk1vemlsbGEiLCAicGx1Z2lucyIsIDApOworICAgIGRpcmVjdG9yeSA9 IGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfaG9tZV9kaXIoKSwgIkFwcGxpY2F0aW9uIERhdGEiLCAi TW96aWxsYSIsICJwbHVnaW5zIiwgTlVMTCk7CiAgICAgZGlyZWN0b3JpZXMuYXBwZW5kKGRpcmVj dG9yeSk7CiAgICAgZ19mcmVlKGRpcmVjdG9yeSk7CiAjZW5kaWYKQEAgLTEwNCwxMyArMTA0LDEz IEBAIGJvb2wgUGx1Z2luRGF0YWJhc2U6OmlzUHJlZmVycmVkUGx1Z2luRGlyZWN0b3J5KGNvbnN0 IFN0cmluZyYgZGlyZWN0b3J5KQogICAgIGhvbWVQYXRoID0gMDsKIAogI2lmIGRlZmluZWQoR0RL X1dJTkRPV0lOR19YMTEpCi0gICAgaG9tZVBhdGggPSBnX2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X2hv bWVfZGlyKCksICIubW96aWxsYSIsICJwbHVnaW5zIiwgMCk7CisgICAgaG9tZVBhdGggPSBnX2J1 aWxkX2ZpbGVuYW1lKGdfZ2V0X2hvbWVfZGlyKCksICIubW96aWxsYSIsICJwbHVnaW5zIiwgTlVM TCk7CiAjZWxpZiBkZWZpbmVkKEdES19XSU5ET1dJTkdfV0lOMzIpCi0gICAgaG9tZVBhdGggPSBn X2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X2hvbWVfZGlyKCksICJBcHBsaWNhdGlvbiBEYXRhIiwgIk1v emlsbGEiLCAicGx1Z2lucyIsIDApOworICAgIGhvbWVQYXRoID0gZ19idWlsZF9maWxlbmFtZShn X2dldF9ob21lX2RpcigpLCAiQXBwbGljYXRpb24gRGF0YSIsICJNb3ppbGxhIiwgInBsdWdpbnMi LCBOVUxMKTsKICNlbmRpZgogCiAgICAgaWYgKGhvbWVQYXRoKQotCXJldHZhbCA9IChzdHJjbXAo aG9tZVBhdGgsIChwYXRoLnV0ZjgoKSkuZGF0YSgpKSA9PSAwKTsKKwlyZXR2YWwgPSAoc3RyY21w KGhvbWVQYXRoLCAoZGlyZWN0b3J5LnV0ZjgoKSkuZGF0YSgpKSA9PSAwKTsKIAogICAgIHJldHVy biByZXR2YWw7CiB9Ci0tIAoxLjUuMy5HSVQKCg==