183591 2018-03-13 03:27:34 -0700 [MSE][GStreamer] Provide a test for r237033 2020-12-11 13:34:43 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 1 bandou.yacine webkit-unassigned aperez bugs-noreply calvaris cturner loic.yhuel olivier.blin peng.liu6 pnormand oldest_to_newest 1406088 0 bandou.yacine 2018-03-13 03:27:34 -0700 Swap the aspectRatioNumerator and aspectRatioDenomirator in the formula. "height * (static_cast<float>(pixelAspectRatioDenominator) / static_cast<float>(pixelAspectRatioNumerator))" instead of "height * (static_cast<float>(pixelAspectRatioNumerator) / static_cast<float>(pixelAspectRatioDenominator))" 1406089 1 335687 bandou.yacine 2018-03-13 03:36:22 -0700 Created attachment 335687 Patch 1406094 2 335687 calvaris 2018-03-13 04:33:30 -0700 Comment on attachment 335687 Patch Oops! I think it would be nice to have a test for this does not happen again. 1406637 3 bandou.yacine 2018-03-15 02:50:39 -0700 (In reply to Xabier Rodríguez Calvar from comment #2) > Comment on attachment 335687 [details] > Patch > > Oops! > > I think it would be nice to have a test for this does not happen again. I'll see what I can do for the test. 1445442 4 aperez 2018-07-26 09:21:59 -0700 (In reply to Yacine Bandou from comment #3) > (In reply to Xabier Rodríguez Calvar from comment #2) > > Comment on attachment 335687 [details] > > Patch > > > > Oops! > > > > I think it would be nice to have a test for this does not happen again. > > I'll see what I can do for the test. Hi Yacine! Are you still willing to write a test case for this? Note that the function was moved to “GStramerCommon.cpp” a while ago. 1445450 5 bandou.yacine 2018-07-26 09:56:16 -0700 Lack of time, I can't do it now. 1468008 6 pnormand 2018-10-11 04:44:59 -0700 *** This bug has been marked as a duplicate of bug 190464 *** 1468022 7 calvaris 2018-10-11 06:48:54 -0700 I did a lousy review of bug 190464 and we should keep this open to track a possible test so that that bug does not regress. Besides, it's a pity that the patch does not have the proper author, who should be Yacine, sorry for that. 335687 2018-03-13 03:36:22 -0700 2020-12-11 13:34:43 -0800 Patch bug-183591-20180313113621.patch text/plain 1845 bandou.yacine U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWQ4NWM0ZDZmYjJhZDJi MjFhZmZlN2YwYTA3NTQzZWM4YmExOTJkMy4uYTJjY2Q5NmJmMDkyMmE1YzcxN2Q2YWU0YjNjMTBl ZWVmNDlmZmMyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAzLTEzICBZYWNp bmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAg W01TRV1bR1N0cmVhbWVyXSBGaXggdGhlIGZvcm11bGEgdXNpbmcgdGhlIHBpeGVsLWFzcGVjdC1y YXRpbyBhZnRlciByMjI4MzE2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODM1OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBTd2FwIHRoZSBhc3BlY3RSYXRpb051bWVyYXRvciBhbmQgYXNwZWN0UmF0aW9E ZW5vbWlyYXRvciB3aGVuIHdlIGNhbGN1bGF0ZSB0aGUgaGVpZ2h0LgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclV0aWxpdGllcy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpnZXRWaWRlb1Jlc29sdXRpb25Gcm9tQ2Fwcyk6CisKIDIwMTgtMDMtMTIgIEpv aG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzb3VyY2UgTG9h ZCBTdGF0aXN0aWNzOiBJbW1lZGlhdGVseSBmb3J3YXJkIGNvb2tpZSBhY2Nlc3MgYXQgdXNlciBp bnRlcmFjdGlvbiB3aGVuIHRoZXJlJ3MgYW4gb3BlbmVyIGRvY3VtZW50CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVXRpbGl0 aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3Ry ZWFtZXJVdGlsaXRpZXMuY3BwCmluZGV4IDE5MzU0NzAwMTJiMjU3ODJmYzE4NmQ5ZmEzZWIxZjhl MTZkMDA1ZmYuLmQ1NmUxZGJkY2U3ODY5MWY5YTY4NTdlYjYyN2E0Y2U5MWMxMWIxZWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFt ZXJVdGlsaXRpZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9HU3RyZWFtZXJVdGlsaXRpZXMuY3BwCkBAIC0xMjMsNyArMTIzLDcgQEAgc3RkOjpv cHRpb25hbDxGbG9hdFNpemU+IGdldFZpZGVvUmVzb2x1dGlvbkZyb21DYXBzKGNvbnN0IEdzdENh cHMqIGNhcHMpCiAgICAgICAgIHBpeGVsQXNwZWN0UmF0aW9EZW5vbWluYXRvciA9IEdTVF9WSURF T19JTkZPX1BBUl9EKCZpbmZvKTsKICAgICB9CiAKLSAgICByZXR1cm4gc3RkOjptYWtlX29wdGlv bmFsKEZsb2F0U2l6ZSh3aWR0aCwgaGVpZ2h0ICogKHN0YXRpY19jYXN0PGZsb2F0PihwaXhlbEFz cGVjdFJhdGlvTnVtZXJhdG9yKSAvIHN0YXRpY19jYXN0PGZsb2F0PihwaXhlbEFzcGVjdFJhdGlv RGVub21pbmF0b3IpKSkpOworICAgIHJldHVybiBzdGQ6Om1ha2Vfb3B0aW9uYWwoRmxvYXRTaXpl KHdpZHRoLCBoZWlnaHQgKiAoc3RhdGljX2Nhc3Q8ZmxvYXQ+KHBpeGVsQXNwZWN0UmF0aW9EZW5v bWluYXRvcikgLyBzdGF0aWNfY2FzdDxmbG9hdD4ocGl4ZWxBc3BlY3RSYXRpb051bWVyYXRvcikp KSk7CiB9CiAKIGJvb2wgZ2V0U2FtcGxlVmlkZW9JbmZvKEdzdFNhbXBsZSogc2FtcGxlLCBHc3RW aWRlb0luZm8mIHZpZGVvSW5mbykK