183588 2018-03-12 20:25:34 -0700 fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates 2018-03-13 11:08:20 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180568 1 cdumez cdumez achristensen beidson commit-queue rniwa webkit-bug-importer youennf oldest_to_newest 1406060 0 cdumez 2018-03-12 20:25:34 -0700 fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates: --- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt +++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt @@ -1,2 +1 @@ -Blocked access to external URL http://does.not.exist/ PASS - Javascript URL blocked without crashing. 1406063 1 cdumez 2018-03-12 20:27:44 -0700 Also: --- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt +++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt @@ -1,2 +1,2 @@ -Blocked access to external URL http://does.not.exist/ +ALERT: FAIL PASS - Javascript URL blocked without crashing. 1406133 2 335701 cdumez 2018-03-13 10:00:01 -0700 Created attachment 335701 Patch 1406162 3 335701 rniwa 2018-03-13 11:06:18 -0700 Comment on attachment 335701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335701&action=review > LayoutTests/ChangeLog:15 > + I checked that this test was printing the "FAIL" alert in both Firefox and Chrome before > + this change. So both Chrome & Firefox run javascript protocol async? 1406163 4 335701 commit-queue 2018-03-13 11:07:35 -0700 Comment on attachment 335701 Patch Clearing flags on attachment: 335701 Committed r229579: <https://trac.webkit.org/changeset/229579> 1406164 5 commit-queue 2018-03-13 11:07:36 -0700 All reviewed patches have been landed. Closing bug. 1406165 6 webkit-bug-importer 2018-03-13 11:08:20 -0700 <rdar://problem/38423408> 335701 2018-03-13 10:00:01 -0700 2018-03-13 11:07:35 -0700 Patch bug-183588-20180313100000.patch text/plain 4290 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTc3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggN2I0OTI0MmNhMGJlZGVlZGI3ZmFj MDRiMjc4MDBlNTBjNGQxZDg5Yy4uMzViNGQzYzdmODQ0MTZlMjEzMjUzM2I4M2NlZWU2NTQ4Y2Jh N2U0NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAzLTEzICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwtaWZy YW1lLXJlbW92ZS1vbi1uYXZpZ2F0ZS5odG1sIGlzIGZsYWt5IHdpdGggYXN5bmMgcG9saWN5IGRl bGVnYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTgzNTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIHRlc3Qgd2FzIHNldHRpbmcgdGhlIGZyYW1lJ3Mgc3JjIHRvIGEgamF2YXNjcmlwdCBVUkwg aW4gYSBzZXRUaW1lb3V0KDApLCBleHBlY3RpbmcgdGhlCisgICAgICAgIG5hdmlnYXRpb24gcG9s aWN5IGRlbGVnYXRlIHRvIGhhdmUgYWxyZWFkeSBjb21wbGV0ZWQuIEhvd2V2ZXIsIHdpdGggYXN5 bmNocm9ub3VzIHBvbGljeQorICAgICAgICBkZWxlZ2F0ZXMsIHRoaXMgaXMgbm90IG5lY2Vzc2Fy aWx5IHRoZSBjYXNlLiBUaGVyZWZvcmUsIHdlIG5vdyB3YWl0IGZvciB0aGUgYmVmb3JldW5sb2Fk CisgICAgICAgIGV2ZW50IHRvIGJlIGZpcmVkIGF0IHRoZSB3aW5kb3csIHNpbmNlIHRoaXMgaW5k aWNhdGVzIGEgcG9saWN5IGRlY2lzaW9uIGhhcyBiZWVuIG1hZGUgYW5kCisgICAgICAgIHdlIGFy ZSBhY3R1YWxseSBuYXZpZ2F0aW5nLgorCisgICAgICAgIEkgY2hlY2tlZCB0aGF0IHRoaXMgdGVz dCB3YXMgcHJpbnRpbmcgdGhlICJGQUlMIiBhbGVydCBpbiBib3RoIEZpcmVmb3ggYW5kIENocm9t ZSBiZWZvcmUKKyAgICAgICAgdGhpcyBjaGFuZ2UuCisKKyAgICAgICAgKiBmYXN0L2xvYWRlci9q YXZhc2NyaXB0LXVybC1pZnJhbWUtcmVtb3ZlLW9uLW5hdmlnYXRlLWFzeW5jLWRlbGVnYXRlLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwt aWZyYW1lLXJlbW92ZS1vbi1uYXZpZ2F0ZS1hc3luYy1kZWxlZ2F0ZS5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2xvYWRlci9qYXZhc2NyaXB0LXVybC1pZnJhbWUtcmVtb3ZlLW9uLW5hdmln YXRlLmh0bWw6CisKIDIwMTgtMDMtMTMgIERhbnlhbyBXYW5nICA8ZGFueWFvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcGFnZS1jYWNo ZS1pZnJhbWUtcHJvdmlzaW9uYWwtbG9hZC5odG1sIGZhaWxzIHdpdGggYXN5bmMgcG9saWN5IGRl bGVnYXRlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9qYXZhc2NyaXB0LXVy bC1pZnJhbWUtcmVtb3ZlLW9uLW5hdmlnYXRlLWFzeW5jLWRlbGVnYXRlLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2phdmFzY3JpcHQtdXJsLWlmcmFtZS1yZW1vdmUtb24t bmF2aWdhdGUtYXN5bmMtZGVsZWdhdGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdiNGRmNjY4 N2Q5ODg0YTcxZjA1YzMyMWRkZTQzMTkwNDgyNTM5Y2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2xvYWRlci9qYXZhc2NyaXB0LXVybC1pZnJhbWUtcmVtb3ZlLW9uLW5hdmln YXRlLWFzeW5jLWRlbGVnYXRlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK0Jsb2NrZWQg YWNjZXNzIHRvIGV4dGVybmFsIFVSTCBodHRwOi8vZG9lcy5ub3QuZXhpc3QvCitQQVNTIC0gSmF2 YXNjcmlwdCBVUkwgYmxvY2tlZCB3aXRob3V0IGNyYXNoaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwtaWZyYW1lLXJlbW92ZS1vbi1uYXZpZ2F0 ZS1hc3luYy1kZWxlZ2F0ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvamF2YXNjcmlw dC11cmwtaWZyYW1lLXJlbW92ZS1vbi1uYXZpZ2F0ZS1hc3luYy1kZWxlZ2F0ZS5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmMwNDE1MGUwNjg2MmE3Y2RhYWJmYWM3N2ZlZmIxMjBhMDczZWRhNDAKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9qYXZhc2NyaXB0LXVybC1pZnJhbWUt cmVtb3ZlLW9uLW5hdmlnYXRlLWFzeW5jLWRlbGVnYXRlLmh0bWwKQEAgLTAsMCArMSwyMiBAQAor PGlmcmFtZSBzcmM9Imh0dHA6Ly9kb2VzLm5vdC5leGlzdC8iIGlkPSJ0YXJnZXQiPjwvaWZyYW1l PgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5uZXIuZHVt cEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIGlmICh0ZXN0 UnVubmVyLnNldFNob3VsZERlY2lkZU5hdmlnYXRpb25Qb2xpY3lBZnRlckRlbGF5KQorICAgICAg ICB0ZXN0UnVubmVyLnNldFNob3VsZERlY2lkZU5hdmlnYXRpb25Qb2xpY3lBZnRlckRlbGF5KHRy dWUpOworfQorCitsZXQgZnJhbWUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iik7 CitmcmFtZS5jb250ZW50V2luZG93Lm9uYmVmb3JldW5sb2FkID0gZnVuY3Rpb24oKSB7CisgICAg c2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgZnJhbWUuc3JjID0gImphdmFzY3JpcHQ6 YWxlcnQoJ0ZBSUwnKSI7CisgICAgfSwgMCk7Cit9OworCit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5l cigibG9hZCIsIGZ1bmN0aW9uKCkgeworICAgIGRvY3VtZW50LndyaXRlKCJQQVNTIC0gSmF2YXNj cmlwdCBVUkwgYmxvY2tlZCB3aXRob3V0IGNyYXNoaW5nLiIpOworICAgIGlmICh3aW5kb3cudGVz dFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9LCBmYWxzZSk7Cis8 L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2phdmFzY3JpcHQt dXJsLWlmcmFtZS1yZW1vdmUtb24tbmF2aWdhdGUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbG9h ZGVyL2phdmFzY3JpcHQtdXJsLWlmcmFtZS1yZW1vdmUtb24tbmF2aWdhdGUuaHRtbAppbmRleCA4 NzhmOGVjMDg2NWM4OTc1YTNhMzVkNjAxOGMyOGU2MDJlNGRiMGZlLi4xNTAxZTJjM2FkYjI1MmE0 M2FkNTQ3Nzk4MmM3N2RiNzMwMTI2MDBiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2xv YWRlci9qYXZhc2NyaXB0LXVybC1pZnJhbWUtcmVtb3ZlLW9uLW5hdmlnYXRlLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvamF2YXNjcmlwdC11cmwtaWZyYW1lLXJlbW92ZS1vbi1u YXZpZ2F0ZS5odG1sCkBAIC01LDEzICs1LDE2IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewog ICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOwogfQogCi1zZXRUaW1lb3V0KGZ1bmN0aW9u KCkgewotICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iikuc3JjID0gImph dmFzY3JpcHQ6YWxlcnQoJ0ZBSUwnKSI7CitsZXQgZnJhbWUgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGFyZ2V0Iik7CitmcmFtZS5jb250ZW50V2luZG93Lm9uYmVmb3JldW5sb2FkID0gZnVu Y3Rpb24oKSB7CisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgZnJhbWUuc3Jj ID0gImphdmFzY3JpcHQ6YWxlcnQoJ0ZBSUwnKSI7CiAgICAgfSwgMCk7Cit9OwogCiB3aW5kb3cu YWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIGZ1bmN0aW9uKCkgewotICAgICAgICBkb2N1bWVudC53 cml0ZSgiUEFTUyAtIEphdmFzY3JpcHQgVVJMIGJsb2NrZWQgd2l0aG91dCBjcmFzaGluZy4iKTsK LSAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQotICAgICAgICAgICAgdGVzdFJ1bm5lci5u b3RpZnlEb25lKCk7Ci0gICAgfSwgZmFsc2UpOworICAgIGRvY3VtZW50LndyaXRlKCJQQVNTIC0g SmF2YXNjcmlwdCBVUkwgYmxvY2tlZCB3aXRob3V0IGNyYXNoaW5nLiIpOworICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9LCBmYWxz ZSk7CiA8L3NjcmlwdD4K