183584 2018-03-12 16:28:22 -0700 Ignore some deprecation warnings encountered when compiling with newer versions of ICU 2018-03-12 16:54:29 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183355 InRadar P2 Normal --- 1 bburg bburg bburg dbates mitz mmaxfield webkit-bug-importer oldest_to_newest 1405966 0 bburg 2018-03-12 16:28:22 -0700 . 1405967 1 bburg 2018-03-12 16:28:42 -0700 <rdar://problem/38395317> 1405970 2 335662 bburg 2018-03-12 16:32:54 -0700 Created attachment 335662 Patch 1405971 3 bburg 2018-03-12 16:33:36 -0700 Reviewed offline by dbates. 1405972 4 335662 mmaxfield 2018-03-12 16:37:12 -0700 Comment on attachment 335662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335662&action=review > Source/WebCore/editing/TextIterator.cpp:2004 > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" Usually we do this around each individual call. > Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp:74 > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" Ditto. > Source/WebCore/platform/text/TextEncoding.cpp:74 > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" Ditto. 1405980 5 bburg 2018-03-12 16:46:11 -0700 Committed r229564: <https://trac.webkit.org/changeset/229564> 1405982 6 mitz 2018-03-12 16:54:29 -0700 Please just bug 183355 already. 335662 2018-03-12 16:32:54 -0700 2018-03-12 16:43:58 -0700 Patch bug-183584-20180312163253.patch text/plain 4311 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTNlOGE0ZDdjMDlkYjIw YTM2N2JkMGE4MDY5YzRkZGNmMmI0ZGMzMC4uYTYxMDA5MjY4YmFhYzAzMmEzNjQwMjhjNWU0ZDdh Y2Y0OWE2Y2QxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAzLTEyICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIElnbm9yZSBzb21lIGRlcHJlY2F0 aW9uIHdhcm5pbmdzIGVuY291bnRlcmVkIHdoZW4gY29tcGlsaW5nIHdpdGggbmV3ZXIgdmVyc2lv bnMgb2YgSUNVCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODM1ODQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4Mzk1MzE3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IERhbmllbCBCYXRlcy4KKworICAgICAgICBJZ25vcmUgbmV3IGRlcHJlY2F0aW9u IHdhcm5pbmdzLiBXaGVyZSBhIGZ1bmN0aW9uIGhhcyBtb3JlIHRoYW4gb25lCisgICAgICAgIGRl cHJlY2F0aW9uIHdhcm5pbmcsIG1hcmsgb3V0IHRoZSBlbnRpcmUgZnVuY3Rpb24gc28gaXQgcmVt YWlucyByZWFkYWJsZS4KKworICAgICAgICAqIGVkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9TdXJyb2dhdGVQYWlyQXdhcmVUZXh0SXRlcmF0b3Iu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U3Vycm9nYXRlUGFpckF3YXJlVGV4dEl0ZXJhdG9yOjpu b3JtYWxpemVWb2ljaW5nTWFya3MpOgorICAgICAgICAqIHBsYXRmb3JtL3RleHQvVGV4dEVuY29k aW5nLmNwcDoKKwogMjAxOC0wMy0xMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+ CiAKICAgICAgICAgUlRDUGVlckNvbm5lY3Rpb24ncyBjbG9zZSBtZXRob2Qgc2hvdWxkIHVwZGF0 ZSBzaWduYWxpbmdTdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0 SXRlcmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0SXRlcmF0b3IuY3BwCmlu ZGV4IDAwM2UwYjJmMGQ0MWY5Yjg3ZWFmZDFiMmFjNzc4MmM1ZTQzYzNmYmQuLjY1NzRmMWVkNTdk MGVkMmI4NzIwZTBjODJiODRhODYyZTJlMjA0NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvVGV4dEl0ZXJhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1Rl eHRJdGVyYXRvci5jcHAKQEAgLTE5OTksNiArMTk5OSwxMiBAQCBzdGF0aWMgaW5saW5lIGJvb2wg Y29udGFpbnNLYW5hTGV0dGVycyhjb25zdCBTdHJpbmcmIHBhdHRlcm4pCiAgICAgcmV0dXJuIGZh bHNlOwogfQogCisjaWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMg cHVzaAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XZGVwcmVjYXRlZC1kZWNs YXJhdGlvbnMiCisjZW5kaWYKKy8vIE5PVEU6IElDVSdzIHVub3JtX25vcm1hbGl6ZSBmdW5jdGlv biBpcyBkZXByZWNhdGVkIGluIHNvbWUgU0RLcy4KKwogc3RhdGljIHZvaWQgbm9ybWFsaXplQ2hh cmFjdGVycyhjb25zdCBVQ2hhciogY2hhcmFjdGVycywgdW5zaWduZWQgbGVuZ3RoLCBWZWN0b3I8 VUNoYXI+JiBidWZmZXIpCiB7CiAgICAgQVNTRVJUKGxlbmd0aCk7CkBAIC0yMDIwLDYgKzIwMjYs MTAgQEAgc3RhdGljIHZvaWQgbm9ybWFsaXplQ2hhcmFjdGVycyhjb25zdCBVQ2hhciogY2hhcmFj dGVycywgdW5zaWduZWQgbGVuZ3RoLCBWZWN0b3IKICAgICBBU1NFUlQoc3RhdHVzID09IFVfU1RS SU5HX05PVF9URVJNSU5BVEVEX1dBUk5JTkcpOwogfQogCisjaWYgQ09NUElMRVIoQ0xBTkcpCisj cHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcG9wCisjZW5kaWYKKwogc3RhdGljIGJvb2wgaXNOb25M YXRpbjFTZXBhcmF0b3IoVUNoYXIzMiBjaGFyYWN0ZXIpCiB7CiAgICAgQVNTRVJUX0FSRyhjaGFy YWN0ZXIsIGNoYXJhY3RlciA+PSAyNTYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvU3Vycm9nYXRlUGFpckF3YXJlVGV4dEl0ZXJhdG9yLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1N1cnJvZ2F0ZVBhaXJBd2FyZVRleHRJdGVyYXRv ci5jcHAKaW5kZXggNjgyZDk4ZTI1MzVjMmRiNGI3YWUxMzBiNTNjZDE2MmQwYjY5ZTFmNS4uM2Fh ZTdlZDQ5Mjg2OTZkZGVkZDBkNDk3OTk5OGQzOTkwM2Y3N2JkNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU3Vycm9nYXRlUGFpckF3YXJlVGV4dEl0ZXJhdG9y LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9TdXJyb2dhdGVQYWly QXdhcmVUZXh0SXRlcmF0b3IuY3BwCkBAIC02OSw2ICs2OSwxMiBAQCBib29sIFN1cnJvZ2F0ZVBh aXJBd2FyZVRleHRJdGVyYXRvcjo6Y29uc3VtZVNsb3dDYXNlKFVDaGFyMzImIGNoYXJhY3Rlciwg dW5zaWduZQogICAgIHJldHVybiB0cnVlOwogfQogCisjaWYgQ09NUElMRVIoQ0xBTkcpCisjcHJh Z21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9y ZWQgIi1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnMiCisjZW5kaWYKKy8vIE5PVEU6IElDVSdzIHVu b3JtX25vcm1hbGl6ZSBmdW5jdGlvbiBpcyBkZXByZWNhdGVkIGluIHNvbWUgU0RLcy4KKwogVUNo YXIzMiBTdXJyb2dhdGVQYWlyQXdhcmVUZXh0SXRlcmF0b3I6Om5vcm1hbGl6ZVZvaWNpbmdNYXJr cygpCiB7CiAgICAgLy8gQWNjb3JkaW5nIHRvIGh0dHA6Ly93d3cudW5pY29kZS5vcmcvUHVibGlj L1VOSURBVEEvVUNELmh0bWwjQ2Fub25pY2FsX0NvbWJpbmluZ19DbGFzc19WYWx1ZXMKQEAgLTg5 LDQgKzk1LDggQEAgVUNoYXIzMiBTdXJyb2dhdGVQYWlyQXdhcmVUZXh0SXRlcmF0b3I6Om5vcm1h bGl6ZVZvaWNpbmdNYXJrcygpCiAgICAgcmV0dXJuIDA7CiB9CiAKKyNpZiBDT01QSUxFUihDTEFO RykKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKyNlbmRpZgorCiB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5jcHAKaW5kZXggNTJkMTc5NDJjNWZk NjUyNTI5M2NmYjdiZmZiMjkzNTc2MzAwYjhiMi4uMTc5MmY4NzkzY2I3ZDQzYmVkM2M3MmE2MzUw NTlkZjlkYzgwN2RiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9U ZXh0RW5jb2RpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVu Y29kaW5nLmNwcApAQCAtNjksNiArNjksMTIgQEAgU3RyaW5nIFRleHRFbmNvZGluZzo6ZGVjb2Rl KGNvbnN0IGNoYXIqIGRhdGEsIHNpemVfdCBsZW5ndGgsIGJvb2wgc3RvcE9uRXJyb3IsIGIKICAg ICByZXR1cm4gbmV3VGV4dENvZGVjKCp0aGlzKS0+ZGVjb2RlKGRhdGEsIGxlbmd0aCwgdHJ1ZSwg c3RvcE9uRXJyb3IsIHNhd0Vycm9yKTsKIH0KIAorI2lmIENPTVBJTEVSKENMQU5HKQorI3ByYWdt YSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVk ICItV2RlcHJlY2F0ZWQtZGVjbGFyYXRpb25zIgorI2VuZGlmCisvLyBOT1RFOiBJQ1UncyB1bm9y bV9xdWlja0NoZWNrIGFuZCB1bm9ybV9ub3JtYWxpemUgZnVuY3Rpb25zIGFyZSBkZXByZWNhdGVk IGluIHNvbWUgU0RLcy4KKwogVmVjdG9yPHVpbnQ4X3Q+IFRleHRFbmNvZGluZzo6ZW5jb2RlKFN0 cmluZ1ZpZXcgdGV4dCwgVW5lbmNvZGFibGVIYW5kbGluZyBoYW5kbGluZykgY29uc3QKIHsKICAg ICBpZiAoIW1fbmFtZSB8fCB0ZXh0LmlzRW1wdHkoKSkKQEAgLTEwNiw2ICsxMTIsMTAgQEAgVmVj dG9yPHVpbnQ4X3Q+IFRleHRFbmNvZGluZzo6ZW5jb2RlKFN0cmluZ1ZpZXcgdGV4dCwgVW5lbmNv ZGFibGVIYW5kbGluZyBoYW5kbGkKICAgICByZXR1cm4gbmV3VGV4dENvZGVjKCp0aGlzKS0+ZW5j b2RlKFN0cmluZ1ZpZXcgeyBzb3VyY2UsIHNvdXJjZUxlbmd0aCB9LCBoYW5kbGluZyk7CiB9CiAK KyNpZiBDT01QSUxFUihDTEFORykKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKKyNlbmRp ZgorCiBjb25zdCBjaGFyKiBUZXh0RW5jb2Rpbmc6OmRvbU5hbWUoKSBjb25zdAogewogICAgIGlm IChub0V4dGVuZGVkVGV4dEVuY29kaW5nTmFtZVVzZWQoKSkK