18357 2008-04-08 02:55:03 -0700 [GTK] Enter on buttons doesn't work 2008-04-19 19:50:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P3 Normal --- 1 marco.barisione webkit-unassigned alp ap oldest_to_newest 76591 0 marco.barisione 2008-04-08 02:55:03 -0700 It's possible to navigate among links and widgets using TAB and shift-TABS but then it's impossible to emulate a click on a button using the ENTER key. 76592 1 20402 marco.barisione 2008-04-08 03:06:49 -0700 Created attachment 20402 Set the text of the event to '\r' when the return/enter key is pressed Note that I used '\r' instead of '\n' because it's what WebCore use. Probably it's better to use '\n' modifying WebCore to allow this, but I think there could be a lot of places in WebCore where the code assumes that enter is '\r'. What do you think? 78033 2 alp 2008-04-17 17:22:48 -0700 (In reply to comment #1) > Created an attachment (id=20402) [edit] > Set the text of the event to '\r' when the return/enter key is pressed > > Note that I used '\r' instead of '\n' because it's what WebCore use. Probably > it's better to use '\n' modifying WebCore to allow this, but I think there > could be a lot of places in WebCore where the code assumes that enter is '\r'. > What do you think? > Yeah. While this fix looks like it'll work I think it'd be great to investigate if this can be fixed better in WebCore. Marco: It's up to you. I can land this patch if you're willing to follow it up with a proper fix (if necessary), or I can leave it out till we get a better idea of how to proceed. It might be worth talking with ap (Alexey) about this one, he has a good eye for input issues. 78068 3 20402 ap 2008-04-17 23:56:49 -0700 Comment on attachment 20402 Set the text of the event to '\r' when the return/enter key is pressed It's surprising that gdk_keyval_to_unicode doesn't handle these keys - what is the story behind this? I couldn't find any hints in documentation. Are there any other keys that need to be special cased? Yes, it is correct to use \r here - JavaScript code on the Web expects to see 0x13 in keypress.charCode, so this is not just internal to WebCore. I have noticed that windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and GDK_KP_Enter - this looks worth fixing, too. r=me 78083 4 marco.barisione 2008-04-18 03:41:30 -0700 (In reply to comment #3) > It's surprising that gdk_keyval_to_unicode doesn't handle these keys - what is > the story behind this? I couldn't find any hints in documentation. Are there > any other keys that need to be special cased? I don't know (I will ping someone on IRC about this) but probably it would return \n not \r, so we would need to special case it even if gdk was changed. Alp, can you commit the patch? > I have noticed that windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and > GDK_KP_Enter - this looks worth fixing, too. Opened another bug on this (bug #18576). 78284 5 alp 2008-04-19 19:50:43 -0700 Landed in r32246. Barisione, can you open another bug if there are other places this needs to be fixed or if it turns out we can fix this in a better place? Cheers 20402 2008-04-08 03:06:49 -0700 2008-04-17 23:56:49 -0700 Set the text of the event to '\r' when the return/enter key is pressed return-text.patch text/plain 1897 marco.barisione SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAJKHJldmlzaW9uZSAzMTYzMykK KysrIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAkoY29waWEgbG9jYWxlKQpA QCAtNDcwLDE5ICs0NzAsMjYgQEAKIAogc3RhdGljIFN0cmluZyBzaW5nbGVDaGFyYWN0ZXJTdHJp bmcoZ3VpbnQgdmFsKQogewotICAgIGdsb25nIG53YzsKLSAgICBTdHJpbmcgcmV0VmFsOwotICAg IGd1bmljaGFyIGMgPSBnZGtfa2V5dmFsX3RvX3VuaWNvZGUodmFsKTsKLSAgICBndW5pY2hhcjIq IHVjaGFyMTYgPSBnX3VjczRfdG9fdXRmMTYoJmMsIDEsIDAsICZud2MsIDApOworICAgIHN3aXRj aCAodmFsKSB7CisgICAgICAgIGNhc2UgR0RLX0lTT19FbnRlcjoKKyAgICAgICAgY2FzZSBHREtf S1BfRW50ZXI6CisgICAgICAgIGNhc2UgR0RLX1JldHVybjoKKyAgICAgICAgICAgIHJldHVybiBT dHJpbmcoIlxyIik7CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICBndW5pY2hhciBjID0g Z2RrX2tleXZhbF90b191bmljb2RlKHZhbCk7CisgICAgICAgICAgICBnbG9uZyBud2M7CisgICAg ICAgICAgICBndW5pY2hhcjIqIHVjaGFyMTYgPSBnX3VjczRfdG9fdXRmMTYoJmMsIDEsIDAsICZu d2MsIDApOwogCi0gICAgaWYgKHVjaGFyMTYpCi0gICAgICAgIHJldFZhbCA9IFN0cmluZygoVUNo YXIqKXVjaGFyMTYsIG53Yyk7Ci0gICAgZWxzZQotICAgICAgICByZXRWYWwgPSBTdHJpbmcoKTsK KyAgICAgICAgICAgIFN0cmluZyByZXRWYWw7CisgICAgICAgICAgICBpZiAodWNoYXIxNikKKyAg ICAgICAgICAgICAgICByZXRWYWwgPSBTdHJpbmcoKFVDaGFyKil1Y2hhcjE2LCBud2MpOworICAg ICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHJldFZhbCA9IFN0cmluZygpOwogCi0gICAg Z19mcmVlKHVjaGFyMTYpOworICAgICAgICAgICAgZ19mcmVlKHVjaGFyMTYpOwogCi0gICAgcmV0 dXJuIHJldFZhbDsKKyAgICAgICAgICAgIHJldHVybiByZXRWYWw7CisgICAgfQogfQogCiAvLyBL ZWVwIHRoaXMgaW4gc3luYyB3aXRoIHRoZSBvdGhlciBwbGF0Zm9ybSBldmVudCBjb25zdHJ1Y3Rv cnMKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbmUgMzE3MTkpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkoY29waWEgbG9jYWxl KQpAQCAtMSwzICsxLDE1IEBACisyMDA4LTA0LTA4ICBNYXJjbyBCYXJpc2lvbmUgIDxtYXJjby5i YXJpc2lvbmVAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MzU3CisgICAgICAgIFtHVEtdIEVudGVyIG9uIGJ1dHRvbnMgZG9lc24ndCB3b3JrCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 c2luZ2xlQ2hhcmFjdGVyU3RyaW5nKTogU2V0IHRoZSB0ZXh0IG9mIGEga2V5Ym9hcmQgZXZlbnQg Zm9yCisgICAgICAgIEdES19JU09fRW50ZXIsIEdES19LUF9FbnRlciwgR0RLX1JldHVybiB0byAi XHIiIGluc3RlYWQgb2YgYW4gZW1wdHkKKyAgICAgICAgc3RyaW5nLgorCiAyMDA4LTA0LTA4ICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqIFN0YWNob3dpYWsuCg==