183554 2018-03-11 19:26:38 -0700 [Web Animations] Fix some WebAnimation lifecycle issues in preparation for declarative animations support 2018-03-12 06:03:55 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 183504 https://bugs.webkit.org/show_bug.cgi?id=183504 P2 Normal --- 1 graouts graouts dino oldest_to_newest 1405620 0 graouts 2018-03-11 19:26:38 -0700 [Web Animations] Fix some WebAnimation lifecycle issues in preparation for declarative animations support 1405623 1 335564 graouts 2018-03-11 19:31:06 -0700 Created attachment 335564 Patch 1405686 2 335564 dino 2018-03-12 02:59:52 -0700 Comment on attachment 335564 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335564&action=review > Source/WebCore/animation/WebAnimation.cpp:664 > + MicrotaskQueue::mainThreadQueue().append(std::make_unique<VoidMicrotask>([this, protectedThis = makeRef(*this)] () { > + this->performMicrotask(); > + })); No need for the this in []. Just use protectedThis->performMicrotask() 1405687 3 graouts 2018-03-12 03:04:58 -0700 (In reply to Dean Jackson from comment #2) > Comment on attachment 335564 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335564&action=review > > > Source/WebCore/animation/WebAnimation.cpp:664 > > + MicrotaskQueue::mainThreadQueue().append(std::make_unique<VoidMicrotask>([this, protectedThis = makeRef(*this)] () { > > + this->performMicrotask(); > > + })); > > No need for the this in []. Just use protectedThis->performMicrotask() It actually is needed, the compiler says "'this' cannot be implicitly captured in this context" otherwise. 1405715 4 graouts 2018-03-12 06:03:55 -0700 *** This bug has been marked as a duplicate of bug 183504 *** 335564 2018-03-11 19:31:06 -0700 2018-03-12 02:59:52 -0700 Patch bug-183554-20180312033105.patch text/plain 5019 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQwZjE0YjczMDM0ZmI0 MzVmMjU2NzVhYjkwNjA3OTUzZjViNjJjZi4uNDljYjg3ZGU5YWIxMGQ2OTA2MDgzY2Q0NWY3NGY4 MWY2NGE2ZjkwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTAzLTExICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBGaXggc29tZSBXZWJBbmltYXRpb24gbGlmZWN5Y2xlIGlzc3VlcyBpbiBwcmVwYXJhdGlvbiBm b3IgZGVjbGFyYXRpdmUgYW5pbWF0aW9ucyBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM1NTQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFuaW1hdGlvbi9BbmltYXRpb25UaW1lbGluZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25UaW1lbGluZTo6fkFuaW1hdGlvblRpbWVs aW5lKTogQ2xlYXIgYWxsIG1hcHMgYW5kIHNldHMgY29udGFpbmluZyBXZWJBbmltYXRpb24gcmVm ZXJlbmNlcyB0byBlbnN1cmUgdGhlc2UgZ2V0IGRlc3RydWN0ZWQKKyAgICAgICAgd2hlbiB0aGUg QW5pbWF0aW9uVGltZWxpbmUgaXMgYmVpbmcgZGVzdHJ1Y3RlZCBhbmQgc2hvdWxkIG5vIGxvbmdl ciBob2xkIGEgcmVmZXJlbmNlIHRvIHRoZW0uCisgICAgICAgICogYW5pbWF0aW9uL1dlYkFuaW1h dGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJBbmltYXRpb246On5XZWJBbmltYXRpb24p OiBXZSB1c2VkIHRvIGRvIHNvbWV0aGluZyB2ZXJ5IHdyb25nIHdoZW4gYSBXZWJBbmltYXRpb24g d2FzIGRlc3Ryb3llZCB3aGljaCB1bmNvdmVyZWQgY3Jhc2hlcyB3aGVuIGRlYWxpbmcgd2l0aAor ICAgICAgICBkZWNsYXJhdGl2ZSBhbmltYXRpb25zLiBXaGVuIHdlIHdpbGwgaWRlbnRpZnkgdGhh dCBhIERlY2xhcmF0aXZlQW5pbWF0aW9uIG5vIGxvbmdlciBtYXRjaGVzIGFuIEFuaW1hdGlvbiBm cm9tIHRoZSBjdXJyZW50IHN0eWxlJ3MgQW5pbWF0aW9uTGlzdCwgd2Ugd2lsbAorICAgICAgICBz ZXQgdGhhdCBEZWNsYXJhdGl2ZUFuaW1hdGlvbidzIGVmZmVjdCB0byBudWxsIGFuZCBjYWxsIHJl bW92ZUFuaW1hdGlvbigpIG9uIHRoZSB0aW1lbGluZS4gVGhpcyByZW1vdmVzIGFsbCByZWZlcmVu Y2VzIGZyb20gQW5pbWF0aW9uVGltZWxpbmUgdG8gdGhpcworICAgICAgICBEZWNsYXJhdGl2ZUFu aW1hdGlvbiBhbmQgbGVhZHMgdG8gfldlYkFuaW1hdGlvbiBiZWluZyBjYWxsZWQuIENhbGxpbmcg cmVtb3ZlQW5pbWF0aW9uKCkgYWdhaW4gaW4gdGhlIGRlc3RydWN0b3IgbWVhbnMgdGhhdCB3ZSdk IGhpdCAKKyAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIW1fZGVsZXRp b25IYXNCZWd1bikgaW4gcmVmKCkuIEl0IHdhcyBhbHNvIG1lYW5pbmdsZXNzIHRvIHBlcmZvcm0g dGhpcyB3b3JrIGluIHRoZSBXZWJBbmltYXRpb24gZGVzdHJ1Y3RvcgorICAgICAgICBzaW5jZSBh biBhbmltYXRpb24gY291bGQgbmV2ZXIgYmUgZGVzdHJveWVkIGlmIGl0IHdlcmUgc3RpbGwgcmVn aXN0ZXJlZCBvbiBhIHRpbWVsaW5lLgorICAgICAgICAoV2ViQ29yZTo6V2ViQW5pbWF0aW9uOjpz Y2hlZHVsZU1pY3JvdGFza0lmTmVlZGVkKTogRW5zdXJlIHRoYXQgdGhlIFdlYkFuaW1hdGlvbidz IGxpZmVjeWNsZSBpcyBleHRlbmRlZCBhdCBsZWFzdCB0byB0aGUgY29tcGxldGlvbiBvZiB0aGUg c2NoZWR1bGVkIG1pY3JvdGFzay4KKyAgICAgICAgVGhpcyB3b3VsZCBvdGhlcndpc2UgY2F1c2Ug Y3Jhc2hlcyBhZnRlciBkZWNsYXJhdGl2ZSBhbmltYXRpb25zIHdlcmUgZGVzdHJveWVkIHdoZW4g dGhleSB3ZXJlIG5vIGxvbmdlciBhcHBsaWVkLgorICAgICAgICAoV2ViQ29yZTo6V2ViQW5pbWF0 aW9uOjpydW5QZW5kaW5nUGxheVRhc2spOiBPbmx5IGZ1bGZpbGwgdGhlICJyZWFkeSIgcHJvbWlz ZSBpZiBpdCBoYXNuJ3QgYWxyZWFkeSBiZWVuLCB3aGljaCBtaWdodCBoYXZlIGJlZW4gdGhlIGNh c2UgaWYgbXVsdGlwbGUgY2FsbHMgdG8gcGxheSgpCisgICAgICAgIGFyZSBtYWRlIGFzIGEgcmVz dWx0IG9mIHVwZGF0aW5nIHRoZSBhbmltYXRpb24gcGxheSBzdGF0ZSBpbiBDU1NBbmltYXRpb246 OnN5bmNQcm9wZXJ0aWVzV2l0aEJhY2tpbmdBbmltYXRpb24oKS4KKyAgICAgICAgKFdlYkNvcmU6 OldlYkFuaW1hdGlvbjo6cnVuUGVuZGluZ1BhdXNlVGFzayk6IFNhbWUgYXMgYWJvdmUgYnV0IHdp dGggbXVsdGlwbGUgcGF1c2UoKSBjYWxscy4KKwogMjAxOC0wMy0xMCAgTWVnYW4gR2FyZG5lciAg PG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1lZGlhIHF1ZXJ5IGZvciBkZWZh dWx0IGFwcGVhcmFuY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9Bbmlt YXRpb25UaW1lbGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQW5pbWF0aW9uVGlt ZWxpbmUuY3BwCmluZGV4IGYzYTEzMDU3OGFlYmViNzE3MDM0ODJmYmE0NDNmYjg3YzYwMjVkZjYu LjlkNWM4MDliNmRhM2EyZWU2ZTE1YmU4MDhlM2JjYTVmMDYwZTZmNWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9BbmltYXRpb25UaW1lbGluZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYW5pbWF0aW9uL0FuaW1hdGlvblRpbWVsaW5lLmNwcApAQCAtNDEsNiArNDEsOCBA QCBBbmltYXRpb25UaW1lbGluZTo6QW5pbWF0aW9uVGltZWxpbmUoQ2xhc3NUeXBlIGNsYXNzVHlw ZSkKIAogQW5pbWF0aW9uVGltZWxpbmU6On5BbmltYXRpb25UaW1lbGluZSgpCiB7CisgICAgbV9h bmltYXRpb25zLmNsZWFyKCk7CisgICAgbV9lbGVtZW50VG9BbmltYXRpb25zTWFwLmNsZWFyKCk7 CiB9CiAKIHZvaWQgQW5pbWF0aW9uVGltZWxpbmU6OmFkZEFuaW1hdGlvbihSZWY8V2ViQW5pbWF0 aW9uPiYmIGFuaW1hdGlvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9X ZWJBbmltYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5j cHAKaW5kZXggNjkzOTUyZmY4MjE3YWU4YTg5YjRjMzkxODdkYTA2OTQwMmYxYjZmZC4uZjI4Yjcz MDM3MWEyZmQzZTFkN2YzNGVjZWI4ZjJkZGUzZGZhODNlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYW5pbWF0aW9uL1dlYkFuaW1hdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYW5p bWF0aW9uL1dlYkFuaW1hdGlvbi5jcHAKQEAgLTY4LDggKzY4LDYgQEAgV2ViQW5pbWF0aW9uOjpX ZWJBbmltYXRpb24oRG9jdW1lbnQmIGRvY3VtZW50KQogCiBXZWJBbmltYXRpb246On5XZWJBbmlt YXRpb24oKQogewotICAgIGlmIChtX3RpbWVsaW5lKQotICAgICAgICBtX3RpbWVsaW5lLT5yZW1v dmVBbmltYXRpb24oKnRoaXMpOwogfQogCiB2b2lkIFdlYkFuaW1hdGlvbjo6dGltaW5nTW9kZWxE aWRDaGFuZ2UoKQpAQCAtNjYxLDcgKzY1OSw5IEBAIHZvaWQgV2ViQW5pbWF0aW9uOjpzY2hlZHVs ZU1pY3JvdGFza0lmTmVlZGVkKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9zY2hlZHVsZWRN aWNyb3Rhc2sgPSB0cnVlOwotICAgIE1pY3JvdGFza1F1ZXVlOjptYWluVGhyZWFkUXVldWUoKS5h cHBlbmQoc3RkOjptYWtlX3VuaXF1ZTxWb2lkTWljcm90YXNrPihzdGQ6OmJpbmQoJldlYkFuaW1h dGlvbjo6cGVyZm9ybU1pY3JvdGFzaywgdGhpcykpKTsKKyAgICBNaWNyb3Rhc2tRdWV1ZTo6bWFp blRocmVhZFF1ZXVlKCkuYXBwZW5kKHN0ZDo6bWFrZV91bmlxdWU8Vm9pZE1pY3JvdGFzaz4oW3Ro aXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKV0gKCkgeworICAgICAgICB0aGlzLT5w ZXJmb3JtTWljcm90YXNrKCk7CisgICAgfSkpOwogfQogCiB2b2lkIFdlYkFuaW1hdGlvbjo6cGVy Zm9ybU1pY3JvdGFzaygpCkBAIC04MDUsNyArODA1LDggQEAgdm9pZCBXZWJBbmltYXRpb246OnJ1 blBlbmRpbmdQbGF5VGFzaygpCiAgICAgfQogCiAgICAgLy8gNC4gUmVzb2x2ZSBhbmltYXRpb24n cyBjdXJyZW50IHJlYWR5IHByb21pc2Ugd2l0aCBhbmltYXRpb24uCi0gICAgbV9yZWFkeVByb21p c2UtPnJlc29sdmUoKnRoaXMpOworICAgIGlmICghbV9yZWFkeVByb21pc2UtPmlzRnVsZmlsbGVk KCkpCisgICAgICAgIG1fcmVhZHlQcm9taXNlLT5yZXNvbHZlKCp0aGlzKTsKIAogICAgIC8vIDUu IFJ1biB0aGUgcHJvY2VkdXJlIHRvIHVwZGF0ZSBhbiBhbmltYXRpb24ncyBmaW5pc2hlZCBzdGF0 ZSBmb3IgYW5pbWF0aW9uIHdpdGggdGhlIGRpZCBzZWVrIGZsYWcgc2V0IHRvIGZhbHNlLCBhbmQg dGhlIHN5bmNocm9ub3VzbHkgbm90aWZ5IGZsYWcgc2V0IHRvIGZhbHNlLgogICAgIHVwZGF0ZUZp bmlzaGVkU3RhdGUoRGlkU2Vlazo6Tm8sIFN5bmNocm9ub3VzbHlOb3RpZnk6Ok5vKTsKQEAgLTky NCw3ICs5MjUsOCBAQCB2b2lkIFdlYkFuaW1hdGlvbjo6cnVuUGVuZGluZ1BhdXNlVGFzaygpCiAg ICAgc2V0U3RhcnRUaW1lKHN0ZDo6bnVsbG9wdCk7CiAKICAgICAvLyA0LiBSZXNvbHZlIGFuaW1h dGlvbidzIGN1cnJlbnQgcmVhZHkgcHJvbWlzZSB3aXRoIGFuaW1hdGlvbi4KLSAgICBtX3JlYWR5 UHJvbWlzZS0+cmVzb2x2ZSgqdGhpcyk7CisgICAgaWYgKCFtX3JlYWR5UHJvbWlzZS0+aXNGdWxm aWxsZWQoKSkKKyAgICAgICAgbV9yZWFkeVByb21pc2UtPnJlc29sdmUoKnRoaXMpOwogCiAgICAg Ly8gNS4gUnVuIHRoZSBwcm9jZWR1cmUgdG8gdXBkYXRlIGFuIGFuaW1hdGlvbidzIGZpbmlzaGVk IHN0YXRlIGZvciBhbmltYXRpb24gd2l0aCB0aGUgZGlkIHNlZWsgZmxhZyBzZXQgdG8gZmFsc2Us IGFuZCB0aGUKICAgICAvLyAgICBzeW5jaHJvbm91c2x5IG5vdGlmeSBmbGFnIHNldCB0byBmYWxz ZS4K