183550 2018-03-11 17:11:39 -0700 Fix the internal iOS build after r229512 2018-03-12 17:24:59 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue dino jer.noble lforschler thorton webkit-bug-importer zalan oldest_to_newest 1405604 0 wenson_hsieh 2018-03-11 17:11:39 -0700 Internal iOS bots are failing after <https://trac.webkit.org/changeset/229512/webkit>: OpenSource/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:33:9: error: non-portable path to file '"WKFullScreenViewController.h"'; specified path differs in case from file name on disk [-Werror,-Wnonportable-include-path] OpenSource/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:771:52: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] 1405605 1 335556 wenson_hsieh 2018-03-11 17:16:12 -0700 Created attachment 335556 Patch 1405649 2 335556 commit-queue 2018-03-11 20:38:26 -0700 Comment on attachment 335556 Patch Clearing flags on attachment: 335556 Committed r229521: <https://trac.webkit.org/changeset/229521> 1405650 3 commit-queue 2018-03-11 20:38:28 -0700 All reviewed patches have been landed. Closing bug. 1406003 4 webkit-bug-importer 2018-03-12 17:24:59 -0700 <rdar://problem/38397881> 335556 2018-03-11 17:16:12 -0700 2018-03-11 20:38:26 -0700 Patch bug-183550-20180311171612.patch text/plain 2296 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhhMjFhOTUwYmEyMjg2MzE5 MGU4MTM2Yzc1MjY2ZTMzYzNhZThiODIuLjVkZDkzYzRlM2IwYmE1OTQ0ZjA5ZGNjOGQxMTIwODYw NjA1YTNmNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDMtMTEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRoZSBpbnRlcm5h bCBpT1MgYnVpbGQgYWZ0ZXIgcjIyOTUxMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4ZXMgYSB0eXBvIGluIGEgaGVhZGVyIGltcG9ydCwgYXMgd2Vs bCBhcyBhIG51bGxhYmlsaXR5IGVycm9yLiBgU2VjVHJ1c3RFdmFsdWF0ZSgpYCB0YWtlcyBpbiBh IG5vbm51bGwgb3V0cGFyYW0sCisgICAgICAgIHdoaWNoIHdhcyByZW1vdmVkIGluIHIyMjk1MTI7 IHRoaXMgYWRkcyB0aGUgb3V0cGFyYW0gYmFjaywgYnV0IGRvZXMgbm90IGNvbnN1bHQgaXRzIHZh bHVlIHdoZW4gc2V0dGluZyB0aGUKKyAgICAgICAgYGluZm9EaWN0aW9uYXJ5YC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy SU9TLm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIF9FVk9yZ2Fu aXphdGlvbk5hbWVdKToKKwogMjAxOC0wMy0xMCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxl LmNvbT4KIAogICAgICAgICBJbXByb3ZlbWVudHMgdG8gZnVsbHNjcmVlbjsgbmV3IFVJIGFuZCBz ZWN1cml0eSBmZWF0dXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcklPUy5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xs ZXJJT1MubW0KaW5kZXggZDY5ZDU0YzVlNTVlOWI5NTA0MzQxNzEwNmYxMmY4ZTI1ZjJkMGE0ZS4u MjM5YWYyZmUzZjkzNWFlMDdjMTZjODhmZDk0MmEwZWIyMmM3ZjE4NyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsU2NyZWVuV2luZG93Q29u dHJvbGxlcklPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVl bi9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVySU9TLm1tCkBAIC0yOSw4ICsyOSw4IEBACiAj aW1wb3J0ICJXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVySU9TLmgiCiAKICNpbXBvcnQgIlVJ S2l0U1BJLmgiCisjaW1wb3J0ICJXS0Z1bGxTY3JlZW5WaWV3Q29udHJvbGxlci5oIgogI2ltcG9y dCAiV0tGdWxsc2NyZWVuU3RhY2tWaWV3LmgiCi0jaW1wb3J0ICJXS0Z1bGxzY3JlZW5WaWV3Q29u dHJvbGxlci5oIgogI2ltcG9ydCAiV0tXZWJWaWV3LmgiCiAjaW1wb3J0ICJXS1dlYlZpZXdJbnRl cm5hbC5oIgogI2ltcG9ydCAiV0tXZWJWaWV3UHJpdmF0ZS5oIgpAQCAtNzY4LDcgKzc2OCw4IEBA IC0gKE5TU3RyaW5nICopX0VWT3JnYW5pemF0aW9uTmFtZQogICAgIC8vIElmIFNlY1RydXN0Q29w eUluZm8gcmV0dXJuZWQgTlVMTCB0aGVuIGl0J3MgbGlrZWx5IHRoYXQgdGhlIFNlY1RydXN0UmVm IGhhcyBub3QgYmVlbiBldmFsdWF0ZWQKICAgICAvLyBhbmQgdGhlIG9ubHkgd2F5IHRvIGdldCB0 aGUgaW5mb3JtYXRpb24gd2UgbmVlZCBpcyB0byBjYWxsIFNlY1RydXN0RXZhbHVhdGUgb3Vyc2Vs dmVzLgogICAgIGlmICghaW5mb0RpY3Rpb25hcnkpIHsKLSAgICAgICAgT1NTdGF0dXMgZXJyID0g U2VjVHJ1c3RFdmFsdWF0ZSh0cnVzdCwgTlVMTCk7CisgICAgICAgIFNlY1RydXN0UmVzdWx0VHlw ZSByZXN1bHQgPSBrU2VjVHJ1c3RSZXN1bHRQcm9jZWVkOworICAgICAgICBPU1N0YXR1cyBlcnIg PSBTZWNUcnVzdEV2YWx1YXRlKHRydXN0LCAmcmVzdWx0KTsKICAgICAgICAgaWYgKGVyciA9PSBu b0VycikKICAgICAgICAgICAgIGluZm9EaWN0aW9uYXJ5ID0gWyhfX2JyaWRnZSBOU0RpY3Rpb25h cnkgKilTZWNUcnVzdENvcHlJbmZvKHRydXN0KSBhdXRvcmVsZWFzZV07CiAgICAgICAgIGlmICgh aW5mb0RpY3Rpb25hcnkpCg==