18354 2008-04-07 23:43:50 -0700 feFlood in attribute should be removed according to SVG 1.1 Errata 2008-04-08 07:59:41 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 rwlbuis webkit-unassigned chris oldest_to_newest 76566 0 rwlbuis 2008-04-07 23:43:50 -0700 See: http://www.w3.org/2003/01/REC-SVG11-20030114-errata#feflood-attribute 76570 1 20400 rwlbuis 2008-04-07 23:51:40 -0700 Created attachment 20400 First attempt Simple removal patch. Cheers, Rob. 76571 2 rwlbuis 2008-04-08 00:23:58 -0700 Landed in r31718. 76605 3 chris 2008-04-08 07:17:59 -0700 Since this change, WebKit no longer builds for me: WebCore/svg/SVGFEFloodElement.cpp: In member function ‘virtual WebCore::SVGFEFlood* WebCore::SVGFEFloodElement::filterEffect(WebCore::SVGResourceFilter*) const’: WebCore/svg/SVGFEFloodElement.cpp:57: error: ‘in1’ was not declared in this scope 76610 4 rwlbuis 2008-04-08 07:59:41 -0700 Hi Chris, (In reply to comment #3) > Since this change, WebKit no longer builds for me: > WebCore/svg/SVGFEFloodElement.cpp: In member function ‘virtual > WebCore::SVGFEFlood* > WebCore::SVGFEFloodElement::filterEffect(WebCore::SVGResourceFilter*) const’: > WebCore/svg/SVGFEFloodElement.cpp:57: error: ‘in1’ was not declared in this > scope Oops! Wierd that I didnt see a compile error myself, or it was too late last night and didnt notice... Just remove that line I'd say, and see if someone can commit it for you if needed. I'll only be able to correct it after work, in an hour or two/three. Cheers, Rob. 20400 2008-04-07 23:51:40 -0700 2008-04-08 00:18:24 -0700 First attempt 18354.diff text/plain 3116 rwlbuis SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTcxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDQtMDcgIFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzU0CisgICAgICAgIGZlRmxvb2QgaW4gYXR0 cmlidXRlIHNob3VsZCBiZSByZW1vdmVkIGFjY29yZGluZyB0byBTVkcgMS4xIEVycmF0YQorCisg ICAgICAgIFJlbW92ZSB0aGUgaW4gYXR0cmlidXRlIGZyb20gU1ZHRkVGbG9vZCBET00uCisKKyAg ICAgICAgKiBzdmcvU1ZHRkVGbG9vZEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZH RkVGbG9vZEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKToKKyAgICAgICAgKiBzdmcvU1ZH RkVGbG9vZEVsZW1lbnQuaDoKKyAgICAgICAgKiBzdmcvU1ZHRkVGbG9vZEVsZW1lbnQuaWRsOgor CiAyMDA4LTA0LTA3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBUb3VjaCBKU1N0b3JhZ2VDdXN0b20uY3BwIHRvIHRyeSB0byBGT1JDRSBhIHJlY29tcGlsZSBv biBib3RzIHRoYXQgaGF2ZW4ndCBnb3R0ZW4gdGhlIG1lc3NhZ2UKSW5kZXg6IFdlYkNvcmUvc3Zn L1NWR0ZFRmxvb2RFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N2Zy9TVkdGRUZs b29kRWxlbWVudC5jcHAJKHJldmlzaW9uIDMxNzE3KQorKysgV2ViQ29yZS9zdmcvU1ZHRkVGbG9v ZEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogLyoKICAgICBDb3B5 cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIwMDcgTmlrb2xhcyBaaW1tZXJtYW5uIDx6aW1tZXJtYW5u QGtkZS5vcmc+Ci0gICAgICAgICAgICAgICAgICAyMDA0LCAyMDA1LCAyMDA3IFJvYiBCdWlzIDxi dWlzQGtkZS5vcmc+CisgICAgICAgICAgICAgICAgICAyMDA0LCAyMDA1LCAyMDA3LCAyMDA4IFJv YiBCdWlzIDxidWlzQGtkZS5vcmc+CiAKICAgICBUaGlzIGZpbGUgaXMgcGFydCBvZiB0aGUgS0RF IHByb2plY3QKIApAQCAtNDQsMTUgKzQ0LDkgQEAgU1ZHRkVGbG9vZEVsZW1lbnQ6On5TVkdGRUZs b29kRWxlbWVudCgpCiAgICAgZGVsZXRlIG1fZmlsdGVyRWZmZWN0OwogfQogCi1BTklNQVRFRF9Q Uk9QRVJUWV9ERUZJTklUSU9OUyhTVkdGRUZsb29kRWxlbWVudCwgU3RyaW5nLCBTdHJpbmcsIHN0 cmluZywgSW4xLCBpbjEsIFNWR05hbWVzOjppbkF0dHIsIG1faW4xKQotCiB2b2lkIFNWR0ZFRmxv b2RFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJpYnV0ZShNYXBwZWRBdHRyaWJ1dGUqIGF0dHIpCiB7 Ci0gICAgY29uc3QgU3RyaW5nJiB2YWx1ZSA9IGF0dHItPnZhbHVlKCk7Ci0gICAgaWYgKGF0dHIt Pm5hbWUoKSA9PSBTVkdOYW1lczo6aW5BdHRyKQotICAgICAgICBzZXRJbjFCYXNlVmFsdWUodmFs dWUpOwotICAgIGVsc2UKLSAgICAgICAgU1ZHRmlsdGVyUHJpbWl0aXZlU3RhbmRhcmRBdHRyaWJ1 dGVzOjpwYXJzZU1hcHBlZEF0dHJpYnV0ZShhdHRyKTsKKyAgICBTVkdGaWx0ZXJQcmltaXRpdmVT dGFuZGFyZEF0dHJpYnV0ZXM6OnBhcnNlTWFwcGVkQXR0cmlidXRlKGF0dHIpOwogfQogCiBTVkdG RUZsb29kKiBTVkdGRUZsb29kRWxlbWVudDo6ZmlsdGVyRWZmZWN0KFNWR1Jlc291cmNlRmlsdGVy KiBmaWx0ZXIpIGNvbnN0CkluZGV4OiBXZWJDb3JlL3N2Zy9TVkdGRUZsb29kRWxlbWVudC5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR0ZFRmxvb2RFbGVtZW50LmgJKHJldmlzaW9uIDMx NzE3KQorKysgV2ViQ29yZS9zdmcvU1ZHRkVGbG9vZEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpA QCAtMSw2ICsxLDYgQEAKIC8qCiAgICAgQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA3IE5p a29sYXMgWmltbWVybWFubiA8emltbWVybWFubkBrZGUub3JnPgotICAgICAgICAgICAgICAgICAg MjAwNCwgMjAwNSBSb2IgQnVpcyA8YnVpc0BrZGUub3JnPgorICAgICAgICAgICAgICAgICAgMjAw NCwgMjAwNSwgMjAwOCBSb2IgQnVpcyA8YnVpc0BrZGUub3JnPgogCiAgICAgVGhpcyBmaWxlIGlz IHBhcnQgb2YgdGhlIEtERSBwcm9qZWN0CiAKQEAgLTQyLDggKzQyLDYgQEAgbmFtZXNwYWNlIFdl YkNvcmUKICAgICAgICAgdmlydHVhbCBjb25zdCBTVkdFbGVtZW50KiBjb250ZXh0RWxlbWVudCgp IGNvbnN0IHsgcmV0dXJuIHRoaXM7IH0KIAogICAgIHByaXZhdGU6Ci0gICAgICAgIEFOSU1BVEVE X1BST1BFUlRZX0RFQ0xBUkFUSU9OUyhTVkdGRUZsb29kRWxlbWVudCwgU3RyaW5nLCBTdHJpbmcs IEluMSwgaW4xKQotCiAgICAgICAgIG11dGFibGUgU1ZHRkVGbG9vZCAqbV9maWx0ZXJFZmZlY3Q7 CiAgICAgfTsKIApJbmRleDogV2ViQ29yZS9zdmcvU1ZHRkVGbG9vZEVsZW1lbnQuaWRsCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR0ZFRmxvb2RFbGVtZW50LmlkbAkocmV2aXNpb24gMzE3 MTcpCisrKyBXZWJDb3JlL3N2Zy9TVkdGRUZsb29kRWxlbWVudC5pZGwJKHdvcmtpbmcgY29weSkK QEAgLTI3LDcgKzI3LDYgQEAgbW9kdWxlIHN2ZyB7CiAKICAgICBpbnRlcmZhY2UgW0NvbmRpdGlv bmFsPVNWRyZTVkdfRklMVEVSU10gU1ZHRkVGbG9vZEVsZW1lbnQgOiBTVkdFbGVtZW50LAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNWR0ZpbHRl clByaW1pdGl2ZVN0YW5kYXJkQXR0cmlidXRlcyB7Ci0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0 ZSBTVkdBbmltYXRlZFN0cmluZyBpbjE7CiAgICAgfTsKIAogfQo=