183538 2018-03-09 18:20:51 -0800 offlineasm should reset the Assembler's working state before doing another pass for a new target. 2018-03-10 12:13:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo jfbastien keith_miller msaboff rmorisset saam webkit-bug-importer oldest_to_newest 1405424 0 mark.lam 2018-03-09 18:20:51 -0800 Patch coming. 1405425 1 webkit-bug-importer 2018-03-09 18:21:26 -0800 <rdar://problem/38325955> 1405428 2 335493 mark.lam 2018-03-09 18:29:42 -0800 Created attachment 335493 proposed patch. 1405449 3 335493 mark.lam 2018-03-09 22:54:15 -0800 Comment on attachment 335493 proposed patch. Taking off review for now. I found another bug in this same class of errors. Will fix that bug as well before reposting a patch. 1405450 4 mark.lam 2018-03-09 22:54:48 -0800 <rdar://problem/38316707> 1405455 5 335503 mark.lam 2018-03-09 23:58:49 -0800 Created attachment 335503 proposed patch. 1405487 6 335503 msaboff 2018-03-10 11:28:56 -0800 Comment on attachment 335503 proposed patch. r=me 1405492 7 mark.lam 2018-03-10 12:13:57 -0800 Thanks for the review. Landed in r229506: <http://trac.webkit.org/r229506>. 335493 2018-03-09 18:29:42 -0800 2018-03-09 23:58:49 -0800 proposed patch. bug-183538.patch text/plain 1564 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5NDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE4LTAzLTA5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBv ZmZsaW5lYXNtIHNob3VsZCBjbGVhciBAZGVmZXJyZWRBY3Rpb25zIGJlZm9yZSBkb2luZyBhbm90 aGVyIGFzbSBwYXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTgzNTM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODMyNTk1NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXIuY3BwOgorICAgICAgICAqIG9mZmxpbmVhc20vYXNtLnJiOgorCiAyMDE4LTAz LTA5ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHRoZXJlIHNob3VsZCBvbmx5IGJlIG9uZSB3YXkgZm9yIGFzeW5jIGJhY2tlbmQgY29tbWFu ZHMgdG8gc2VuZCBmYWlsdXJlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93 TGV2ZWxJbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAyMjk0OTYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlIDx3dGYvSW5saW5lQVNNLmg+CiAKICNp ZiAhRU5BQkxFKEpJVCkKKyNpbmNsdWRlICJCeXRlY29kZXMuaCIKICNpbmNsdWRlICJDTG9vcFN0 YWNrSW5saW5lcy5oIgogI2luY2x1ZGUgIkNvZGVCbG9jay5oIgogI2luY2x1ZGUgIkNvbW1vblNs b3dQYXRocy5oIgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJi Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzbS5yYgko cmV2aXNpb24gMjI5NDk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNt LnJiCSh3b3JraW5nIGNvcHkpCkBAIC01NCw2ICs1NCw3IEBAIGNsYXNzIEFzc2VtYmxlcgogICAg IGVuZAogCiAgICAgZGVmIGVudGVyQXNtCisgICAgICAgIEBkZWZlcnJlZEFjdGlvbnMgPSBbXQog ICAgICAgICBAb3V0cC5wdXRzICJPRkZMSU5FX0FTTV9CRUdJTiIgaWYgISRlbWl0V2luQXNtCiAK ICAgICAgICAgaWYgISRlbWl0V2luQXNtCg== 335503 2018-03-09 23:58:49 -0800 2018-03-10 11:28:56 -0800 proposed patch. bug-183538.patch text/plain 3168 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5NTAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTAzLTA5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBv ZmZsaW5lYXNtIHNob3VsZCByZXNldCB0aGUgQXNzZW1ibGVyJ3Mgd29ya2luZyBzdGF0ZSBiZWZv cmUgZG9pbmcgYW5vdGhlciBwYXNzIGZvciBhIG5ldyB0YXJnZXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM1MzgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM4MzI1OTU1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHA6CisgICAgICAgICogb2Zm bGluZWFzbS9hc20ucmI6CisgICAgICAgICogb2ZmbGluZWFzbS9jbG9vcC5yYjoKKwogMjAxOC0w My0wOSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiB0aGVyZSBzaG91bGQgb25seSBiZSBvbmUgd2F5IGZvciBhc3luYyBiYWNrZW5kIGNvbW1h bmRzIHRvIHNlbmQgZmFpbHVyZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xv d0xldmVsSW50ZXJwcmV0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNwcAkocmV2aXNpb24gMjI5NDk2KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSA8d3RmL0lubGluZUFTTS5oPgogCiAj aWYgIUVOQUJMRShKSVQpCisjaW5jbHVkZSAiQnl0ZWNvZGVzLmgiCiAjaW5jbHVkZSAiQ0xvb3BT dGFja0lubGluZXMuaCIKICNpbmNsdWRlICJDb2RlQmxvY2suaCIKICNpbmNsdWRlICJDb21tb25T bG93UGF0aHMuaCIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzbS5y Ygo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc20ucmIJ KHJldmlzaW9uIDIyOTQ5NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Fz bS5yYgkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksMTAgQEAgY2xhc3MgQXNzZW1ibGVyCiAg ICAgZGVmIGluaXRpYWxpemUob3V0cCkKICAgICAgICAgQG91dHAgPSBvdXRwCiAgICAgICAgIEBz dGF0ZSA9IDpjcHAKKyAgICAgICAgcmVzZXRBc20KKyAgICBlbmQKKworICAgIGRlZiByZXNldEFz bQogICAgICAgICBAY29tbWVudFN0YXRlID0gOm5vbmUKICAgICAgICAgQGNvbW1lbnQgPSBuaWwK ICAgICAgICAgQGludGVybmFsQ29tbWVudCA9IG5pbApAQCAtOTMsNiArOTcsNyBAQCBjbGFzcyBB c3NlbWJsZXIKICAgICBlbmQKICAgICAKICAgICBkZWYgaW5Bc20KKyAgICAgICAgcmVzZXRBc20K ICAgICAgICAgZW50ZXJBc20KICAgICAgICAgeWllbGQKICAgICAgICAgbGVhdmVBc20KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCShyZXZpc2lvbiAyMjk0 OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgkod29ya2lu ZyBjb3B5KQpAQCAtNTE5LDggKzUxOSw2IEBAIGRlZiBjbG9vcEVtaXRDYWxsU2xvd1BhdGhWb2lk KG9wZXJhbmRzKQogZW5kCiAKIGNsYXNzIEluc3RydWN0aW9uCi0gICAgQEBkaWRSZXR1cm5Gcm9t SlNMYWJlbENvdW50ZXIgPSAwCi0KICAgICBkZWYgbG93ZXJDX0xPT1AKICAgICAgICAgY2FzZSBv cGNvZGUKICAgICAgICAgd2hlbiAiYWRkaSIKQEAgLTEwNzgsMTEgKzEwNzYsMTEgQEAgY2xhc3Mg SW5zdHJ1Y3Rpb24KICAgICAgICAgIyB1c2Ugb2YgdGhlIGNhbGwgaW5zdHJ1Y3Rpb24uIEluc3Rl YWQsIHdlIGp1c3QgaW1wbGVtZW50IEpTIGNhbGxzCiAgICAgICAgICMgYXMgYW4gb3Bjb2RlIGRp c3BhdGNoLgogICAgICAgICB3aGVuICJjbG9vcENhbGxKU0Z1bmN0aW9uIgotICAgICAgICAgICAg QEBkaWRSZXR1cm5Gcm9tSlNMYWJlbENvdW50ZXIgKz0gMQotICAgICAgICAgICAgJGFzbS5wdXRj ICJsci5vcGNvZGUgPSBnZXRPcGNvZGUobGxpbnRfY2xvb3BfZGlkX3JldHVybl9mcm9tX2pzXyN7 QEBkaWRSZXR1cm5Gcm9tSlNMYWJlbENvdW50ZXJ9KTsiCisgICAgICAgICAgICB1aWQgPSAkYXNt Lm5ld1VJRAorICAgICAgICAgICAgJGFzbS5wdXRjICJsci5vcGNvZGUgPSBnZXRPcGNvZGUobGxp bnRfY2xvb3BfZGlkX3JldHVybl9mcm9tX2pzXyN7dWlkfSk7IgogICAgICAgICAgICAgJGFzbS5w dXRjICJvcGNvZGUgPSAje29wZXJhbmRzWzBdLmNsVmFsdWUoOm9wY29kZSl9OyIKICAgICAgICAg ICAgICRhc20ucHV0YyAiRElTUEFUQ0hfT1BDT0RFKCk7IgotICAgICAgICAgICAgJGFzbS5wdXRz TGFiZWwoImxsaW50X2Nsb29wX2RpZF9yZXR1cm5fZnJvbV9qc18je0BAZGlkUmV0dXJuRnJvbUpT TGFiZWxDb3VudGVyfSIsIGZhbHNlKQorICAgICAgICAgICAgJGFzbS5wdXRzTGFiZWwoImxsaW50 X2Nsb29wX2RpZF9yZXR1cm5fZnJvbV9qc18je3VpZH0iLCBmYWxzZSkKIAogICAgICAgICAjIFdl IGNhbid0IGRvIGdlbmVyaWMgZnVuY3Rpb24gY2FsbHMgd2l0aCBhbiBhcmJpdHJhcnkgc2V0IG9m IGFyZ3MsIGJ1dAogICAgICAgICAjIGZvcnR1bmF0ZWx5IHdlIGRvbid0IGhhdmUgdG8gaGVyZS4g QWxsIG5hdGl2ZSBmdW5jdGlvbiBjYWxscyBhbHdheXMK