<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183535</bug_id>
          
          <creation_ts>2018-03-09 15:57:31 -0800</creation_ts>
          <short_desc>[WebAuthN] Improve CBOR encoding/decoding</short_desc>
          <delta_ts>2020-03-08 21:59:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>181943</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Jiewen Tan">jiewen_tan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alex.gaynor</cc>
    
    <cc>jiewen_tan</cc>
    
    <cc>jonathan</cc>
    
    <cc>jschoi</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1405376</commentid>
    <comment_count>0</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-03-09 15:57:31 -0800</bug_when>
    <thetext>CBOR encoder needs to deal with bytes directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1450536</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-08-15 17:09:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/43357405&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465321</commentid>
    <comment_count>2</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2018-10-01 17:13:48 -0700</bug_when>
    <thetext>Actually, this bug applies to all different value types the encoder support. Instead of holding the value, the encoder will be more efficient to provide a mode to only hold a reference to the value and then let the caller to guarantee the value is unchanged and alive during the encoding period. Anyway, it will be good to optimize it but not a blocker for the feature.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1627659</commentid>
    <comment_count>3</comment_count>
    <who name="Jiewen Tan">jiewen_tan</who>
    <bug_when>2020-03-08 21:59:23 -0700</bug_when>
    <thetext>We should consider adding &amp;&amp; getter for CBORValue.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>