183512 2018-03-09 05:20:48 -0800 Move jsc CLI breakpoint function to $vm 2018-03-14 12:44:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ddkilzer ews-watchlist mark.lam msaboff saam ysuzuki oldest_to_newest 1405153 0 keith_miller 2018-03-09 05:20:48 -0800 Move jsc CLI breakpoint function to $vm 1405154 1 335423 keith_miller 2018-03-09 05:22:12 -0800 Created attachment 335423 Patch 1405155 2 ews-watchlist 2018-03-09 05:23:03 -0800 Attachment 335423 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:8: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzzer [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1405159 3 335423 ysuzuki 2018-03-09 06:03:35 -0800 Comment on attachment 335423 Patch r=me, nice. 1405161 4 335423 ysuzuki 2018-03-09 06:06:10 -0800 Comment on attachment 335423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335423&action=review > Source/JavaScriptCore/jsc.cpp:582 > + addFunction(vm, dollar, "breakpoint", functionBreakpoint, 0); I think, this is `$.breakpoint`, not `$vm.breakpoint`, correct? You can move this to tools/JSDollarVM.cpp 1405164 5 335423 mark.lam 2018-03-09 06:42:08 -0800 Comment on attachment 335423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335423&action=review >> Source/JavaScriptCore/jsc.cpp:582 >> + addFunction(vm, dollar, "breakpoint", functionBreakpoint, 0); > > I think, this is `$.breakpoint`, not `$vm.breakpoint`, correct? > You can move this to tools/JSDollarVM.cpp Yes, to put this in $vm, you should add it in JSDollarVM. 1406450 6 ddkilzer 2018-03-14 11:33:33 -0700 <rdar://problem/38462027> 1406455 7 335783 keith_miller 2018-03-14 12:07:14 -0700 Created attachment 335783 Patch for landing 1406469 8 335783 commit-queue 2018-03-14 12:44:40 -0700 Comment on attachment 335783 Patch for landing Clearing flags on attachment: 335783 Committed r229605: <https://trac.webkit.org/changeset/229605> 1406470 9 commit-queue 2018-03-14 12:44:43 -0700 All reviewed patches have been landed. Closing bug. 335423 2018-03-09 05:22:12 -0800 2018-03-14 12:07:13 -0700 Patch bug-183512-20180309052211.patch text/plain 1758 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh M2VhOTNjZDFmZTVmZTUzOTAzOTU1YzFlY2RmNjMwNDdlMjgyZTgwLi42YzhiN2FmODRlY2I2MjJm ZTNiMTk1OWFiYmRiYjdlYmJjMjVkZWYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wMy0wOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBNb3ZlIGpzYyBDTEkgYnJlYWtwb2ludCBmdW5jdGlvbiB0byAkdm0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzUxMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlY2F1c2Ug dGhpcyBtZXRob2Qgd2lsbCBwcm9iYWJseSBjb25mdXNlIGZ1enplcnMuCisKKyAgICAgICAgKiBq c2MuY3BwOgorICAgICAgICAoR2xvYmFsT2JqZWN0OjpmaW5pc2hDcmVhdGlvbik6CisKIDIwMTgt MDMtMDggIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgYW5vdGhlciBhdHRlbXB0IGF0IGZpeGluZyB0aGUgV2luZG93cyBidWlsZC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2pzYy5jcHAKaW5kZXggZWY5MmM0MjI5MmYwODU2YThkOTdmYWU5MzgwMDZiMjMx MmQ3ZjdhMy4uMTMwZDNmYTUyY2I5MmY1MDgxMWY1MmFhMmE2NzhlNmI4OGFkMDU2NCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2pzYy5jcHAKQEAgLTQ3NCw3ICs0NzQsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgewogICAg ICAgICBCYXNlOjpmaW5pc2hDcmVhdGlvbih2bSk7CiAKLSAgICAgICAgYWRkRnVuY3Rpb24odm0s ICJicmVha3BvaW50IiwgZnVuY3Rpb25CcmVha3BvaW50LCAwKTsKICAgICAgICAgYWRkRnVuY3Rp b24odm0sICJkZWJ1ZyIsIGZ1bmN0aW9uRGVidWcsIDEpOwogICAgICAgICBhZGRGdW5jdGlvbih2 bSwgImRlc2NyaWJlIiwgZnVuY3Rpb25EZXNjcmliZSwgMSk7CiAgICAgICAgIGFkZEZ1bmN0aW9u KHZtLCAiZGVzY3JpYmVBcnJheSIsIGZ1bmN0aW9uRGVzY3JpYmVBcnJheSwgMSk7CkBAIC01ODAs NiArNTc5LDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBhZGRGdW5jdGlvbih2bSwgZG9sbGFyLCAi Y3JlYXRlUmVhbG0iLCBmdW5jdGlvbkRvbGxhckNyZWF0ZVJlYWxtLCAwKTsKICAgICAgICAgYWRk RnVuY3Rpb24odm0sIGRvbGxhciwgImRldGFjaEFycmF5QnVmZmVyIiwgZnVuY3Rpb25Eb2xsYXJE ZXRhY2hBcnJheUJ1ZmZlciwgMSk7CiAgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCBkb2xsYXIsICJl dmFsU2NyaXB0IiwgZnVuY3Rpb25Eb2xsYXJFdmFsU2NyaXB0LCAxKTsKKyAgICAgICAgYWRkRnVu Y3Rpb24odm0sIGRvbGxhciwgImJyZWFrcG9pbnQiLCBmdW5jdGlvbkJyZWFrcG9pbnQsIDApOwog ICAgICAgICAKICAgICAgICAgZG9sbGFyLT5wdXREaXJlY3Qodm0sIElkZW50aWZpZXI6OmZyb21T dHJpbmcoZ2xvYmFsRXhlYygpLCAiZ2xvYmFsIiksIHRoaXMpOwogICAgICAgICAK 335783 2018-03-14 12:07:14 -0700 2018-03-14 12:44:40 -0700 Patch for landing bug-183512-20180314120713.patch text/plain 4098 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MDlhNDNkOGM0MjczNTdjNzRmMDMzYzA0NWUyYzYzZTE2YTNiNmE5Li45Y2MzNWYwNGM5OTUwMmNl YTdlMDQzN2JhMTgwZGMzYTVkNDY2ZTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wMy0xNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBNb3ZlIGpzYyBDTEkgYnJlYWtwb2ludCBmdW5jdGlvbiB0byAkdm0K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzUxMgor CisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgKiBqc2MuY3Bw OgorICAgICAgICAoR2xvYmFsT2JqZWN0OjpmaW5pc2hDcmVhdGlvbik6CisgICAgICAgIChmdW5j dGlvbkJyZWFrcG9pbnQpOiBEZWxldGVkLgorICAgICAgICAqIHRvb2xzL0pTRG9sbGFyVk0uY3Bw OgorICAgICAgICAoSlNDOjpmdW5jdGlvbkJyZWFrcG9pbnQpOgorICAgICAgICAoSlNDOjpKU0Rv bGxhclZNOjpmaW5pc2hDcmVhdGlvbik6CisKIDIwMTgtMDMtMTQgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHRoZSBidWlsZCBhZnRlciByMjI5 NTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qc2MuY3BwCmluZGV4IDZjZDIzOGFmZWRkNGIyMTQyMjg2ZmZjM2Q4Y2Y0 MjFkNWQ2OGMxOTcuLjQwYzdlZGM4ZjZlNzBiMGEzNmE5Yjc5NTc1NWI2Njc2ODUyZjlkYjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9qc2MuY3BwCkBAIC0yNTUsNyArMjU1LDYgQEAgc3RhdGljIEVuY29kZWRKU1Zh bHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25DcmVhdGVHbG9iYWxPYmplY3QoRXhlY1N0YXRlKik7 CiAKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uUHJpbnRTdGRP dXQoRXhlY1N0YXRlKik7CiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5j dGlvblByaW50U3RkRXJyKEV4ZWNTdGF0ZSopOwotc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgZnVuY3Rpb25CcmVha3BvaW50KEV4ZWNTdGF0ZSopOwogc3RhdGljIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25EZWJ1ZyhFeGVjU3RhdGUqKTsKIHN0YXRpYyBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uRGVzY3JpYmUoRXhlY1N0YXRlKik7 CiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRlc2NyaWJlQXJy YXkoRXhlY1N0YXRlKik7CkBAIC00NzMsNyArNDcyLDYgQEAgcHJvdGVjdGVkOgogICAgIHsKICAg ICAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24odm0pOwogCi0gICAgICAgIGFkZEZ1bmN0aW9uKHZt LCAiYnJlYWtwb2ludCIsIGZ1bmN0aW9uQnJlYWtwb2ludCwgMCk7CiAgICAgICAgIGFkZEZ1bmN0 aW9uKHZtLCAiZGVidWciLCBmdW5jdGlvbkRlYnVnLCAxKTsKICAgICAgICAgYWRkRnVuY3Rpb24o dm0sICJkZXNjcmliZSIsIGZ1bmN0aW9uRGVzY3JpYmUsIDEpOwogICAgICAgICBhZGRGdW5jdGlv bih2bSwgImRlc2NyaWJlQXJyYXkiLCBmdW5jdGlvbkRlc2NyaWJlQXJyYXksIDEpOwpAQCAtMTA0 NCwxOCArMTA0Miw2IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZnVuY3Rpb25EdW1w Q2FsbEZyYW1lKEV4ZWNTdGF0ZSogZXhlYykKIH0KICNlbmRpZgogCi1FbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGZ1bmN0aW9uQnJlYWtwb2ludChFeGVjU3RhdGUqIGV4ZWMpCi17Ci0gICAg Ly8gTm90aGluZyBzaG91bGQgdGhyb3cgaGVyZSBidXQgd2UgbWlnaHQgYXMgd2VsbCBkb3VibGUg Y2hlY2suLi4KLSAgICBWTSYgdm0gPSBleGVjLT52bSgpOwotICAgIGF1dG8gc2NvcGUgPSBERUNM QVJFX0NBVENIX1NDT1BFKHZtKTsKLSAgICBVTlVTRURfUEFSQU0oc2NvcGUpOwotICAgIGlmICgh ZXhlYy0+YXJndW1lbnRDb3VudCgpIHx8IGV4ZWMtPmFyZ3VtZW50KDApLnRvQm9vbGVhbihleGVj KSkKLSAgICAgICAgV1RGQnJlYWtwb2ludFRyYXAoKTsKLQotICAgIHJldHVybiBlbmNvZGVkSlNV bmRlZmluZWQoKTsKLX0KLQogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRl YnVnKEV4ZWNTdGF0ZSogZXhlYykKIHsKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCmluZGV4IDQyYTliNWY5NTI5NzQ2 MWYwY2IzNzM0Y2ViYWUzM2FkMWU2NzZjMjAuLjc3ZjYwMzk1Y2Y2YTk0MjZjMTY2MGJlMGViODAx ZWY2NmNhYzc0YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0Rv bGxhclZNLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5j cHAKQEAgLTEwNDIsNiArMTA0MiwyMCBAQCBzdGF0aWMgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uQ3Jhc2goRXhlY1N0YQogICAgIENS QVNIKCk7CiB9CiAKKy8vIEV4ZWN1dGVzIGEgYnJlYWtwb2ludCBpbnN0cnVjdGlvbiBpZiB0aGUg Zmlyc3QgYXJndW1lbnQgaXMgdHJ1dGh5IG9yIGlzIHVuc2V0LgorLy8gVXNhZ2U6ICR2bS5icmVh a3BvaW50KDxjb25kaXRpb24+KQorc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg ZnVuY3Rpb25CcmVha3BvaW50KEV4ZWNTdGF0ZSogZXhlYykKK3sKKyAgICAvLyBOb3RoaW5nIHNo b3VsZCB0aHJvdyBoZXJlIGJ1dCB3ZSBtaWdodCBhcyB3ZWxsIGRvdWJsZSBjaGVjay4uLgorICAg IFZNJiB2bSA9IGV4ZWMtPnZtKCk7CisgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfQ0FUQ0hfU0NP UEUodm0pOworICAgIFVOVVNFRF9QQVJBTShzY29wZSk7CisgICAgaWYgKCFleGVjLT5hcmd1bWVu dENvdW50KCkgfHwgZXhlYy0+YXJndW1lbnQoMCkudG9Cb29sZWFuKGV4ZWMpKQorICAgICAgICBX VEZCcmVha3BvaW50VHJhcCgpOworCisgICAgcmV0dXJuIGVuY29kZWRKU1VuZGVmaW5lZCgpOwor fQorCiAvLyBSZXR1cm5zIHRydWUgaWYgdGhlIGN1cnJlbnQgZnJhbWUgaXMgYSBERkcgZnJhbWUu CiAvLyBVc2FnZTogaXNERkcgPSAkdm0uZGZnVHJ1ZSgpCiBzdGF0aWMgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBmdW5jdGlvbkRGR1RydWUoRXhlY1N0YXRlKikKQEAgLTE3NjQsNiArMTc3 OCw3IEBAIHZvaWQgSlNEb2xsYXJWTTo6ZmluaXNoQ3JlYXRpb24oVk0mIHZtKQogCiAgICAgYWRk RnVuY3Rpb24odm0sICJhYm9ydCIsIGZ1bmN0aW9uQ3Jhc2gsIDApOwogICAgIGFkZEZ1bmN0aW9u KHZtLCAiY3Jhc2giLCBmdW5jdGlvbkNyYXNoLCAwKTsKKyAgICBhZGRGdW5jdGlvbih2bSwgImJy ZWFrcG9pbnQiLCBmdW5jdGlvbkJyZWFrcG9pbnQsIDApOwogCiAgICAgcHV0RGlyZWN0TmF0aXZl RnVuY3Rpb24odm0sIGdsb2JhbE9iamVjdCwgSWRlbnRpZmllcjo6ZnJvbVN0cmluZygmdm0sICJk ZmdUcnVlIiksIDAsIGZ1bmN0aW9uREZHVHJ1ZSwgREZHVHJ1ZUludHJpbnNpYywgc3RhdGljX2Nh c3Q8dW5zaWduZWQ+KFByb3BlcnR5QXR0cmlidXRlOjpEb250RW51bSkpOwogICAgIHB1dERpcmVj dE5hdGl2ZUZ1bmN0aW9uKHZtLCBnbG9iYWxPYmplY3QsIElkZW50aWZpZXI6OmZyb21TdHJpbmco JnZtLCAiZnRsVHJ1ZSIpLCAwLCBmdW5jdGlvbkZUTFRydWUsIEZUTFRydWVJbnRyaW5zaWMsIHN0 YXRpY19jYXN0PHVuc2lnbmVkPihQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udEVudW0pKTsK