183488 2018-03-08 17:21:25 -0800 testmasm crashes in testBranchTruncateDoubleToInt32() on ARM64 2018-03-09 15:08:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff jlewis3 mark.lam ryanhaddad webkit-bug-importer oldest_to_newest 1404996 0 msaboff 2018-03-08 17:21:25 -0800 The code was written by adjusting sp down by 8 bytes. ARM64 hardware asserts that sp is 16 byte align when used as the destination of the load/store. The fix is to keep the stack aligned. 1404999 1 335371 msaboff 2018-03-08 17:30:08 -0800 Created attachment 335371 Patch for landing 1405011 2 msaboff 2018-03-08 17:46:25 -0800 Committed r229446: <https://trac.webkit.org/changeset/229446> 1405012 3 webkit-bug-importer 2018-03-08 17:47:18 -0800 <rdar://problem/38285026> 1405193 4 ryanhaddad 2018-03-09 10:00:14 -0800 Reverted r229446 for reason: This change relies on changes that have been rolled out. Committed r229464: <https://trac.webkit.org/changeset/229464> 1405282 5 jlewis3 2018-03-09 13:15:34 -0800 This looks to have broke The High Sierra LLINT CLoop build when it was re-landed in https://trac.webkit.org/changeset/229476/webkit https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/4330 https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/4330/steps/compile-webkit/logs/stdio /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:45:80: error: use of undeclared identifier 'CallFrame' /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:45:116: error: use of undeclared identifier 'CallFrame' /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:52:85: error: use of undeclared identifier 'CallerFrameAndPC' /Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:52:122: error: use of undeclared identifier 'CallerFrameAndPC' 1405334 6 mark.lam 2018-03-09 15:04:14 -0800 Michael relanded the patch in r229476: <http://trac.webkit.org/r229476>. 1405341 7 mark.lam 2018-03-09 15:08:10 -0800 Build fix landed in r229486: <http://trac.webkit.org/r229486>. 335371 2018-03-08 17:30:08 -0800 2018-03-08 17:30:08 -0800 Patch for landing 183488.patch text/plain 2142 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5NDQyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTAzLTA4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIHRlc3RtYXNtIGNyYXNoZXMgaW4gdGVzdEJyYW5jaFRydW5jYXRlRG91YmxlVG9JbnQzMigp IG9uIEFSTTY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODM0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAgICBVc2lu ZyBzdGFja0FsaWdubWVudEJ5dGVzKCkgd2lsbCBrZWVwIHRoZSBzdGFjayBwcm9wZXJseSBhbGln bmVkLgorCisgICAgICAgICogYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcDoKKyAgICAgICAgKEpTQzo6 dGVzdEJyYW5jaFRydW5jYXRlRG91YmxlVG9JbnQzMik6CisKIDIwMTgtMDMtMDggIEtlaXRoIE1p bGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYW5v dGhlciBhdHRlbXB0IGF0IGZpeGluZyB0aGUgV2luZG93cyBidWlsZC4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvdGVzdG1hc20uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvdGVzdG1hc20uY3BwCShyZXZpc2lvbiAyMjk0NDIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL3Rlc3RtYXNtLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIkluaXRpYWxpemVUaHJlYWRpbmcu aCIKICNpbmNsdWRlICJMaW5rQnVmZmVyLmgiCiAjaW5jbHVkZSAiUHJvYmVDb250ZXh0LmgiCisj aW5jbHVkZSAiU3RhY2tBbGlnbm1lbnQuaCIKICNpbmNsdWRlIDxsaW1pdHM+CiAjaW5jbHVkZSA8 d3RmL0NvbXBpbGVyLmg+CiAjaW5jbHVkZSA8d3RmL0RhdGFMb2cuaD4KQEAgLTE5OCw3ICsxOTks NyBAQCB2b2lkIHRlc3RCcmFuY2hUcnVuY2F0ZURvdWJsZVRvSW50MzIoZG91CiAjZW5kaWYKICAg ICBDSEVDS19FUShjb21waWxlQW5kUnVuPGludD4oWyZdIChDQ2FsbEhlbHBlcnMmIGppdCkgewog ICAgICAgICBqaXQuZW1pdEZ1bmN0aW9uUHJvbG9ndWUoKTsKLSAgICAgICAgaml0LnN1YlB0cihD Q2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMig4KSwgTWFjcm9Bc3NlbWJsZXI6OnN0YWNrUG9pbnRl clJlZ2lzdGVyKTsKKyAgICAgICAgaml0LnN1YlB0cihDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0z MihzdGFja0FsaWdubWVudEJ5dGVzKCkpLCBNYWNyb0Fzc2VtYmxlcjo6c3RhY2tQb2ludGVyUmVn aXN0ZXIpOwogICAgICAgICBpZiAoaXNCaWdFbmRpYW4pIHsKICAgICAgICAgICAgIGppdC5zdG9y ZTMyKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKHZhbEFzVUludCA+PiAzMiksCiAgICAgICAg ICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6OnN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKQEAgLTIxOCw3 ICsyMTksNyBAQCB2b2lkIHRlc3RCcmFuY2hUcnVuY2F0ZURvdWJsZVRvSW50MzIoZG91CiAgICAg ICAgIGppdC5tb3ZlKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKDApLCBHUFJJbmZvOjpyZXR1 cm5WYWx1ZUdQUik7CiAKICAgICAgICAgZG9uZS5saW5rKCZqaXQpOwotICAgICAgICBqaXQuYWRk UHRyKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKDgpLCBNYWNyb0Fzc2VtYmxlcjo6c3RhY2tQ b2ludGVyUmVnaXN0ZXIpOworICAgICAgICBqaXQuYWRkUHRyKENDYWxsSGVscGVyczo6VHJ1c3Rl ZEltbTMyKHN0YWNrQWxpZ25tZW50Qnl0ZXMoKSksIE1hY3JvQXNzZW1ibGVyOjpzdGFja1BvaW50 ZXJSZWdpc3Rlcik7CiAgICAgICAgIGppdC5lbWl0RnVuY3Rpb25FcGlsb2d1ZSgpOwogICAgICAg ICBqaXQucmV0KCk7CiAgICAgfSksIGV4cGVjdGVkKTsK