183486 2018-03-08 16:42:24 -0800 WPE and GTK builds fail after moving WebCookieManager from WebProcess to NetworkProcess 2018-03-08 17:04:19 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build All Linux RESOLVED FIXED InRadar P2 Normal --- 183382 1 bfulgham webkit-unassigned bfulgham clopez mcatanzaro mrobinson webkit-bug-importer oldest_to_newest 1404979 0 bfulgham 2018-03-08 16:42:24 -0800 WPE (and GTK) Failure looks like this: [668/857] Linking CXX executable bin/WPENetworkProcess FAILED: bin/WPENetworkProcess : && /usr/lib/ccache/c++ -fdiagnostics-color=always -Wno-attributes -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -O3 -DNDEBUG -L/home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/DependenciesWPE/Root/lib -fuse-ld=gold -Wl,--disable-new-dtags Source/WebKit/CMakeFiles/NetworkProcess.dir/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp.o -o bin/WPENetworkProcess -Wl,-rpath,/home/buildbot/wpe/wpe-linux-64-release/build/WebKitBuild/Release/lib: -rdynamic lib/libWPEWebKit.so.1.0.0 lib/libWebCore.a lib/libPAL.a lib/libJavaScriptCore.a lib/libWTF.a lib/libbmalloc.a -ldl ../DependenciesWPE/Root/lib/libWPEBackend.so && : lib/libWPEWebKit.so.1.0.0: error: undefined reference to 'non-virtual thunk to WebKit::WebCookieManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)' lib/libWPEWebKit.so.1.0.0: error: undefined reference to 'WebKit::WebCookieManager::didReceiveMessage(IPC::Connection&, IPC::Decoder&)' The WebCookieManager message handling doesn't seem to be getting generated, even though it appears in the CMakeLists.txt and SourcesWPE.txt/SourcesGTK.txt files. 1404980 1 bfulgham 2018-03-08 16:44:09 -0800 See <https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/9314> for a build failure log. 1404989 2 bfulgham 2018-03-08 17:02:43 -0800 This was fixed here: Committed r229442: <https://trac.webkit.org/changeset/229442> 1404990 3 webkit-bug-importer 2018-03-08 17:04:19 -0800 <rdar://problem/38283714>