183482 2018-03-08 14:49:54 -0800 Ensure default appearance for selection form control 2018-03-08 15:21:05 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner bdakin thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1404930 0 megan_gardner 2018-03-08 14:49:54 -0800 Ensure default appearance for selection form control 1404933 1 335350 megan_gardner 2018-03-08 14:51:57 -0800 Created attachment 335350 Patch 1404935 2 webkit-bug-importer 2018-03-08 14:52:35 -0800 <rdar://problem/38278174> 1404936 3 335350 thorton 2018-03-08 14:55:00 -0800 Comment on attachment 335350 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335350&action=review > Source/WebCore/rendering/RenderThemeMac.mm:340 > + LocalDefaultSystemAppearance localAppearance; Should this just be inside platformInactiveSelectionBackgroundColor, where we presumably call to NSColor? Aren't there other callers? 1404937 4 megan_gardner 2018-03-08 14:55:44 -0800 <rdar://problem/38274894> 1404948 5 megan_gardner 2018-03-08 15:19:17 -0800 possibly, but right now I'm trying to limit how deep everything is getting plumbed in the next patch. 1404949 6 megan_gardner 2018-03-08 15:21:05 -0800 https://trac.webkit.org/changeset/229438/webkit 335350 2018-03-08 14:51:57 -0800 2018-03-08 14:55:00 -0800 Patch bug-183482-20180308145157.patch text/plain 1316 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTQzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAzLTA4ICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRW5zdXJlIGRlZmF1 bHQgYXBwZWFyYW5jZSBmb3Igc2VsZWN0aW9uIGZvcm0gY29udHJvbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNDgyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFwcGVhcmFuY2UgZm9yIHNlbGVj dGlvbiBmb3JtIGNvbnRyb2xzIHdhcyBub3Qgc2V0IHRvIGRlZmF1bHQuCisKKyAgICAgICAgTm90 IGN1cnJlbnRseSB0ZXN0YWJsZSwgd2lsbCBhZGQgdGVzdHMgaW4gYSBsYXRlciBwYXRjaC4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRoZW1lTWFjOjpwbGF0Zm9ybUluYWN0aXZlTGlzdEJveFNlbGVjdGlvbkJhY2tncm91 bmRDb2xvciBjb25zdCk6CisKIDIwMTgtMDMtMDggIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIENvbXBpbGUgZXJyb3I6IHBhbC9FeHBvcnRNYWNy b3MuaCBub3QgZm91bmQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lTWFjLm1tCShyZXZpc2lvbiAyMjkzODApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTMzNyw2ICszMzcsNyBAQCBDb2xv ciBSZW5kZXJUaGVtZU1hYzo6cGxhdGZvcm1Gb2N1c1JpbmdDCiAKIENvbG9yIFJlbmRlclRoZW1l TWFjOjpwbGF0Zm9ybUluYWN0aXZlTGlzdEJveFNlbGVjdGlvbkJhY2tncm91bmRDb2xvcigpIGNv bnN0CiB7CisgICAgTG9jYWxEZWZhdWx0U3lzdGVtQXBwZWFyYW5jZSBsb2NhbEFwcGVhcmFuY2U7 CiAgICAgcmV0dXJuIHBsYXRmb3JtSW5hY3RpdmVTZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IoKTsK IH0KIAo=