<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183474</bug_id>
          
          <creation_ts>2018-03-08 13:29:40 -0800</creation_ts>
          <short_desc>MIPS+Armv7 builds are broken since r229391</short_desc>
          <delta_ts>2018-03-20 13:38:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>183786</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Guillaume Emont">guijemont</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1404881</commentid>
    <comment_count>0</comment_count>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2018-03-08 13:29:40 -0800</bug_when>
    <thetext>Some extra work is needed to make them build again (I started work on this).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405437</commentid>
    <comment_count>1</comment_count>
      <attachid>335497</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2018-03-09 19:49:06 -0800</bug_when>
    <thetext>Created attachment 335497
Patch

Preliminary patch that fixes a bunch of small things. With that, things compile on arm and mips, but will follow the x86 calling convention and therefore should be expected to fail at runtime.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405440</commentid>
    <comment_count>2</comment_count>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2018-03-09 19:58:15 -0800</bug_when>
    <thetext>From what I understood of the armv7 calling convention, it should be relatively easy to get that working, as it seems to be pretty similar to what we have for x86_64 or arm64.
Mips on the other hand has a whole bunch of special rules that will need to be put in place, especially when floats/doubles come into the equation, incuding, but not limited to:
 - a float/double passed as first argument is always in $f12
 - a float/double in second argument will be in $f14 if the first argument is a float/double, but in $a3 (or $a3 and $a4 for double) if the first argument is integral.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405441</commentid>
    <comment_count>3</comment_count>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2018-03-09 20:02:29 -0800</bug_when>
    <thetext>Also a note regarding the operationGetByValCell call: this looks like it was a bug that was found thanks to the new system, so yay! It was quite hard to find where was the offending call with the output I got from gcc though (more recent versions of gcc might be better at it, not sure, I should try).

Relatedly, I guess it would be nice to add a unit test for that operationGetByValCell call if we can.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407718</commentid>
    <comment_count>4</comment_count>
      <attachid>336132</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2018-03-20 10:53:12 -0700</bug_when>
    <thetext>Created attachment 336132
Patch

Rebased patch. A patch fixing the CCallHelpers will be provided in a separate bug by Dominik Infuehr</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407741</commentid>
    <comment_count>5</comment_count>
      <attachid>336137</attachid>
    <who name="Guillaume Emont">guijemont</who>
    <bug_when>2018-03-20 11:40:48 -0700</bug_when>
    <thetext>Created attachment 336137
Patch

Fixed CellTag → JSCellType</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407747</commentid>
    <comment_count>6</comment_count>
      <attachid>336137</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-03-20 12:26:45 -0700</bug_when>
    <thetext>Comment on attachment 336137
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407782</commentid>
    <comment_count>7</comment_count>
      <attachid>336137</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-20 13:37:51 -0700</bug_when>
    <thetext>Comment on attachment 336137
Patch

Clearing flags on attachment: 336137

Committed r229772: &lt;https://trac.webkit.org/changeset/229772&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407783</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-03-20 13:37:52 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1407784</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-03-20 13:38:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/38677603&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>335497</attachid>
            <date>2018-03-09 19:49:06 -0800</date>
            <delta_ts>2018-03-20 10:53:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183474-20180309214906.patch</filename>
            <type>text/plain</type>
            <size>3387</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKaW5kZXggYmZiNzA2YzQyN2FlMmIzODQ5N2IzODBm
NjQ4YmNhOWMwNzgwNjEzNy4uZDI1ZGEzYzFkNzRkZjYwZDBjYzM4ODk5YzMwZGQ1MjhjNzI5Mjlj
ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt
Ymxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs
ZXIuaApAQCAtMzU1LDE0ICszNTUsNiBAQCBwdWJsaWM6CiAgICAgICAgIHN0b3JlNjQoc3JjLCBh
ZGRyZXNzRm9yUG9rZShpbmRleCkpOwogICAgIH0KICNlbmRpZgotICAgIAotI2lmIENQVShNSVBT
KQotICAgIHZvaWQgcG9rZShGUFJlZ2lzdGVySUQgc3JjLCBpbnQgaW5kZXggPSAwKQotICAgIHsK
LSAgICAgICAgQVNTRVJUKCEoaW5kZXggJiAxKSk7Ci0gICAgICAgIHN0b3JlRG91YmxlKHNyYywg
YWRkcmVzc0ZvclBva2UoaW5kZXgpKTsKLSAgICB9Ci0jZW5kaWYKIAogICAgIC8vIEltbWVkaWF0
ZSBzaGlmdHMgb25seSBoYXZlIDUgY29udHJvbGxhYmxlIGJpdHMKICAgICAvLyBzbyB3ZSdsbCBj
b25zaWRlciB0aGVtIHNhZmUgZm9yIG5vdy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKaW5kZXggZmRhZWRiOTA2ZmIzZWI2
M2IyYmY0NjZiOGQ5YWQ2ODA5YTRjZDAxMS4uOTg5MDkxNmFiNGZmMTFiNDUxYTU0YzVmZGIyMGUx
YzEwMmNkZjBkMSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N
YWNyb0Fzc2VtYmxlckFSTXY3LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl
ci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKQEAgLTEzMzksNiArMTMzOSwxMyBAQCBwdWJsaWM6CiAg
ICAgICAgIG1vdmUoZGF0YVRlbXBSZWdpc3RlciwgcmVnMik7CiAgICAgfQogCisgICAgdm9pZCBz
d2FwKEZQUmVnaXN0ZXJJRCBmcjEsIEZQUmVnaXN0ZXJJRCBmcjIpCisgICAgeworICAgICAgICBt
b3ZlRG91YmxlKGZyMSwgZnBUZW1wUmVnaXN0ZXIpOworICAgICAgICBtb3ZlRG91YmxlKGZyMiwg
ZnIxKTsKKyAgICAgICAgbW92ZURvdWJsZShmcFRlbXBSZWdpc3RlciwgZnIyKTsKKyAgICB9CisK
ICAgICB2b2lkIHNpZ25FeHRlbmQzMlRvUHRyKFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRl
c3QpCiAgICAgewogICAgICAgICBtb3ZlKHNyYywgZGVzdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAppbmRleCAzZjI3MGZl
ZGJmZjdjZTMwMDQzNmY2ZWU5OTdiYmJlZWM0YzcwMGYzLi5lZDVmOWE4NjA2YmM5NWEzYTAxMjcy
YTczOTA0Y2RhZTMzYWZmYzUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz
ZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h
c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKQEAgLTI3NDksNyArMjc0OSw3IEBAIHB1Ymxp
YzoKICAgICAgICAgY29udmVydEludDMyVG9Eb3VibGUoTUlQU1JlZ2lzdGVyczo6emVybywgcmVn
KTsKICAgICB9CiAKLSAgICB2b2lkIHN3YXBEb3VibGUoRlBSZWdpc3RlcklEIGZyMSwgRlBSZWdp
c3RlcklEIGZyMikKKyAgICB2b2lkIHN3YXAoRlBSZWdpc3RlcklEIGZyMSwgRlBSZWdpc3RlcklE
IGZyMikKICAgICB7CiAgICAgICAgIG1vdmVEb3VibGUoZnIxLCBmcFRlbXBSZWdpc3Rlcik7CiAg
ICAgICAgIG1vdmVEb3VibGUoZnIyLCBmcjEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKaW5kZXggNDVlMmI2ZjllZDdiNTcz
MmViMjYzYzA1MTM4ODZmMDc1MzA1ZDBlYi4uNWEwODMxMWUyOGY2OWI0YjllNmRmYzk5ZmViOGQ2
MjdmNTQ3NWRlOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj
dWxhdGl2ZUpJVDMyXzY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw
ZWN1bGF0aXZlSklUMzJfNjQuY3BwCkBAIC00OTcxLDcgKzQ5NzEsOCBAQCB2b2lkIFNwZWN1bGF0
aXZlSklUOjpjb21waWxlKE5vZGUqIG5vZGUpCiAKICAgICAgICAgZG9uZS5saW5rKCZtX2ppdCk7
CiAKLSAgICAgICAgYWRkU2xvd1BhdGhHZW5lcmF0b3Ioc2xvd1BhdGhDYWxsKHNsb3dQYXRoLCB0
aGlzLCBvcGVyYXRpb25HZXRCeVZhbENlbGwsIHJlc3VsdFJlZ3MsIGJhc2VHUFIsIHByb3BlcnR5
R1BSKSk7CisgICAgICAgIG1faml0Lm1vdmUoTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJbW0zMihK
U1ZhbHVlOjpDZWxsVGFnKSwgc2NyYXRjaEdQUik7CisgICAgICAgIGFkZFNsb3dQYXRoR2VuZXJh
dG9yKHNsb3dQYXRoQ2FsbChzbG93UGF0aCwgdGhpcywgb3BlcmF0aW9uR2V0QnlWYWxDZWxsLCBy
ZXN1bHRSZWdzLCBiYXNlR1BSLCBKU1ZhbHVlUmVncyhzY3JhdGNoR1BSLCBwcm9wZXJ0eUdQUikp
KTsKICNlbmRpZgogCiAgICAgICAgIGpzVmFsdWVSZXN1bHQocmVzdWx0UmVncywgbm9kZSk7CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0ZQUkluZm8uaCBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCmluZGV4IDk4NTIwNzg5MmQ1MzA2YTg1ZjdjOTE5
NjUzODVhMmViMTMzNjU2NWEuLjZmZjgyNDliODQ1M2RlNWM2MmRlYjJlNzc2MGQ2ZGYwM2Q4YTI0
ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCisrKyBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCkBAIC0yNTYsNiArMjU2LDcgQEAg
Y2xhc3MgRlBSSW5mbyB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiBGUFJSZWcgUmVnaXN0ZXJUeXBl
OwogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBudW1iZXJPZlJlZ2lzdGVycyA9IDc7CisgICAg
c3RhdGljIGNvbnN0IHVuc2lnbmVkIG51bWJlck9mQXJndW1lbnRSZWdpc3RlcnMgPSAyOwogCiAg
ICAgLy8gVGVtcG9yYXJ5IHJlZ2lzdGVycy4KICAgICBzdGF0aWMgY29uc3QgRlBSUmVnIGZwUmVn
VDAgPSBNSVBTUmVnaXN0ZXJzOjpmMDsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336132</attachid>
            <date>2018-03-20 10:53:12 -0700</date>
            <delta_ts>2018-03-20 11:40:46 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183474-20180320125311.patch</filename>
            <type>text/plain</type>
            <size>3299</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKaW5kZXggYmZiNzA2YzQyN2FlMmIzODQ5N2IzODBm
NjQ4YmNhOWMwNzgwNjEzNy4uZDI1ZGEzYzFkNzRkZjYwZDBjYzM4ODk5YzMwZGQ1MjhjNzI5Mjlj
ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2Vt
Ymxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs
ZXIuaApAQCAtMzU1LDE0ICszNTUsNiBAQCBwdWJsaWM6CiAgICAgICAgIHN0b3JlNjQoc3JjLCBh
ZGRyZXNzRm9yUG9rZShpbmRleCkpOwogICAgIH0KICNlbmRpZgotICAgIAotI2lmIENQVShNSVBT
KQotICAgIHZvaWQgcG9rZShGUFJlZ2lzdGVySUQgc3JjLCBpbnQgaW5kZXggPSAwKQotICAgIHsK
LSAgICAgICAgQVNTRVJUKCEoaW5kZXggJiAxKSk7Ci0gICAgICAgIHN0b3JlRG91YmxlKHNyYywg
YWRkcmVzc0ZvclBva2UoaW5kZXgpKTsKLSAgICB9Ci0jZW5kaWYKIAogICAgIC8vIEltbWVkaWF0
ZSBzaGlmdHMgb25seSBoYXZlIDUgY29udHJvbGxhYmxlIGJpdHMKICAgICAvLyBzbyB3ZSdsbCBj
b25zaWRlciB0aGVtIHNhZmUgZm9yIG5vdy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKaW5kZXggMWJhYmM0ZGY3NzBiZmY1
MzczMzgyMjhiNDI3NmNiM2ViYzhjYmMzZi4uNTJhYTk1YjU1NWJlMWZjMDc1ZDEyMTI5ZDEzMjU4
YzA5Mjc5YjcwZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N
YWNyb0Fzc2VtYmxlckFSTXY3LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl
ci9NYWNyb0Fzc2VtYmxlckFSTXY3LmgKQEAgLTEzMzksNiArMTMzOSwxMyBAQCBwdWJsaWM6CiAg
ICAgICAgIG1vdmUoZGF0YVRlbXBSZWdpc3RlciwgcmVnMik7CiAgICAgfQogCisgICAgdm9pZCBz
d2FwKEZQUmVnaXN0ZXJJRCBmcjEsIEZQUmVnaXN0ZXJJRCBmcjIpCisgICAgeworICAgICAgICBt
b3ZlRG91YmxlKGZyMSwgZnBUZW1wUmVnaXN0ZXIpOworICAgICAgICBtb3ZlRG91YmxlKGZyMiwg
ZnIxKTsKKyAgICAgICAgbW92ZURvdWJsZShmcFRlbXBSZWdpc3RlciwgZnIyKTsKKyAgICB9CisK
ICAgICB2b2lkIHNpZ25FeHRlbmQzMlRvUHRyKFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRl
c3QpCiAgICAgewogICAgICAgICBtb3ZlKHNyYywgZGVzdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAppbmRleCAzZDQ5ZGVi
YjhmMWJkZGYyMzU0M2E3ZGVjYWFkMjczYjZlNGI2NjJlLi4wODg2ZTBkNGEzZjc1MjQwZGM4MWQ1
OTAzZjRhNTkyZjFkNjY5ODhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz
ZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h
c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKQEAgLTI3NDksNyArMjc0OSw3IEBAIHB1Ymxp
YzoKICAgICAgICAgY29udmVydEludDMyVG9Eb3VibGUoTUlQU1JlZ2lzdGVyczo6emVybywgcmVn
KTsKICAgICB9CiAKLSAgICB2b2lkIHN3YXBEb3VibGUoRlBSZWdpc3RlcklEIGZyMSwgRlBSZWdp
c3RlcklEIGZyMikKKyAgICB2b2lkIHN3YXAoRlBSZWdpc3RlcklEIGZyMSwgRlBSZWdpc3RlcklE
IGZyMikKICAgICB7CiAgICAgICAgIG1vdmVEb3VibGUoZnIxLCBmcFRlbXBSZWdpc3Rlcik7CiAg
ICAgICAgIG1vdmVEb3VibGUoZnIyLCBmcjEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKaW5kZXggNDM5MTQ1NDc4NzVhMWUw
MWI4YjMyZmI5NzdkZDc5Nzk1ZTM0ZmVmMi4uNGQzZWI5NTg3M2VkMmMwOTZlYzJlYTdkMmM2NGQ4
MWQ3NjYxYzcxOSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj
dWxhdGl2ZUpJVDMyXzY0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw
ZWN1bGF0aXZlSklUMzJfNjQuY3BwCkBAIC00OTc2LDcgKzQ5NzYsNyBAQCB2b2lkIFNwZWN1bGF0
aXZlSklUOjpjb21waWxlKE5vZGUqIG5vZGUpCiAKICAgICAgICAgZG9uZS5saW5rKCZtX2ppdCk7
CiAKLSAgICAgICAgYWRkU2xvd1BhdGhHZW5lcmF0b3Ioc2xvd1BhdGhDYWxsKHNsb3dQYXRoLCB0
aGlzLCBvcGVyYXRpb25HZXRCeVZhbENlbGwsIHJlc3VsdFJlZ3MsIGJhc2VHUFIsIHByb3BlcnR5
R1BSKSk7CisgICAgICAgIGFkZFNsb3dQYXRoR2VuZXJhdG9yKHNsb3dQYXRoQ2FsbChzbG93UGF0
aCwgdGhpcywgb3BlcmF0aW9uR2V0QnlWYWxDZWxsLCByZXN1bHRSZWdzLCBiYXNlR1BSLCBKU1Zh
bHVlOjpDZWxsVGFnLCBwcm9wZXJ0eUdQUikpOwogI2VuZGlmCiAKICAgICAgICAganNWYWx1ZVJl
c3VsdChyZXN1bHRSZWdzLCBub2RlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9qaXQvRlBSSW5mby5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9GUFJJbmZvLmgKaW5k
ZXggOTg1MjA3ODkyZDUzMDZhODVmN2M5MTk2NTM4NWEyZWIxMzM2NTY1YS4uNmZmODI0OWI4NDUz
ZGU1YzYyZGViMmU3NzYwZDZkZjAzZDhhMjRlYSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp
cHRDb3JlL2ppdC9GUFJJbmZvLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9GUFJJ
bmZvLmgKQEAgLTI1Niw2ICsyNTYsNyBAQCBjbGFzcyBGUFJJbmZvIHsKIHB1YmxpYzoKICAgICB0
eXBlZGVmIEZQUlJlZyBSZWdpc3RlclR5cGU7CiAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIG51
bWJlck9mUmVnaXN0ZXJzID0gNzsKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgbnVtYmVyT2ZB
cmd1bWVudFJlZ2lzdGVycyA9IDI7CiAKICAgICAvLyBUZW1wb3JhcnkgcmVnaXN0ZXJzLgogICAg
IHN0YXRpYyBjb25zdCBGUFJSZWcgZnBSZWdUMCA9IE1JUFNSZWdpc3RlcnM6OmYwOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>336137</attachid>
            <date>2018-03-20 11:40:48 -0700</date>
            <delta_ts>2018-03-20 13:37:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183474-20180320134047.patch</filename>
            <type>text/plain</type>
            <size>4467</size>
            <attacher name="Guillaume Emont">guijemont</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj
YmQ5Yjc3MDFmMDQ1NTRiNGM1YzYwYWMyMmEwZTRlNDhlZmU0MzBkLi45MGI1Yzc4YzFhNTY3MTQy
ZmRhMTc2NTFhMzk1MzdhZGJkMjIyMzVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwyNCBAQAorMjAxOC0wMy0yMCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp
YS5jb20+CisKKyAgICAgICAgTUlQUytBcm12NyBidWlsZHMgYXJlIGJyb2tlbiBzaW5jZSByMjI5
MzkxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM0
NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg
bWlzc2luZyBhcm12NyBhbmQgbWlwcyBvcGVyYXRpb25zIGFuZCBmaXggYXJndW1lbnRzIHRvIGEg
Y2FsbCB0bworICAgICAgICBvcGVyYXRpb25HZXRCeVZhbENlbGwuIFRoaXMgc2hvdWxkIGZpeCBj
b21waWxhdGlvbiBvbiBNSVBTIGFuZCBBcm12NworICAgICAgICAodGhvdWdoIGl0IGRvZXMgbm90
IGltcGxlbWVudCB0aGUgbWlzc2luZyBzZXR1cEFyZ3VtZW50cyBzdHVmZiBpbgorICAgICAgICBD
Q2FsbEhlbHBlcnMpLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmg6Cisg
ICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaDoKKyAgICAgICAgKEpTQzo6
TWFjcm9Bc3NlbWJsZXJBUk12Nzo6c3dhcCk6CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNz
ZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6OnN3YXApOgor
ICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6
REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZSk6CisgICAgICAgICogaml0L0ZQUkluZm8uaDoK
KwogMjAxOC0wMy0xNiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAog
ICAgICAgICBbREZHXVtGVExdIEFkZCB2ZWN0b3JMZW5ndGhIaW50IGZvciBOZXdBcnJheQpkaWZm
IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5o
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCmluZGV4
IGJmYjcwNmM0MjdhZTJiMzg0OTdiMzgwZjY0OGJjYTljMDc4MDYxMzcuLmQyNWRhM2MxZDc0ZGY2
MGQwY2MzODg5OWMzMGRkNTI4YzcyOTI5Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgKQEAgLTM1NSwxNCArMzU1LDYgQEAgcHVibGlj
OgogICAgICAgICBzdG9yZTY0KHNyYywgYWRkcmVzc0ZvclBva2UoaW5kZXgpKTsKICAgICB9CiAj
ZW5kaWYKLSAgICAKLSNpZiBDUFUoTUlQUykKLSAgICB2b2lkIHBva2UoRlBSZWdpc3RlcklEIHNy
YywgaW50IGluZGV4ID0gMCkKLSAgICB7Ci0gICAgICAgIEFTU0VSVCghKGluZGV4ICYgMSkpOwot
ICAgICAgICBzdG9yZURvdWJsZShzcmMsIGFkZHJlc3NGb3JQb2tlKGluZGV4KSk7Ci0gICAgfQot
I2VuZGlmCiAKICAgICAvLyBJbW1lZGlhdGUgc2hpZnRzIG9ubHkgaGF2ZSA1IGNvbnRyb2xsYWJs
ZSBiaXRzCiAgICAgLy8gc28gd2UnbGwgY29uc2lkZXIgdGhlbSBzYWZlIGZvciBub3cuCmRpZmYg
LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJN
djcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12
Ny5oCmluZGV4IDFiYWJjNGRmNzcwYmZmNTM3MzM4MjI4YjQyNzZjYjNlYmM4Y2JjM2YuLjUyYWE5
NWI1NTViZTFmYzA3NWQxMjEyOWQxMzI1OGMwOTI3OWI3MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCisrKyBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCkBAIC0xMzM5
LDYgKzEzMzksMTMgQEAgcHVibGljOgogICAgICAgICBtb3ZlKGRhdGFUZW1wUmVnaXN0ZXIsIHJl
ZzIpOwogICAgIH0KIAorICAgIHZvaWQgc3dhcChGUFJlZ2lzdGVySUQgZnIxLCBGUFJlZ2lzdGVy
SUQgZnIyKQorICAgIHsKKyAgICAgICAgbW92ZURvdWJsZShmcjEsIGZwVGVtcFJlZ2lzdGVyKTsK
KyAgICAgICAgbW92ZURvdWJsZShmcjIsIGZyMSk7CisgICAgICAgIG1vdmVEb3VibGUoZnBUZW1w
UmVnaXN0ZXIsIGZyMik7CisgICAgfQorCiAgICAgdm9pZCBzaWduRXh0ZW5kMzJUb1B0cihSZWdp
c3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgbW92ZShzcmMsIGRl
c3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz
c2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl
bWJsZXJNSVBTLmgKaW5kZXggM2Q0OWRlYmI4ZjFiZGRmMjM1NDNhN2RlY2FhZDI3M2I2ZTRiNjYy
ZS4uMDg4NmUwZDRhM2Y3NTI0MGRjODFkNTkwM2Y0YTU5MmYxZDY2OTg4ZSAxMDA2NDQKLS0tIGEv
U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAorKysg
Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCkBA
IC0yNzQ5LDcgKzI3NDksNyBAQCBwdWJsaWM6CiAgICAgICAgIGNvbnZlcnRJbnQzMlRvRG91Ymxl
KE1JUFNSZWdpc3RlcnM6Onplcm8sIHJlZyk7CiAgICAgfQogCi0gICAgdm9pZCBzd2FwRG91Ymxl
KEZQUmVnaXN0ZXJJRCBmcjEsIEZQUmVnaXN0ZXJJRCBmcjIpCisgICAgdm9pZCBzd2FwKEZQUmVn
aXN0ZXJJRCBmcjEsIEZQUmVnaXN0ZXJJRCBmcjIpCiAgICAgewogICAgICAgICBtb3ZlRG91Ymxl
KGZyMSwgZnBUZW1wUmVnaXN0ZXIpOwogICAgICAgICBtb3ZlRG91YmxlKGZyMiwgZnIxKTsKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82
NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQu
Y3BwCmluZGV4IDQzOTE0NTQ3ODc1YTFlMDFiOGIzMmZiOTc3ZGQ3OTc5NWUzNGZlZjIuLmQ4MWE1
ZWY5YjQzNTQ5ZWY0ZTY1MzgzMjdiNDM3YjY3Mzk4NzZiODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAKKysrIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcApAQCAtNDk3Niw3
ICs0OTc2LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogCiAg
ICAgICAgIGRvbmUubGluaygmbV9qaXQpOwogCi0gICAgICAgIGFkZFNsb3dQYXRoR2VuZXJhdG9y
KHNsb3dQYXRoQ2FsbChzbG93UGF0aCwgdGhpcywgb3BlcmF0aW9uR2V0QnlWYWxDZWxsLCByZXN1
bHRSZWdzLCBiYXNlR1BSLCBwcm9wZXJ0eUdQUikpOworICAgICAgICBhZGRTbG93UGF0aEdlbmVy
YXRvcihzbG93UGF0aENhbGwoc2xvd1BhdGgsIHRoaXMsIG9wZXJhdGlvbkdldEJ5VmFsQ2VsbCwg
cmVzdWx0UmVncywgYmFzZUdQUiwgSlNWYWx1ZTo6SlNDZWxsVHlwZSwgcHJvcGVydHlHUFIpKTsK
ICNlbmRpZgogCiAgICAgICAgIGpzVmFsdWVSZXN1bHQocmVzdWx0UmVncywgbm9kZSk7CmRpZmYg
LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0ZQUkluZm8uaCBiL1NvdXJjZS9KYXZh
U2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCmluZGV4IDk4NTIwNzg5MmQ1MzA2YTg1ZjdjOTE5NjUz
ODVhMmViMTMzNjU2NWEuLjZmZjgyNDliODQ1M2RlNWM2MmRlYjJlNzc2MGQ2ZGYwM2Q4YTI0ZWEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCisrKyBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRlBSSW5mby5oCkBAIC0yNTYsNiArMjU2LDcgQEAgY2xh
c3MgRlBSSW5mbyB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiBGUFJSZWcgUmVnaXN0ZXJUeXBlOwog
ICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBudW1iZXJPZlJlZ2lzdGVycyA9IDc7CisgICAgc3Rh
dGljIGNvbnN0IHVuc2lnbmVkIG51bWJlck9mQXJndW1lbnRSZWdpc3RlcnMgPSAyOwogCiAgICAg
Ly8gVGVtcG9yYXJ5IHJlZ2lzdGVycy4KICAgICBzdGF0aWMgY29uc3QgRlBSUmVnIGZwUmVnVDAg
PSBNSVBTUmVnaXN0ZXJzOjpmMDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>