183468 2018-03-08 11:42:11 -0800 Resource Load Statistics: Make debug mode always partition prevalent resources 2018-03-08 13:36:03 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183476 InRadar P2 Normal --- 1 wilander wilander bfulgham webkit-bug-importer oldest_to_newest 1404844 0 wilander 2018-03-08 11:42:11 -0800 After some testing we decided that a 30 second timeout in ITP debug mode just makes it confusing. We should instead always partition prevalent resources in debug mode to make it easy to understand. The partitioned state is what developers want to test anyway. 1404846 1 wilander 2018-03-08 11:43:34 -0800 <rdar://problem/38269437> 1404857 2 335327 wilander 2018-03-08 12:22:21 -0800 Created attachment 335327 Patch 1404869 3 335327 bfulgham 2018-03-08 13:06:38 -0800 Comment on attachment 335327 Patch Awesome! This should help us run through our tests more quickly, too. Thanks for adjusting this! 1404871 4 wilander 2018-03-08 13:11:52 -0800 Committed r229427: <https://trac.webkit.org/changeset/229427> 335327 2018-03-08 12:22:21 -0800 2018-03-08 13:06:38 -0800 Patch bug-183468-20180308122220.patch text/plain 6908 wilander SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjk0MjMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDE4LTAzLTA4ICBKb2huIFdpbGFu ZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlz dGljczogTWFrZSBkZWJ1ZyBtb2RlIGFsd2F5cyBwYXJ0aXRpb24gcHJldmFsZW50IHJlc291cmNl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzNDY4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zODI2OTQzNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBzb21lIHRlc3Rpbmcgd2UgZGVjaWRl ZCB0aGF0IGEgMzAgc2Vjb25kIHRpbWVvdXQgaW4gSVRQIGRlYnVnIG1vZGUganVzdCBtYWtlcwor ICAgICAgICBpdCBjb25mdXNpbmcuIFdlIHNob3VsZCBpbnN0ZWFkIGFsd2F5cyBwYXJ0aXRpb24g cHJldmFsZW50IHJlc291cmNlcyBpbiBkZWJ1ZyBtb2RlCisgICAgICAgIHRvIG1ha2UgaXQgZWFz eSB0byB1bmRlcnN0YW5kLiBUaGUgcGFydGl0aW9uZWQgc3RhdGUgaXMgd2hhdCBkZXZlbG9wZXJz IHdhbnQgdG8gdGVzdAorICAgICAgICBhbnl3YXkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29j b2EvV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlQ29jb2EubW06CisgICAgICAgIChXZWJL aXQ6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6cmVnaXN0ZXJVc2VyRGVmYXVsdHNJ Zk5lZWRlZCk6CisgICAgICAgICAgICBNaW5vciBjaGFuZ2UgdG8gaW5jbHVkZSAwIGFzIHZhbGlk IHNldHRpbmcuCisgICAgICAgICogVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NT dG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9y ZTo6c2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnTW9kZSk6CisgICAgICAgICAgICBOb3cg anVzdCBzdG9yZXMgdGhlIHNldHRpbmcgb2YgZGVidWcgbW9kZSBpbnN0ZWFkIG9mIGNoYW5naW5n IHRoZSB0aW1lb3V0LgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNz U3RvcmU6OmxvZ1VzZXJJbnRlcmFjdGlvbik6CisgICAgICAgICAgICBOb3cgZG9lcyBub3QgZGlz YWJsZSBwYXJ0aXRpb25pbmcgdW5kZXIgZGVidWcgbW9kZS4KKyAgICAgICAgKFdlYktpdDo6V2Vi UmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpzaG91bGRQYXJ0aXRpb25Db29raWVzIGNvbnN0 KToKKyAgICAgICAgICAgIE5vdyByZXR1cm5zIHRydWUgZm9yIHByZXZhbGVudCByZXNvdXJjZXMg d2l0aCB1c2VyIGludGVyYWN0aW9uIHVuZGVyIGRlYnVnIG1vZGUuICAgICAgICAgICAgCisgICAg ICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6dXBkYXRlQ29va2ll UGFydGl0aW9uaW5nKToKKyAgICAgICAgICAgIFJlbW92ZWQgZHVwbGljYXRlIGRlYnVnIGxvZ2dp bmcgc3RhdGVtZW50LgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0 aWNzU3RvcmUuaDoKKyAgICAgICAgICAgIEFkZGVkIG1lbWJlciBtX2RlYnVnTW9kZUVuYWJsZWQu CisKIDIwMTgtMDMtMDggIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIGxpYndlYnJ0YyB1cGRhdGUgYnJva2UgaW50ZXJuYWwgYnVpbGRzCkluZGV4OiBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRpc3Rp Y3NTdG9yZS5jcHAJKHJldmlzaW9uIDIyOTM1MSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0 MywxMCArNDQzLDEwIEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlOjpzdWIK IAogdm9pZCBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OnNldFJlc291cmNlTG9hZFN0 YXRpc3RpY3NEZWJ1Z01vZGUoYm9vbCBlbmFibGUpCiB7Ci0gICAgaWYgKGVuYWJsZSkKLSAgICAg ICAgc2V0VGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZyZWUoMzBfcyk7Ci0gICAgZWxzZQotICAg ICAgICByZXNldFBhcmFtZXRlcnNUb0RlZmF1bHRWYWx1ZXMoKTsKKyAgICBtX2RlYnVnTW9kZUVu YWJsZWQgPSBlbmFibGU7CisjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECisgICAgUkVMRUFTRV9M T0dfSU5GT19JRihtX2RlYnVnTG9nZ2luZ0VuYWJsZWQsIFJlc291cmNlTG9hZFN0YXRpc3RpY3NE ZWJ1ZywgIklUUCBEZWJ1ZyBNb2RlICV7cHVibGljfXMuIiwgKG1fZGVidWdNb2RlRW5hYmxlZCA/ ICJlbmFibGVkIiA6ICJkaXNhYmxlZCIpKTsKKyNlbmRpZgogfQogCiB2b2lkIFdlYlJlc291cmNl TG9hZFN0YXRpc3RpY3NTdG9yZTo6bG9nVXNlckludGVyYWN0aW9uKGNvbnN0IFVSTCYgdXJsKQpA QCAtNDU5LDggKzQ1OSwxMiBAQCB2b2lkIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6 bG9nCiAgICAgICAgIHN0YXRpc3RpY3MuaGFkVXNlckludGVyYWN0aW9uID0gdHJ1ZTsKICAgICAg ICAgc3RhdGlzdGljcy5tb3N0UmVjZW50VXNlckludGVyYWN0aW9uVGltZSA9IFdhbGxUaW1lOjpu b3coKTsKIAotICAgICAgICBpZiAoc3RhdGlzdGljcy5pc01hcmtlZEZvckNvb2tpZVBhcnRpdGlv bmluZyB8fCBzdGF0aXN0aWNzLmlzTWFya2VkRm9yQ29va2llQmxvY2tpbmcpCi0gICAgICAgICAg ICB1cGRhdGVDb29raWVQYXJ0aXRpb25pbmdGb3JEb21haW5zKHsgfSwgeyB9LCB7IHByaW1hcnlE b21haW4gfSwgU2hvdWxkQ2xlYXJGaXJzdDo6Tm8sIFtdKCkgeyB9KTsKKyAgICAgICAgaWYgKG1f ZGVidWdNb2RlRW5hYmxlZCkgeworICAgICAgICAgICAgaWYgKHN0YXRpc3RpY3MuaXNNYXJrZWRG b3JDb29raWVCbG9ja2luZykKKyAgICAgICAgICAgICAgICB1cGRhdGVDb29raWVQYXJ0aXRpb25p bmdGb3JEb21haW5zKHsgcHJpbWFyeURvbWFpbiB9LCB7IH0sIHsgfSwgU2hvdWxkQ2xlYXJGaXJz dDo6Tm8sIFtdKCkgeyB9KTsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBpZiAoc3RhdGlz dGljcy5pc01hcmtlZEZvckNvb2tpZVBhcnRpdGlvbmluZyB8fCBzdGF0aXN0aWNzLmlzTWFya2Vk Rm9yQ29va2llQmxvY2tpbmcpCisgICAgICAgICAgICAgICAgdXBkYXRlQ29va2llUGFydGl0aW9u aW5nRm9yRG9tYWlucyh7IH0sIHsgfSwgeyBwcmltYXJ5RG9tYWluIH0sIFNob3VsZENsZWFyRmly c3Q6Ok5vLCBbXSgpIHsgfSk7CiAgICAgfSk7CiB9CiAKQEAgLTk1NSw2ICs5NTksOSBAQCB2b2lk IFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6bWVyCiAKIGJvb2wgV2ViUmVzb3VyY2VM b2FkU3RhdGlzdGljc1N0b3JlOjpzaG91bGRQYXJ0aXRpb25Db29raWVzKGNvbnN0IFJlc291cmNl TG9hZFN0YXRpc3RpY3MmIHN0YXRpc3RpYykgY29uc3QKIHsKKyAgICBpZiAobV9kZWJ1Z01vZGVF bmFibGVkKQorICAgICAgICByZXR1cm4gc3RhdGlzdGljLmlzUHJldmFsZW50UmVzb3VyY2UgJiYg c3RhdGlzdGljLmhhZFVzZXJJbnRlcmFjdGlvbjsKKwogICAgIHJldHVybiBzdGF0aXN0aWMuaXNQ cmV2YWxlbnRSZXNvdXJjZSAmJiBzdGF0aXN0aWMuaGFkVXNlckludGVyYWN0aW9uICYmIFdhbGxU aW1lOjpub3coKSA+IHN0YXRpc3RpYy5tb3N0UmVjZW50VXNlckludGVyYWN0aW9uVGltZSArIG1f cGFyYW1ldGVycy50aW1lVG9MaXZlQ29va2llUGFydGl0aW9uRnJlZTsKIH0KIApAQCAtMTAwMyw3 ICsxMDEwLDYgQEAgdm9pZCBXZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmU6OnVwZAogICAg ICAgICAgICAgICAgIGlzRmlyc3REb21haW4gPSBmYWxzZTsKICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIFJFTEVBU0VfTE9HX0lORk8oUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RlYnVnLCAiQWJv dXQgdG8gcGFydGl0aW9uIGNvb2tpZXMgaW4gdGhpcmQtcGFydHkgY29udGV4dHMgZm9yICV7cHVi bGljfXMuIiwgZG9tYWluc1RvUGFydGl0aW9uQnVpbGRlci50b1N0cmluZygpLnV0ZjgoKS5kYXRh KCkpOwotICAgICAgICAgICAgUkVMRUFTRV9MT0dfSU5GTyhSZXNvdXJjZUxvYWRTdGF0aXN0aWNz RGVidWcsICJBYm91dCB0byBwYXJ0aXRpb24gY29va2llcyBpbiB0aGlyZC1wYXJ0eSBjb250ZXh0 cyBmb3IgJXMuIiwgZG9tYWluc1RvUGFydGl0aW9uQnVpbGRlci50b1N0cmluZygpLnV0ZjgoKS5k YXRhKCkpOwogICAgICAgICB9CiAKICAgICAgICAgaWYgKCFkb21haW5zVG9CbG9jay5pc0VtcHR5 KCkpIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJlc291cmNlTG9hZFN0YXRp c3RpY3NTdG9yZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlJl c291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZS5oCShyZXZpc2lvbiAyMjkzNTEpCisrKyBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmUuaAkod29ya2lu ZyBjb3B5KQpAQCAtMjI0LDYgKzIyNCw3IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICBib29sIG1f ZGF0YVJlY29yZHNCZWluZ1JlbW92ZWQgeyBmYWxzZSB9OwogCisgICAgYm9vbCBtX2RlYnVnTW9k ZUVuYWJsZWQgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9kZWJ1Z0xvZ2dpbmdFbmFibGVkIHsgZmFs c2UgfTsKIAogICAgIEZ1bmN0aW9uPHZvaWQgKGNvbnN0IFN0cmluZyYpPiBtX3N0YXRpc3RpY3NU ZXN0aW5nQ2FsbGJhY2s7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJS ZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmVDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzU3RvcmVDb2Nv YS5tbQkocmV2aXNpb24gMjI5MzUxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2Ev V2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAg LTM4LDE1ICszOCwxNSBAQCB2b2lkIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NTdG9yZTo6cmVn CiAgICAgICAgICAgICBzZXRUaW1lVG9MaXZlVXNlckludGVyYWN0aW9uKHRpbWVUb0xpdmVVc2Vy SW50ZXJhY3Rpb24pOwogCiAgICAgICAgIFNlY29uZHMgdGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlv bkZyZWUoW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gZG91YmxlRm9yS2V5 OkAiUmVzb3VyY2VMb2FkU3RhdGlzdGljc1RpbWVUb0xpdmVDb29raWVQYXJ0aXRpb25GcmVlIl0p OwotICAgICAgICBpZiAodGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZyZWUgPiAwX3MgJiYgdGlt ZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZyZWUgPD0gMjRfaCkKKyAgICAgICAgaWYgKHRpbWVUb0xp dmVDb29raWVQYXJ0aXRpb25GcmVlID49IDBfcyAmJiB0aW1lVG9MaXZlQ29va2llUGFydGl0aW9u RnJlZSA8PSAyNF9oKQogICAgICAgICAgICAgc2V0VGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZy ZWUodGltZVRvTGl2ZUNvb2tpZVBhcnRpdGlvbkZyZWUpOwogCiAgICAgICAgIFNlY29uZHMgbWlu aW11bVRpbWVCZXR3ZWVuRGF0YVJlY29yZHNSZW1vdmFsKFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRh cmRVc2VyRGVmYXVsdHNdIGRvdWJsZUZvcktleTpAIlJlc291cmNlTG9hZFN0YXRpc3RpY3NNaW5p bXVtVGltZUJldHdlZW5EYXRhUmVjb3Jkc1JlbW92YWwiXSk7Ci0gICAgICAgIGlmIChtaW5pbXVt VGltZUJldHdlZW5EYXRhUmVjb3Jkc1JlbW92YWwgPiAwX3MgJiYgbWluaW11bVRpbWVCZXR3ZWVu RGF0YVJlY29yZHNSZW1vdmFsIDwgMV9oKQorICAgICAgICBpZiAobWluaW11bVRpbWVCZXR3ZWVu RGF0YVJlY29yZHNSZW1vdmFsID49IDBfcyAmJiBtaW5pbXVtVGltZUJldHdlZW5EYXRhUmVjb3Jk c1JlbW92YWwgPCAxX2gpCiAgICAgICAgICAgICBzZXRNaW5pbXVtVGltZUJldHdlZW5EYXRhUmVj b3Jkc1JlbW92YWwobWluaW11bVRpbWVCZXR3ZWVuRGF0YVJlY29yZHNSZW1vdmFsKTsKIAogICAg ICAgICBTZWNvbmRzIGdyYW5kZmF0aGVyaW5nVGltZShbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJk VXNlckRlZmF1bHRzXSBkb3VibGVGb3JLZXk6QCJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzR3JhbmRm YXRoZXJpbmdUaW1lIl0pOwotICAgICAgICBpZiAoZ3JhbmRmYXRoZXJpbmdUaW1lID4gMF9zICYm IGdyYW5kZmF0aGVyaW5nVGltZSA8PSAyNF9oICogNykKKyAgICAgICAgaWYgKGdyYW5kZmF0aGVy aW5nVGltZSA+PSAwX3MgJiYgZ3JhbmRmYXRoZXJpbmdUaW1lIDw9IDI0X2ggKiA3KQogICAgICAg ICAgICAgc2V0R3JhbmRmYXRoZXJpbmdUaW1lKGdyYW5kZmF0aGVyaW5nVGltZSk7CiAKICAgICAg ICAgc2V0RGVidWdMb2dnZ2luZ0VuYWJsZWQoW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJE ZWZhdWx0c10gYm9vbEZvcktleTpAIlJlc291cmNlTG9hZFN0YXRpc3RpY3NEZWJ1Z0xvZ2dpbmdF bmFibGVkIl0pOwo=