183455 2018-03-08 09:25:18 -0800 Possible null dereference of the page under WebFrameNetworkingContext::storageSession() 2018-03-08 11:18:55 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez aakash_jain achristensen commit-queue webkit-bug-importer youennf oldest_to_newest 1404762 0 cdumez 2018-03-08 09:25:18 -0800 Possible null dereference of the page under WebFrameNetworkingContext::storageSession(): --> Crashing stack is: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Subtype: KERN_INVALID_ADDRESS at 0x0000000000000878 Thread 3 (WebThread) Crashed: 0 WebCore 0x000000018bca9d98 WebCore::Page::sessionID() const + 0 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7605.1.33.0.2/page/Page.cpp:2111) x0: 0x0000000000000000 (this) = NULL 1 WebKitLegacy 0x000000018c38a204 WebFrameNetworkingContext::storageSession() const + 24 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WebKit/WebKit-7605.1.33.0.2/mac/WebCoreSupport/WebFrameNetworkingContext.mm:96) x0: 0x0000000000000000 (this->m_Frame->m_page) = NULL x8: 0x000000010d5e0900 (this->m_Frame) 2 WebCore 0x000000018b27a8bc WebCore::ResourceHandle::willSendRequest(WebCore::ResourceRequest&&, WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&)>&&) + 1012 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7605.1.33.0.2/platform/network/mac/ResourceHandleMac.mm:456) 3 WebCore 0x000000018b27ff88 WTF::Function<void ()>::CallableWrapper<-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]::$_1>::call() + 208 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7605.1.33.0.2/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:160) 4 JavaScriptCore 0x000000018970d7d4 WTF::dispatchFunctionsFromMainThread() + 344 (/BuildRoot/Library/Caches/com.apple.xbs/Binaries/WTF/install/Root/usr/local/include/wtf/Function.h:56) 5 JavaScriptCore 0x0000000189834650 WTF::timerFired(__CFRunLoopTimer*, void*) + 40 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WTF/WTF-7605.1.33.0.2/wtf/mac/MainThreadMac.mm:110) 6 CoreFoundation 0x0000000182298aa8 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 28 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/CoreFoundation/Foundation-1452.23/CoreFoundation/RunLoop.subproj/CFRunLoop.c:1832) 7 CoreFoundation 0x000000018229876c __CFRunLoopDoTimer + 864 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/CoreFoundation/Foundation-1452.23/CoreFoundation/RunLoop.subproj/CFRunLoop.c:2415) 8 CoreFoundation 0x0000000182298010 __CFRunLoopDoTimers + 248 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/CoreFoundation/Foundation-1452.23/CoreFoundation/RunLoop.subproj/CFRunLoop.c:2562) 9 CoreFoundation 0x0000000182295b60 __CFRunLoopRun + 2168 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/CoreFoundation/Foundation-1452.23/CoreFoundation/RunLoop.subproj/CFRunLoop.c:0) 10 CoreFoundation 0x00000001821b5da8 CFRunLoopRunSpecific + 552 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/CoreFoundation/Foundation-1452.23/CoreFoundation/RunLoop.subproj/CFRunLoop.c:3245) 11 WebCore 0x000000018acfedcc RunWebThread(void*) + 592 (/BuildRoot/Library/Caches/com.apple.xbs/Sources/WebCore/WebCore-7605.1.33.0.2/platform/ios/wak/WebCoreThread.mm:624) 12 libsystem_pthread.dylib 0x0000000181f19220 _pthread_body + 272 (~rc/Software/Fatsa/Projects/libpthread/libpthread-301.50.1/src/pthread.c:740) 13 libsystem_pthread.dylib 0x0000000181f19110 _pthread_start + 292 (~rc/Software/Fatsa/Projects/libpthread/libpthread-301.50.1/src/pthread.c:799) 14 libsystem_pthread.dylib 0x0000000181f17b10 thread_start + 4 1404763 1 cdumez 2018-03-08 09:25:34 -0800 <rdar://problem/38191749> 1404768 2 335306 cdumez 2018-03-08 09:28:56 -0800 Created attachment 335306 Patch 1404797 3 335306 commit-queue 2018-03-08 10:29:13 -0800 Comment on attachment 335306 Patch Rejecting attachment 335306 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335306, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6858890 1404803 4 335306 commit-queue 2018-03-08 10:42:03 -0800 Comment on attachment 335306 Patch Rejecting attachment 335306 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 335306, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: arsed 2 diffs from patch file(s). patching file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm Hunk #1 FAILED at 93. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/6859146 1404804 5 cdumez 2018-03-08 10:43:51 -0800 Apparently got committed anyway in r229414. 1404822 6 aakash_jain 2018-03-08 11:18:55 -0800 (In reply to WebKit Commit Bot from comment #3) > mechanize/_urllib2_fork.py", line 1118, in do_open > raise URLError(err) > urllib2.URLError: <urlopen error [Errno 60] Operation timed out> > > Full output: http://webkit-queues.webkit.org/results/6858890 Tracking commit-queue issue in https://bugs.webkit.org/show_bug.cgi?id=183463 335306 2018-03-08 09:28:56 -0800 2018-03-08 10:42:03 -0800 Patch bug-183455-20180308092855.patch text/plain 2092 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggZTAwMjY4MjFjNDg2YjE2NDAyNTRmMTBmMmNiMjRmMTRiMDE0MGE3OC4uZTA1MjIyNTFmZTA4 NjJmNGE4YjJhMmQzNGIzMjJkMTQ1M2E4YzI2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAzLTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CisKKyAgICAgICAgUG9zc2libGUgbnVsbCBkZXJlZmVyZW5jZSBvZiB0aGUgcGFnZSB1 bmRlciBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0OjpzdG9yYWdlU2Vzc2lvbigpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM0NTUKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzM4MTkxNzQ5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgZm9yIHRoZSBwYWdlIGFzIHdlIGhh dmUgZXZpZGVuY2UgZnJvbSBjcmFzaGVzIHRoYXQgaXQgY2FuIGJlIG51bGwuCisgICAgICAgIE90 aGVyIGZ1bmN0aW9ucyBpbiBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0IGFscmVhZHkgbnVsbCBj aGVjayB0aGUgcGFnZSBhcyB3ZWxsLAorICAgICAgICBub3QganVzdCB0aGUgZnJhbWUgc28gdGhp cyBpcyBjb25zaXN0ZW50LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVOZXR3 b3JraW5nQ29udGV4dC5tbToKKyAgICAgICAgKFdlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OnN0 b3JhZ2VTZXNzaW9uIGNvbnN0KToKKwogMjAxOC0wMy0wOCAgWXVzdWtlIFN1enVraSAgPHV0YXRh bmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBBZGQgaW5oZXJpdHM8VD4oVk0mKSBs ZXZlcmFnaW5nIEpTQ2FzdCBmYXN0IHBhdGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdh Y3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRleHQubW0gYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZU5ldHdvcmtpbmdDb250 ZXh0Lm1tCmluZGV4IGM3ZDlhMzI4MjViYTlhNGI3YzQ0MWNkZTEwZTVlODc5Njg4NTY3YWIuLjE5 ZjUxY2QwZTA4Yjk3NGVlYjU3ODYwNWRlN2QzMDY0NmI4ZWUyZDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTmV0d29ya2luZ0NvbnRl eHQubW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVOZXR3b3JraW5nQ29udGV4dC5tbQpAQCAtOTMsNyArOTMsNyBAQCBSZXNvdXJjZUVycm9yIFdl YkZyYW1lTmV0d29ya2luZ0NvbnRleHQ6OmJsb2NrZWRFcnJvcihjb25zdCBSZXNvdXJjZVJlcXVl c3QmIHJlcQogTmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBXZWJGcmFtZU5ldHdvcmtpbmdDb250ZXh0 OjpzdG9yYWdlU2Vzc2lvbigpIGNvbnN0CiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK LSAgICBpZiAoZnJhbWUoKSAmJiBmcmFtZSgpLT5wYWdlKCktPnNlc3Npb25JRCgpLmlzRXBoZW1l cmFsKCkpIHsKKyAgICBpZiAoZnJhbWUoKSAmJiBmcmFtZSgpLT5wYWdlKCkgJiYgZnJhbWUoKS0+ cGFnZSgpLT5zZXNzaW9uSUQoKS5pc0VwaGVtZXJhbCgpKSB7CiAgICAgICAgIGlmIChhdXRvKiBz ZXNzaW9uID0gTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzdG9yYWdlU2Vzc2lvbihQQUw6OlNlc3Np b25JRDo6bGVnYWN5UHJpdmF0ZVNlc3Npb25JRCgpKSkKICAgICAgICAgICAgIHJldHVybiAqc2Vz c2lvbjsKICAgICAgICAgLy8gU29tZSByZXF1ZXN0cyBtYXkgc3RpbGwgYmUgY29taW5nIHNob3J0 bHkgYmVmb3JlIFdlYkNvcmUgdXBkYXRlcyB0aGUgc2Vzc2lvbiBJRCBhbmQgYWZ0ZXIgV2ViS2l0 IGRlc3Ryb3lzIHRoZSBwcml2YXRlIGJyb3dzaW5nIHNlc3Npb24uCg==