18342 2008-04-07 07:56:09 -0700 Add logging to HTTP soup backend 2008-04-10 17:55:36 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned alp danw mrowe oldest_to_newest 76499 0 xan.lopez 2008-04-07 07:56:09 -0700 Patch attached. 76500 1 20381 xan.lopez 2008-04-07 07:57:52 -0700 Created attachment 20381 0001-Add-logging-to-http-soup-backend.patch 76511 2 danw 2008-04-07 09:50:16 -0700 You should unref the logger after attaching it to the session. (It doesn't really matter since the session is never destroyed anyway, so it doesn't actually cause a leak, but...) Any reason you used two environment variables instead of just one? 76515 3 xan.lopez 2008-04-07 10:03:10 -0700 (In reply to comment #2) > You should unref the logger after attaching it to the session. (It doesn't > really matter since the session is never destroyed anyway, so it doesn't > actually cause a leak, but...) Right, actually thought about that after sending the patch... fixed in the next patch anyway. > > Any reason you used two environment variables instead of just one? > Not really, might be handy if it could be changed at run-time, but I guess there is no point right now (and you could still manage with one variable anyway). 76516 4 20382 xan.lopez 2008-04-07 10:03:31 -0700 Created attachment 20382 0001-Add-logging-to-http-soup-backend.patch 76518 5 20383 xan.lopez 2008-04-07 10:05:16 -0700 Created attachment 20383 0001-Add-logging-to-http-soup-backend.patch Fix ChangeLog 76524 6 mrowe 2008-04-07 10:36:42 -0700 What is the behaviour if I pass a value for WEBKIT_SOUP_LOGGING outside of the range 0-3? 76538 7 xan.lopez 2008-04-07 13:26:11 -0700 (In reply to comment #6) > What is the behaviour if I pass a value for WEBKIT_SOUP_LOGGING outside of the > range 0-3? > As far as I understand the code the value is checked progressively against 0/1/2 and if it's not equal it's assumed to be the maximum verbosity value. We can clamp it here or, maybe better, soup should warn about invalid values. 77223 8 20383 alp 2008-04-10 17:53:17 -0700 Comment on attachment 20383 0001-Add-logging-to-http-soup-backend.patch Think this is fine, no need to clamp. This will help debug the soup backend, r=me 77224 9 alp 2008-04-10 17:55:36 -0700 Landed in r31792. 20381 2008-04-07 07:57:52 -0700 2008-04-07 10:03:31 -0700 0001-Add-logging-to-http-soup-backend.patch 0001-Add-logging-to-http-soup-backend.patch text/plain 2315 xan.lopez RnJvbSA1YzJkOGRmMjAwZjVkMjljZjgyNmNlOTI1OWE4ZTM0Y2E1Y2I2ZGZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IE1vbiwg NyBBcHIgMjAwOCAxNzo1NzoyMyArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBsb2dnaW5nIHRv IGh0dHAgc291cCBiYWNrZW5kLgoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3Jt L25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDE1ICsrKysrKysrKysr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTA3NDFiZi4uYWMwYmYyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOC0wNC0wNyAgWGFuIExvcGV6ICA8 eGFuQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAg ICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM0MgorICAgICAgICBC dWcgIzE4MzQyIC0gQWRkIGxvZ2dpbmcgdG8gSFRUUCBzb3VwIGJhY2tlbmQKKyAgICAgICAgCisg ICAgICAgIEFkZCBzb3VwIGxvZ2dpbmcgZmFjaWxpdGllcyB0byBIVFRQIHNvdXAgYmFja2VuZC4K KyAgICAgICAgRW5hYmxlIHdpdGggV0VCS0lUX1NPVVBfTE9HR0lORyBhbmQgY29udHJvbCB0aGUg dmVyYm9zaXR5IHdpdGgKKyAgICAgICAgV0VCS0lUX1NPVVBfTE9HX0xFVkVMICgwIC0gbWluLCAz IG1heCkuCisgICAgICAgIAorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJj ZUhhbmRsZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnN0YXJ0 KToKKwogMjAwOC0wNC0wNyAgTHVjYSBCcnVubyAgPGxldGhhbG1hbjg4QGdtYWlsLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbHAgVG9rZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCA5NjY0MjhlLi5iOTg5 ZDA1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhh bmRsZVNvdXAuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHAKQEAgLTI0NCw4ICsyNDQsMjEgQEAgYm9vbCBSZXNvdXJjZUhhbmRsZTo6 c3RhcnQoRnJhbWUqIGZyYW1lKQogICAgICAgICBkLT5tX3Jlc3BvbnNlLnNldE1pbWVUeXBlKE1J TUVUeXBlUmVnaXN0cnk6OmdldE1JTUVUeXBlRm9yUGF0aChTdHJpbmcodXJsU3RyaW5nKSkpOwog ICAgIH0KIAotICAgIGlmICghc2Vzc2lvbikKKyAgICBpZiAoIXNlc3Npb24pIHsKICAgICAgICAg c2Vzc2lvbiA9IHNvdXBfc2Vzc2lvbl9hc3luY19uZXcoKTsKKyAgICAgICAgaWYgKGdfZ2V0ZW52 KCJXRUJLSVRfU09VUF9MT0dHSU5HIikpIHsKKyAgICAgICAgICAgIGNvbnN0IGNoYXIqIHNvdXBf ZGVidWcgPSBnX2dldGVudigiV0VCS0lUX1NPVVBfTE9HX0xFVkVMIik7CisgICAgICAgICAgICBp bnQgc291cF9kZWJ1Z19sZXZlbDsKKworICAgICAgICAgICAgaWYgKHNvdXBfZGVidWcpCisgICAg ICAgICAgICAgICAgc291cF9kZWJ1Z19sZXZlbCA9IGF0b2koc291cF9kZWJ1Zyk7CisgICAgICAg ICAgICBlbHNlCisgICAgICAgICAgICAgICAgc291cF9kZWJ1Z19sZXZlbCA9IFNPVVBfTE9HR0VS X0xPR19IRUFERVJTOworCisgICAgICAgICAgICBTb3VwTG9nZ2VyKiBsb2dnZXIgPSBzb3VwX2xv Z2dlcl9uZXcoc3RhdGljX2Nhc3Q8U291cExvZ2dlckxvZ0xldmVsPihzb3VwX2RlYnVnX2xldmVs KSwgLTEpOworICAgICAgICAgICAgc291cF9sb2dnZXJfYXR0YWNoKGxvZ2dlciwgc2Vzc2lvbik7 CisgICAgICAgIH0KKyAgICB9CiAKICAgICBTb3VwTWVzc2FnZSogbXNnOwogICAgIG1zZyA9IHNv dXBfbWVzc2FnZV9uZXcocmVxdWVzdCgpLmh0dHBNZXRob2QoKS51dGY4KCkuZGF0YSgpLCB1cmxT dHJpbmcudXRmOCgpLmRhdGEoKSk7Ci0tIAoxLjUuNC41Cgo= 20382 2008-04-07 10:03:31 -0700 2008-04-07 10:05:16 -0700 0001-Add-logging-to-http-soup-backend.patch 0001-Add-logging-to-http-soup-backend.patch text/plain 2176 xan.lopez RnJvbSA3ZDAzMjRlNTkwMWQyYmYxMDE5MDg2YjQ4ZWVkNjUwZGNkYjU3MjFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IE1vbiwg NyBBcHIgMjAwOCAxNzo1NzoyMyArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBsb2dnaW5nIHRv IGh0dHAgc291cCBiYWNrZW5kLgoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3Jt L25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDExICsrKysrKysrKyst CiAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMDc0 MWJmLi5hYzBiZjI3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA4LTA0LTA3ICBYYW4gTG9wZXogIDx4YW5A Z25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzQyCisgICAgICAgIEJ1ZyAj MTgzNDIgLSBBZGQgbG9nZ2luZyB0byBIVFRQIHNvdXAgYmFja2VuZAorICAgICAgICAKKyAgICAg ICAgQWRkIHNvdXAgbG9nZ2luZyBmYWNpbGl0aWVzIHRvIEhUVFAgc291cCBiYWNrZW5kLgorICAg ICAgICBFbmFibGUgd2l0aCBXRUJLSVRfU09VUF9MT0dHSU5HIGFuZCBjb250cm9sIHRoZSB2ZXJi b3NpdHkgd2l0aAorICAgICAgICBXRUJLSVRfU09VUF9MT0dfTEVWRUwgKDAgLSBtaW4sIDMgbWF4 KS4KKyAgICAgICAgCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnQpOgor CiAyMDA4LTA0LTA3ICBMdWNhIEJydW5vICA8bGV0aGFsbWFuODhAZ21haWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFscCBUb2tlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDk2NjQyOGUuLmYzYmIwNjkg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxl U291cC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5k bGVTb3VwLmNwcApAQCAtMjQ0LDggKzI0NCwxNyBAQCBib29sIFJlc291cmNlSGFuZGxlOjpzdGFy dChGcmFtZSogZnJhbWUpCiAgICAgICAgIGQtPm1fcmVzcG9uc2Uuc2V0TWltZVR5cGUoTUlNRVR5 cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JQYXRoKFN0cmluZyh1cmxTdHJpbmcpKSk7CiAgICAg fQogCi0gICAgaWYgKCFzZXNzaW9uKQorICAgIGlmICghc2Vzc2lvbikgewogICAgICAgICBzZXNz aW9uID0gc291cF9zZXNzaW9uX2FzeW5jX25ldygpOworICAgICAgICBjb25zdCBjaGFyKiBzb3Vw X2RlYnVnID0gZ19nZXRlbnYoIldFQktJVF9TT1VQX0xPR0dJTkciKTsKKyAgICAgICAgaWYgKHNv dXBfZGVidWcpIHsKKyAgICAgICAgICAgIGludCBzb3VwX2RlYnVnX2xldmVsID0gYXRvaShzb3Vw X2RlYnVnKTsKKworICAgICAgICAgICAgU291cExvZ2dlciogbG9nZ2VyID0gc291cF9sb2dnZXJf bmV3KHN0YXRpY19jYXN0PFNvdXBMb2dnZXJMb2dMZXZlbD4oc291cF9kZWJ1Z19sZXZlbCksIC0x KTsKKyAgICAgICAgICAgIHNvdXBfbG9nZ2VyX2F0dGFjaChsb2dnZXIsIHNlc3Npb24pOworICAg ICAgICAgICAgZ19vYmplY3RfdW5yZWYobG9nZ2VyKTsKKyAgICAgICAgfQorICAgIH0KIAogICAg IFNvdXBNZXNzYWdlKiBtc2c7CiAgICAgbXNnID0gc291cF9tZXNzYWdlX25ldyhyZXF1ZXN0KCku aHR0cE1ldGhvZCgpLnV0ZjgoKS5kYXRhKCksIHVybFN0cmluZy51dGY4KCkuZGF0YSgpKTsKLS0g CjEuNS40LjUKCg== 20383 2008-04-07 10:05:16 -0700 2008-04-10 17:53:17 -0700 0001-Add-logging-to-http-soup-backend.patch 0001-Add-logging-to-http-soup-backend.patch text/plain 2154 xan.lopez RnJvbSBjMjMwMGZhMjY4NjEwMjJjZGNiZjk0NTk3OGRmNDg4ODRlZGJlN2JiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IE1vbiwg NyBBcHIgMjAwOCAxNzo1NzoyMyArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBsb2dnaW5nIHRv IGh0dHAgc291cCBiYWNrZW5kLgoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogLi4uL3BsYXRmb3Jt L25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwICAgfCAgIDExICsrKysrKysrKyst CiAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMDc0 MWJmLi4zYTg4YjIxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA4LTA0LTA3ICBYYW4gTG9wZXogIDx4YW5A Z25vbWUub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisgICAgICAgIGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzQyCisgICAgICAgIEJ1ZyAj MTgzNDIgLSBBZGQgbG9nZ2luZyB0byBIVFRQIHNvdXAgYmFja2VuZAorICAgICAgICAKKyAgICAg ICAgQWRkIHNvdXAgbG9nZ2luZyBmYWNpbGl0aWVzIHRvIEhUVFAgc291cCBiYWNrZW5kLgorICAg ICAgICBFbmFibGUgZGVmaW5pbmcgV0VCS0lUX1NPVVBfTE9HR0lORywgd2l0aCB2YWx1ZXMgZnJv bQorICAgICAgICAwIHRvIDMgZm9yIG1vcmUgdmVyYm9zaXR5LgorICAgICAgICAKKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpzdGFydCk6CisKIDIwMDgtMDQtMDcgIEx1Y2EgQnJ1 bm8gIDxsZXRoYWxtYW44OEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxwIFRv a2VyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VI YW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHAKaW5kZXggOTY2NDI4ZS4uZjNiYjA2OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC0yNDQsOCAr MjQ0LDE3IEBAIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnN0YXJ0KEZyYW1lKiBmcmFtZSkKICAgICAg ICAgZC0+bV9yZXNwb25zZS5zZXRNaW1lVHlwZShNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlw ZUZvclBhdGgoU3RyaW5nKHVybFN0cmluZykpKTsKICAgICB9CiAKLSAgICBpZiAoIXNlc3Npb24p CisgICAgaWYgKCFzZXNzaW9uKSB7CiAgICAgICAgIHNlc3Npb24gPSBzb3VwX3Nlc3Npb25fYXN5 bmNfbmV3KCk7CisgICAgICAgIGNvbnN0IGNoYXIqIHNvdXBfZGVidWcgPSBnX2dldGVudigiV0VC S0lUX1NPVVBfTE9HR0lORyIpOworICAgICAgICBpZiAoc291cF9kZWJ1ZykgeworICAgICAgICAg ICAgaW50IHNvdXBfZGVidWdfbGV2ZWwgPSBhdG9pKHNvdXBfZGVidWcpOworCisgICAgICAgICAg ICBTb3VwTG9nZ2VyKiBsb2dnZXIgPSBzb3VwX2xvZ2dlcl9uZXcoc3RhdGljX2Nhc3Q8U291cExv Z2dlckxvZ0xldmVsPihzb3VwX2RlYnVnX2xldmVsKSwgLTEpOworICAgICAgICAgICAgc291cF9s b2dnZXJfYXR0YWNoKGxvZ2dlciwgc2Vzc2lvbik7CisgICAgICAgICAgICBnX29iamVjdF91bnJl Zihsb2dnZXIpOworICAgICAgICB9CisgICAgfQogCiAgICAgU291cE1lc3NhZ2UqIG1zZzsKICAg ICBtc2cgPSBzb3VwX21lc3NhZ2VfbmV3KHJlcXVlc3QoKS5odHRwTWV0aG9kKCkudXRmOCgpLmRh dGEoKSwgdXJsU3RyaW5nLnV0ZjgoKS5kYXRhKCkpOwotLSAKMS41LjQuNQoK