183414 2018-03-07 12:20:09 -0800 Rename ProtoCallFrame::arityMissMatch to hasArityMismatch. 2018-03-07 14:19:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1404431 0 mark.lam 2018-03-07 12:20:09 -0800 Fixes a misspelling and make it more descriptive (using the is-a / has-a pattern). 1404432 1 webkit-bug-importer 2018-03-07 12:20:42 -0800 <rdar://problem/38231678> 1404440 2 335206 mark.lam 2018-03-07 12:40:23 -0800 Created attachment 335206 proposed patch. 1404449 3 335206 msaboff 2018-03-07 13:00:48 -0800 Comment on attachment 335206 proposed patch. rs=me 1404470 4 mark.lam 2018-03-07 14:19:58 -0800 Thanks for the review. Landed in r229373: <http://trac.webkit.org/r229373>. 335206 2018-03-07 12:40:23 -0800 2018-03-07 13:00:48 -0800 proposed patch. bug-183414.patch text/plain 2971 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjI5MzcxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTAzLTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgUHJvdG9DYWxsRnJhbWU6OmFyaXR5TWlzc01hdGNoIHRvIGhhc0FyaXR5TWlzbWF0Y2gu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODM0MTQK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4MjMxNjc4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvUHJvdG9DYWxsRnJhbWUu Y3BwOgorICAgICAgICAoSlNDOjpQcm90b0NhbGxGcmFtZTo6aW5pdCk6CisgICAgICAgICogaW50 ZXJwcmV0ZXIvUHJvdG9DYWxsRnJhbWUuaDoKKwogMjAxOC0wMy0wNyAgTWFyayBMYW0gIDxtYXJr LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgU2ltcGxpZnkgdGhlIHZhcmlhbnRzIG9mIEZ1bmN0 aW9uUHRyIGNvbnN0cnVjdG9ycy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9Qcm90b0NhbGxGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ludGVycHJldGVyL1Byb3RvQ2FsbEZyYW1lLmNwcAkocmV2aXNpb24gMjI5MzcxKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL1Byb3RvQ2FsbEZyYW1lLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTMgQXBw bGUgSW5jLiBBbGwgUmlnaHRzIFJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzLTIwMTgg QXBwbGUgSW5jLiBBbGwgUmlnaHRzIFJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC0zOSw5ICszOSw5IEBAIHZvaWQgUHJvdG9DYWxsRnJhbWU6OmluaXQoQ29kZUJs b2NrKiBjb2QKICAgICB0aGlzLT5zZXRDYWxsZWUoY2FsbGVlKTsKICAgICB0aGlzLT5zZXRBcmd1 bWVudENvdW50SW5jbHVkaW5nVGhpcyhhcmdDb3VudEluY2x1ZGluZ1RoaXMpOwogICAgIGlmIChj b2RlQmxvY2sgJiYgYXJnQ291bnRJbmNsdWRpbmdUaGlzIDwgY29kZUJsb2NrLT5udW1QYXJhbWV0 ZXJzKCkpCi0gICAgICAgIHRoaXMtPmFyaXR5TWlzc01hdGNoID0gdHJ1ZTsKKyAgICAgICAgdGhp cy0+aGFzQXJpdHlNaXNtYXRjaCA9IHRydWU7CiAgICAgZWxzZQotICAgICAgICB0aGlzLT5hcml0 eU1pc3NNYXRjaCA9IGZhbHNlOworICAgICAgICB0aGlzLT5oYXNBcml0eU1pc21hdGNoID0gZmFs c2U7CiAKICAgICAvLyBSb3VuZCB1cCBhcmdDb3VudEluY2x1ZGluZ1RoaXMgdG8ga2VlcCB0aGUg c3RhY2sgZnJhbWUgc2l6ZSBhbGlnbmVkLgogICAgIHNpemVfdCBwYWRkZWRBcmdzQ291bnQgPSBy b3VuZEFyZ3VtZW50Q291bnRUb0FsaWduRnJhbWUoYXJnQ291bnRJbmNsdWRpbmdUaGlzKTsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9Qcm90b0NhbGxGcmFtZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9Qcm90b0NhbGxG cmFtZS5oCShyZXZpc2lvbiAyMjkzNzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJw cmV0ZXIvUHJvdG9DYWxsRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8q Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxNyBBcHBsZSBJbmMuIEFsbCBSaWdodHMgUmVzZXJ2 ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxOCBBcHBsZSBJbmMuIEFsbCBSaWdodHMgUmVz ZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTM4LDcgKzM4LDcgQEAg cHVibGljOgogICAgIFJlZ2lzdGVyIGFyZ0NvdW50QW5kQ29kZU9yaWdpblZhbHVlOwogICAgIFJl Z2lzdGVyIHRoaXNBcmc7CiAgICAgdWludDMyX3QgcGFkZGVkQXJnQ291bnQ7Ci0gICAgYm9vbCBh cml0eU1pc3NNYXRjaDsKKyAgICBib29sIGhhc0FyaXR5TWlzbWF0Y2g7CiAgICAgSlNWYWx1ZSAq YXJnczsKIAogICAgIHZvaWQgaW5pdChDb2RlQmxvY2sqLCBKU09iamVjdCosIEpTVmFsdWUsIGlu dCwgSlNWYWx1ZSogb3RoZXJBcmdzID0gMCk7CkBAIC01OSw3ICs1OSw3IEBAIHB1YmxpYzoKICAg ICBKU1ZhbHVlIHRoaXNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIHRoaXNBcmcuUmVnaXN0ZXI6Ompz VmFsdWUoKTsgfQogICAgIHZvaWQgc2V0VGhpc1ZhbHVlKEpTVmFsdWUgdmFsdWUpIHsgdGhpc0Fy ZyA9IHZhbHVlOyB9CiAKLSAgICBib29sIG5lZWRBcml0eUNoZWNrKCkgeyByZXR1cm4gYXJpdHlN aXNzTWF0Y2g7IH0KKyAgICBib29sIG5lZWRBcml0eUNoZWNrKCkgeyByZXR1cm4gaGFzQXJpdHlN aXNtYXRjaDsgfQogCiAgICAgSlNWYWx1ZSBhcmd1bWVudChzaXplX3QgYXJndW1lbnRJbmRleCkK ICAgICB7Cg==