<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183397</bug_id>
          
          <creation_ts>2018-03-06 21:27:43 -0800</creation_ts>
          <short_desc>Implement customElements.upgrade()</short_desc>
          <delta_ts>2019-03-23 23:37:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>154907</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Domenic Denicola">d</reporter>
          <assigned_to name="Ryosuke Niwa">rniwa</assigned_to>
          <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>dbates</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fred.wang</cc>
    
    <cc>justin</cc>
    
    <cc>kangil.han</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1404268</commentid>
    <comment_count>0</comment_count>
    <who name="Domenic Denicola">d</who>
    <bug_when>2018-03-06 21:27:43 -0800</bug_when>
    <thetext>Recently added to the spec: https://github.com/whatwg/html/pull/3535

Spec: https://html.spec.whatwg.org/multipage/custom-elements.html#dom-customelementregistry-upgrade

Tests: https://github.com/w3c/web-platform-tests/pull/9869</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1405080</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-03-08 23:09:19 -0800</bug_when>
    <thetext>&lt;rdar://problem/38292356&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1447194</commentid>
    <comment_count>2</comment_count>
      <attachid>346361</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-08-01 23:37:34 -0700</bug_when>
    <thetext>Created attachment 346361
Implements the feature</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1447195</commentid>
    <comment_count>3</comment_count>
      <attachid>346361</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-08-01 23:43:18 -0700</bug_when>
    <thetext>Comment on attachment 346361
Implements the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=346361&amp;action=review

&gt; Source/WebCore/dom/CustomElementReactionQueue.cpp:-125
&gt; -    ASSERT(element.isConnected());

We need to remove this since upgrade can be called on a disconnected tree, and that&apos;s sort of the whole point of this API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1447196</commentid>
    <comment_count>4</comment_count>
      <attachid>346362</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-08-01 23:50:36 -0700</bug_when>
    <thetext>Created attachment 346362
Added more descriptions to the change log</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1447197</commentid>
    <comment_count>5</comment_count>
      <attachid>346361</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-08-02 00:50:30 -0700</bug_when>
    <thetext>Comment on attachment 346361
Implements the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=346361&amp;action=review

&gt;&gt; Source/WebCore/dom/CustomElementReactionQueue.cpp:-125
&gt;&gt; -    ASSERT(element.isConnected());
&gt; 
&gt; We need to remove this since upgrade can be called on a disconnected tree, and that&apos;s sort of the whole point of this API.

Right. It seems Element::insertedIntoAncestor is the only place where enqueueElementUpgradeIfDefined was called.

&gt; Source/WebCore/dom/CustomElementRegistry.cpp:117
&gt; +static void upgradeElementsInShadowIncludingdescendants(ContainerNode&amp; root)

nit: &apos;D&apos; of descendants should be uppercase.

&gt; Source/WebCore/dom/CustomElementRegistry.h:44
&gt; +class DeferredPromise;

The DeferredPromise include / forward declaration change seems unrelated to this patch, right? Maybe mention in the ChangeLog whether it is just a fix passing by.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1447333</commentid>
    <comment_count>6</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-08-02 12:23:47 -0700</bug_when>
    <thetext>Thanks for the review!

(In reply to Frédéric Wang (:fredw) from comment #5)
&gt; Comment on attachment 346361 [details]
&gt; Implements the feature
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=346361&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebCore/dom/CustomElementReactionQueue.cpp:-125
&gt; &gt;&gt; -    ASSERT(element.isConnected());
&gt; &gt; 
&gt; &gt; We need to remove this since upgrade can be called on a disconnected tree, and that&apos;s sort of the whole point of this API.
&gt; 
&gt; Right. It seems Element::insertedIntoAncestor is the only place where
&gt; enqueueElementUpgradeIfDefined was called.
&gt; 
&gt; &gt; Source/WebCore/dom/CustomElementRegistry.cpp:117
&gt; &gt; +static void upgradeElementsInShadowIncludingdescendants(ContainerNode&amp; root)
&gt; 
&gt; nit: &apos;D&apos; of descendants should be uppercase.

Fixed.

&gt; &gt; Source/WebCore/dom/CustomElementRegistry.h:44
&gt; &gt; +class DeferredPromise;
&gt; 
&gt; The DeferredPromise include / forward declaration change seems unrelated to
&gt; this patch, right? Maybe mention in the ChangeLog whether it is just a fix
&gt; passing by.

Sure, I&apos;d add a change log comment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1447334</commentid>
    <comment_count>7</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-08-02 12:25:25 -0700</bug_when>
    <thetext>Committed r234507: &lt;https://trac.webkit.org/changeset/234507&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1520680</commentid>
    <comment_count>8</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2019-03-23 23:37:36 -0700</bug_when>
    <thetext>*** Bug 196165 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>346361</attachid>
            <date>2018-08-01 23:37:34 -0700</date>
            <delta_ts>2018-08-02 00:50:30 -0700</delta_ts>
            <desc>Implements the feature</desc>
            <filename>bug-183397-20180801233734.patch</filename>
            <type>text/plain</type>
            <size>8043</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE4LTA4LTAxICBSeW9zdWtl
IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEltcGxlbWVudCBjdXN0b21FbGVt
ZW50cy51cGdyYWRlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE4MzM5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEltcGxlbWVudGVkIHRoZSBtZXRob2QgYXMgc3BlY2lmaWVkIGF0OgorICAgICAgICBo
dHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9jdXN0b20tZWxlbWVudHMuaHRt
bCNkb20tY3VzdG9tZWxlbWVudHJlZ2lzdHJ5LXVwZ3JhZGUKKworICAgICAgICAgICAgV2hlbiBp
bnZva2VkLCB0aGUgdXBncmFkZShyb290KSBtZXRob2QgbXVzdCBydW4gdGhlc2Ugc3RlcHM6Cisg
ICAgICAgICAgICAxLiBMZXQgY2FuZGlkYXRlcyBiZSBhIGxpc3Qgb2YgYWxsIG9mIHJvb3QncyBz
aGFkb3ctaW5jbHVkaW5nIGluY2x1c2l2ZSBkZXNjZW5kYW50IGVsZW1lbnRzLCBpbiBzaGFkb3ct
aW5jbHVkaW5nIHRyZWUgb3JkZXIuCisgICAgICAgICAgICAyLiBGb3IgZWFjaCBjYW5kaWRhdGUg
b2YgY2FuZGlkYXRlcywgdHJ5IHRvIHVwZ3JhZGUgY2FuZGlkYXRlLgorCisgICAgICAgIFRlc3Rz
OiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2N1c3RvbS1lbGVtZW50cy9jdXN0b20t
ZWxlbWVudC1yZWdpc3RyeS91cGdyYWRlLmh0bWwKKworICAgICAgICAqIGRvbS9DdXN0b21FbGVt
ZW50UmVhY3Rpb25RdWV1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDdXN0b21FbGVtZW50UmVh
Y3Rpb25RdWV1ZTo6ZW5xdWV1ZUVsZW1lbnRVcGdyYWRlSWZEZWZpbmVkKToKKyAgICAgICAgKiBk
b20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnVwZ3JhZGVF
bGVtZW50c0luU2hhZG93SW5jbHVkaW5nZGVzY2VuZGFudHMpOgorICAgICAgICAoV2ViQ29yZTo6
Q3VzdG9tRWxlbWVudFJlZ2lzdHJ5Ojp1cGdyYWRlKToKKyAgICAgICAgKiBkb20vQ3VzdG9tRWxl
bWVudFJlZ2lzdHJ5Lmg6CisgICAgICAgICogZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5pZGw6
CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6
aW5zZXJ0ZWRJbnRvQW5jZXN0b3IpOgorCiAyMDE4LTA4LTAxICBZdXN1a2UgU3V6dWtpICA8dXRh
dGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJlbmFtZSBUcmFuc2Zv
cm1hdGlvbk1hdHJpeDo6SWRlbnRpdHkgdG8gVHJhbnNmb3JtYXRpb25NYXRyaXg6OmlkZW50aXR5
CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25R
dWV1ZS5jcHAJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21F
bGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsNiBA
QCB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlOjplbnF1ZXVlCiAKIHZvaWQgQ3VzdG9t
RWxlbWVudFJlYWN0aW9uUXVldWU6OmVucXVldWVFbGVtZW50VXBncmFkZUlmRGVmaW5lZChFbGVt
ZW50JiBlbGVtZW50KQogewotICAgIEFTU0VSVChlbGVtZW50LmlzQ29ubmVjdGVkKCkpOwogICAg
IEFTU0VSVChlbGVtZW50LmlzQ3VzdG9tRWxlbWVudFVwZ3JhZGVDYW5kaWRhdGUoKSk7CiAgICAg
YXV0byogd2luZG93ID0gZWxlbWVudC5kb2N1bWVudCgpLmRvbVdpbmRvdygpOwogICAgIGlmICgh
d2luZG93KQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5j
cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3Ry
eS5jcHAJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVt
ZW50UmVnaXN0cnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw2ICszNSw3IEBACiAjaW5jbHVk
ZSAiTWF0aE1MTmFtZXMuaCIKICNpbmNsdWRlICJRdWFsaWZpZWROYW1lLmgiCiAjaW5jbHVkZSAi
U2hhZG93Um9vdC5oIgorI2luY2x1ZGUgIlR5cGVkRWxlbWVudERlc2NlbmRhbnRJdGVyYXRvci5o
IgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTQ0pTVmFsdWVJbmxpbmVzLmg+CiAjaW5jbHVk
ZSA8d3RmL3RleHQvQXRvbWljU3RyaW5nLmg+CiAKQEAgLTExMyw0ICsxMTQsMjUgQEAgSlNDOjpK
U1ZhbHVlIEN1c3RvbUVsZW1lbnRSZWdpc3RyeTo6Z2V0KAogICAgIHJldHVybiBKU0M6OmpzVW5k
ZWZpbmVkKCk7CiB9CiAKK3N0YXRpYyB2b2lkIHVwZ3JhZGVFbGVtZW50c0luU2hhZG93SW5jbHVk
aW5nZGVzY2VuZGFudHMoQ29udGFpbmVyTm9kZSYgcm9vdCkKK3sKKyAgICBmb3IgKGF1dG8mIGVs
ZW1lbnQgOiBkZXNjZW5kYW50c09mVHlwZTxFbGVtZW50Pihyb290KSkgeworICAgICAgICBpZiAo
ZWxlbWVudC5pc0N1c3RvbUVsZW1lbnRVcGdyYWRlQ2FuZGlkYXRlKCkpCisgICAgICAgICAgICBD
dXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZTo6ZW5xdWV1ZUVsZW1lbnRVcGdyYWRlSWZEZWZpbmVk
KGVsZW1lbnQpOworICAgICAgICBpZiAoYXV0byogc2hhZG93Um9vdCA9IGVsZW1lbnQuc2hhZG93
Um9vdCgpKQorICAgICAgICAgICAgdXBncmFkZUVsZW1lbnRzSW5TaGFkb3dJbmNsdWRpbmdkZXNj
ZW5kYW50cygqc2hhZG93Um9vdCk7CisgICAgfQorfQorCit2b2lkIEN1c3RvbUVsZW1lbnRSZWdp
c3RyeTo6dXBncmFkZShOb2RlJiByb290KQoreworICAgIGlmICghaXM8Q29udGFpbmVyTm9kZT4o
cm9vdCkpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChpczxFbGVtZW50Pihyb290KSAmJiBk
b3duY2FzdDxFbGVtZW50Pihyb290KS5pc0N1c3RvbUVsZW1lbnRVcGdyYWRlQ2FuZGlkYXRlKCkp
CisgICAgICAgIEN1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlOjplbnF1ZXVlRWxlbWVudFVwZ3Jh
ZGVJZkRlZmluZWQoZG93bmNhc3Q8RWxlbWVudD4ocm9vdCkpOworCisgICAgdXBncmFkZUVsZW1l
bnRzSW5TaGFkb3dJbmNsdWRpbmdkZXNjZW5kYW50cyhkb3duY2FzdDxDb250YWluZXJOb2RlPihy
b290KSk7Cit9CisKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVn
aXN0cnkuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJl
Z2lzdHJ5LmgJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21F
bGVtZW50UmVnaXN0cnkuaAkod29ya2luZyBjb3B5KQpAQCAtMjUsNyArMjUsNiBAQAogCiAjcHJh
Z21hIG9uY2UKIAotI2luY2x1ZGUgIkpTRE9NUHJvbWlzZURlZmVycmVkLmgiCiAjaW5jbHVkZSAi
UXVhbGlmaWVkTmFtZS5oIgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3Rm
L3RleHQvQXRvbWljU3RyaW5nLmg+CkBAIC00Miw4ICs0MSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29y
ZSB7CiAKIGNsYXNzIEN1c3RvbUVsZW1lbnRSZWdpc3RyeTsKIGNsYXNzIERPTVdpbmRvdzsKK2Ns
YXNzIERlZmVycmVkUHJvbWlzZTsKIGNsYXNzIEVsZW1lbnQ7CiBjbGFzcyBKU0N1c3RvbUVsZW1l
bnRJbnRlcmZhY2U7CitjbGFzcyBOb2RlOwogY2xhc3MgUXVhbGlmaWVkTmFtZTsKIAogY2xhc3Mg
Q3VzdG9tRWxlbWVudFJlZ2lzdHJ5IDogcHVibGljIFJlZkNvdW50ZWQ8Q3VzdG9tRWxlbWVudFJl
Z2lzdHJ5PiB7CkBAIC02Miw2ICs2Myw3IEBAIHB1YmxpYzoKICAgICBib29sIGNvbnRhaW5zQ29u
c3RydWN0b3IoY29uc3QgSlNDOjpKU09iamVjdCopIGNvbnN0OwogCiAgICAgSlNDOjpKU1ZhbHVl
IGdldChjb25zdCBBdG9taWNTdHJpbmcmKTsKKyAgICB2b2lkIHVwZ3JhZGUoTm9kZSYgcm9vdCk7
CiAKICAgICBIYXNoTWFwPEF0b21pY1N0cmluZywgUmVmPERlZmVycmVkUHJvbWlzZT4+JiBwcm9t
aXNlTWFwKCkgeyByZXR1cm4gbV9wcm9taXNlTWFwOyB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl
L2RvbS9DdXN0b21FbGVtZW50UmVnaXN0cnkuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD
b3JlL2RvbS9DdXN0b21FbGVtZW50UmVnaXN0cnkuaWRsCShyZXZpc2lvbiAyMzQ0OTIpCisrKyBT
b3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5LmlkbAkod29ya2luZyBjb3B5
KQpAQCAtMzEsNCArMzEsNSBAQAogICAgIFtDRVJlYWN0aW9ucywgQ3VzdG9tXSB2b2lkIGRlZmlu
ZShET01TdHJpbmcgbmFtZSwgRnVuY3Rpb24gY29uc3RydWN0b3IpOwogICAgIGFueSBnZXQoRE9N
U3RyaW5nIG5hbWUpOwogICAgIFtDdXN0b20sIE1heVRocm93RXhjZXB0aW9uLCBSZXR1cm5zT3du
UHJvbWlzZV0gUHJvbWlzZTx2b2lkPiB3aGVuRGVmaW5lZChET01TdHJpbmcgbmFtZSk7CisgICAg
W0NFUmVhY3Rpb25zXSB2b2lkIHVwZ3JhZGUoTm9kZSByb290KTsKIH07CkluZGV4OiBTb3VyY2Uv
V2ViQ29yZS9kb20vRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9t
L0VsZW1lbnQuY3BwCShyZXZpc2lvbiAyMzQ0OTIpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxl
bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3NDcsOCArMTc0NywxMCBAQCBOb2RlOjpJbnNl
cnRlZEludG9BbmNlc3RvclJlc3VsdCBFbGVtZW50CiAgICAgfQogCiAgICAgaWYgKGJlY29tZUNv
bm5lY3RlZCkgewotICAgICAgICBpZiAoVU5MSUtFTFkoaXNDdXN0b21FbGVtZW50VXBncmFkZUNh
bmRpZGF0ZSgpKSkKKyAgICAgICAgaWYgKFVOTElLRUxZKGlzQ3VzdG9tRWxlbWVudFVwZ3JhZGVD
YW5kaWRhdGUoKSkpIHsKKyAgICAgICAgICAgIEFTU0VSVChpc0Nvbm5lY3RlZCgpKTsKICAgICAg
ICAgICAgIEN1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlOjplbnF1ZXVlRWxlbWVudFVwZ3JhZGVJ
ZkRlZmluZWQoKnRoaXMpOworICAgICAgICB9CiAgICAgICAgIGlmIChVTkxJS0VMWShpc0RlZmlu
ZWRDdXN0b21FbGVtZW50KCkpKQogICAgICAgICAgICAgQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVl
dWU6OmVucXVldWVDb25uZWN0ZWRDYWxsYmFja0lmTmVlZGVkKCp0aGlzKTsKICAgICB9CkluZGV4
OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91
dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDQ5NikKKysrIExheW91
dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx
NCBAQAorMjAxOC0wOC0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAg
ICAgICBJbXBsZW1lbnQgY3VzdG9tRWxlbWVudHMudXBncmFkZSgpCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzOTcKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lIHRoZSB0ZXN0IG5vdyB0
aGF0IHdlJ3JlIHBhc3NpbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvY3VzdG9t
LWVsZW1lbnRzL2N1c3RvbS1lbGVtZW50LXJlZ2lzdHJ5L3VwZ3JhZGUtZXhwZWN0ZWQudHh0Ogor
CiAyMDE4LTA3LTIzICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgog
CiAgICAgICAgIFtjc3MtZ3JpZF0gQWRkIHN1cHBvcnQgZm9yIGNhbGMoKSBpbiBndXR0ZXIgcHJv
cGVydGllcwpJbmRleDogTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0
cy9jdXN0b20tZWxlbWVudHMvY3VzdG9tLWVsZW1lbnQtcmVnaXN0cnkvdXBncmFkZS1leHBlY3Rl
ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y
bS10ZXN0cy9jdXN0b20tZWxlbWVudHMvY3VzdG9tLWVsZW1lbnQtcmVnaXN0cnkvdXBncmFkZS1l
eHBlY3RlZC50eHQJKHJldmlzaW9uIDIzNDQ5MikKKysrIExheW91dFRlc3RzL2ltcG9ydGVkL3cz
Yy93ZWItcGxhdGZvcm0tdGVzdHMvY3VzdG9tLWVsZW1lbnRzL2N1c3RvbS1lbGVtZW50LXJlZ2lz
dHJ5L3VwZ3JhZGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAog
Ci1GQUlMIFVwZ3JhZGluZyBhbiBlbGVtZW50IGRpcmVjdGx5IChleGFtcGxlIGZyb20gdGhlIHNw
ZWMpIGN1c3RvbUVsZW1lbnRzLnVwZ3JhZGUgaXMgbm90IGEgZnVuY3Rpb24uIChJbiAnY3VzdG9t
RWxlbWVudHMudXBncmFkZShlbCknLCAnY3VzdG9tRWxlbWVudHMudXBncmFkZScgaXMgdW5kZWZp
bmVkKQotRkFJTCBUd28gZWxlbWVudHMgYXMgY2hpbGRyZW4gb2YgdGhlIHVwZ3JhZGVkIG5vZGUg
Y3VzdG9tRWxlbWVudHMudXBncmFkZSBpcyBub3QgYSBmdW5jdGlvbi4gKEluICdjdXN0b21FbGVt
ZW50cy51cGdyYWRlKGNvbnRhaW5lciknLCAnY3VzdG9tRWxlbWVudHMudXBncmFkZScgaXMgdW5k
ZWZpbmVkKQotRkFJTCBUd28gZWxlbWVudHMgYXMgZGVzY2VuZGFudHMgb2YgdGhlIHVwZ3JhZGVk
IG5vZGUgY3VzdG9tRWxlbWVudHMudXBncmFkZSBpcyBub3QgYSBmdW5jdGlvbi4gKEluICdjdXN0
b21FbGVtZW50cy51cGdyYWRlKGNvbnRhaW5lciknLCAnY3VzdG9tRWxlbWVudHMudXBncmFkZScg
aXMgdW5kZWZpbmVkKQotRkFJTCBUd28gZWxlbWVudHMgYXMgc2hhZG93LWluY2x1ZGluZyBkZXNj
ZW5kYW50cyAoYW5kIG5vdCBkZXNjZW5kYW50cykgb2YgdGhlIHVwZ3JhZGVkIG5vZGUgY3VzdG9t
RWxlbWVudHMudXBncmFkZSBpcyBub3QgYSBmdW5jdGlvbi4gKEluICdjdXN0b21FbGVtZW50cy51
cGdyYWRlKGNvbnRhaW5lciknLCAnY3VzdG9tRWxlbWVudHMudXBncmFkZScgaXMgdW5kZWZpbmVk
KQotRkFJTCBFbGVtZW50cyBpbnNpZGUgYSB0ZW1wbGF0ZSBjb250ZW50cyBEb2N1bWVudEZyYWdt
ZW50IG5vZGUgY3VzdG9tRWxlbWVudHMudXBncmFkZSBpcyBub3QgYSBmdW5jdGlvbi4gKEluICdj
dXN0b21FbGVtZW50cy51cGdyYWRlKHRlbXBsYXRlKScsICdjdXN0b21FbGVtZW50cy51cGdyYWRl
JyBpcyB1bmRlZmluZWQpCitQQVNTIFVwZ3JhZGluZyBhbiBlbGVtZW50IGRpcmVjdGx5IChleGFt
cGxlIGZyb20gdGhlIHNwZWMpIAorUEFTUyBUd28gZWxlbWVudHMgYXMgY2hpbGRyZW4gb2YgdGhl
IHVwZ3JhZGVkIG5vZGUgCitQQVNTIFR3byBlbGVtZW50cyBhcyBkZXNjZW5kYW50cyBvZiB0aGUg
dXBncmFkZWQgbm9kZSAKK1BBU1MgVHdvIGVsZW1lbnRzIGFzIHNoYWRvdy1pbmNsdWRpbmcgZGVz
Y2VuZGFudHMgKGFuZCBub3QgZGVzY2VuZGFudHMpIG9mIHRoZSB1cGdyYWRlZCBub2RlIAorUEFT
UyBFbGVtZW50cyBpbnNpZGUgYSB0ZW1wbGF0ZSBjb250ZW50cyBEb2N1bWVudEZyYWdtZW50IG5v
ZGUgCiAK
</data>
<flag name="review"
          id="364234"
          type_id="1"
          status="+"
          setter="fred.wang"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>346362</attachid>
            <date>2018-08-01 23:50:36 -0700</date>
            <delta_ts>2018-08-02 01:19:47 -0700</delta_ts>
            <desc>Added more descriptions to the change log</desc>
            <filename>bug-183397-20180801235035.patch</filename>
            <type>text/plain</type>
            <size>8555</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBACisyMDE4LTA4LTAxICBSeW9zdWtl
IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEltcGxlbWVudCBjdXN0b21FbGVt
ZW50cy51cGdyYWRlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE4MzM5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEFkZGVkIHRoZSBzdXBwb3J0IHRvIHVwZ3JhZGUgY3VzdG9tIGVsZW1lbnRzIGRpcmVj
dGx5LiBPcmRpbmFyaWx5LCBjdXN0b20gZWxlbWVudHMgZ2V0IHVwZ3JhZGVkIGFzIHRoZXkgYXJl
CisgICAgICAgIGluc2VydGVkIC8gY29ubmVjdGVkIGludG8gYSBkb2N1bWVudCBidXQgc29tZSBz
Y3JpcHQgbGlicmFyaWVzIGFuZCBhdXRob3JzIHdhbnQgdG8gYmUgYWJsZSB0byB1cGdyYWRlIHRo
ZW0gYmVmb3JlIHRoYXQuCisgICAgICAgIEFsc28gc2VlIGh0dHBzOi8vZ2l0aHViLmNvbS93M2Mv
d2ViY29tcG9uZW50cy9pc3N1ZXMvNzEwCisKKyAgICAgICAgSW1wbGVtZW50ZWQgdGhlIG1ldGhv
ZCBhcyBzcGVjaWZpZWQgYXQ6CisgICAgICAgIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcv
bXVsdGlwYWdlL2N1c3RvbS1lbGVtZW50cy5odG1sI2RvbS1jdXN0b21lbGVtZW50cmVnaXN0cnkt
dXBncmFkZQorCisgICAgICAgICAgICBXaGVuIGludm9rZWQsIHRoZSB1cGdyYWRlKHJvb3QpIG1l
dGhvZCBtdXN0IHJ1biB0aGVzZSBzdGVwczoKKyAgICAgICAgICAgIDEuIExldCBjYW5kaWRhdGVz
IGJlIGEgbGlzdCBvZiBhbGwgb2Ygcm9vdCdzIHNoYWRvdy1pbmNsdWRpbmcgaW5jbHVzaXZlIGRl
c2NlbmRhbnQgZWxlbWVudHMsCisgICAgICAgICAgICAgICBpbiBzaGFkb3ctaW5jbHVkaW5nIHRy
ZWUgb3JkZXIuCisgICAgICAgICAgICAyLiBGb3IgZWFjaCBjYW5kaWRhdGUgb2YgY2FuZGlkYXRl
cywgdHJ5IHRvIHVwZ3JhZGUgY2FuZGlkYXRlLgorCisgICAgICAgIFRlc3RzOiBpbXBvcnRlZC93
M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2N1c3RvbS1lbGVtZW50cy9jdXN0b20tZWxlbWVudC1yZWdp
c3RyeS91cGdyYWRlLmh0bWwKKworICAgICAgICAqIGRvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25R
dWV1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZTo6
ZW5xdWV1ZUVsZW1lbnRVcGdyYWRlSWZEZWZpbmVkKTogUmVtb3ZlZCB0aGUgYXNzZXJ0aW9uIHRo
YXQgdGhlIHVwZ3JhZGVkIGVsZW1lbnQKKyAgICAgICAgaXMgY29ubmVjdGVkIHNpbmNlIHRoZSB3
aG9sZSBwb2ludCBvZiB0aGlzIEFQSSBpcyB0byB1cGdyYWRlIGEgZGlzY29ubmVjdGVkIGVsZW1l
bnQuCisgICAgICAgICogZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjp1cGdyYWRlRWxlbWVudHNJblNoYWRvd0luY2x1ZGluZ2Rlc2NlbmRhbnRzKTogQWRk
ZWQuCisgICAgICAgIChXZWJDb3JlOjpDdXN0b21FbGVtZW50UmVnaXN0cnk6OnVwZ3JhZGUpOiBB
ZGRlZC4KKyAgICAgICAgKiBkb20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5Lmg6CisgICAgICAgICog
ZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5pZGw6CisgICAgICAgICogZG9tL0VsZW1lbnQuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6aW5zZXJ0ZWRJbnRvQW5jZXN0b3IpOiBNb3Zl
ZCB0aGUgYXNzZXJ0aW9uIGhlcmUuCisKIDIwMTgtMDgtMDEgIFl1c3VrZSBTdXp1a2kgIDx1dGF0
YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmVuYW1lIFRyYW5zZm9y
bWF0aW9uTWF0cml4OjpJZGVudGl0eSB0byBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6aWRlbnRpdHkK
SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1
ZXVlLmNwcAkocmV2aXNpb24gMjM0NDkyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVs
ZW1lbnRSZWFjdGlvblF1ZXVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIyLDcgKzEyMiw2IEBA
IHZvaWQgQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6OmVucXVldWUKIAogdm9pZCBDdXN0b21F
bGVtZW50UmVhY3Rpb25RdWV1ZTo6ZW5xdWV1ZUVsZW1lbnRVcGdyYWRlSWZEZWZpbmVkKEVsZW1l
bnQmIGVsZW1lbnQpCiB7Ci0gICAgQVNTRVJUKGVsZW1lbnQuaXNDb25uZWN0ZWQoKSk7CiAgICAg
QVNTRVJUKGVsZW1lbnQuaXNDdXN0b21FbGVtZW50VXBncmFkZUNhbmRpZGF0ZSgpKTsKICAgICBh
dXRvKiB3aW5kb3cgPSBlbGVtZW50LmRvY3VtZW50KCkuZG9tV2luZG93KCk7CiAgICAgaWYgKCF3
aW5kb3cpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5LmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5
LmNwcAkocmV2aXNpb24gMjM0NDkyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1l
bnRSZWdpc3RyeS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRl
ICJNYXRoTUxOYW1lcy5oIgogI2luY2x1ZGUgIlF1YWxpZmllZE5hbWUuaCIKICNpbmNsdWRlICJT
aGFkb3dSb290LmgiCisjaW5jbHVkZSAiVHlwZWRFbGVtZW50RGVzY2VuZGFudEl0ZXJhdG9yLmgi
CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvSlNDSlNWYWx1ZUlubGluZXMuaD4KICNpbmNsdWRl
IDx3dGYvdGV4dC9BdG9taWNTdHJpbmcuaD4KIApAQCAtMTEzLDQgKzExNCwyNSBAQCBKU0M6OkpT
VmFsdWUgQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5OjpnZXQoCiAgICAgcmV0dXJuIEpTQzo6anNVbmRl
ZmluZWQoKTsKIH0KIAorc3RhdGljIHZvaWQgdXBncmFkZUVsZW1lbnRzSW5TaGFkb3dJbmNsdWRp
bmdkZXNjZW5kYW50cyhDb250YWluZXJOb2RlJiByb290KQoreworICAgIGZvciAoYXV0byYgZWxl
bWVudCA6IGRlc2NlbmRhbnRzT2ZUeXBlPEVsZW1lbnQ+KHJvb3QpKSB7CisgICAgICAgIGlmIChl
bGVtZW50LmlzQ3VzdG9tRWxlbWVudFVwZ3JhZGVDYW5kaWRhdGUoKSkKKyAgICAgICAgICAgIEN1
c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlOjplbnF1ZXVlRWxlbWVudFVwZ3JhZGVJZkRlZmluZWQo
ZWxlbWVudCk7CisgICAgICAgIGlmIChhdXRvKiBzaGFkb3dSb290ID0gZWxlbWVudC5zaGFkb3dS
b290KCkpCisgICAgICAgICAgICB1cGdyYWRlRWxlbWVudHNJblNoYWRvd0luY2x1ZGluZ2Rlc2Nl
bmRhbnRzKCpzaGFkb3dSb290KTsKKyAgICB9Cit9CisKK3ZvaWQgQ3VzdG9tRWxlbWVudFJlZ2lz
dHJ5Ojp1cGdyYWRlKE5vZGUmIHJvb3QpCit7CisgICAgaWYgKCFpczxDb250YWluZXJOb2RlPihy
b290KSkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKGlzPEVsZW1lbnQ+KHJvb3QpICYmIGRv
d25jYXN0PEVsZW1lbnQ+KHJvb3QpLmlzQ3VzdG9tRWxlbWVudFVwZ3JhZGVDYW5kaWRhdGUoKSkK
KyAgICAgICAgQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6OmVucXVldWVFbGVtZW50VXBncmFk
ZUlmRGVmaW5lZChkb3duY2FzdDxFbGVtZW50Pihyb290KSk7CisKKyAgICB1cGdyYWRlRWxlbWVu
dHNJblNoYWRvd0luY2x1ZGluZ2Rlc2NlbmRhbnRzKGRvd25jYXN0PENvbnRhaW5lck5vZGU+KHJv
b3QpKTsKK30KKwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWdp
c3RyeS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVn
aXN0cnkuaAkocmV2aXNpb24gMjM0NDkyKQorKysgU291cmNlL1dlYkNvcmUvZG9tL0N1c3RvbUVs
ZW1lbnRSZWdpc3RyeS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw2IEBACiAKICNwcmFn
bWEgb25jZQogCi0jaW5jbHVkZSAiSlNET01Qcm9taXNlRGVmZXJyZWQuaCIKICNpbmNsdWRlICJR
dWFsaWZpZWROYW1lLmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYv
dGV4dC9BdG9taWNTdHJpbmcuaD4KQEAgLTQyLDggKzQxLDEwIEBAIG5hbWVzcGFjZSBXZWJDb3Jl
IHsKIAogY2xhc3MgQ3VzdG9tRWxlbWVudFJlZ2lzdHJ5OwogY2xhc3MgRE9NV2luZG93OworY2xh
c3MgRGVmZXJyZWRQcm9taXNlOwogY2xhc3MgRWxlbWVudDsKIGNsYXNzIEpTQ3VzdG9tRWxlbWVu
dEludGVyZmFjZTsKK2NsYXNzIE5vZGU7CiBjbGFzcyBRdWFsaWZpZWROYW1lOwogCiBjbGFzcyBD
dXN0b21FbGVtZW50UmVnaXN0cnkgOiBwdWJsaWMgUmVmQ291bnRlZDxDdXN0b21FbGVtZW50UmVn
aXN0cnk+IHsKQEAgLTYyLDYgKzYzLDcgQEAgcHVibGljOgogICAgIGJvb2wgY29udGFpbnNDb25z
dHJ1Y3Rvcihjb25zdCBKU0M6OkpTT2JqZWN0KikgY29uc3Q7CiAKICAgICBKU0M6OkpTVmFsdWUg
Z2V0KGNvbnN0IEF0b21pY1N0cmluZyYpOworICAgIHZvaWQgdXBncmFkZShOb2RlJiByb290KTsK
IAogICAgIEhhc2hNYXA8QXRvbWljU3RyaW5nLCBSZWY8RGVmZXJyZWRQcm9taXNlPj4mIHByb21p
c2VNYXAoKSB7IHJldHVybiBtX3Byb21pc2VNYXA7IH0KIApJbmRleDogU291cmNlL1dlYkNvcmUv
ZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv
cmUvZG9tL0N1c3RvbUVsZW1lbnRSZWdpc3RyeS5pZGwJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNv
dXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVnaXN0cnkuaWRsCSh3b3JraW5nIGNvcHkp
CkBAIC0zMSw0ICszMSw1IEBACiAgICAgW0NFUmVhY3Rpb25zLCBDdXN0b21dIHZvaWQgZGVmaW5l
KERPTVN0cmluZyBuYW1lLCBGdW5jdGlvbiBjb25zdHJ1Y3Rvcik7CiAgICAgYW55IGdldChET01T
dHJpbmcgbmFtZSk7CiAgICAgW0N1c3RvbSwgTWF5VGhyb3dFeGNlcHRpb24sIFJldHVybnNPd25Q
cm9taXNlXSBQcm9taXNlPHZvaWQ+IHdoZW5EZWZpbmVkKERPTVN0cmluZyBuYW1lKTsKKyAgICBb
Q0VSZWFjdGlvbnNdIHZvaWQgdXBncmFkZShOb2RlIHJvb3QpOwogfTsKSW5kZXg6IFNvdXJjZS9X
ZWJDb3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20v
RWxlbWVudC5jcHAJKHJldmlzaW9uIDIzNDQ5MikKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVt
ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc0Nyw4ICsxNzQ3LDEwIEBAIE5vZGU6Okluc2Vy
dGVkSW50b0FuY2VzdG9yUmVzdWx0IEVsZW1lbnQKICAgICB9CiAKICAgICBpZiAoYmVjb21lQ29u
bmVjdGVkKSB7Ci0gICAgICAgIGlmIChVTkxJS0VMWShpc0N1c3RvbUVsZW1lbnRVcGdyYWRlQ2Fu
ZGlkYXRlKCkpKQorICAgICAgICBpZiAoVU5MSUtFTFkoaXNDdXN0b21FbGVtZW50VXBncmFkZUNh
bmRpZGF0ZSgpKSkgeworICAgICAgICAgICAgQVNTRVJUKGlzQ29ubmVjdGVkKCkpOwogICAgICAg
ICAgICAgQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWU6OmVucXVldWVFbGVtZW50VXBncmFkZUlm
RGVmaW5lZCgqdGhpcyk7CisgICAgICAgIH0KICAgICAgICAgaWYgKFVOTElLRUxZKGlzRGVmaW5l
ZEN1c3RvbUVsZW1lbnQoKSkpCiAgICAgICAgICAgICBDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1
ZTo6ZW5xdWV1ZUNvbm5lY3RlZENhbGxiYWNrSWZOZWVkZWQoKnRoaXMpOwogICAgIH0KSW5kZXg6
IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0
VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwkocmV2aXNpb24gMjM0NDk2KQorKysgTGF5b3V0
VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0
IEBACisyMDE4LTA4LTAxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAg
ICAgIEltcGxlbWVudCBjdXN0b21FbGVtZW50cy51cGdyYWRlKCkKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzM5NworCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmUgdGhlIHRlc3Qgbm93IHRo
YXQgd2UncmUgcGFzc2luZy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9jdXN0b20t
ZWxlbWVudHMvY3VzdG9tLWVsZW1lbnQtcmVnaXN0cnkvdXBncmFkZS1leHBlY3RlZC50eHQ6CisK
IDIwMTgtMDctMjMgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAK
ICAgICAgICAgW2Nzcy1ncmlkXSBBZGQgc3VwcG9ydCBmb3IgY2FsYygpIGluIGd1dHRlciBwcm9w
ZXJ0aWVzCkluZGV4OiBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz
L2N1c3RvbS1lbGVtZW50cy9jdXN0b20tZWxlbWVudC1yZWdpc3RyeS91cGdyYWRlLWV4cGVjdGVk
LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt
LXRlc3RzL2N1c3RvbS1lbGVtZW50cy9jdXN0b20tZWxlbWVudC1yZWdpc3RyeS91cGdyYWRlLWV4
cGVjdGVkLnR4dAkocmV2aXNpb24gMjM0NDkyKQorKysgTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj
L3dlYi1wbGF0Zm9ybS10ZXN0cy9jdXN0b20tZWxlbWVudHMvY3VzdG9tLWVsZW1lbnQtcmVnaXN0
cnkvdXBncmFkZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSw3IEBACiAK
LUZBSUwgVXBncmFkaW5nIGFuIGVsZW1lbnQgZGlyZWN0bHkgKGV4YW1wbGUgZnJvbSB0aGUgc3Bl
YykgY3VzdG9tRWxlbWVudHMudXBncmFkZSBpcyBub3QgYSBmdW5jdGlvbi4gKEluICdjdXN0b21F
bGVtZW50cy51cGdyYWRlKGVsKScsICdjdXN0b21FbGVtZW50cy51cGdyYWRlJyBpcyB1bmRlZmlu
ZWQpCi1GQUlMIFR3byBlbGVtZW50cyBhcyBjaGlsZHJlbiBvZiB0aGUgdXBncmFkZWQgbm9kZSBj
dXN0b21FbGVtZW50cy51cGdyYWRlIGlzIG5vdCBhIGZ1bmN0aW9uLiAoSW4gJ2N1c3RvbUVsZW1l
bnRzLnVwZ3JhZGUoY29udGFpbmVyKScsICdjdXN0b21FbGVtZW50cy51cGdyYWRlJyBpcyB1bmRl
ZmluZWQpCi1GQUlMIFR3byBlbGVtZW50cyBhcyBkZXNjZW5kYW50cyBvZiB0aGUgdXBncmFkZWQg
bm9kZSBjdXN0b21FbGVtZW50cy51cGdyYWRlIGlzIG5vdCBhIGZ1bmN0aW9uLiAoSW4gJ2N1c3Rv
bUVsZW1lbnRzLnVwZ3JhZGUoY29udGFpbmVyKScsICdjdXN0b21FbGVtZW50cy51cGdyYWRlJyBp
cyB1bmRlZmluZWQpCi1GQUlMIFR3byBlbGVtZW50cyBhcyBzaGFkb3ctaW5jbHVkaW5nIGRlc2Nl
bmRhbnRzIChhbmQgbm90IGRlc2NlbmRhbnRzKSBvZiB0aGUgdXBncmFkZWQgbm9kZSBjdXN0b21F
bGVtZW50cy51cGdyYWRlIGlzIG5vdCBhIGZ1bmN0aW9uLiAoSW4gJ2N1c3RvbUVsZW1lbnRzLnVw
Z3JhZGUoY29udGFpbmVyKScsICdjdXN0b21FbGVtZW50cy51cGdyYWRlJyBpcyB1bmRlZmluZWQp
Ci1GQUlMIEVsZW1lbnRzIGluc2lkZSBhIHRlbXBsYXRlIGNvbnRlbnRzIERvY3VtZW50RnJhZ21l
bnQgbm9kZSBjdXN0b21FbGVtZW50cy51cGdyYWRlIGlzIG5vdCBhIGZ1bmN0aW9uLiAoSW4gJ2N1
c3RvbUVsZW1lbnRzLnVwZ3JhZGUodGVtcGxhdGUpJywgJ2N1c3RvbUVsZW1lbnRzLnVwZ3JhZGUn
IGlzIHVuZGVmaW5lZCkKK1BBU1MgVXBncmFkaW5nIGFuIGVsZW1lbnQgZGlyZWN0bHkgKGV4YW1w
bGUgZnJvbSB0aGUgc3BlYykgCitQQVNTIFR3byBlbGVtZW50cyBhcyBjaGlsZHJlbiBvZiB0aGUg
dXBncmFkZWQgbm9kZSAKK1BBU1MgVHdvIGVsZW1lbnRzIGFzIGRlc2NlbmRhbnRzIG9mIHRoZSB1
cGdyYWRlZCBub2RlIAorUEFTUyBUd28gZWxlbWVudHMgYXMgc2hhZG93LWluY2x1ZGluZyBkZXNj
ZW5kYW50cyAoYW5kIG5vdCBkZXNjZW5kYW50cykgb2YgdGhlIHVwZ3JhZGVkIG5vZGUgCitQQVNT
IEVsZW1lbnRzIGluc2lkZSBhIHRlbXBsYXRlIGNvbnRlbnRzIERvY3VtZW50RnJhZ21lbnQgbm9k
ZSAKIAo=
</data>
<flag name="review"
          id="364233"
          type_id="1"
          status="+"
          setter="fred.wang"
    />
          </attachment>
      

    </bug>

</bugzilla>