183374 2018-03-06 09:41:53 -0800 LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy delegate 2018-03-06 11:24:32 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 180568 1 danyao webkit-unassigned beidson cdumez oldest_to_newest 1404035 0 danyao 2018-03-06 09:41:53 -0800 This test now fails because with async decide policy, the iframe navigation is canceled before it gets to willSendRequest stage. window.stop is still working as intended. 1404050 1 335112 danyao 2018-03-06 10:29:00 -0800 Created attachment 335112 Patch 1404051 2 335113 danyao 2018-03-06 10:33:15 -0800 Created attachment 335113 Fixed typo. Patch for review 1404059 3 335113 cdumez 2018-03-06 10:43:31 -0800 Comment on attachment 335113 Fixed typo. Patch for review You would also need to fix the existing test. Otherwise, this does not help us enable async delegates by default. In this case though, since there is no code change, I am not convinced it is worth landing any new test. We can merely rebaseline LayoutTests/http/tests/misc/window-dot-stop.html when we enable async delegates by default. 1404078 4 danyao 2018-03-06 11:24:32 -0800 OK that sounds reasonable. I think the failure message I added to the onload events make the test slightly more clear, but this seems minor and I'm OK just rebaseline later. 335112 2018-03-06 10:29:00 -0800 2018-03-06 10:33:05 -0800 Patch bug-183374-20180306132859.patch text/plain 3216 danyao U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5Mjg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGMxNjVkYjQwYzM2N2U1MWFmNGMy Y2I2YWVjN2Y3YjliNGQ2ZjY5ZS4uMjcxNmFlMDJiN2UzMWM0OWMxN2NmY2ZlNWEwNmEyNzNkMzQ3 ZTFiMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAzLTA2ICBEYW55YW8gV2FuZyAgPGRh bnlhb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNj L3dpbmRvdy1kb3Qtc3RvcC5odG1sIGZhaWxzIHdpdGggYXN5bmMgcG9saWN5IGRlbGVnYXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzNzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3Qg ZXhwZWN0cyB0byBzZWUgYSBzbG93IGxvYWQgaW4gYW4gaWZyYW1lIHN0YXJ0ZWQgYnV0IHRoZW4g Y2FuY2VsZWQgZHVlIHRvCisgICAgICAgIHdpbmRvdy5zdG9wKCkuIFdpdGggYXN5bmMgZGVjaWRl IHBvbGljeSwgdGhlIGNhbmNlbGF0aW9uIGhhcHBlbnMgYmVmb3JlCisgICAgICAgIGNvbnRpbnVl TG9hZEFmdGVyTmF2aWdhdGlvblBvbGljeSgpIGFuZCBEb2N1bWVudExvYWRlcjo6d2lsbFNlbmRS ZXF1ZXN0IGlzIG5ldmVyIGNhbGxlZC4KKyAgICAgICAgSW5zdGVhZCwgd2UgY2FuIHVzZSB0aGUg YWJzZW5jZSBvZiBvbmxvYWQgY2FsbGJhY2tzIHRvIG1ha2Ugc3VyZSB0aGF0IHdpbmRvdy5zdG9w KCkKKyAgICAgICAgd29ya3MgYXMgaW50ZW5kZWQuCisKKyAgICAgICAgQWRkIGEgdmVyc2lvbiBv ZiB0aGUgdGVzdCB0aGF0IGZvcmNlcyBhc3luYyBkZWNpZGUgcG9saWN5LgorCisgICAgICAgICog aHR0cC90ZXN0cy9taXNjL3dpbmRvdy1kb3Qtc3RvcC1hc3luYy1wb2xpY3ktZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2Mvd2luZG93LWRvdC1zdG9wLWFzeW5j LXBvbGljeS5odG1sOiBBZGRlZC4KKwogMjAxOC0wMy0wNSAgQWxpIEp1bWEgIDxhanVtYUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L3NlbWFudGljcy90ZXh0LWxldmVsLXNlbWFudGljcy90aGUtYS1lbGVtZW50L2EtZG93bmxvYWQt Y2xpY2stNDA0Lmh0bWwgdGltZXMgb3V0IHdpdGggYXN5bmMgcG9saWN5IGRlbGVnYXRlcwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3dpbmRvdy1kb3Qtc3RvcC1hc3lu Yy1wb2xpY3ktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3dpbmRv dy1kb3Qtc3RvcC1hc3luYy1wb2xpY3ktZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIwYjAwOTA1 NjFjYzFjNTRiYWZmZjAyMmNjZTc3ODg2YzcyN2Y5MDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvd2luZG93LWRvdC1zdG9wLWFzeW5jLXBvbGljeS1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitodHRwOi8vMTI3LjAuMC4xOjgwMDAvbWlzYy93aW5k b3ctZG90LXN0b3AtYXN5bmMtcG9saWN5Lmh0bWwgLSBkaWRGYWlsTG9hZGluZ1dpdGhFcnJvcjog PE5TRXJyb3IgZG9tYWluIE5TVVJMRXJyb3JEb21haW4sIGNvZGUgLTk5OSwgZmFpbGluZyBVUkwg Imh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9taXNjL3dpbmRvdy1kb3Qtc3RvcC1hc3luYy1wb2xpY3ku aHRtbCI+CitUaGlzIHRlc3RzIGZvciB0aGUgc3VjY2Vzc2Z1bCB1c2Ugb2Ygd2luZG93LnN0b3Ao KQorCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy93aW5kb3ctZG90 LXN0b3AtYXN5bmMtcG9saWN5Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvd2lu ZG93LWRvdC1zdG9wLWFzeW5jLXBvbGljeS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdjZmY2NWFiMTFlNDBi ODk4NWE5MjU4YTkzMDZhNjgwNDUzMjZjOTIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL21pc2Mvd2luZG93LWRvdC1zdG9wLWFzeW5jLXBvbGljeS5odG1sCkBAIC0w LDAgKzEsMjggQEAKKzxodG1sPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKKyAgICAgICAgaWYgKHRlc3RSdW5uZXIuc2V0U2hvdWxkRGVjaWRlTmF2aWdhdGlvblBvbGlj eUFmdGVyRGVsYXkpCisgICAgICAgICAgdGVzdFJ1bm5lci5zZXRTaG91bGREZWNpZGVOYXZpZ2F0 aW9uUG9saWN5QWZ0ZXJEZWxheSh0cnVlKTsKKworICAgICAgICB0ZXN0UnVubmVyLmR1bXBSZXNv dXJjZUxvYWRDYWxsYmFja3MoKTsKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7 CisgICAgfQorCisgICAgZnVuY3Rpb24gdGVzdEZhaWxlZChsYWJlbCkgeworICAgICAgY29uc29s ZS5sb2coIlRFU1QgRkFJTEVEOiBJZiB3aW5kb3cuc3RvcCgpLCAiICsgbGFiZWwgKyAiIHNob3Vs ZCBub3QgaGF2ZSBmaXJlZC4iKTsKKyAgICB9Cis8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0idGVz dEZhaWxlZCgnYm9keS5vbmxvYWQnKSI+CitUaGlzIHRlc3RzIGZvciB0aGUgc3VjY2Vzc2Z1bCB1 c2Ugb2Ygd2luZG93LnN0b3AoKTxicj4KKzxpZnJhbWUgc3JjPSJodHRwOi8vMTI3LjAuMC4xOjgw MDAvaW5jcmVtZW50YWwvc2xvdy11dGY4LXRleHQucGwiIG9ubG9hZD0idGVzdEZhaWxlZCgnaWZy YW1lLm9ubG9hZCcpIj4KKzwvaWZyYW1lPjxicj4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RS dW5uZXIpIHsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICBzZXRUaW1lb3V0KCJ0 ZXN0UnVubmVyLm5vdGlmeURvbmUoKSIsIDApOworfQord2luZG93LnN0b3AoKTsKKzwvc2NyaXB0 PgorVEVTVCBGQUlMRUQ6ICBJZiB3aW5kb3cuc3RvcCgpIHdvcmtzLCB5b3Ugc2hvdWxkbid0IGJl IGFibGUgdG8gc2VlIHRoaXMgYW5kIHRoZSBhYm92ZSBpZnJhbWUgc2hvdWxkIG5vdCBoYXZlIGxv YWRlZC4KKzwvYm9keT4KKzwvaHRtbD4K 335113 2018-03-06 10:33:15 -0800 2018-03-06 10:43:42 -0800 Fixed typo. Patch for review bug-183374-20180306133314.patch text/plain 3222 danyao U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5Mjg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGMxNjVkYjQwYzM2N2U1MWFmNGMy Y2I2YWVjN2Y3YjliNGQ2ZjY5ZS4uMjcxNmFlMDJiN2UzMWM0OWMxN2NmY2ZlNWEwNmEyNzNkMzQ3 ZTFiMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTAzLTA2ICBEYW55YW8gV2FuZyAgPGRh bnlhb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNj L3dpbmRvdy1kb3Qtc3RvcC5odG1sIGZhaWxzIHdpdGggYXN5bmMgcG9saWN5IGRlbGVnYXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzNzQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3Qg ZXhwZWN0cyB0byBzZWUgYSBzbG93IGxvYWQgaW4gYW4gaWZyYW1lIHN0YXJ0ZWQgYnV0IHRoZW4g Y2FuY2VsZWQgZHVlIHRvCisgICAgICAgIHdpbmRvdy5zdG9wKCkuIFdpdGggYXN5bmMgZGVjaWRl IHBvbGljeSwgdGhlIGNhbmNlbGF0aW9uIGhhcHBlbnMgYmVmb3JlCisgICAgICAgIGNvbnRpbnVl TG9hZEFmdGVyTmF2aWdhdGlvblBvbGljeSgpIGFuZCBEb2N1bWVudExvYWRlcjo6d2lsbFNlbmRS ZXF1ZXN0IGlzIG5ldmVyIGNhbGxlZC4KKyAgICAgICAgSW5zdGVhZCwgd2UgY2FuIHVzZSB0aGUg YWJzZW5jZSBvZiBvbmxvYWQgY2FsbGJhY2tzIHRvIG1ha2Ugc3VyZSB0aGF0IHdpbmRvdy5zdG9w KCkKKyAgICAgICAgd29ya3MgYXMgaW50ZW5kZWQuCisKKyAgICAgICAgQWRkIGEgdmVyc2lvbiBv ZiB0aGUgdGVzdCB0aGF0IGZvcmNlcyBhc3luYyBkZWNpZGUgcG9saWN5LgorCisgICAgICAgICog aHR0cC90ZXN0cy9taXNjL3dpbmRvdy1kb3Qtc3RvcC1hc3luYy1wb2xpY3ktZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2Mvd2luZG93LWRvdC1zdG9wLWFzeW5j LXBvbGljeS5odG1sOiBBZGRlZC4KKwogMjAxOC0wMy0wNSAgQWxpIEp1bWEgIDxhanVtYUBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L3NlbWFudGljcy90ZXh0LWxldmVsLXNlbWFudGljcy90aGUtYS1lbGVtZW50L2EtZG93bmxvYWQt Y2xpY2stNDA0Lmh0bWwgdGltZXMgb3V0IHdpdGggYXN5bmMgcG9saWN5IGRlbGVnYXRlcwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3dpbmRvdy1kb3Qtc3RvcC1hc3lu Yy1wb2xpY3ktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3dpbmRv dy1kb3Qtc3RvcC1hc3luYy1wb2xpY3ktZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIwYjAwOTA1 NjFjYzFjNTRiYWZmZjAyMmNjZTc3ODg2YzcyN2Y5MDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvd2luZG93LWRvdC1zdG9wLWFzeW5jLXBvbGljeS1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitodHRwOi8vMTI3LjAuMC4xOjgwMDAvbWlzYy93aW5k b3ctZG90LXN0b3AtYXN5bmMtcG9saWN5Lmh0bWwgLSBkaWRGYWlsTG9hZGluZ1dpdGhFcnJvcjog PE5TRXJyb3IgZG9tYWluIE5TVVJMRXJyb3JEb21haW4sIGNvZGUgLTk5OSwgZmFpbGluZyBVUkwg Imh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9taXNjL3dpbmRvdy1kb3Qtc3RvcC1hc3luYy1wb2xpY3ku aHRtbCI+CitUaGlzIHRlc3RzIGZvciB0aGUgc3VjY2Vzc2Z1bCB1c2Ugb2Ygd2luZG93LnN0b3Ao KQorCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy93aW5kb3ctZG90 LXN0b3AtYXN5bmMtcG9saWN5Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvd2lu ZG93LWRvdC1zdG9wLWFzeW5jLXBvbGljeS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjNmODJiNGFiZTE5MzE4 NzNlY2Q5OGUwN2NhYjg3NGJmNDdlZDNjY2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL21pc2Mvd2luZG93LWRvdC1zdG9wLWFzeW5jLXBvbGljeS5odG1sCkBAIC0w LDAgKzEsMjggQEAKKzxodG1sPgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKKyAgICAgICAgaWYgKHRlc3RSdW5uZXIuc2V0U2hvdWxkRGVjaWRlTmF2aWdhdGlvblBvbGlj eUFmdGVyRGVsYXkpCisgICAgICAgICAgdGVzdFJ1bm5lci5zZXRTaG91bGREZWNpZGVOYXZpZ2F0 aW9uUG9saWN5QWZ0ZXJEZWxheSh0cnVlKTsKKworICAgICAgICB0ZXN0UnVubmVyLmR1bXBSZXNv dXJjZUxvYWRDYWxsYmFja3MoKTsKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7 CisgICAgfQorCisgICAgZnVuY3Rpb24gdGVzdEZhaWxlZChsYWJlbCkgeworICAgICAgY29uc29s ZS5sb2coIlRFU1QgRkFJTEVEOiBJZiB3aW5kb3cuc3RvcCgpIHdvcmtzLCAiICsgbGFiZWwgKyAi IHNob3VsZCBub3QgaGF2ZSBmaXJlZC4iKTsKKyAgICB9Cis8L3NjcmlwdD4KKzxib2R5IG9ubG9h ZD0idGVzdEZhaWxlZCgnYm9keS5vbmxvYWQnKSI+CitUaGlzIHRlc3RzIGZvciB0aGUgc3VjY2Vz c2Z1bCB1c2Ugb2Ygd2luZG93LnN0b3AoKTxicj4KKzxpZnJhbWUgc3JjPSJodHRwOi8vMTI3LjAu MC4xOjgwMDAvaW5jcmVtZW50YWwvc2xvdy11dGY4LXRleHQucGwiIG9ubG9hZD0idGVzdEZhaWxl ZCgnaWZyYW1lLm9ubG9hZCcpIj4KKzwvaWZyYW1lPjxicj4KKzxzY3JpcHQ+CitpZiAod2luZG93 LnRlc3RSdW5uZXIpIHsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICBzZXRUaW1l b3V0KCJ0ZXN0UnVubmVyLm5vdGlmeURvbmUoKSIsIDApOworfQord2luZG93LnN0b3AoKTsKKzwv c2NyaXB0PgorVEVTVCBGQUlMRUQ6ICBJZiB3aW5kb3cuc3RvcCgpIHdvcmtzLCB5b3Ugc2hvdWxk bid0IGJlIGFibGUgdG8gc2VlIHRoaXMgYW5kIHRoZSBhYm92ZSBpZnJhbWUgc2hvdWxkIG5vdCBo YXZlIGxvYWRlZC4KKzwvYm9keT4KKzwvaHRtbD4K