183370 2018-03-06 08:35:07 -0800 [Web Animations] Add a new runtime flag to control whether CSS Animations and CSS Transitions should run using the Web Animations timeline 2018-03-11 18:25:13 -0700 1 1 1 Unclassified WebKit Animations Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183552 InRadar P2 Normal --- 1 graouts graouts commit-queue dino thorton webkit-bug-importer oldest_to_newest 1403999 0 graouts 2018-03-06 08:35:07 -0800 We need a new runtime flag to control whether CSS Animations and CSS Transitions should run using the Web Animations timeline or using CSSAnimationController. 1404000 1 graouts 2018-03-06 08:35:22 -0800 <rdar://problem/38180729> 1404001 2 335100 graouts 2018-03-06 08:50:27 -0800 Created attachment 335100 Patch 1404038 3 335100 dino 2018-03-06 09:51:32 -0800 Comment on attachment 335100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335100&action=review You should check with Weinig here. > Source/WebKit/UIProcess/API/C/WKPreferences.cpp:527 > +void WKPreferencesSetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef preferencesRef, bool flag) > +{ > + toImpl(preferencesRef)->setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(flag); > +} > + > +bool WKPreferencesGetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef preferencesRef) > +{ > + return toImpl(preferencesRef)->cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(); > +} > + Don't need this. Remove it. > Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:125 > +// Defaults to false > +WK_EXPORT void WKPreferencesSetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef, bool flag); > +WK_EXPORT bool WKPreferencesGetCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(WKPreferencesRef); > + Ditto. > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:979 > +- (void)_setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:(BOOL)enabled > +{ > + _preferences->setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(enabled); > +} > + Actually I'm not sure if you need any of this other than the .yaml change. > Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:196 > + if (preference == "WebKitCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled") > + RuntimeEnabledFeatures::sharedFeatures().setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(enabled); Maybe I misunderstand the code, but I thought you didn't need to do this explicitly because the .yaml is generating code for it. 1404060 4 335100 thorton 2018-03-06 10:47:08 -0800 Comment on attachment 335100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335100&action=review >> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:527 >> + > > Don't need this. Remove it. Some clients still use this API >> Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:196 >> + RuntimeEnabledFeatures::sharedFeatures().setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled(enabled); > > Maybe I misunderstand the code, but I thought you didn't need to do this explicitly because the .yaml is generating code for it. Maybe plumbing to overrideBoolPreferenceForTestRunner isn't generated yet? 1404091 5 335100 commit-queue 2018-03-06 11:51:01 -0800 Comment on attachment 335100 Patch Clearing flags on attachment: 335100 Committed r229334: <https://trac.webkit.org/changeset/229334> 1404092 6 commit-queue 2018-03-06 11:51:02 -0800 All reviewed patches have been landed. Closing bug. 335100 2018-03-06 08:50:27 -0800 2018-03-06 11:51:01 -0800 Patch bug-183370-20180306175025.patch text/plain 11558 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQ4NzBiNjI3OTYwNzk4 ODllYzNmYmRiZTg4OWNjOTNhZTcwMWMyYy4uZTIwNzA4YzVkMDBmOGE0YjU4YTc1NzhkYTk1ZmE0 MjJjZjJhMGExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAzLTA2ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBBbmltYXRpb25z XSBBZGQgYSBuZXcgcnVudGltZSBmbGFnIHRvIGNvbnRyb2wgd2hldGhlciBDU1MgQW5pbWF0aW9u cyBhbmQgQ1NTIFRyYW5zaXRpb25zIHNob3VsZCBydW4gdXNpbmcgdGhlIFdlYiBBbmltYXRpb25z IHRpbWVsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODMzNzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4MTgwNzI5PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJlZm9yZSB3ZSBzdGFydCBjcmVh dGluZyBXZWJBbmltYXRpb24gb2JqZWN0cyB0byBwZXJmb3JtIENTUyBBbmltYXRpb25zIGFuZCBD U1MgVHJhbnNpdGlvbnMsIHdoaWNoIHdpbGwgcmVwbGFjZSB0aGUgZXhpc3RpbmcgY29kZXBhdGgK KyAgICAgICAgaW52b2x2aW5nIENTU0FuaW1hdGlvbkNvbnRyb2xsZXIgYW5kIENvbXBvc2l0ZUFu aW1hdGlvbiwgd2UgbmVlZCBhIHJ1bnRpbWUgZmxhZyB0aGF0IHdpbGwgYWxsb3cgYWxsIHRoZSBu ZXcgY29kZSB0byBiZSB0dXJuZWQgb2ZmIGJ5CisgICAgICAgIGRlZmF1bHQgd2hpbGUgd2UgYnJp bmcgdGhpcyBmZWF0dXJlIHVwLgorCisgICAgICAgICogcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1 cmVzLmg6CisgICAgICAgIChXZWJDb3JlOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXRDU1NB bmltYXRpb25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFuaW1hdGlvbnNFbmFibGVkKToK KyAgICAgICAgKFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmNzc0FuaW1hdGlvbnNB bmRDU1NUcmFuc2l0aW9uc0JhY2tlZEJ5V2ViQW5pbWF0aW9uc0VuYWJsZWQgY29uc3QpOgorCiAy MDE4LTAzLTAzICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAK ICAgICAgICAgRGVsZXRlIGluY29ycmVjdCB2ZXJzaW9uIG9mIGNsYW1wVG8oKSBmdW5jdGlvbiBm cm9tIFNWR1RvT1RGRm9udENvbnZlcnNpb24uY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNmNmQ3YjhmZjA3NGU2 ZjJjZjRkY2Y2ZWMyODdlZmM1ZDg4ZmRlMTQuLmY5ZmQ3NDFjNDEwMWY5MDE1ODVkNTRlZjgzNTA1 OTVlYWU4ZGFiNzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTgtMDMtMDYgIEFudG9p bmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViIEFuaW1hdGlvbnNd IEFkZCBhIG5ldyBydW50aW1lIGZsYWcgdG8gY29udHJvbCB3aGV0aGVyIENTUyBBbmltYXRpb25z IGFuZCBDU1MgVHJhbnNpdGlvbnMgc2hvdWxkIHJ1biB1c2luZyB0aGUgV2ViIEFuaW1hdGlvbnMg dGltZWxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MzM3MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzgxODA3Mjk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlIHdlIHN0YXJ0IGNyZWF0 aW5nIFdlYkFuaW1hdGlvbiBvYmplY3RzIHRvIHBlcmZvcm0gQ1NTIEFuaW1hdGlvbnMgYW5kIENT UyBUcmFuc2l0aW9ucywgd2hpY2ggd2lsbCByZXBsYWNlIHRoZSBleGlzdGluZyBjb2RlcGF0aAor ICAgICAgICBpbnZvbHZpbmcgQ1NTQW5pbWF0aW9uQ29udHJvbGxlciBhbmQgQ29tcG9zaXRlQW5p bWF0aW9uLCB3ZSBuZWVkIGEgcnVudGltZSBmbGFnIHRoYXQgd2lsbCBhbGxvdyBhbGwgdGhlIG5l dyBjb2RlIHRvIGJlIHR1cm5lZCBvZmYgYnkKKyAgICAgICAgZGVmYXVsdCB3aGlsZSB3ZSBicmlu ZyB0aGlzIGZlYXR1cmUgdXAuCisKKyAgICAgICAgKiBTaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFt bDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHA6CisgICAgICAg IChXS1ByZWZlcmVuY2VzU2V0Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlX ZWJBbmltYXRpb25zRW5hYmxlZCk6CisgICAgICAgIChXS1ByZWZlcmVuY2VzR2V0Q1NTQW5pbWF0 aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZCk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmg6CisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tOgorICAgICAgICAoLVtXS1By ZWZlcmVuY2VzIF9zZXRDU1NBbmltYXRpb25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFu aW1hdGlvbnNFbmFibGVkOl0pOgorICAgICAgICAoLVtXS1ByZWZlcmVuY2VzIF9jc3NBbmltYXRp b25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFuaW1hdGlvbnNFbmFibGVkXSk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oOgorICAgICAg ICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZTo6b3ZlcnJpZGVCb29sUHJlZmVyZW5jZUZvclRlc3RS dW5uZXIpOgorICAgICAgICAoV2ViS2l0OjpJbmplY3RlZEJ1bmRsZTo6c2V0Q1NTQW5pbWF0aW9u c0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZCk6CisgICAgICAg ICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5oOgorCiAyMDE4LTAz LTAzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE5vdGlm eSB0aGUgTmV0d29ya1Byb2Nlc3Mgd2hlbiBhIHNlc3Npb24gaXMgc2VydmljaW5nIGFuIGF1dG9t YXRpb24gY2xpZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1bnRpbWVFbmFi bGVkRmVhdHVyZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJl cy5oCmluZGV4IDI1ZmU2MDZhZTU3MzhkMmU2MjMyNTQxMDZhOGVlNDVjYzE5ZTQ0ZWEuLjBjNWJl NjQ3MTc2NzQxN2VjYzY3Mzg4ZmYzNDliNzMxNzUyMWZkZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCkBAIC0xNjgsNiArMTY4LDkgQEAgcHVibGlj OgogICAgIHZvaWQgc2V0V2ViQW5pbWF0aW9uc0VuYWJsZWQoYm9vbCBhcmVFbmFibGVkKSB7IG1f YXJlV2ViQW5pbWF0aW9uc0VuYWJsZWQgPSBhcmVFbmFibGVkOyB9CiAgICAgYm9vbCB3ZWJBbmlt YXRpb25zRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYXJlV2ViQW5pbWF0aW9uc0VuYWJsZWQ7 IH0KIAorICAgIHZvaWQgc2V0Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlX ZWJBbmltYXRpb25zRW5hYmxlZChib29sIGFyZUVuYWJsZWQpIHsgbV9hcmVDU1NBbmltYXRpb25z QW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFuaW1hdGlvbnNFbmFibGVkID0gYXJlRW5hYmxl ZDsgfQorICAgIGJvb2wgY3NzQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJB bmltYXRpb25zRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYXJlQ1NTQW5pbWF0aW9uc0FuZENT U1RyYW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZDsgfQorCiAjaWYgRU5BQkxF KFdFQkdMMikKICAgICB2b2lkIHNldFdlYkdMMkVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgbV9p c1dlYkdMMkVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0KICAgICBib29sIHdlYkdMMkVuYWJsZWQoKSBj b25zdCB7IHJldHVybiBtX2lzV2ViR0wyRW5hYmxlZDsgfQpAQCAtMzMxLDYgKzMzNCw3IEBAIHBy aXZhdGU6CiAjZW5kaWYKIAogICAgIGJvb2wgbV9hcmVXZWJBbmltYXRpb25zRW5hYmxlZCB7IGZh bHNlIH07CisgICAgYm9vbCBtX2FyZUNTU0FuaW1hdGlvbnNBbmRDU1NUcmFuc2l0aW9uc0JhY2tl ZEJ5V2ViQW5pbWF0aW9uc0VuYWJsZWQgeyBmYWxzZSB9OwogCiAjaWYgRU5BQkxFKFdFQkdMMikK ICAgICBib29sIG1faXNXZWJHTDJFbmFibGVkIHsgZmFsc2UgfTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9XZWJQcmVmZXJlbmNlcy55YW1sCmluZGV4IGI4MjZlNGI3MzQxOGVlMjJiZTQzOWRjZDBmZjli ZTFiOTJhMWM2OTYuLmEyNDBhODhlNzBiYWQ3OGE3ZDM5MTQ4M2FhNjJlMzFiM2ZjMjU5NTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIv U291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbApAQCAtOTksNiArOTksMTEg QEAgQ1NTQW5pbWF0aW9uVHJpZ2dlcnNFbmFibGVkOgogICB3ZWJjb3JlTmFtZTogYW5pbWF0aW9u VHJpZ2dlcnNFbmFibGVkCiAgIGNvbmRpdGlvbjogRU5BQkxFKENTU19BTklNQVRJT05TX0xFVkVM XzIpCiAKK0NTU0FuaW1hdGlvbnNBbmRDU1NUcmFuc2l0aW9uc0JhY2tlZEJ5V2ViQW5pbWF0aW9u c0VuYWJsZWQ6CisgIHR5cGU6IGJvb2wKKyAgZGVmYXVsdFZhbHVlOiBmYWxzZQorICB3ZWJjb3Jl QmluZGluZzogUnVudGltZUVuYWJsZWRGZWF0dXJlcworCiBGb3JjZUZUUERpcmVjdG9yeUxpc3Rp bmdzOgogICB0eXBlOiBib29sCiAgIGRlZmF1bHRWYWx1ZTogZmFsc2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXMuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlcy5jcHAKaW5kZXggOGE3M2JkYjYwNThl Mzk0OTRmNTZmODQ0NTgyN2E3YzVhNmM5OTE1Ni4uMjQzODU0NzFkMTI5NmY2OWI3Njg2MzRmNjVm NWM4NGJmYWQ2NmYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Mv V0tQcmVmZXJlbmNlcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQ cmVmZXJlbmNlcy5jcHAKQEAgLTUxNSw2ICs1MTUsMTYgQEAgYm9vbCBXS1ByZWZlcmVuY2VzR2V0 V2ViQW5pbWF0aW9uc0VuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZiBwcmVmZXJlbmNlc1JlZikKICAg ICByZXR1cm4gdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+d2ViQW5pbWF0aW9uc0VuYWJsZWQoKTsK IH0KIAordm9pZCBXS1ByZWZlcmVuY2VzU2V0Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25z QmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVuY2Vz UmVmLCBib29sIGZsYWcpCit7CisgICAgdG9JbXBsKHByZWZlcmVuY2VzUmVmKS0+c2V0Q1NTQW5p bWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZChmbGFn KTsKK30KKworYm9vbCBXS1ByZWZlcmVuY2VzR2V0Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRp b25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmIHByZWZlcmVu Y2VzUmVmKQoreworICAgIHJldHVybiB0b0ltcGwocHJlZmVyZW5jZXNSZWYpLT5jc3NBbmltYXRp b25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFuaW1hdGlvbnNFbmFibGVkKCk7Cit9CisK IHZvaWQgV0tQcmVmZXJlbmNlc1NldE5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKFdLUHJlZmVyZW5j ZXNSZWYgcHJlZmVyZW5jZXNSZWYsIGJvb2wgZmxhZykKIHsKICAgICB0b0ltcGwocHJlZmVyZW5j ZXNSZWYpLT5zZXROZWVkc1NpdGVTcGVjaWZpY1F1aXJrcyhmbGFnKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmggYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUmVmUHJpdmF0ZS5oCmlu ZGV4IDBhODVmNjllNDZkOTc4MTA1NDFhZDFjMTYxODk4MWFmMWUwMjZiNTAuLjgwOWIzMTg5MWIy YzUwMWEwMTNlNmFlODkzN2MxYzc4Nzg0M2U5YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmgKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlc1JlZlByaXZhdGUuaApAQCAtMTE5LDYg KzExOSwxMCBAQCBXS19FWFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0Q1NTQW5pbWF0aW9uVHJp Z2dlcnNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYpOwogV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJl bmNlc1NldFdlYkFuaW1hdGlvbnNFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYsIGJvb2wgZmxhZyk7 CiBXS19FWFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0V2ViQW5pbWF0aW9uc0VuYWJsZWQoV0tQ cmVmZXJlbmNlc1JlZik7CiAKKy8vIERlZmF1bHRzIHRvIGZhbHNlCitXS19FWFBPUlQgdm9pZCBX S1ByZWZlcmVuY2VzU2V0Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJB bmltYXRpb25zRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpOworV0tfRVhQT1JU IGJvb2wgV0tQcmVmZXJlbmNlc0dldENTU0FuaW1hdGlvbnNBbmRDU1NUcmFuc2l0aW9uc0JhY2tl ZEJ5V2ViQW5pbWF0aW9uc0VuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZik7CisKIC8vIERlZmF1bHRz IHRvIGZhbHNlLgogV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNlc1NldE5lZWRzU2l0ZVNwZWNp ZmljUXVpcmtzKFdLUHJlZmVyZW5jZXNSZWYsIGJvb2wpOwogV0tfRVhQT1JUIGJvb2wgV0tQcmVm ZXJlbmNlc0dldE5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKFdLUHJlZmVyZW5jZXNSZWYpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMu bW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQpp bmRleCA3NDU1NjhlMjJiY2MxMmU1ODI3ODg4MDcxZjY2YjUzYzNkODIwZjBkLi5jM2ExNjZkNWU4 NWQ4MzQ2YjE1NjcyODhkYmQ5MzU1MTdmNGU5NjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQpAQCAtOTcyLDYgKzk3MiwxNiBA QCAtIChCT09MKV9jc3NBbmltYXRpb25UcmlnZ2Vyc0VuYWJsZWQKICAgICByZXR1cm4gX3ByZWZl cmVuY2VzLT5jc3NBbmltYXRpb25UcmlnZ2Vyc0VuYWJsZWQoKTsKIH0KIAorLSAodm9pZClfc2V0 Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxl ZDooQk9PTCllbmFibGVkCit7CisgICAgX3ByZWZlcmVuY2VzLT5zZXRDU1NBbmltYXRpb25zQW5k Q1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFuaW1hdGlvbnNFbmFibGVkKGVuYWJsZWQpOworfQor CistIChCT09MKV9jc3NBbmltYXRpb25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdlYkFuaW1h dGlvbnNFbmFibGVkCit7CisgICAgcmV0dXJuIF9wcmVmZXJlbmNlcy0+Y3NzQW5pbWF0aW9uc0Fu ZENTU1RyYW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZCgpOworfQorCiAtICh2 b2lkKV9zZXRTdGFuZGFyZEZvbnRGYW1pbHk6KE5TU3RyaW5nICopZmFtaWx5CiB7CiAgICAgX3By ZWZlcmVuY2VzLT5zZXRTdGFuZGFyZEZvbnRGYW1pbHkoZmFtaWx5KTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgK aW5kZXggNzIzMDNiM2M1ZGZlMDhhOTNjNDI4YjZkNTg5ZGJiYjQ3ODgxZTA4Mi4uY2I3OTAyNzdm MjMwYzliNzViYzFhNTUyY2JiMjk1OGY0NjYxMjc0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTE1 OCw2ICsxNTgsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tFZGl0YWJsZUxpbmtC ZWhhdmlvcikgewogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0TWVkaWFTb3VyY2VF bmFibGVkOikgQk9PTCBfbWVkaWFTb3VyY2VFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4 KFdLX01BQ19UQkEpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldFZpZXdHZXN0 dXJlRGVidWdnaW5nRW5hYmxlZDopIEJPT0wgX3ZpZXdHZXN0dXJlRGVidWdnaW5nRW5hYmxlZCBX S19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSk7CiBAcHJvcGVydHkgKG5vbmF0b21p Yywgc2V0dGVyPV9zZXRDU1NBbmltYXRpb25UcmlnZ2Vyc0VuYWJsZWQ6KSBCT09MIF9jc3NBbmlt YXRpb25UcmlnZ2Vyc0VuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSkp OworQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0Q1NTQW5pbWF0aW9uc0FuZENTU1Ry YW5zaXRpb25zQmFja2VkQnlXZWJBbmltYXRpb25zRW5hYmxlZDopIEJPT0wgX2Nzc0FuaW1hdGlv bnNBbmRDU1NUcmFuc2l0aW9uc0JhY2tlZEJ5V2ViQW5pbWF0aW9uc0VuYWJsZWQgV0tfQVBJX0FW QUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSkpOwogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRl cj1fc2V0U3RhbmRhcmRGb250RmFtaWx5OikgTlNTdHJpbmcgKl9zdGFuZGFyZEZvbnRGYW1pbHkg V0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSkpOwogQHByb3BlcnR5IChub25hdG9t aWMsIHNldHRlcj1fc2V0Tm90aWZpY2F0aW9uc0VuYWJsZWQ6KSBCT09MIF9ub3RpZmljYXRpb25z RW5hYmxlZCBXS19BUElfQVZBSUxBQkxFKG1hY29zeChXS19NQUNfVEJBKSk7CiBAcHJvcGVydHkg KG5vbmF0b21pYywgc2V0dGVyPV9zZXRCYWNrc3BhY2VLZXlOYXZpZ2F0aW9uRW5hYmxlZDopIEJP T0wgX2JhY2tzcGFjZUtleU5hdmlnYXRpb25FbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4 KFdLX01BQ19UQkEpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCmluZGV4IDlkODI3ZDVhZWFkYWVmM2M2 ZTYwOTNhNjAzNmQ1Yjg3ODc1N2Q1ZGEuLmFhMjMwOGE5YWE3ZWE3MmIyOWJmZGRkYjM1MWY2MDQ5 ZGY3OTRiZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1 bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcApAQCAtMTkyLDYgKzE5Miw5IEBAIHZvaWQg SW5qZWN0ZWRCdW5kbGU6Om92ZXJyaWRlQm9vbFByZWZlcmVuY2VGb3JUZXN0UnVubmVyKFdlYlBh Z2VHcm91cFByb3h5KiBwYWdlCiAgICAgaWYgKHByZWZlcmVuY2UgPT0gIldlYktpdFdlYkFuaW1h dGlvbnNFbmFibGVkIikKICAgICAgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVh dHVyZXMoKS5zZXRXZWJBbmltYXRpb25zRW5hYmxlZChlbmFibGVkKTsKIAorICAgIGlmIChwcmVm ZXJlbmNlID09ICJXZWJLaXRDU1NBbmltYXRpb25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdl YkFuaW1hdGlvbnNFbmFibGVkIikKKyAgICAgICAgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hh cmVkRmVhdHVyZXMoKS5zZXRDU1NBbmltYXRpb25zQW5kQ1NTVHJhbnNpdGlvbnNCYWNrZWRCeVdl YkFuaW1hdGlvbnNFbmFibGVkKGVuYWJsZWQpOworCiAgICAgaWYgKHByZWZlcmVuY2UgPT0gIldl YktpdENhY2hlQVBJRW5hYmxlZCIpCiAgICAgICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNo YXJlZEZlYXR1cmVzKCkuc2V0Q2FjaGVBUElFbmFibGVkKGVuYWJsZWQpOwogCkBAIC02MTQsNCAr NjE3LDkgQEAgdm9pZCBJbmplY3RlZEJ1bmRsZTo6c2V0V2ViQW5pbWF0aW9uc0VuYWJsZWQoYm9v bCBlbmFibGVkKQogICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCku c2V0V2ViQW5pbWF0aW9uc0VuYWJsZWQoZW5hYmxlZCk7CiB9CiAKK3ZvaWQgSW5qZWN0ZWRCdW5k bGU6OnNldENTU0FuaW1hdGlvbnNBbmRDU1NUcmFuc2l0aW9uc0JhY2tlZEJ5V2ViQW5pbWF0aW9u c0VuYWJsZWQoYm9vbCBlbmFibGVkKQoreworICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNo YXJlZEZlYXR1cmVzKCkuc2V0Q1NTQW5pbWF0aW9uc0FuZENTU1RyYW5zaXRpb25zQmFja2VkQnlX ZWJBbmltYXRpb25zRW5hYmxlZChlbmFibGVkKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvSW5q ZWN0ZWRCdW5kbGUuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9J bmplY3RlZEJ1bmRsZS5oCmluZGV4IGQwY2U3Y2U0ZDYxM2Y3M2QxYmZjODAwNTNmMDUzZmU3YjVm OGI4YjkuLmFiYmYzOTdhM2JkYTEwNGIyNDY3ZWNjMmNjYWU5NDZlYzI2NzY0YjkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRs ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3Rl ZEJ1bmRsZS5oCkBAIC0xNTEsNiArMTUxLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0U2VyaWFs TG9hZGluZ0VuYWJsZWQoYm9vbCk7CiAgICAgdm9pZCBzZXRDU1NBbmltYXRpb25UcmlnZ2Vyc0Vu YWJsZWQoYm9vbCk7CiAgICAgdm9pZCBzZXRXZWJBbmltYXRpb25zRW5hYmxlZChib29sKTsKKyAg ICB2b2lkIHNldENTU0FuaW1hdGlvbnNBbmRDU1NUcmFuc2l0aW9uc0JhY2tlZEJ5V2ViQW5pbWF0 aW9uc0VuYWJsZWQoYm9vbCk7CiAgICAgdm9pZCBkaXNwYXRjaFBlbmRpbmdMb2FkUmVxdWVzdHMo KTsKIAogI2lmIFBMQVRGT1JNKENPQ09BKSAmJiBXS19BUElfRU5BQkxFRAo=