18337 2008-04-06 17:41:14 -0700 Multiline <select> don't fire onchange events when typing-to-select 2008-06-06 14:13:41 -0700 1 1 1 Unclassified WebKit DOM 525.x (Safari 3.1) Mac OS X 10.5 RESOLVED FIXED HasReduction P2 Normal --- 1 rik webkit-unassigned adele ap mitz oldest_to_newest 76448 0 rik 2008-04-06 17:41:14 -0700 When typing the name of an option, the onchange event is never fired. Even after defocusing the <select> element. The event fires using up and down arrows. Steps to Reproduce: 1) Select the "aaaaa" option. "aaaaa" is written in the console. 2) Hit the down arrow. "bbbbb" is written in the console. 3) Hit the "c" key. "ccccc" is NOT written in the console. 4) Unfocus the <select> element. "ccccc" is NOT written in the console. Spec : http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-eventgroupings-htmlevents Even if the specs says that the event should fire when the element loses the focus, other browsers are firing the event each time a new row is selected. 76449 1 20374 rik 2008-04-06 17:42:22 -0700 Created attachment 20374 Testcase 82117 2 21461 rik 2008-06-02 06:58:06 -0700 Created attachment 21461 Proposed patch I think this is the right place to fire this event but i'm not really confident. However, the testcase and the original application are fixed with this patch. 82253 3 21487 rik 2008-06-03 16:14:46 -0700 Created attachment 21487 Patch with LayoutTest Added some tests thanks to Alexey Proskuryakov. 82456 4 eric 2008-06-06 14:13:41 -0700 http://trac.webkit.org/changeset/34405 20374 2008-04-06 17:42:22 -0700 2008-04-06 17:42:22 -0700 Testcase testcase.html text/html 678 rik PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIK CSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4KCjxo dG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iIGxh bmc9ImVuIj4KPGhlYWQ+Cgk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9 InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCIvPgoKCTx0aXRsZT5NdWx0aWxpbmUgU2VsZWN0cyBk b24ndCBmaXJlIG9uY2hhbmdlIGV2ZW50cyB3aGVuIHR5cGluZy10by1zZWxlY3Q8L3RpdGxlPgoJ CjwvaGVhZD4KCjxib2R5Pgo8Zm9ybSBhY3Rpb249IiI+CiAgICA8ZmllbGRzZXQ+CiAgICAgICAg PHNlbGVjdCBvbmNoYW5nZT0iY29uc29sZS5sb2codGhpcy5vcHRpb25zW3RoaXMuc2VsZWN0ZWRJ bmRleF0udmFsdWUpIiBzaXplPSI0Ij4KICAgICAgICAgICAgPG9wdGlvbj5hYWFhYTwvb3B0aW9u PgogICAgICAgICAgICA8b3B0aW9uPmJiYmJiPC9vcHRpb24+CiAgICAgICAgICAgIDxvcHRpb24+ Y2NjY2M8L29wdGlvbj4KICAgICAgICAgICAgPG9wdGlvbj5kZGRkZDwvb3B0aW9uPgogICAgICAg IDwvc2VsZWN0PgogICAgPC9maWVsZHNldD4KPC9mb3JtPgo8L2JvZHk+CjwvaHRtbD4K 21461 2008-06-02 06:58:06 -0700 2008-06-03 16:14:46 -0700 Proposed patch pouet.patch text/plain 1202 rik ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODVhZGVmOS4uYjJlYjg0YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOC0wNi0wMiAgQW50aG9ueSBSaWNh dWQgIDxyaWsyNGRAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODMzNworICAgICAgICAKKyAgICAgICAgQ2FsbHMgbGlzdEJveE9uQ2hhbmdlKCkgaW4gdHlwZUFo ZWFkRmluZCgpIHdoZW4gdGhlIDxzZWxlY3Q+IHRhZyBpcyBhIGxpc3RCb3guCisgICAgICAgIAor ICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAg ICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFNl bGVjdEVsZW1lbnQ6OnR5cGVBaGVhZEZpbmQpOgorCiAyMDA4LTA2LTAxICBSb2IgQnVpcyAgPGJ1 aXNAa2RlLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTFNlbGVj dEVsZW1lbnQuY3BwCmluZGV4IDNmNzc5OWIuLmU2NmMzNDMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv aHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RF bGVtZW50LmNwcApAQCAtOTg3LDYgKzk4Nyw4IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnR5 cGVBaGVhZEZpbmQoS2V5Ym9hcmRFdmVudCogZXZlbnQpCiAKICAgICAgICAgaWYgKHN0cmlwTGVh ZGluZ1doaXRlU3BhY2Uoc3RhdGljX2Nhc3Q8SFRNTE9wdGlvbkVsZW1lbnQqPihpdGVtc1tpbmRl eF0pLT5vcHRpb25UZXh0KCkpLnN0YXJ0c1dpdGgocHJlZml4LCBmYWxzZSkpIHsKICAgICAgICAg ICAgIHNldFNlbGVjdGVkSW5kZXgobGlzdFRvT3B0aW9uSW5kZXgoaW5kZXgpKTsKKyAgICAgICAg ICAgIGlmKCF1c2VzTWVudUxpc3QoKSkKKyAgICAgICAgICAgICAgICBsaXN0Qm94T25DaGFuZ2Uo KTsKICAgICAgICAgICAgIHNldENoYW5nZWQoKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAg ICAgfQo= 21487 2008-06-03 16:14:46 -0700 2008-06-06 13:52:29 -0700 Patch with LayoutTest plop.patch text/plain 3742 rik SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDM1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDYtMDMgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMzcKKyAgICAgICAgCisg ICAgICAgIENhbGxzIGxpc3RCb3hPbkNoYW5nZSgpIGluIHR5cGVBaGVhZEZpbmQoKSB3aGVuIHRo ZSA8c2VsZWN0PiB0YWcgaXMgYSBsaXN0Qm94LgorICAgICAgICAKKyAgICAgICAgKiBodG1sL0hU TUxTZWxlY3RFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxTZWxlY3RFbGVtZW50 Ojp0eXBlQWhlYWRGaW5kKToKKwogMjAwOC0wNi0wMyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbS4KSW5kZXg6IFdlYkNvcmUvaHRtbC9I VE1MU2VsZWN0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxTZWxl Y3RFbGVtZW50LmNwcAkocmV2aXNpb24gMzQzNTMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTFNlbGVj dEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDYsNiArOTQ2LDcgQEAgc3RhdGljIFN0 cmluZyBzdHJpcExlYWRpbmdXaGl0ZVNwYWNlKGNvbgogCiB2b2lkIEhUTUxTZWxlY3RFbGVtZW50 Ojp0eXBlQWhlYWRGaW5kKEtleWJvYXJkRXZlbnQqIGV2ZW50KQogewogICAgIGlmIChldmVudC0+ dGltZVN0YW1wKCkgPCBtX2xhc3RDaGFyVGltZSkKICAgICAgICAgcmV0dXJuOwogCkBAIC05ODcs NiArOTg4LDggQEAgdm9pZCBIVE1MU2VsZWN0RWxlbWVudDo6dHlwZUFoZWFkRmluZChLZQogCiAg ICAgICAgIGlmIChzdHJpcExlYWRpbmdXaGl0ZVNwYWNlKHN0YXRpY19jYXN0PEhUTUxPcHRpb25F bGVtZW50Kj4oaXRlbXNbaW5kZXhdKS0+b3B0aW9uVGV4dCgpKS5zdGFydHNXaXRoKHByZWZpeCwg ZmFsc2UpKSB7CiAgICAgICAgICAgICBzZXRTZWxlY3RlZEluZGV4KGxpc3RUb09wdGlvbkluZGV4 KGluZGV4KSk7CisgICAgICAgICAgICBpZighdXNlc01lbnVMaXN0KCkpCisgICAgICAgICAgICAg ICAgbGlzdEJveE9uQ2hhbmdlKCk7CiAgICAgICAgICAgICBzZXRDaGFuZ2VkKCk7CiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM0MzUzKQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgt MDYtMDMgIEFudGhvbnkgUmljYXVkICA8cmlrMjRkQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMzcKKyAgICAgICAgCisgICAgICAgIENoZWNrcyB0aGF0IG9u Y2hhbmdlIGZpcmVzIHdoZW4gdHlwaW5nIHRoZSBuYW1lIG9mIGFuIG9wdGlvbiBhbmQgZG9lc24n dCBmaXJlIHdoZW4gbGVhdmluZyB0aGUgbGlzdGJveC4KKyAgICAgICAgCisgICAgICAgICogZmFz dC9mb3Jtcy9saXN0Ym94LW9uY2hhbmdlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zv cm1zL2xpc3Rib3gtb25jaGFuZ2UuaHRtbDoKKwogMjAwOC0wNi0wMyAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gYW5kIFNh bS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGlzdGJveC1vbmNoYW5nZS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LW9uY2hh bmdlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMzQzNTMpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2xpc3Rib3gtb25jaGFuZ2UtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yMiwz ICsyMiw2IEBAIG9uQ2hhbmdlIGZpcmVkCiBvbkNoYW5nZSBmaXJlZAogMTUpIE1ha2Ugc3VyZSBv bkNoYW5nZSBkb2Vzbid0IGZpcmUgd2hlbiByZW1vdmluZyBhIHNlbGVjdGVkIG9wdGlvbgogMTYp IE1ha2Ugc3VyZSBvbkNoYW5nZSBkb2Vzbid0IGZpcmUgd2hlbiBjbGlja2luZyBvbiB0aGUgb3B0 aW9uIHRoYXQgcmVtYWlucyBzZWxlY3RlZAorMTcpIE1ha2Ugc3VyZSBvbkNoYW5nZSBmaXJlcyB3 aGVuIHR5cGluZyB0aGUgbmFtZSBvZiBhbiBvcHRpb24KK29uQ2hhbmdlIGZpcmVkCisxOCkgTWFr ZSBzdXJlIG9uQ2hhbmdlIGRvZXNuJ3QgZmlyZSB3aGVuIGxlYXZpbmcgdGhlIHNlbGVjdApJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LW9uY2hhbmdlLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LW9uY2hhbmdlLmh0bWwJKHJldmlz aW9uIDM0MzUzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LW9uY2hhbmdlLmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTEwNSw2ICsxMDUsMTcgQEAKICAgICAgICAgICAgICAgICBt b3VzZVVwT25TZWxlY3QoInNsMSIsIDMsIGZhbHNlLCBmYWxzZSk7CiAgICAgICAgICAgICAgICAg Y2hlY2tTZWxlY3Rpb24oIjMiKTsKIAorICAgICAgICAgICAgICAgIGxvZygiMTcpIE1ha2Ugc3Vy ZSBvbkNoYW5nZSBmaXJlcyB3aGVuIHR5cGluZyB0aGUgbmFtZSBvZiBhbiBvcHRpb24iKTsKKyAg ICAgICAgICAgICAgICBvcHRpb24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJvcHRpb24iKTsK KyAgICAgICAgICAgICAgICBvcHRpb24uYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoImtleWJvYXJkIHRlc3QiKSk7CisgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInNsMSIpLmFwcGVuZENoaWxkKG9wdGlvbik7CisgICAgICAgICAgICAgICAga2V5RG93 bk9uU2VsZWN0KCJzbDEiLCAiSyIsIGZhbHNlLCBmYWxzZSk7CisgICAgICAgICAgICAgICAgY2hl Y2tTZWxlY3Rpb24oIjQiKTsKKworICAgICAgICAgICAgICAgIGxvZygiMTgpIE1ha2Ugc3VyZSBv bkNoYW5nZSBkb2Vzbid0IGZpcmUgd2hlbiBsZWF2aW5nIHRoZSBzZWxlY3QiKTsKKyAgICAgICAg ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic2wxIikuYmx1cigpOworICAgICAgICAg ICAgICAgIGNoZWNrU2VsZWN0aW9uKCI0Iik7CisKICAgICAgICAgICAgICAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5ub3RpZnlEb25lKCk7CiAgICAgICAgICAgICB9Cg==