183369 2018-03-06 08:28:24 -0800 Remove unused crash hook functionality 2018-04-12 11:56:37 -0700 1 1 1 Unclassified WebKit Web Template Framework Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 183379 1 mcatanzaro mcatanzaro ap benjamin cdumez cmarcelo commit-queue dbates ews-watchlist mcatanzaro rdemarest ryanhaddad webkit-bug-importer oldest_to_newest 1403997 0 mcatanzaro 2018-03-06 08:28:24 -0800 WTFSetCrashHook and WTFInstallReportBacktraceOnCrashHook are not used on any platforms 1403998 1 335099 mcatanzaro 2018-03-06 08:29:36 -0800 Created attachment 335099 Patch 1404070 2 mcatanzaro 2018-03-06 11:11:01 -0800 Committed r229330: <https://trac.webkit.org/changeset/229330> 1404071 3 webkit-bug-importer 2018-03-06 11:11:22 -0800 <rdar://problem/38186660> 1404109 4 ap 2018-03-06 12:48:49 -0800 Turns out that these are still used by some Apple internal code. Filed rdar://problem/38190507 to remove the dependency, rolling back for now. 1404111 5 commit-queue 2018-03-06 12:49:27 -0800 Re-opened since this is blocked by bug 183379 1404156 6 mcatanzaro 2018-03-06 14:26:55 -0800 Hardly a big deal, but I'm a bit surprised because the crash hook is only ever used in debug builds on Darwin. My guess is that something (Safari?) is installing a nonfunctional crash hook, perhaps? (Maybe we should consider renaming the *_EXPORT_PRIVATE macros, since they actually make the symbols public.) 1414079 7 ap 2018-04-12 10:47:49 -0700 I think that this can be re-landed now. 1414093 8 mcatanzaro 2018-04-12 11:14:09 -0700 Okidokie then. 1414094 9 337810 mcatanzaro 2018-04-12 11:17:17 -0700 Created attachment 337810 Patch for landing 1414122 10 337810 commit-queue 2018-04-12 11:56:35 -0700 Comment on attachment 337810 Patch for landing Clearing flags on attachment: 337810 Committed r230589: <https://trac.webkit.org/changeset/230589> 1414123 11 commit-queue 2018-04-12 11:56:37 -0700 All reviewed patches have been landed. Closing bug. 335099 2018-03-06 08:29:36 -0800 2018-04-12 11:17:15 -0700 Patch bug-183369-20180306102935.patch text/plain 3510 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI0NzAyMjhlY2EyZGNiOGEzMmVkYWRk ODcwZGQwYjQ0MDBkNDk0MDUuLmQ3ZTVkZGFkMTllZjdlZDk1ZDA5M2UzYmIwZjdjNmQ1MmQ3MGMy MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDMtMDYgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgY3Jhc2ggaG9v ayBmdW5jdGlvbmFsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODMzNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXVEZTZXRDcmFzaEhvb2sgYW5kIFdURkluc3RhbGxSZXBvcnRCYWNrdHJhY2VPbkNy YXNoSG9vayBhcmUgbm90IHVzZWQgb24gYW55IHBsYXRmb3JtcyBhbmQKKyAgICAgICAgY2FuIGJl IHJlbW92ZWQuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5jcHA6CisgICAgICAgICogd3Rm L0Fzc2VydGlvbnMuaDoKKwogMjAxOC0wMy0wMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVh QGdtYWlsLmNvbT4KIAogICAgICAgICBbV1RGXSBSZW1vdmUgUnVuTG9vcCBhbmQgUnVuTG9vcDo6 VGltZXIncyBpbnRlcmZhY2UgdXNpbmcgZG91YmxlIGFzIHNlY29uZHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5j cHAKaW5kZXggMDYxMDkzYWNjOWU5NzkxMTE0ZmM2YzE1YmExZTJjYWMzMGIwOWE2ZS4uOTQ4MjZk NzgxMWIxNzkyNWU0MGIzNDc2ZThiNTYwZTMxOWRjY2YwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAK QEAgLTI1MSwxOSArMjUxLDkgQEAgdm9pZCBXVEZQcmludEJhY2t0cmFjZSh2b2lkKiogc3RhY2ss IGludCBzaXplKQogICAgIG91dC5wcmludChzdGFja1RyYWNlKTsKIH0KIAotc3RhdGljIFdURkNy YXNoSG9va0Z1bmN0aW9uIGdsb2JhbEhvb2sgPSAwOwotCi12b2lkIFdURlNldENyYXNoSG9vayhX VEZDcmFzaEhvb2tGdW5jdGlvbiBmdW5jdGlvbikKLXsKLSAgICBnbG9iYWxIb29rID0gZnVuY3Rp b247Ci19Ci0KICNpZiAhZGVmaW5lZChOREVCVUcpIHx8ICFPUyhEQVJXSU4pCiB2b2lkIFdURkNy YXNoKCkKIHsKLSAgICBpZiAoZ2xvYmFsSG9vaykKLSAgICAgICAgZ2xvYmFsSG9vaygpOwotCiAg ICAgV1RGUmVwb3J0QmFja3RyYWNlKCk7CiAjaWYgQVNBTl9FTkFCTEVECiAgICAgX19idWlsdGlu X3RyYXAoKTsKQEAgLTI5Miw0MiArMjgyLDYgQEAgdm9pZCBXVEZDcmFzaFdpdGhTZWN1cml0eUlt cGxpY2F0aW9uKCkKICAgICBDUkFTSCgpOwogfQogCi0jaWYgSEFWRShTSUdOQUxfSCkKLXN0YXRp YyBOT19SRVRVUk4gdm9pZCBkdW1wQmFja3RyYWNlU2lnbmFsSGFuZGxlcihpbnQgc2lnKQotewot ICAgIFdURlJlcG9ydEJhY2t0cmFjZSgpOwotICAgIGV4aXQoMTI4ICsgc2lnKTsKLX0KLQotc3Rh dGljIHZvaWQgaW5zdGFsbFNpZ25hbEhhbmRsZXJzRm9yRmF0YWxFcnJvcnModm9pZCAoKmhhbmRs ZXIpKGludCkpCi17Ci0gICAgc2lnbmFsKFNJR0lMTCwgaGFuZGxlcik7IC8vICAgIDQ6IGlsbGVn YWwgaW5zdHJ1Y3Rpb24gKG5vdCByZXNldCB3aGVuIGNhdWdodCkuCi0gICAgc2lnbmFsKFNJR1RS QVAsIGhhbmRsZXIpOyAvLyAgIDU6IHRyYWNlIHRyYXAgKG5vdCByZXNldCB3aGVuIGNhdWdodCku Ci0gICAgc2lnbmFsKFNJR0ZQRSwgaGFuZGxlcik7IC8vICAgIDg6IGZsb2F0aW5nIHBvaW50IGV4 Y2VwdGlvbi4KLSAgICBzaWduYWwoU0lHQlVTLCBoYW5kbGVyKTsgLy8gICAxMDogYnVzIGVycm9y LgotICAgIHNpZ25hbChTSUdTRUdWLCBoYW5kbGVyKTsgLy8gIDExOiBzZWdtZW50YXRpb24gdmlv bGF0aW9uLgotICAgIHNpZ25hbChTSUdTWVMsIGhhbmRsZXIpOyAvLyAgIDEyOiBiYWQgYXJndW1l bnQgdG8gc3lzdGVtIGNhbGwuCi0gICAgc2lnbmFsKFNJR1BJUEUsIGhhbmRsZXIpOyAvLyAgMTM6 IHdyaXRlIG9uIGEgcGlwZSB3aXRoIG5vIHJlYWRlci4KLSAgICBzaWduYWwoU0lHWENQVSwgaGFu ZGxlcik7IC8vICAyNDogZXhjZWVkZWQgQ1BVIHRpbWUgbGltaXQuCi0gICAgc2lnbmFsKFNJR1hG U1osIGhhbmRsZXIpOyAvLyAgMjU6IGV4Y2VlZGVkIGZpbGUgc2l6ZSBsaW1pdC4KLX0KLQotc3Rh dGljIHZvaWQgcmVzZXRTaWduYWxIYW5kbGVyc0ZvckZhdGFsRXJyb3JzKCkKLXsKLSAgICBpbnN0 YWxsU2lnbmFsSGFuZGxlcnNGb3JGYXRhbEVycm9ycyhTSUdfREZMKTsKLX0KLSNlbmRpZgotCi12 b2lkIFdURkluc3RhbGxSZXBvcnRCYWNrdHJhY2VPbkNyYXNoSG9vaygpCi17Ci0jaWYgSEFWRShT SUdOQUxfSCkKLSAgICAvLyBOZWVkZWQgb3RoZXJ3aXNlIHdlIGFyZSBnb2luZyB0byBkdW1wIHRo ZSBzdGFjayB0cmFjZSB0d2ljZQotICAgIC8vIGluIGNhc2Ugd2UgaGl0IGFuIGFzc2VydGlvbi4K LSAgICBXVEZTZXRDcmFzaEhvb2soJnJlc2V0U2lnbmFsSGFuZGxlcnNGb3JGYXRhbEVycm9ycyk7 Ci0gICAgaW5zdGFsbFNpZ25hbEhhbmRsZXJzRm9yRmF0YWxFcnJvcnMoJmR1bXBCYWNrdHJhY2VT aWduYWxIYW5kbGVyKTsKLSNlbmRpZgotfQotCiBib29sIFdURklzRGVidWdnZXJBdHRhY2hlZCgp CiB7CiAjaWYgT1MoREFSV0lOKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9u cy5oIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCmluZGV4IDBkYTFiNzcxOTk4ZDllNDVm ZDBiZTIyNmE5MzRhZGI3NGNjODdiYmYuLjRiZTc2OTJiN2IxNDk4ZWQ4ZGNjZTZkZGI0NWE2ZWY4 MzRjZWE4OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTIwMCwxMCArMjAwLDYgQEAgV1RGX0VYUE9S VF9QUklWQVRFIHZvaWQgV1RGR2V0QmFja3RyYWNlKHZvaWQqKiBzdGFjaywgaW50KiBzaXplKTsK IFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURlJlcG9ydEJhY2t0cmFjZSh2b2lkKTsKIFdURl9F WFBPUlRfUFJJVkFURSB2b2lkIFdURlByaW50QmFja3RyYWNlKHZvaWQqKiBzdGFjaywgaW50IHNp emUpOwogCi10eXBlZGVmIHZvaWQgKCpXVEZDcmFzaEhvb2tGdW5jdGlvbikodm9pZCk7Ci1XVEZf RVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZTZXRDcmFzaEhvb2soV1RGQ3Jhc2hIb29rRnVuY3Rpb24p OwotV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW5zdGFsbFJlcG9ydEJhY2t0cmFjZU9uQ3Jh c2hIb29rKHZvaWQpOwotCiBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCBXVEZJc0RlYnVnZ2VyQXR0 YWNoZWQodm9pZCk7CiAKICNpZiBBU0FOX0VOQUJMRUQK 337810 2018-04-12 11:17:17 -0700 2018-04-12 11:56:35 -0700 Patch for landing bug-183369-20180412131716.patch text/plain 3479 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMwNTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUyZTMxZGU1NjZkNDI1ZjMzYWQwOTlh YTgyYzU3OTg5NTE1MDFiMmEuLjA1YzEwMjViZjU2YjFiNmFmODZjYzNhYWFkNDEyOTdmM2JiMDhj NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDQtMTIgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgY3Jhc2ggaG9v ayBmdW5jdGlvbmFsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODMzNjkKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292 LgorCisgICAgICAgIFdURlNldENyYXNoSG9vayBhbmQgV1RGSW5zdGFsbFJlcG9ydEJhY2t0cmFj ZU9uQ3Jhc2hIb29rIGFyZSBub3QgdXNlZCBvbiBhbnkgcGxhdGZvcm1zIGFuZAorICAgICAgICBj YW4gYmUgcmVtb3ZlZC4KKworICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmNwcDoKKyAgICAgICAg KiB3dGYvQXNzZXJ0aW9ucy5oOgorCiAyMDE4LTA0LTExICBTYWlkIEFib3UtSGFsbGF3YSAgPHNh Ym91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjIzMDUyMy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuY3BwIGIvU291 cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKaW5kZXggMGQ5NzNlNjQ3MDk3YWE1OTMyNDI5YzU4 MTY5YmFhZTYwMTA5YzYwMC4uZTE1YTA5MjNiMzhiZDNhN2YzMmYyM2Q1MTExY2E1MjRkNzJlZDc1 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvU291cmNl L1dURi93dGYvQXNzZXJ0aW9ucy5jcHAKQEAgLTI1MSwxOSArMjUxLDkgQEAgdm9pZCBXVEZQcmlu dEJhY2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCBzaXplKQogICAgIG91dC5wcmludChzdGFja1Ry YWNlKTsKIH0KIAotc3RhdGljIFdURkNyYXNoSG9va0Z1bmN0aW9uIGdsb2JhbEhvb2sgPSAwOwot Ci12b2lkIFdURlNldENyYXNoSG9vayhXVEZDcmFzaEhvb2tGdW5jdGlvbiBmdW5jdGlvbikKLXsK LSAgICBnbG9iYWxIb29rID0gZnVuY3Rpb247Ci19Ci0KICNpZiAhZGVmaW5lZChOREVCVUcpIHx8 ICFPUyhEQVJXSU4pCiB2b2lkIFdURkNyYXNoKCkKIHsKLSAgICBpZiAoZ2xvYmFsSG9vaykKLSAg ICAgICAgZ2xvYmFsSG9vaygpOwotCiAgICAgV1RGUmVwb3J0QmFja3RyYWNlKCk7CiAjaWYgQVNB Tl9FTkFCTEVECiAgICAgX19idWlsdGluX3RyYXAoKTsKQEAgLTI5Miw0MiArMjgyLDYgQEAgdm9p ZCBXVEZDcmFzaFdpdGhTZWN1cml0eUltcGxpY2F0aW9uKCkKICAgICBDUkFTSCgpOwogfQogCi0j aWYgSEFWRShTSUdOQUxfSCkKLXN0YXRpYyBOT19SRVRVUk4gdm9pZCBkdW1wQmFja3RyYWNlU2ln bmFsSGFuZGxlcihpbnQgc2lnKQotewotICAgIFdURlJlcG9ydEJhY2t0cmFjZSgpOwotICAgIGV4 aXQoMTI4ICsgc2lnKTsKLX0KLQotc3RhdGljIHZvaWQgaW5zdGFsbFNpZ25hbEhhbmRsZXJzRm9y RmF0YWxFcnJvcnModm9pZCAoKmhhbmRsZXIpKGludCkpCi17Ci0gICAgc2lnbmFsKFNJR0lMTCwg aGFuZGxlcik7IC8vICAgIDQ6IGlsbGVnYWwgaW5zdHJ1Y3Rpb24gKG5vdCByZXNldCB3aGVuIGNh dWdodCkuCi0gICAgc2lnbmFsKFNJR1RSQVAsIGhhbmRsZXIpOyAvLyAgIDU6IHRyYWNlIHRyYXAg KG5vdCByZXNldCB3aGVuIGNhdWdodCkuCi0gICAgc2lnbmFsKFNJR0ZQRSwgaGFuZGxlcik7IC8v ICAgIDg6IGZsb2F0aW5nIHBvaW50IGV4Y2VwdGlvbi4KLSAgICBzaWduYWwoU0lHQlVTLCBoYW5k bGVyKTsgLy8gICAxMDogYnVzIGVycm9yLgotICAgIHNpZ25hbChTSUdTRUdWLCBoYW5kbGVyKTsg Ly8gIDExOiBzZWdtZW50YXRpb24gdmlvbGF0aW9uLgotICAgIHNpZ25hbChTSUdTWVMsIGhhbmRs ZXIpOyAvLyAgIDEyOiBiYWQgYXJndW1lbnQgdG8gc3lzdGVtIGNhbGwuCi0gICAgc2lnbmFsKFNJ R1BJUEUsIGhhbmRsZXIpOyAvLyAgMTM6IHdyaXRlIG9uIGEgcGlwZSB3aXRoIG5vIHJlYWRlci4K LSAgICBzaWduYWwoU0lHWENQVSwgaGFuZGxlcik7IC8vICAyNDogZXhjZWVkZWQgQ1BVIHRpbWUg bGltaXQuCi0gICAgc2lnbmFsKFNJR1hGU1osIGhhbmRsZXIpOyAvLyAgMjU6IGV4Y2VlZGVkIGZp bGUgc2l6ZSBsaW1pdC4KLX0KLQotc3RhdGljIHZvaWQgcmVzZXRTaWduYWxIYW5kbGVyc0ZvckZh dGFsRXJyb3JzKCkKLXsKLSAgICBpbnN0YWxsU2lnbmFsSGFuZGxlcnNGb3JGYXRhbEVycm9ycyhT SUdfREZMKTsKLX0KLSNlbmRpZgotCi12b2lkIFdURkluc3RhbGxSZXBvcnRCYWNrdHJhY2VPbkNy YXNoSG9vaygpCi17Ci0jaWYgSEFWRShTSUdOQUxfSCkKLSAgICAvLyBOZWVkZWQgb3RoZXJ3aXNl IHdlIGFyZSBnb2luZyB0byBkdW1wIHRoZSBzdGFjayB0cmFjZSB0d2ljZQotICAgIC8vIGluIGNh c2Ugd2UgaGl0IGFuIGFzc2VydGlvbi4KLSAgICBXVEZTZXRDcmFzaEhvb2soJnJlc2V0U2lnbmFs SGFuZGxlcnNGb3JGYXRhbEVycm9ycyk7Ci0gICAgaW5zdGFsbFNpZ25hbEhhbmRsZXJzRm9yRmF0 YWxFcnJvcnMoJmR1bXBCYWNrdHJhY2VTaWduYWxIYW5kbGVyKTsKLSNlbmRpZgotfQotCiBib29s IFdURklzRGVidWdnZXJBdHRhY2hlZCgpCiB7CiAjaWYgT1MoREFSV0lOKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5o CmluZGV4IGI2Yzg1MmZhNWY2YTczYmIxZjE5MDUyNTA0MGFhMjFhZjUwNTZiMjcuLmVhMDAyNGIx ZjE0ZjY1NGMxYTZkMWM0YmI5OWVlMTZkYjEyM2YxNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv d3RmL0Fzc2VydGlvbnMuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTIw MCwxMCArMjAwLDYgQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGR2V0QmFja3RyYWNlKHZv aWQqKiBzdGFjaywgaW50KiBzaXplKTsKIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURlJlcG9y dEJhY2t0cmFjZSh2b2lkKTsKIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIFdURlByaW50QmFja3Ry YWNlKHZvaWQqKiBzdGFjaywgaW50IHNpemUpOwogCi10eXBlZGVmIHZvaWQgKCpXVEZDcmFzaEhv b2tGdW5jdGlvbikodm9pZCk7Ci1XVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBXVEZTZXRDcmFzaEhv b2soV1RGQ3Jhc2hIb29rRnVuY3Rpb24pOwotV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGSW5z dGFsbFJlcG9ydEJhY2t0cmFjZU9uQ3Jhc2hIb29rKHZvaWQpOwotCiBXVEZfRVhQT1JUX1BSSVZB VEUgYm9vbCBXVEZJc0RlYnVnZ2VyQXR0YWNoZWQodm9pZCk7CiAKICNpZiBDT01QSUxFUihNU1ZD KQo=