183367 2018-03-06 08:10:02 -0800 Explicitly qualify some method calls on this in lambdas in Service Worker code. 2018-03-06 09:11:17 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Ms2ger Ms2ger cdumez commit-queue dbates ews-watchlist japhet webkit-bug-importer oldest_to_newest 1403990 0 Ms2ger 2018-03-06 08:10:02 -0800 In code added since bug 182875 landed. 1403991 1 335096 Ms2ger 2018-03-06 08:14:21 -0800 Created attachment 335096 Patch 1404015 2 335096 commit-queue 2018-03-06 09:10:47 -0800 Comment on attachment 335096 Patch Clearing flags on attachment: 335096 Committed r229323: <https://trac.webkit.org/changeset/229323> 1404016 3 commit-queue 2018-03-06 09:10:48 -0800 All reviewed patches have been landed. Closing bug. 1404017 4 webkit-bug-importer 2018-03-06 09:11:17 -0800 <rdar://problem/38182084> 335096 2018-03-06 08:14:21 -0800 2018-03-06 09:10:47 -0800 Patch bug-183367-20180306171420.patch text/plain 2588 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM0ZjI5MDk3OGQyMzE2 MmNkZWVmYjdlODYzNjZhMjNjYTQ2NjRjNC4uZWMyNWMzOWE2NDkyMGRhNmEyNjAyNzdlYTZkYjdm OTAwYzMzN2RmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAzLTA2ICBNczJn ZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBFeHBsaWNpdGx5IHF1YWxpZnkgc29t ZSBtZXRob2QgY2FsbHMgb24gdGhpcyBpbiBsYW1iZGFzIGluIFNlcnZpY2UgV29ya2VyIGNvZGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzNjcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMgLS0gbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogbG9hZGVyL0RvY3Vt ZW50TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpzdGFydExv YWRpbmdNYWluUmVzb3VyY2UpOgorICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dT ZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6Om1hdGNoQWxsKToKKwogMjAx OC0wMy0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0Nvb3JkR3JhcGhpY3NdIFJlbW92ZSB1bnVzZWQgc2Nyb2xsaW5nLXJlbGF0ZWQgY29kZSBpbiBU ZXh0dXJlTWFwcGVyTGF5ZXIsIENvb3JkaW5hdGVkR3JhcGhpY3Mgc3RhY2sKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IDBmYTRiMzhlNTU3MTlmZTZlMTQ3ZmI0 NDgyY2U3YzUwODYyODU3OTYuLjJkOGVkYWI0OGMwY2I3NjA1MzhhNWIzYWE3YjQ1NWE4ZjJlMTA0 YjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcApAQCAtMTY4Myw3 ICsxNjgzLDcgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6c3RhcnRMb2FkaW5nTWFpblJlc291cmNl KCkKICAgICAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAgIG1fc2VydmljZVdvcmtl clJlZ2lzdHJhdGlvbkRhdGEgPSBXVEZNb3ZlKHJlZ2lzdHJhdGlvbkRhdGEpOwotICAgICAgICAg ICAgaWYgKCFtX3NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25EYXRhICYmIHRyeUxvYWRpbmdSZXF1 ZXN0RnJvbUFwcGxpY2F0aW9uQ2FjaGUoKSkKKyAgICAgICAgICAgIGlmICghbV9zZXJ2aWNlV29y a2VyUmVnaXN0cmF0aW9uRGF0YSAmJiB0aGlzLT50cnlMb2FkaW5nUmVxdWVzdEZyb21BcHBsaWNh dGlvbkNhY2hlKCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgdGhpcy0+ bG9hZE1haW5SZXNvdXJjZShXVEZNb3ZlKHJlcXVlc3QpKTsKICAgICAgICAgfSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2VydmVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCmluZGV4 IGYxZWI0MGZhOGQ3ZmZmZTg4NzQ4NjU1ODAxMWRlZmZmMjJhYzJiMjEuLjMzYTMzYWM3Y2FiZTZi MmE5ZTFmYWEwZGYxMWQ0M2FlYzk5MzA4ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dv cmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC00MjEsNyArNDIxLDcgQEAgdm9p ZCBTV1NlcnZlcjo6bWF0Y2hBbGwoU1dTZXJ2ZXJXb3JrZXImIHdvcmtlciwgY29uc3QgU2Vydmlj ZVdvcmtlckNsaWVudFF1ZXJ5T3AKICAgICAgICAgICAgIGF1dG8gcmVnaXN0cmF0aW9uSWRlbnRp ZmllciA9IG1fY2xpZW50VG9Db250cm9sbGluZ1JlZ2lzdHJhdGlvbi5nZXQoY2xpZW50RGF0YS5p ZGVudGlmaWVyKTsKICAgICAgICAgICAgIGlmICh3b3JrZXIuZGF0YSgpLnJlZ2lzdHJhdGlvbklk ZW50aWZpZXIgIT0gcmVnaXN0cmF0aW9uSWRlbnRpZmllcikKICAgICAgICAgICAgICAgICByZXR1 cm47Ci0gICAgICAgICAgICBpZiAoJndvcmtlciAhPSBhY3RpdmVXb3JrZXJGcm9tUmVnaXN0cmF0 aW9uSUQocmVnaXN0cmF0aW9uSWRlbnRpZmllcikpCisgICAgICAgICAgICBpZiAoJndvcmtlciAh PSB0aGlzLT5hY3RpdmVXb3JrZXJGcm9tUmVnaXN0cmF0aW9uSUQocmVnaXN0cmF0aW9uSWRlbnRp ZmllcikpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgIGlmIChv cHRpb25zLnR5cGUgIT0gU2VydmljZVdvcmtlckNsaWVudFR5cGU6OkFsbCAmJiBvcHRpb25zLnR5 cGUgIT0gY2xpZW50RGF0YS50eXBlKQo=