183366 2018-03-06 06:12:01 -0800 REGRESSION(r229309): s_exceptionInstructions allocation change causing crashes in LLInt on WPE 2018-03-06 09:39:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan ysuzuki ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1403971 0 zan 2018-03-06 06:12:01 -0800 In r229309, changes in the LLInt::Data::s_exceptionInstructions allocation process are causing crashes on WPE, making the testing bot quit early. Not yet sure what exactly is the cause for this, but the s_exceptionInstructions symbol appears in both libWPEWebKit.so and libTestRunnerInjectedBundle.so, and it might be that it clashes because of that duplication. 1403973 1 ysuzuki 2018-03-06 06:16:44 -0800 (In reply to Zan Dobersek from comment #0) > In r229309, changes in the LLInt::Data::s_exceptionInstructions allocation > process are causing crashes on WPE, making the testing bot quit early. > > Not yet sure what exactly is the cause for this, but the > s_exceptionInstructions symbol appears in both libWPEWebKit.so and > libTestRunnerInjectedBundle.so, and it might be that it clashes because of > that duplication. OK, let's annotate this with JS_EXPORTDATA. 1403974 2 335089 zan 2018-03-06 06:18:42 -0800 Created attachment 335089 Mini-revert patch 1403975 3 mcatanzaro 2018-03-06 06:22:06 -0800 (In reply to Yusuke Suzuki from comment #1) > OK, let's annotate this with JS_EXPORTDATA. WPE doesn't use export macros. (Same for GTK.) 1403981 4 335093 zan 2018-03-06 06:48:41 -0800 Created attachment 335093 Patch 1403982 5 zan 2018-03-06 06:50:42 -0800 (In reply to Zan Dobersek from comment #4) > Created attachment 335093 [details] > Patch This avoids the problem on the WPE port by using a narrowed-down list of libraries that the injected bundle .so should be linked against. As such, it avoids the JavaScriptCore archive being linked into the final .so object, avoiding duplicate symbols. Will also test how the GTK+ port is affected by this change, if at all. But in general, on that port the JSC symbols are all bundled into the libjavascriptcoregtk.so object. 1403985 6 zan 2018-03-06 07:08:04 -0800 (In reply to Zan Dobersek from comment #5) > Will also test how the GTK+ port is affected by this change, if at all. But > in general, on that port the JSC symbols are all bundled into the > libjavascriptcoregtk.so object. No problem with GTK+ with the patch. 1404009 7 ysuzuki 2018-03-06 09:06:55 -0800 (In reply to Michael Catanzaro from comment #3) > (In reply to Yusuke Suzuki from comment #1) > > OK, let's annotate this with JS_EXPORTDATA. > > WPE doesn't use export macros. (Same for GTK.) Oops, thanks! 1404028 8 335093 zan 2018-03-06 09:38:09 -0800 Comment on attachment 335093 Patch Clearing flags on attachment: 335093 Committed r229325: <https://trac.webkit.org/changeset/229325> 1404031 9 zan 2018-03-06 09:38:14 -0800 All reviewed patches have been landed. Closing bug. 1404034 10 webkit-bug-importer 2018-03-06 09:39:32 -0800 <rdar://problem/38182758> 335089 2018-03-06 06:18:42 -0800 2018-03-06 06:48:38 -0800 Mini-revert patch bug-183366-20180306151840.patch text/plain 2362 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MGM5NjUwNDE1YjRmYjk3OThmYWQ3ZTBiNWY3NTIwMzZmN2ExYzVhLi45M2M2NzNhZjMwNmU5YWY3 OTkxZWNlZWFmN2M3ZjlkMGI4MWYyZmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wMy0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjI5MzA5KTogc19leGNlcHRpb25JbnN0cnVjdGlv bnMgYWxsb2NhdGlvbiBjaGFuZ2UgY2F1c2luZyBjcmFzaGVzIGluIExMSW50IG9uIFdQRQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMzY2CisKKyAg ICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIGEgc21hbGwgcGFydCBvZiByMjI5MzA5IHRoYXQg aXMgY2F1c2luZyBjcmFzaGVzCisgICAgICAgIHVuZGVyIExMSW50IG9uIHRoZSBXUEUgcG9ydC4g VGhlIGNoYW5nZXMgaW4gdGhlIGNvbW1pdCBhcmUgb3RoZXJ3aXNlCisgICAgICAgIG5vdCBwcm9i bGVtYXRpYywgYW5kIHRoaXMgcmV2ZXJ0IHdpbGwgYmUgdW5kb25lIG9uY2UgdGhlIHJvb3QgY2F1 c2UgaXMKKyAgICAgICAgZm91bmQgYW5kIHRoZSBjcmFzaGVzIGZpeGVkLgorCisgICAgICAgICog bGxpbnQvTExJbnREYXRhLmNwcDoKKyAgICAgICAgKEpTQzo6TExJbnQ6OmluaXRpYWxpemUpOgor ICAgICAgICAqIGxsaW50L0xMSW50RGF0YS5oOgorCiAyMDE4LTAzLTA1ICBZdXN1a2UgU3V6dWtp ICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIEZpeCBzdGQ6Om1ha2VfdW5pcXVl IC8gbmV3W10gdXNpbmcgc3lzdGVtIG1hbGxvYwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xMSW50RGF0YS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TExJbnREYXRhLmNwcAppbmRleCAzYTFlYTM3NDgyNDFhNGMwZDZhNTdmMmJkZjE4YWQ2NjUyNWIx ZjlhLi40Y2Y4YzZkNGVkOWYxYTMxMmM0MTQzZTU0YjEwMjZiNTU3YTYwMDZiIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmNwcApAQCAtNDcsNyArNDcsNyBAQAogCiBu YW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIExMSW50IHsKIAotSW5zdHJ1Y3Rpb24gRGF0YTo6c19l eGNlcHRpb25JbnN0cnVjdGlvbnNbbWF4T3Bjb2RlTGVuZ3RoICsgMV0gPSB7IH07CitJbnN0cnVj dGlvbiogRGF0YTo6c19leGNlcHRpb25JbnN0cnVjdGlvbnMgPSAwOwogT3Bjb2RlIERhdGE6OnNf b3Bjb2RlTWFwW251bU9wY29kZUlEc10gPSB7IH07CiBPcGNvZGVTdGF0c0FycmF5KiBEYXRhOjpz X29wY29kZVN0YXRzQXJyYXkgPSBudWxscHRyOwogCkBAIC01Nyw2ICs1Nyw4IEBAIGV4dGVybiAi QyIgdm9pZCBsbGludF9lbnRyeSh2b2lkKik7CiAKIHZvaWQgaW5pdGlhbGl6ZSgpCiB7CisgICAg RGF0YTo6c19leGNlcHRpb25JbnN0cnVjdGlvbnMgPSBuZXcgSW5zdHJ1Y3Rpb25bbWF4T3Bjb2Rl TGVuZ3RoICsgMV07CisKICNpZiAhRU5BQkxFKEpJVCkKICAgICBDTG9vcDo6aW5pdGlhbGl6ZSgp OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmgg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnREYXRhLmgKaW5kZXggMzAxZDA3N2Vj YmI1OWU2NjU1Nzk2ODg4NTQ3MWQwMjQyZGM2NGZjMS4uNjAyZGQ2NDZlNTczYjg2MWI1YjI2ZmM4 NjM1ZGY1NDc0NjA5Y2E3YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xMSW50RGF0YS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludERhdGEu aApAQCAtNjYsNyArNjYsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyB2b2lkIHJlc2V0U3RhdHMo KTsKICAgICBzdGF0aWMgdm9pZCBzYXZlU3RhdHMoKTsKIAotICAgIHN0YXRpYyBJbnN0cnVjdGlv biBzX2V4Y2VwdGlvbkluc3RydWN0aW9uc1ttYXhPcGNvZGVMZW5ndGggKyAxXTsKKyAgICBzdGF0 aWMgSW5zdHJ1Y3Rpb24qIHNfZXhjZXB0aW9uSW5zdHJ1Y3Rpb25zOwogICAgIHN0YXRpYyBPcGNv ZGUgc19vcGNvZGVNYXBbbnVtT3Bjb2RlSURzXTsKICAgICBzdGF0aWMgT3Bjb2RlU3RhdHNBcnJh eSogc19vcGNvZGVTdGF0c0FycmF5OwogCg== 335093 2018-03-06 06:48:41 -0800 2018-03-06 09:38:09 -0800 Patch bug-183366-20180306154840.patch text/plain 3047 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MzE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY3OGY2YTk5ZjNjN2JlZTRmMWM1NDY3MjM2MTY2MmNk ZDFkMjViMS4uODBjNWQxNjY5YTE3ZmQyZTI5NjE4ODM2MzczN2NlZTRjNTEwMjIwYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDE4LTAzLTA2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OKHIyMjkzMDkpOiBzX2V4Y2VwdGlvbkluc3RydWN0aW9ucyBhbGxv Y2F0aW9uIGNoYW5nZSBjYXVzaW5nIGNyYXNoZXMgaW4gTExJbnQgb24gV1BFCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzNjYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlIHRoZSBUZXN0UnVubmVy SW5qZWN0ZWRCdW5kbGUgQ01ha2UgbGlicmFyeSBsaW5rIGFnYWluc3QgbGlicmFyaWVzCisgICAg ICAgIGluIHRoZSBXZWJLaXRUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGVfTElCUkFSSUVTIGxpc3Qs IGFuZCBub3QgdGhlCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXJfTElCUkFSSUVTIGxpc3QsIHdo aWNoIGlzIHVzZWQgZm9yIHRoZSBXZWJLaXRUZXN0UnVubmVyCisgICAgICAgIGV4ZWN1dGFibGUu IFRoaXMgYWxsb3dzIG5hcnJvd2luZyBkb3duIHRoZSBsaWJyYXJpZXMgdG8gb25seSB0aG9zZSB0 aGF0CisgICAgICAgIGFyZSBuZWNlc3NhcnkgZm9yIHRoZSBpbmplY3RlZCBidW5kbGUgc2hhcmVk IG9iamVjdC4KKworICAgICAgICBUaGUgR1RLKyBwb3J0IGFscmVhZHkgaGFzIHRoaXMgbGlzdCBz cGVjaWZpZWQsIGFkZGluZyBvbmUgZm9yIHRoZSBXUEUKKyAgICAgICAgcG9ydC4KKworICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvQ01ha2VMaXN0cy50eHQ6CisgICAgICAgIExpbmsgdGhlIFRl c3RSdW5uZXJJbmplY3RlZEJ1bmRsZSBsaWJyYXJ5IGFnYWluc3QgdGhlIGxpYnJhcmllcyBpbiB0 aGUKKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lckluamVjdGVkQnVuZGxlX0xJQlJBUklFUyBsaXN0 LgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XUEUuY21ha2U6CisgICAgICAg IFNwZWNpZnkgdGhlIFdlYktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRsZV9MSUJSQVJJRVMgbGlz dCwgaW5jbHVkaW5nIHRoZQorICAgICAgICBiYXNpYyBzeXN0ZW0gZGVwZW5kZW5jaWVzLCBXZWJD b3JlVGVzdFN1cHBvcnQgYW5kIFdlYktpdC4gVGhpcyBmb2xsb3dzCisgICAgICAgIHRoZSBHVEsr IHBvcnQuCisKIDIwMTgtMDMtMDYgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0FSTV0gRGlzYWJsZSB0ZXN0cyB0aGF0IHJ1biBvdXQgb2YgbWVtb3J5 CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0NNYWtlTGlzdHMudHh0IGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9DTWFrZUxpc3RzLnR4dAppbmRleCA2YTIzYzhmYTdmMjgyZjMz MTg2MmM3OWUyYWZjZGM3N2MwNTIyNmFkLi5lY2VlYzQyMDg2MzI1N2UxODJlYjliNTA3ZDc4NjA0 YTYzOWRiZTM3IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0NNYWtlTGlzdHMu dHh0CisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvQ01ha2VMaXN0cy50eHQKQEAgLTEwOSw3 ICsxMDksNyBAQCBpbmNsdWRlX2RpcmVjdG9yaWVzKCR7V2ViS2l0VGVzdFJ1bm5lcl9JTkNMVURF X0RJUkVDVE9SSUVTfSkKIGluY2x1ZGVfZGlyZWN0b3JpZXMoU1lTVEVNICR7V2ViS2l0VGVzdFJ1 bm5lcl9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklFU30pCiAKIGFkZF9saWJyYXJ5KFRlc3RSdW5u ZXJJbmplY3RlZEJ1bmRsZSBTSEFSRUQgJHtXZWJLaXRUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGVf U09VUkNFU30pCi10YXJnZXRfbGlua19saWJyYXJpZXMoVGVzdFJ1bm5lckluamVjdGVkQnVuZGxl ICR7V2ViS2l0VGVzdFJ1bm5lcl9MSUJSQVJJRVN9KQordGFyZ2V0X2xpbmtfbGlicmFyaWVzKFRl c3RSdW5uZXJJbmplY3RlZEJ1bmRsZSAke1dlYktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRsZV9M SUJSQVJJRVN9KQogYWRkX2RlcGVuZGVuY2llcyhUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUgV2Vi S2l0VGVzdFJ1bm5lckluamVjdGVkQnVuZGxlQmluZGluZ3MpCiAKIGFkZF9leGVjdXRhYmxlKFdl YktpdFRlc3RSdW5uZXIgJHtXZWJLaXRUZXN0UnVubmVyX1NPVVJDRVN9KQpkaWZmIC0tZ2l0IGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdQRS5jbWFrZSBiL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvUGxhdGZvcm1XUEUuY21ha2UKaW5kZXggOGQyODA1Y2EyMzBiOGVhZTZhOTU4Y2Mz YjNjMGE5NjMzNjY2Mzg2ZC4uMWNkMWYyODYxNTQ2MmE1OTdhNGJmNDUyZDg5OTNlNzE1MGZmOTAz ZCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdQRS5jbWFrZQor KysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0zNCw2ICsz NCwxMyBAQCBsaXN0KEFQUEVORCBXZWJLaXRUZXN0UnVubmVyX0xJQlJBUklFUwogICAgIFdQRUhl YWRsZXNzVmlld0JhY2tlbmQKICkKIAorc2V0KFdlYktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRs ZV9MSUJSQVJJRVMKKyAgICAke0NBSVJPX0xJQlJBUklFU30KKyAgICAke0dMSUJfTElCUkFSSUVT fQorICAgIFdlYkNvcmVUZXN0U3VwcG9ydAorICAgIFdlYktpdAorKQorCiBsaXN0KEFQUEVORCBX ZWJLaXRUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGVfU09VUkNFUwogICAgICR7V0VCS0lUX1RFU1RS VU5ORVJfSU5KRUNURURCVU5ETEVfRElSfS93cGUvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJXUEUu Y3BwCiAgICAgJHtXRUJLSVRfVEVTVFJVTk5FUl9JTkpFQ1RFREJVTkRMRV9ESVJ9L3dwZS9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50V1BFLmNwcAo=