183363 2018-03-06 03:56:00 -0800 Cache hasComplexSelectorsForStyleAttribute bit 2018-03-06 12:52:19 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue kling webkit-bug-importer zalan oldest_to_newest 1403951 0 koivisto 2018-03-06 03:56:00 -0800 Factor this special case code to DocumentRuleSets and cache the bit. 1403953 1 335083 koivisto 2018-03-06 03:58:41 -0800 Created attachment 335083 patch 1403988 2 335083 kling 2018-03-06 07:47:16 -0800 Comment on attachment 335083 patch r=me 1404061 3 zalan 2018-03-06 10:48:50 -0800 (In reply to Andreas Kling from comment #2) > Comment on attachment 335083 [details] > patch > > r=me wow wait, what!? 1404077 4 koivisto 2018-03-06 11:22:25 -0800 (In reply to Andreas Kling from comment #2) > Comment on attachment 335083 [details] > patch > > r=me Thank you Kling, 1404083 5 335083 commit-queue 2018-03-06 11:41:38 -0800 Comment on attachment 335083 patch Rejecting attachment 335083 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335083, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e too many unreachable loose objects; run 'git prune' to remove them. Current branch master is up to date. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. error: The last gc run reported the following. Please correct the root cause and remove /Volumes/Data/EWS/WebKit/.git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. Full output: http://webkit-queues.webkit.org/results/6829317 1404108 6 zalan 2018-03-06 12:39:53 -0800 (In reply to WebKit Commit Bot from comment #5) > Comment on attachment 335083 [details] > patch > > Rejecting attachment 335083 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', > 'land-attachment', '--force-clean', '--non-interactive', > '--parent-command=commit-queue', 335083, '--port=mac']" exit_code: 2 cwd: > /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > e too many unreachable loose objects; run 'git prune' to remove them. > > Current branch master is up to date. > Auto packing the repository in background for optimum performance. > See "git help gc" for manual housekeeping. > error: The last gc run reported the following. Please correct the root cause > and remove /Volumes/Data/EWS/WebKit/.git/gc.log. > Automatic cleanup will not be performed until the file is removed. > > warning: There are too many unreachable loose objects; run 'git prune' to > remove them. > > > Full output: http://webkit-queues.webkit.org/results/6829317 Thank you, Kling. 1404113 7 koivisto 2018-03-06 12:51:19 -0800 Lies. This did land as https://trac.webkit.org/r229332 1404115 8 webkit-bug-importer 2018-03-06 12:52:19 -0800 <rdar://problem/38190645> 335083 2018-03-06 03:58:41 -0800 2018-03-06 12:49:55 -0800 patch complex-style-attribute-selector-cache.patch text/plain 5087 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyOTMxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE4LTAzLTA2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBDYWNoZSBoYXNDb21wbGV4U2Vs ZWN0b3JzRm9yU3R5bGVBdHRyaWJ1dGUgYml0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGNzcy9Eb2N1bWVudFJ1bGVTZXRzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50UnVsZVNldHM6OmNvbGxlY3RGZWF0dXJlcyBjb25zdCk6CisgICAg ICAgIChXZWJDb3JlOjpEb2N1bWVudFJ1bGVTZXRzOjpoYXNDb21wbGV4U2VsZWN0b3JzRm9yU3R5 bGVBdHRyaWJ1dGUgY29uc3QpOgorCisgICAgICAgIENhY2hlIHRoZSBiaXQgdG8gYXZvaWQgaGFz aCBsb29rdXBzLgorCisgICAgICAgICogY3NzL0RvY3VtZW50UnVsZVNldHMuaDoKKyAgICAgICAg KiBkb20vU3R5bGVkRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZWRFbGVtZW50 OjppbnZhbGlkYXRlU3R5bGVBdHRyaWJ1dGUpOgorICAgICAgICAoV2ViQ29yZTo6c2hvdWxkU3lu Y2hyb25pemVTdHlsZUF0dHJpYnV0ZUltbWVkaWF0ZWx5Rm9ySW52YWxpZGF0aW9uKTogRGVsZXRl ZC4KKworICAgICAgICBNb3ZlIGNvZGUgdG8gRG9jdW1lbnRSdWxlU2V0cy4KKwogMjAxOC0wMy0w NiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0Nvb3Jk R3JhcGhpY3NdIEFwcGx5IFRleHR1cmVNYXBwZXJMYXllciBhbmltYXRpb25zIHdpdGggYSBzaW5n bGUgTW9ub3RvbmljVGltZSB2YWx1ZQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0RvY3VtZW50 UnVsZVNldHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9Eb2N1bWVudFJ1 bGVTZXRzLmNwcAkocmV2aXNpb24gMjI5MzA3KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0RvY3Vt ZW50UnVsZVNldHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjksNiArMTY5LDcgQEAgdm9pZCBE b2N1bWVudFJ1bGVTZXRzOjpjb2xsZWN0RmVhdHVyZXMoKQogCiAgICAgbV9jbGFzc0ludmFsaWRh dGlvblJ1bGVTZXRzLmNsZWFyKCk7CiAgICAgbV9hdHRyaWJ1dGVJbnZhbGlkYXRpb25SdWxlU2V0 cy5jbGVhcigpOworICAgIG1fY2FjaGVkSGFzQ29tcGxleFNlbGVjdG9yc0ZvclN0eWxlQXR0cmli dXRlID0gc3RkOjpudWxsb3B0OwogCiAgICAgbV9mZWF0dXJlcy5zaHJpbmtUb0ZpdCgpOwogfQpA QCAtMjEwLDQgKzIxMSwyMyBAQCBjb25zdCBWZWN0b3I8SW52YWxpZGF0aW9uUnVsZVNldD4qIERv Y3VtCiAgICAgcmV0dXJuIGVuc3VyZUludmFsaWRhdGlvblJ1bGVTZXRzKGF0dHJpYnV0ZU5hbWUs IG1fYXR0cmlidXRlSW52YWxpZGF0aW9uUnVsZVNldHMsIG1fZmVhdHVyZXMuYXR0cmlidXRlUnVs ZXMpOwogfQogCitib29sIERvY3VtZW50UnVsZVNldHM6Omhhc0NvbXBsZXhTZWxlY3RvcnNGb3JT dHlsZUF0dHJpYnV0ZSgpIGNvbnN0Cit7CisgICAgYXV0byBjb21wdXRlID0gWyZdIHsKKyAgICAg ICAgYXV0byogcnVsZVNldHMgPSBhdHRyaWJ1dGVJbnZhbGlkYXRpb25SdWxlU2V0cyhIVE1MTmFt ZXM6OnN0eWxlQXR0ci0+bG9jYWxOYW1lKCkpOworICAgICAgICBpZiAoIXJ1bGVTZXRzKQorICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBmb3IgKGF1dG8mIHJ1bGVTZXQgOiAqcnVs ZVNldHMpIHsKKyAgICAgICAgICAgIGlmIChydWxlU2V0Lm1hdGNoRWxlbWVudCAhPSBNYXRjaEVs ZW1lbnQ6OlN1YmplY3QpCisgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0K KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH07CisKKyAgICBpZiAoIW1fY2FjaGVkSGFzQ29t cGxleFNlbGVjdG9yc0ZvclN0eWxlQXR0cmlidXRlKQorICAgICAgICBtX2NhY2hlZEhhc0NvbXBs ZXhTZWxlY3RvcnNGb3JTdHlsZUF0dHJpYnV0ZSA9IGNvbXB1dGUoKTsKKworICAgIHJldHVybiAq bV9jYWNoZWRIYXNDb21wbGV4U2VsZWN0b3JzRm9yU3R5bGVBdHRyaWJ1dGU7Cit9CisKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9Eb2N1bWVudFJ1bGVT ZXRzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0RvY3VtZW50UnVsZVNldHMu aAkocmV2aXNpb24gMjI5MzA3KQorKysgU291cmNlL1dlYkNvcmUvY3NzL0RvY3VtZW50UnVsZVNl dHMuaAkod29ya2luZyBjb3B5KQpAQCAtNjIsNiArNjIsOCBAQCBwdWJsaWM6CiAgICAgY29uc3Qg VmVjdG9yPEludmFsaWRhdGlvblJ1bGVTZXQ+KiBjbGFzc0ludmFsaWRhdGlvblJ1bGVTZXRzKGNv bnN0IEF0b21pY1N0cmluZyYgY2xhc3NOYW1lKSBjb25zdDsKICAgICBjb25zdCBWZWN0b3I8SW52 YWxpZGF0aW9uUnVsZVNldD4qIGF0dHJpYnV0ZUludmFsaWRhdGlvblJ1bGVTZXRzKGNvbnN0IEF0 b21pY1N0cmluZyYgYXR0cmlidXRlTmFtZSkgY29uc3Q7CiAKKyAgICBib29sIGhhc0NvbXBsZXhT ZWxlY3RvcnNGb3JTdHlsZUF0dHJpYnV0ZSgpIGNvbnN0OworCiAgICAgdm9pZCBzZXRJc0ZvclNo YWRvd1Njb3BlKCkgeyBtX2lzRm9yU2hhZG93U2NvcGUgPSB0cnVlOyB9CiAKICAgICB2b2lkIHNl dFVzZXNTaGFyZWRVc2VyU3R5bGUoYm9vbCBiKSB7IG1fdXNlc1NoYXJlZFVzZXJTdHlsZSA9IGI7 IH0KQEAgLTk0LDYgKzk2LDcgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIHN0ZDo6dW5pcXVlX3B0 cjxSdWxlU2V0PiBtX3VuY29tbW9uQXR0cmlidXRlUnVsZVNldDsKICAgICBtdXRhYmxlIEhhc2hN YXA8QXRvbWljU3RyaW5nLCBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPEludmFsaWRhdGlvblJ1bGVT ZXQ+Pj4gbV9jbGFzc0ludmFsaWRhdGlvblJ1bGVTZXRzOwogICAgIG11dGFibGUgSGFzaE1hcDxB dG9taWNTdHJpbmcsIHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8SW52YWxpZGF0aW9uUnVsZVNldD4+ PiBtX2F0dHJpYnV0ZUludmFsaWRhdGlvblJ1bGVTZXRzOworICAgIG11dGFibGUgc3RkOjpvcHRp b25hbDxib29sPiBtX2NhY2hlZEhhc0NvbXBsZXhTZWxlY3RvcnNGb3JTdHlsZUF0dHJpYnV0ZTsK IH07CiAKIGlubGluZSBjb25zdCBSdWxlRmVhdHVyZVNldCYgRG9jdW1lbnRSdWxlU2V0czo6ZmVh dHVyZXMoKSBjb25zdApJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TdHlsZWRFbGVtZW50LmNwcAkocmV2 aXNpb24gMjI5MzA3KQorKysgU291cmNlL1dlYkNvcmUvZG9tL1N0eWxlZEVsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNDYsMTkgKzE0Niw2IEBAIHZvaWQgU3R5bGVkRWxlbWVudDo6c3R5 bGVBdHRyaWJ1dGVDaGFuZ2UKICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZEludmFs aWRhdGVTdHlsZUF0dHIoZG9jdW1lbnQoKSwgKnRoaXMpOwogfQogCi1zdGF0aWMgYm9vbCBzaG91 bGRTeW5jaHJvbml6ZVN0eWxlQXR0cmlidXRlSW1tZWRpYXRlbHlGb3JJbnZhbGlkYXRpb24oU3R5 bGVkRWxlbWVudCYgZWxlbWVudCkKLXsKLSAgICAvLyBJbiByYXJlIGNhc2UgdGhlcmUgaXMgYSBj b21wbGV4IGF0dHJpYnV0ZSBzZWxlY3RvciB0YXJnZXRpbmcgc3R5bGUgYXR0cmlidXRlIChsaWtl ICJbc3R5bGVdIH4gZGl2Iikgd2UgbmVlZCB0byBzeW5jaHJvbml6ZSBpbW1lZGlhdGVseS4KLSAg ICBhdXRvKiBydWxlU2V0cyA9IGVsZW1lbnQuc3R5bGVSZXNvbHZlcigpLnJ1bGVTZXRzKCkuYXR0 cmlidXRlSW52YWxpZGF0aW9uUnVsZVNldHMoc3R5bGVBdHRyLT5sb2NhbE5hbWUoKSk7Ci0gICAg aWYgKCFydWxlU2V0cykKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGZvciAoYXV0byYgcnVs ZVNldCA6ICpydWxlU2V0cykgewotICAgICAgICBpZiAocnVsZVNldC5tYXRjaEVsZW1lbnQgIT0g TWF0Y2hFbGVtZW50OjpTdWJqZWN0KQotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQot ICAgIHJldHVybiBmYWxzZTsKLX0KLQogdm9pZCBTdHlsZWRFbGVtZW50OjppbnZhbGlkYXRlU3R5 bGVBdHRyaWJ1dGUoKQogewogICAgIGlmICh1c2VzU3R5bGVCYXNlZEVkaXRhYmlsaXR5KCppbmxp bmVTdHlsZSgpKSkKQEAgLTE2Nyw3ICsxNTQsOCBAQCB2b2lkIFN0eWxlZEVsZW1lbnQ6OmludmFs aWRhdGVTdHlsZUF0dHJpCiAgICAgZWxlbWVudERhdGEoKS0+c2V0U3R5bGVBdHRyaWJ1dGVJc0Rp cnR5KHRydWUpOwogICAgIGludmFsaWRhdGVTdHlsZSgpOwogCi0gICAgaWYgKHNob3VsZFN5bmNo cm9uaXplU3R5bGVBdHRyaWJ1dGVJbW1lZGlhdGVseUZvckludmFsaWRhdGlvbigqdGhpcykpIHsK KyAgICAvLyBJbiB0aGUgcmFyZSBjYXNlIG9mIHNlbGVjdG9ycyBsaWtlICJbc3R5bGVdIH4gZGl2 IiB3ZSBuZWVkIHRvIHN5bmNocm9uaXplIGltbWVkaWF0ZWx5IHRvIGludmFsaWRhdGUuCisgICAg aWYgKHN0eWxlUmVzb2x2ZXIoKS5ydWxlU2V0cygpLmhhc0NvbXBsZXhTZWxlY3RvcnNGb3JTdHls ZUF0dHJpYnV0ZSgpKSB7CiAgICAgICAgIGlmIChhdXRvKiBpbmxpbmVTdHlsZSA9IHRoaXMtPmlu bGluZVN0eWxlKCkpIHsKICAgICAgICAgICAgIGVsZW1lbnREYXRhKCktPnNldFN0eWxlQXR0cmli dXRlSXNEaXJ0eShmYWxzZSk7CiAgICAgICAgICAgICBhdXRvIG5ld1ZhbHVlID0gaW5saW5lU3R5 bGUtPmFzVGV4dCgpOwo=