183330 2018-03-05 06:49:19 -0800 [GTK][Wayland] The GTK Wayland bot exits early because of assertions related with libsecret since r221925 2018-03-05 11:29:54 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176755 P2 Normal --- 1 clopez clopez agomez bugs-noreply clopez ews-watchlist ltilve mcatanzaro pnormand oldest_to_newest 1403612 0 clopez 2018-03-05 06:49:19 -0800 Since r221925 <https://trac.webkit.org/r221925> enabled G_DEBUG=fatal-criticals for the tests the GTK Wayland bot has been constantly crashing on many network-related tests. The usual crash log is like this: Thread 1 (Thread 0x7f6924feb3c0 (LWP 18364)): #0 _g_log_abort () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:554 #1 0x00007f692d9b9415 in g_logv () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1362 #2 0x00007f692d9b9562 in g_log () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmessages.c:1403 #3 0x00007f692d72e1bc in search_closure_free (data=0x555b8bcf2040) at libsecret/secret-methods.c:54 #4 0x00007f692db4ce78 in clear_op_res () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:247 #5 g_simple_async_result_finalize () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:267 #6 0x00007f692da9444a in g_object_unref () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gobject.c:3330 #7 0x00007f692d72df94 in on_search_service (source=<optimized out>, result=0x555b8bc17ed0, user_data=<optimized out>) at libsecret/secret-methods.c:257 #8 0x00007f692db4db57 in g_simple_async_result_complete () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsimpleasyncresult.c:801 #9 0x00007f692d7354ac in on_init_base (source=<optimized out>, result=0x7f68d000d6d0, user_data=<optimized out>) at libsecret/secret-service.c:692 #10 0x00007f692db5eb13 in g_task_return_now () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145 #11 0x00007f692db5f5b6 in g_task_return () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1203 #12 0x00007f692db9b805 in get_connection_cb () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gdbusproxy.c:1827 #13 0x00007f692db5eb13 in g_task_return_now () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1145 #14 0x00007f692db5eb49 in complete_in_idle_cb () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gtask.c:1159 #15 0x00007f692d9b281a in g_main_dispatch () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148 #16 g_main_context_dispatch () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813 #17 0x00007f692d9b2ba8 in g_main_context_iterate () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886 #18 0x00007f692d9b2ec2 in g_main_loop_run () at /home/buildbot/webkitgtk/gtk-linux-64-release-wayland-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082 #19 0x00007f6931da9670 in WTF::RunLoop::run() () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #20 0x00007f6934328872 in NetworkProcessMainUnix () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #21 0x00007f692ab632b1 in __libc_start_main (main=0x555b89d9dd20 <main>, argc=3, argv=0x7ffead27f668, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffead27f658) at ../csu/libc-start.c:291 #22 0x0000555b89d9ddaa in _start () More details: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20Wayland%20(Tests)/r229257%20(5451)/results.html 1403618 1 clopez 2018-03-05 07:07:08 -0800 The issue triggers here: https://sources.debian.org/src/libsecret/0.18.5-3.1/libsecret/secret-methods.c/#L54 Looking at master for libsecret it looks this might have been fixed already by Michael in https://bugzilla.gnome.org/show_bug.cgi?id=787391 ? Should we include libsecret in the jhbuild with that patch? 1403625 2 mcatanzaro 2018-03-05 09:03:17 -0800 Yeah, might as well. 1403637 3 335005 clopez 2018-03-05 09:29:08 -0800 Created attachment 335005 Patch 1403684 4 335005 mcatanzaro 2018-03-05 11:20:40 -0800 Comment on attachment 335005 Patch Eh, I did not realize that it was not already in the JHBuild... but OK, I guess, since getting the Wayland bot working again seems desirable 1403691 5 335005 clopez 2018-03-05 11:29:50 -0800 Comment on attachment 335005 Patch Clearing flags on attachment: 335005 Committed r229290: <https://trac.webkit.org/changeset/229290> 1403692 6 clopez 2018-03-05 11:29:54 -0800 All reviewed patches have been landed. Closing bug. 335005 2018-03-05 09:29:08 -0800 2018-03-05 11:29:50 -0800 Patch bug-183330-20180305182907.patch text/plain 3910 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5Mjg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmM4OTk3MTRjOTg3MjA2ZmNiYTRjMzNlMDk5YmNhNjg5 OTU2MjVmMy4uZmI5MGFhMDlmOTZhYzU4MmUwMDg3NTlmZmRiZDQ4ZWU1YjhiZDFkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE4LTAzLTA1ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dheWxhbmRdIFRoZSBHVEsgV2F5bGFuZCBib3QgZXhp dHMgZWFybHkgYmVjYXVzZSBvZiBhc3NlcnRpb25zIHJlbGF0ZWQgd2l0aCBsaWJzZWNyZXQgc2lu Y2UgcjIyMTkyNQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTgzMzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIGxpYnNlY3JldCB0byB0aGUgSkhCdWlsZCBhbmQgYnVpbGQgaXQgb25seSB3aGVuIHRo ZSBzeXN0ZW0gdmVyc2lvbiBpcworICAgICAgICBsZXNzIHRoYW4gMC4xOC42ICh1bnJlbGVhc2Vk IGFzIG9mIHdyaXRpbmcgdGhpcykgaW4gb3JkZXIgdG8gY2hlcnJ5IHBpY2sKKyAgICAgICAgYSBm aXggZm9yIGEgYnVnIHRoYXQgY2F1c2VzIGNyYXNoZXMgd2l0aCBsYXlvdXQgdGVzdHMuCisKKyAg ICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVzOgorICAgICAgICAqIGd0ay9wYXRjaGVzL2xpYnNl Y3JldC1zZWNyZXQtbWV0aG9kcy1Eb24tdC11bnJlZi1OVUxMLXdoZW4tc2VhcmNoLWZhaWxzLnBh dGNoOiBBZGRlZC4KKwogMjAxOC0wMy0wNSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEltcGxlbWVudCBXVFIncyBQbGF0Zm9ybVdlYlZp ZXc6OnNldFdpbmRvd0lzS2V5KCkKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVs ZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IDljMzI5NDI3MjBmNjgzOTMzODBj ZWU2ZDA2OWEwMjNiZWZjOGE2ODkuLjEzNGM2NGM0YTNjYzljOTkwNTNmODQyMzE5YjljNzQ5ZWM0 ZmY2YjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMv Z3RrL2poYnVpbGQubW9kdWxlcwpAQCAtMjgsNiArMjgsNyBAQAogICAgICAgPGRlcCBwYWNrYWdl PSJwYW5nbyIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJsbHZtIi8+CiAgICAgICA8ZGVwIHBhY2th Z2U9InNoYXJlZC1taW1lLWluZm8iLz4KKyAgICAgIDxkZXAgcGFja2FnZT0ibGlic2VjcmV0Ii8+ CiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYmdwZy1lcnJvciIvPgogICAgICAgPGRlcCBwYWNrYWdl PSJsaWJnY3J5cHQiLz4KICAgICAgIDxpZiBjb25kaXRpb24tc2V0PSJsaW51eCI+CkBAIC00ODks NiArNDkwLDIzIEBACiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6NzRkYTI3OTg3MjhlNzljM2Fl ZGZmZmEyNjhkOGZlODExYzM3NjZjYTM3MDgzMDljMGRjNDU1MDJiZTEzN2RhMSIvPgogICA8L2F1 dG90b29scz4KIAorCisgIDwhLS0gbGlic2VjcmV0IGlzIG9ubHkgYnVpbHQgaWYgdGhlIHN5c3Rl bSB2ZXJzaW9uIGlzIGxlc3MgdGhhbiAwLjE4LjYgKHVucmVsZWFzZWQKKyAgICAgICBhcyBvZiB3 cml0aW5nIHRoaXMpIGluIG9yZGVyIHRvIGNoZXJyeSBwaWNrIGEgZml4IGZvciBhIGJ1ZyB0aGF0 IGNhdXNlcyBjcmFzaGVzCisgICAgICAgd2l0aCBsYXlvdXQgdGVzdHMuIC0tPgorICA8YXV0b3Rv b2xzIGlkPSJsaWJzZWNyZXQiIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+CisgICAgPHBrZy1jb25m aWc+bGlic2VjcmV0LTEucGM8L3BrZy1jb25maWc+CisgICAgPGJyYW5jaCByZXBvPSJmdHAuZ25v bWUub3JnIgorICAgICAgICAgICAgdmVyc2lvbj0iMC4xOC42IgorICAgICAgICAgICAgbW9kdWxl PSIvcHViL0dOT01FL3NvdXJjZXMvbGlic2VjcmV0LzAuMTgvbGlic2VjcmV0LTAuMTguNS50YXIu eHoiCisgICAgICAgICAgICBoYXNoPSJzaGEyNTY6OWNlN2JkOGRkNTgzMWYyNzg2YzkzNWQ4MjYz OGFjNDI4ZmEwODUwNTdjYzY3ODBhYmEwZTM5Mzc1ODg3Y2NiMyI+CisgICAgPHBhdGNoIGZpbGU9 ImxpYnNlY3JldC1zZWNyZXQtbWV0aG9kcy1Eb24tdC11bnJlZi1OVUxMLXdoZW4tc2VhcmNoLWZh aWxzLnBhdGNoIiBzdHJpcD0iMSIvPgorICAgIDwvYnJhbmNoPgorICAgIDxkZXBlbmRlbmNpZXM+ CisgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICA8L2RlcGVuZGVuY2llcz4KKyAgPC9h dXRvdG9vbHM+CisKICAgPGRpc3R1dGlscyBpZD0ibWVzb24iIHB5dGhvbjM9IjEiPgogICAgIDxi cmFuY2ggcmVwbz0iZ2l0aHViLXRhcmJhbGwiCiAgICAgICAgICAgICB2ZXJzaW9uPSIwLjQyLjAi CmRpZmYgLS1naXQgYS9Ub29scy9ndGsvcGF0Y2hlcy9saWJzZWNyZXQtc2VjcmV0LW1ldGhvZHMt RG9uLXQtdW5yZWYtTlVMTC13aGVuLXNlYXJjaC1mYWlscy5wYXRjaCBiL1Rvb2xzL2d0ay9wYXRj aGVzL2xpYnNlY3JldC1zZWNyZXQtbWV0aG9kcy1Eb24tdC11bnJlZi1OVUxMLXdoZW4tc2VhcmNo LWZhaWxzLnBhdGNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMyMjViYjc1YTUyZDhjMmVjZWUyZDBlZjE0YTYyMTkz YmZjNjQ3ZmYKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9ndGsvcGF0Y2hlcy9saWJzZWNyZXQt c2VjcmV0LW1ldGhvZHMtRG9uLXQtdW5yZWYtTlVMTC13aGVuLXNlYXJjaC1mYWlscy5wYXRjaApA QCAtMCwwICsxLDMwIEBACitGcm9tIGY3NmUzMzNkMDliYzQzYTMwMDM3NDkwYTYzZDE2ZmI3OWNj YjMxNDkgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxCitGcm9tOiBNaWNoYWVsIENhdGFuemFybyA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorRGF0ZTogV2VkLCA2IFNlcCAyMDE3IDIwOjQ2OjE0IC0w NTAwCitTdWJqZWN0OiBbUEFUQ0hdIHNlY3JldC1tZXRob2RzOiBEb24ndCB1bnJlZiBOVUxMIHdo ZW4gc2VhcmNoIGZhaWxzCisKK0lmIHRoZSBnbm9tZS1rZXlyaW5nIEQtQnVzIHNlcnZpY2UgaXMg bm90IHJlc3BvbmRpbmcsIHdlIHdpbmQgdXAgZnJlZWluZwordGhlIFNlYXJjaENsb3N1cmUgaW4g YW4gZXJyb3IgcGF0aCB3aXRob3V0IGV2ZXIgY3JlYXRpbmcgYSBTZWNyZXRTZXJ2aWNlCitvYmpl Y3QuIEd1YXJkIGFnYWluc3QgdGhpcy4KKworaHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hv d19idWcuY2dpP2lkPTc4NzM5MQorLS0tCisgbGlic2VjcmV0L3NlY3JldC1tZXRob2RzLmMgfCAy ICstCisgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCisKK2Rp ZmYgLS1naXQgYS9saWJzZWNyZXQvc2VjcmV0LW1ldGhvZHMuYyBiL2xpYnNlY3JldC9zZWNyZXQt bWV0aG9kcy5jCitpbmRleCA0OGViNzE2Li5jMGNiYzk5IDEwMDY0NAorLS0tIGEvbGlic2VjcmV0 L3NlY3JldC1tZXRob2RzLmMKKysrKyBiL2xpYnNlY3JldC9zZWNyZXQtbWV0aG9kcy5jCitAQCAt NTEsNyArNTEsNyBAQCBzdGF0aWMgdm9pZAorIHNlYXJjaF9jbG9zdXJlX2ZyZWUgKGdwb2ludGVy IGRhdGEpCisgeworIAlTZWFyY2hDbG9zdXJlICpjbG9zdXJlID0gZGF0YTsKKy0JZ19vYmplY3Rf dW5yZWYgKGNsb3N1cmUtPnNlcnZpY2UpOworKwlnX2NsZWFyX29iamVjdCAoJmNsb3N1cmUtPnNl cnZpY2UpOworIAlnX2NsZWFyX29iamVjdCAoJmNsb3N1cmUtPmNhbmNlbGxhYmxlKTsKKyAJZ19o YXNoX3RhYmxlX3VucmVmIChjbG9zdXJlLT5pdGVtcyk7CisgCWdfdmFyaWFudF91bnJlZiAoY2xv c3VyZS0+YXR0cmlidXRlcyk7CistLSAKKzIuMTEuMAorCg==