183319 2018-03-04 08:29:24 -0800 [WTF] Use __builtin_xxx_overflow for CheckedArithmetic 2018-03-05 03:13:04 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist mark.lam sam webkit-bug-importer oldest_to_newest 1403529 0 ysuzuki 2018-03-04 08:29:24 -0800 ... 1403532 1 334980 ysuzuki 2018-03-04 08:46:21 -0800 Created attachment 334980 Patch 1403552 2 334980 ysuzuki 2018-03-04 17:50:12 -0800 Comment on attachment 334980 Patch Thank you! 1403556 3 334980 commit-queue 2018-03-04 18:15:16 -0800 Comment on attachment 334980 Patch Clearing flags on attachment: 334980 Committed r229208: <https://trac.webkit.org/changeset/229208> 1403557 4 commit-queue 2018-03-04 18:15:17 -0800 All reviewed patches have been landed. Closing bug. 1403558 5 webkit-bug-importer 2018-03-04 18:16:25 -0800 <rdar://problem/38125797> 1403587 6 ysuzuki 2018-03-05 03:13:04 -0800 Committed r229242: <https://trac.webkit.org/changeset/229242> 334980 2018-03-04 08:46:21 -0800 2018-03-04 18:15:16 -0800 Patch bug-183319-20180305014620.patch text/plain 6278 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI0NzAyMjhlY2EyZGNiOGEzMmVkYWRk ODcwZGQwYjQ0MDBkNDk0MDUuLjMyZTljMDljMjIyMjRlYmM2YjEwNjQwOTI2NmFjN2FmYWM3ZGM1 NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDMtMDQgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW1dURl0gVXNlIF9fYnVpbHRpbl94eHhfb3Zl cmZsb3cgZm9yIENoZWNrZWRBcml0aG1ldGljCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBHQ0MgYW5kIENsYW5nIGhhcyB0aGUgYnVpbHRpbnMgZm9yIGFy aXRobWV0aWMgb3BlcmF0aW9ucyB3aXRoIG92ZXJmbG93IGZsYWdzLgorICAgICAgICBDaGVja2Vk QXJpdGhtZXRpYyBvcGVyYXRpb25zIGNhbiBiZSBkb25lIHdpdGggdGhpcyBidWlsdGlucy4gU2lu Y2UgdGhlIGNvbXBpbGVyCisgICAgICAgIGNhbiB1c2Ugb3ZlcmZsb3cgZmxhZ3MsIHBvdGVudGlh bGx5IHRoaXMgaXMgbW9yZSBlZmZpY2llbnQuIENoZWNrZWRBcml0aG1ldGljCisgICAgICAgIGFs cmVhZHkgaGFzIFRlc3RXZWJLaXRBUEkgdGVzdHMgYW5kIHdlIGVuc3VyZWQgdGhlIHRlc3RzIHBh c3MuCisKKyAgICAgICAgKiB3dGYvQ2hlY2tlZEFyaXRobWV0aWMuaDoKKwogMjAxOC0wMy0wMiAg WXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbV1RGXSBS ZW1vdmUgUnVuTG9vcCBhbmQgUnVuTG9vcDo6VGltZXIncyBpbnRlcmZhY2UgdXNpbmcgZG91Ymxl IGFzIHNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0aG1ldGlj LmggYi9Tb3VyY2UvV1RGL3d0Zi9DaGVja2VkQXJpdGhtZXRpYy5oCmluZGV4IDhiZDMwNjRmN2M1 MTU1ZjJiMzU2YjM5OGZhNDhiZDA4OWMwMWNkNTcuLjg1NjhlZDE1MTM4NDJhMTZjODIzOTFlYWZk ZTBiNjAzMDcwOWEzMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NoZWNrZWRBcml0aG1l dGljLmgKKysrIGIvU291cmNlL1dURi93dGYvQ2hlY2tlZEFyaXRobWV0aWMuaApAQCAtMjcwLDYg KzI3MCw5IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBMSFMsIHR5cGVuYW1lIFJIUywgdHlwZW5hbWUg UmVzdWx0VHlwZT4gc3RydWN0IEFyaXRobWV0aWNPcGVyCiAKICAgICBzdGF0aWMgaW5saW5lIGJv b2wgYWRkKExIUyBsaHMsIFJIUyByaHMsIFJlc3VsdFR5cGUmIHJlc3VsdCkgV0FSTl9VTlVTRURf UkVUVVJOCiAgICAgeworI2lmIENPTVBJTEVSKEdDQ19PUl9DTEFORykKKyAgICAgICAgcmV0dXJu ICFfX2J1aWx0aW5fYWRkX292ZXJmbG93KGxocywgcmhzLCAmcmVzdWx0KTsKKyNlbHNlCiAgICAg ICAgIGlmIChzaWduc01hdGNoKGxocywgcmhzKSkgewogICAgICAgICAgICAgaWYgKGxocyA+PSAw KSB7CiAgICAgICAgICAgICAgICAgaWYgKChzdGQ6Om51bWVyaWNfbGltaXRzPFJlc3VsdFR5cGU+ OjptYXgoKSAtIHJocykgPCBsaHMpCkBAIC0yODIsMTAgKzI4NSwxNCBAQCB0ZW1wbGF0ZSA8dHlw ZW5hbWUgTEhTLCB0eXBlbmFtZSBSSFMsIHR5cGVuYW1lIFJlc3VsdFR5cGU+IHN0cnVjdCBBcml0 aG1ldGljT3BlcgogICAgICAgICB9IC8vIGlmIHRoZSBzaWducyBkbyBub3QgbWF0Y2ggdGhpcyBv cGVyYXRpb24gY2FuJ3Qgb3ZlcmZsb3cKICAgICAgICAgcmVzdWx0ID0gbGhzICsgcmhzOwogICAg ICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAgIH0KIAogICAgIHN0YXRpYyBpbmxpbmUgYm9v bCBzdWIoTEhTIGxocywgUkhTIHJocywgUmVzdWx0VHlwZSYgcmVzdWx0KSBXQVJOX1VOVVNFRF9S RVRVUk4KICAgICB7CisjaWYgQ09NUElMRVIoR0NDX09SX0NMQU5HKQorICAgICAgICByZXR1cm4g IV9fYnVpbHRpbl9zdWJfb3ZlcmZsb3cobGhzLCByaHMsICZyZXN1bHQpOworI2Vsc2UKICAgICAg ICAgaWYgKCFzaWduc01hdGNoKGxocywgcmhzKSkgewogICAgICAgICAgICAgaWYgKGxocyA+PSAw KSB7CiAgICAgICAgICAgICAgICAgaWYgKGxocyA+IHN0ZDo6bnVtZXJpY19saW1pdHM8UmVzdWx0 VHlwZT46Om1heCgpICsgcmhzKQpAQCAtMjk3LDEwICszMDQsMTQgQEAgdGVtcGxhdGUgPHR5cGVu YW1lIExIUywgdHlwZW5hbWUgUkhTLCB0eXBlbmFtZSBSZXN1bHRUeXBlPiBzdHJ1Y3QgQXJpdGht ZXRpY09wZXIKICAgICAgICAgfSAvLyBpZiB0aGUgc2lnbnMgbWF0Y2ggdGhpcyBvcGVyYXRpb24g Y2FuJ3Qgb3ZlcmZsb3cKICAgICAgICAgcmVzdWx0ID0gbGhzIC0gcmhzOwogICAgICAgICByZXR1 cm4gdHJ1ZTsKKyNlbmRpZgogICAgIH0KIAogICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBtdWx0aXBs eShMSFMgbGhzLCBSSFMgcmhzLCBSZXN1bHRUeXBlJiByZXN1bHQpIFdBUk5fVU5VU0VEX1JFVFVS TgogICAgIHsKKyNpZiBDT01QSUxFUihHQ0NfT1JfQ0xBTkcpCisgICAgICAgIHJldHVybiAhX19i dWlsdGluX211bF9vdmVyZmxvdyhsaHMsIHJocywgJnJlc3VsdCk7CisjZWxzZQogICAgICAgICBp ZiAoc2lnbnNNYXRjaChsaHMsIHJocykpIHsKICAgICAgICAgICAgIGlmIChsaHMgPj0gMCkgewog ICAgICAgICAgICAgICAgIGlmIChsaHMgJiYgKHN0ZDo6bnVtZXJpY19saW1pdHM8UmVzdWx0VHlw ZT46Om1heCgpIC8gbGhzKSA8IHJocykKQEAgLTMyMiw2ICszMzMsNyBAQCB0ZW1wbGF0ZSA8dHlw ZW5hbWUgTEhTLCB0eXBlbmFtZSBSSFMsIHR5cGVuYW1lIFJlc3VsdFR5cGU+IHN0cnVjdCBBcml0 aG1ldGljT3BlcgogICAgICAgICB9CiAgICAgICAgIHJlc3VsdCA9IGxocyAqIHJoczsKICAgICAg ICAgcmV0dXJuIHRydWU7CisjZW5kaWYKICAgICB9CiAKICAgICBzdGF0aWMgaW5saW5lIGJvb2wg ZXF1YWxzKExIUyBsaHMsIFJIUyByaHMpIHsgcmV0dXJuIGxocyA9PSByaHM7IH0KQEAgLTMzMiwy NCArMzQ0LDM1IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBMSFMsIHR5cGVuYW1lIFJIUywgdHlwZW5h bWUgUmVzdWx0VHlwZT4gc3RydWN0IEFyaXRobWV0aWNPcGVyCiAgICAgLy8gTEhTIGFuZCBSSFMg YXJlIHVuc2lnbmVkIHR5cGVzIHNvIGJvdW5kcyBjaGVja3MgYXJlIG5pY2UgYW5kIGVhc3kKICAg ICBzdGF0aWMgaW5saW5lIGJvb2wgYWRkKExIUyBsaHMsIFJIUyByaHMsIFJlc3VsdFR5cGUmIHJl c3VsdCkgV0FSTl9VTlVTRURfUkVUVVJOCiAgICAgeworI2lmIENPTVBJTEVSKEdDQ19PUl9DTEFO RykKKyAgICAgICAgcmV0dXJuICFfX2J1aWx0aW5fYWRkX292ZXJmbG93KGxocywgcmhzLCAmcmVz dWx0KTsKKyNlbHNlCiAgICAgICAgIFJlc3VsdFR5cGUgdGVtcCA9IGxocyArIHJoczsKICAgICAg ICAgaWYgKHRlbXAgPCBsaHMpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHJl c3VsdCA9IHRlbXA7CiAgICAgICAgIHJldHVybiB0cnVlOworI2VuZGlmCiAgICAgfQogCiAgICAg c3RhdGljIGlubGluZSBib29sIHN1YihMSFMgbGhzLCBSSFMgcmhzLCBSZXN1bHRUeXBlJiByZXN1 bHQpIFdBUk5fVU5VU0VEX1JFVFVSTgogICAgIHsKKyNpZiBDT01QSUxFUihHQ0NfT1JfQ0xBTkcp CisgICAgICAgIHJldHVybiAhX19idWlsdGluX3N1Yl9vdmVyZmxvdyhsaHMsIHJocywgJnJlc3Vs dCk7CisjZWxzZQogICAgICAgICBSZXN1bHRUeXBlIHRlbXAgPSBsaHMgLSByaHM7CiAgICAgICAg IGlmICh0ZW1wID4gbGhzKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICByZXN1 bHQgPSB0ZW1wOwogICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAgIH0KIAogICAgIHN0 YXRpYyBpbmxpbmUgYm9vbCBtdWx0aXBseShMSFMgbGhzLCBSSFMgcmhzLCBSZXN1bHRUeXBlJiBy ZXN1bHQpIFdBUk5fVU5VU0VEX1JFVFVSTgogICAgIHsKKyNpZiBDT01QSUxFUihHQ0NfT1JfQ0xB TkcpCisgICAgICAgIHJldHVybiAhX19idWlsdGluX211bF9vdmVyZmxvdyhsaHMsIHJocywgJnJl c3VsdCk7CisjZWxzZQogICAgICAgICBpZiAoIWxocyB8fCAhcmhzKSB7CiAgICAgICAgICAgICBy ZXN1bHQgPSAwOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0zNTgsNiArMzgxLDcgQEAg dGVtcGxhdGUgPHR5cGVuYW1lIExIUywgdHlwZW5hbWUgUkhTLCB0eXBlbmFtZSBSZXN1bHRUeXBl PiBzdHJ1Y3QgQXJpdGhtZXRpY09wZXIKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAg ICAgcmVzdWx0ID0gbGhzICogcmhzOwogICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAg IH0KIAogICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBlcXVhbHMoTEhTIGxocywgUkhTIHJocykgeyBy ZXR1cm4gbGhzID09IHJoczsgfQpAQCAtMzY3LDYgKzM5MSw5IEBAIHRlbXBsYXRlIDx0eXBlbmFt ZSBMSFMsIHR5cGVuYW1lIFJIUywgdHlwZW5hbWUgUmVzdWx0VHlwZT4gc3RydWN0IEFyaXRobWV0 aWNPcGVyCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgUmVzdWx0VHlwZT4gc3RydWN0IEFyaXRobWV0aWNP cGVyYXRpb25zPGludCwgdW5zaWduZWQsIFJlc3VsdFR5cGUsIHRydWUsIGZhbHNlPiB7CiAgICAg c3RhdGljIGlubGluZSBib29sIGFkZChpbnQ2NF90IGxocywgaW50NjRfdCByaHMsIFJlc3VsdFR5 cGUmIHJlc3VsdCkKICAgICB7CisjaWYgQ09NUElMRVIoR0NDX09SX0NMQU5HKQorICAgICAgICBy ZXR1cm4gIV9fYnVpbHRpbl9hZGRfb3ZlcmZsb3cobGhzLCByaHMsICZyZXN1bHQpOworI2Vsc2UK ICAgICAgICAgaW50NjRfdCB0ZW1wID0gbGhzICsgcmhzOwogICAgICAgICBpZiAodGVtcCA8IHN0 ZDo6bnVtZXJpY19saW1pdHM8UmVzdWx0VHlwZT46Om1pbigpKQogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMzc0LDEwICs0MDEsMTQgQEAgdGVtcGxhdGUgPHR5cGVuYW1lIFJlc3VsdFR5 cGU+IHN0cnVjdCBBcml0aG1ldGljT3BlcmF0aW9uczxpbnQsIHVuc2lnbmVkLCBSZXN1bHQKICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgcmVzdWx0ID0gc3RhdGljX2Nhc3Q8UmVz dWx0VHlwZT4odGVtcCk7CiAgICAgICAgIHJldHVybiB0cnVlOworI2VuZGlmCiAgICAgfQogICAg IAogICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBzdWIoaW50NjRfdCBsaHMsIGludDY0X3QgcmhzLCBS ZXN1bHRUeXBlJiByZXN1bHQpCiAgICAgeworI2lmIENPTVBJTEVSKEdDQ19PUl9DTEFORykKKyAg ICAgICAgcmV0dXJuICFfX2J1aWx0aW5fc3ViX292ZXJmbG93KGxocywgcmhzLCAmcmVzdWx0KTsK KyNlbHNlCiAgICAgICAgIGludDY0X3QgdGVtcCA9IGxocyAtIHJoczsKICAgICAgICAgaWYgKHRl bXAgPCBzdGQ6Om51bWVyaWNfbGltaXRzPFJlc3VsdFR5cGU+OjptaW4oKSkKICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKQEAgLTM4NSwxMCArNDE2LDE0IEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBS ZXN1bHRUeXBlPiBzdHJ1Y3QgQXJpdGhtZXRpY09wZXJhdGlvbnM8aW50LCB1bnNpZ25lZCwgUmVz dWx0CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHJlc3VsdCA9IHN0YXRpY19j YXN0PFJlc3VsdFR5cGU+KHRlbXApOwogICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgogICAg IH0KIAogICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBtdWx0aXBseShpbnQ2NF90IGxocywgaW50NjRf dCByaHMsIFJlc3VsdFR5cGUmIHJlc3VsdCkKICAgICB7CisjaWYgQ09NUElMRVIoR0NDX09SX0NM QU5HKQorICAgICAgICByZXR1cm4gIV9fYnVpbHRpbl9tdWxfb3ZlcmZsb3cobGhzLCByaHMsICZy ZXN1bHQpOworI2Vsc2UKICAgICAgICAgaW50NjRfdCB0ZW1wID0gbGhzICogcmhzOwogICAgICAg ICBpZiAodGVtcCA8IHN0ZDo6bnVtZXJpY19saW1pdHM8UmVzdWx0VHlwZT46Om1pbigpKQogICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMzk2LDYgKzQzMSw3IEBAIHRlbXBsYXRlIDx0eXBl bmFtZSBSZXN1bHRUeXBlPiBzdHJ1Y3QgQXJpdGhtZXRpY09wZXJhdGlvbnM8aW50LCB1bnNpZ25l ZCwgUmVzdWx0CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHJlc3VsdCA9IHN0 YXRpY19jYXN0PFJlc3VsdFR5cGU+KHRlbXApOwogICAgICAgICByZXR1cm4gdHJ1ZTsKKyNlbmRp ZgogICAgIH0KIAogICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBlcXVhbHMoaW50IGxocywgdW5zaWdu ZWQgcmhzKQo=