183308 2018-03-02 18:07:57 -0800 Calling removeTrack with RTCRtpSender does not set SenderTrack to null 2018-03-13 14:15:35 -0700 1 1 1 Unclassified WebKit WebRTC Safari 11 Mac macOS 10.13 RESOLVED FIXED InRadar P2 Normal --- 1 thomasmullendesign youennf achristensen commit-queue eric.carlson webkit-bug-importer youennf oldest_to_newest 1403440 0 thomasmullendesign 2018-03-02 18:07:57 -0800 Calling RTCPeerConnection.removeTrack with a RTCRtpSender does not set the sender's "track" attribute to null. This is against the the specification: https://www.w3.org/TR/webrtc/#removeTrack Both Chrome and Firefox do this and it is important to determining if a sender has been removed after renegotiation. 1403441 1 thomasmullendesign 2018-03-02 18:08:46 -0800 Simple way to reproduce: ``` var config = { "iceTransports": 'all', "iceServers": [{ "urls": "stun:global.stun.twilio.com:3478?transport=udp" }] } var pc = new RTCPeerConnection(config) var getUserMedia = (navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.mozGetUserMedia).bind(navigator) getUserMedia({ video: true, audio: true }, function(stream) { var track = stream.getTracks()[0] var sender = pc.addTrack(track, stream) pc.removeTrack(sender) console.log(sender.track) // should be null }, function(err) { throw err }) ``` 1405906 2 335641 youennf 2018-03-12 14:42:20 -0700 Created attachment 335641 Patch 1406238 3 335641 commit-queue 2018-03-13 14:14:18 -0700 Comment on attachment 335641 Patch Clearing flags on attachment: 335641 Committed r229587: <https://trac.webkit.org/changeset/229587> 1406239 4 commit-queue 2018-03-13 14:14:19 -0700 All reviewed patches have been landed. Closing bug. 1406242 5 webkit-bug-importer 2018-03-13 14:15:35 -0700 <rdar://problem/38431087> 335641 2018-03-12 14:42:20 -0700 2018-03-13 14:14:18 -0700 Patch bug-183308-20180312144220.patch text/plain 4682 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzcyY2NkM2I2ODYzMzgx MWQ3Nzg3OTU1Nzk1OTNmYTlkYmJlZTZjYS4uZTQxODdmMDkxZWI1ZmJmZDM3YTNmZTlhM2M4YjZm NTU4NjdjYjNiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAzLTEyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDYWxsaW5nIHJlbW92ZVRy YWNrIHdpdGggUlRDUnRwU2VuZGVyIGRvZXMgbm90IHNldCBTZW5kZXJUcmFjayB0byBudWxsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMzMDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5 IHVwZGF0ZWQgdGVzdC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUnRwU2Vu ZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJUQ1J0cFNlbmRlcjo6c3RvcCk6IFNldCB0cmFj ayB0byBudWxsIHdoZW4gYmVpbmcgc3RvcHBlZCBpLmUuIHJlbW92ZWQuCisgICAgICAgICogTW9k dWxlcy9tZWRpYXN0cmVhbS9SVENSdHBTZW5kZXIuaDoKKwogMjAxOC0wMy0xMiAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgU2FmYXJpIFdlYktpdFdlYlJUQ0F1 ZGlvTW9kdWxlIGNyYXNoIGR1cmluZyA8dmlkZW8+IHRhZyB1cGRhdGUgd2hlbiBhdWRpbyB0cmFj ayBwcmVzZW50IGluIE1lZGlhU3RyZWFtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci5jcHAKaW5kZXggODY0YmI5ODJkNDc5Nzk0NDJlZDA5 MDZhYzE5ZTNmYjY5YTAyZDY4OC4uOTNkYjNkYmMyZDQ2ZTkwMDg2MDU0MzYwYzI0Yzk1ZDQzODJh ZTg0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENS dHBTZW5kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD UnRwU2VuZGVyLmNwcApAQCAtNjIsNiArNjIsMTMgQEAgdm9pZCBSVENSdHBTZW5kZXI6OnNldFRy YWNrVG9OdWxsKCkKICAgICBtX3RyYWNrID0gbnVsbHB0cjsKIH0KIAordm9pZCBSVENSdHBTZW5k ZXI6OnN0b3AoKQoreworICAgIG1fdHJhY2tJZCA9IHsgfTsKKyAgICBtX3RyYWNrID0gbnVsbHB0 cjsKKyAgICBtX2JhY2tlbmQgPSBudWxscHRyOworfQorCiB2b2lkIFJUQ1J0cFNlbmRlcjo6c2V0 VHJhY2soUmVmPE1lZGlhU3RyZWFtVHJhY2s+JiYgdHJhY2spCiB7CiAgICAgQVNTRVJUKCFpc1N0 b3BwZWQoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFt L1JUQ1J0cFNlbmRlci5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENS dHBTZW5kZXIuaAppbmRleCAzMGU5NThiOGYyNDdkYWUxN2E0NWJhNmRiNDZkYTcyMTlhMDFjMzI1 Li44OTU4ZGY2NzkxMzJkNGY4ZTZmMjVkODRiZDBlYzExNzkzNjc2ZmNhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUnRwU2VuZGVyLmgKQEAgLTU2LDcg KzU2LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0TWVkaWFTdHJlYW1JZHMoVmVjdG9yPFN0cmlu Zz4mJiBtZWRpYVN0cmVhbUlkcykgeyBtX21lZGlhU3RyZWFtSWRzID0gV1RGTW92ZShtZWRpYVN0 cmVhbUlkcyk7IH0KIAogICAgIGJvb2wgaXNTdG9wcGVkKCkgY29uc3QgeyByZXR1cm4gIW1fYmFj a2VuZDsgfQotICAgIHZvaWQgc3RvcCgpIHsgbV9iYWNrZW5kID0gbnVsbHB0cjsgfQorICAgIHZv aWQgc3RvcCgpOwogICAgIHZvaWQgc2V0VHJhY2soUmVmPE1lZGlhU3RyZWFtVHJhY2s+JiYpOwog ICAgIHZvaWQgc2V0VHJhY2tUb051bGwoKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cK aW5kZXggN2Y2ZmM3ODJkMmJlZWUzOWRmYTE4MThlYTEyNGFmNTJhMjgyNzEzYS4uMjMzYjk4ZDYw OGNhZjUyOTdlNGQ2MTJlNGVhMGYzNGQ0MTkzZTZlZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMDMtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgorCisgICAgICAgIENhbGxpbmcgcmVtb3ZlVHJhY2sgd2l0aCBSVENSdHBT ZW5kZXIgZG9lcyBub3Qgc2V0IFNlbmRlclRyYWNrIHRvIG51bGwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzMwOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnJ0 Yy9SVENQZWVyQ29ubmVjdGlvbi1yZW1vdmVUcmFjay5odHRwcy1leHBlY3RlZC50eHQ6CisKIDIw MTgtMDMtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJU Q1BlZXJDb25uZWN0aW9uJ3MgY2xvc2UgbWV0aG9kIHNob3VsZCB1cGRhdGUgc2lnbmFsaW5nU3Rh dGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvd2VicnRjL1JUQ1BlZXJDb25uZWN0aW9uLXJlbW92ZVRyYWNrLmh0dHBzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL1JU Q1BlZXJDb25uZWN0aW9uLXJlbW92ZVRyYWNrLmh0dHBzLWV4cGVjdGVkLnR4dAppbmRleCBjMzMz NDEyYWU5NzY4ZGQ1MWYwNmY4OTdlZDFlZDViYzc3MmM5ZTc0Li5hYWU0ZTU5ZjBlMWMxNmViNzYw YmYyOTIyNjE3NjRiNjFkYjg3MzQ2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYnJ0Yy9SVENQZWVyQ29ubmVjdGlvbi1yZW1vdmVUcmFj ay5odHRwcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy93ZWJydGMvUlRDUGVlckNvbm5lY3Rpb24tcmVtb3ZlVHJhY2suaHR0cHMt ZXhwZWN0ZWQudHh0CkBAIC02LDcgKzYsNyBAQCBQQVNTIGFkZFRyYWNrIC0gQ2FsbGluZyByZW1v dmVUcmFjayBvbiBkaWZmZXJlbnQgY29ubmVjdGlvbiB0aGF0IGlzIGNsb3NlZCBzaG91bAogRkFJ TCBhZGRUcmFuc2NlaXZlciAtIENhbGxpbmcgcmVtb3ZlVHJhY2sgb24gZGlmZmVyZW50IGNvbm5l Y3Rpb24gc2hvdWxkIHRocm93IEludmFsaWRBY2Nlc3NFcnJvciBhc3NlcnRfdGhyb3dzOiBmdW5j dGlvbiAiKCkgPT4gcGMyLnJlbW92ZVRyYWNrKHNlbmRlcikiIGRpZCBub3QgdGhyb3cKIEZBSUwg YWRkVHJhY2sgLSBDYWxsaW5nIHJlbW92ZVRyYWNrIG9uIGRpZmZlcmVudCBjb25uZWN0aW9uIHNo b3VsZCB0aHJvdyBJbnZhbGlkQWNjZXNzRXJyb3IgYXNzZXJ0X3Rocm93czogZnVuY3Rpb24gIigp ID0+IHBjMi5yZW1vdmVUcmFjayhzZW5kZXIpIiBkaWQgbm90IHRocm93CiBGQUlMIGFkZFRyYW5z Y2VpdmVyIC0gQ2FsbGluZyByZW1vdmVUcmFjayB3aXRoIHZhbGlkIHNlbmRlciBzaG91bGQgc2V0 IHNlbmRlci50cmFjayB0byBudWxsIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkIChvYmplY3QpIG51 bGwgYnV0IGdvdCAodW5kZWZpbmVkKSB1bmRlZmluZWQKLUZBSUwgYWRkVHJhY2sgLSBDYWxsaW5n IHJlbW92ZVRyYWNrIHdpdGggdmFsaWQgc2VuZGVyIHNob3VsZCBzZXQgc2VuZGVyLnRyYWNrIHRv IG51bGwgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgbnVsbCBidXQgZ290IG9iamVjdCAiW29iamVj dCBNZWRpYVN0cmVhbVRyYWNrXSIKK1BBU1MgYWRkVHJhY2sgLSBDYWxsaW5nIHJlbW92ZVRyYWNr IHdpdGggdmFsaWQgc2VuZGVyIHNob3VsZCBzZXQgc2VuZGVyLnRyYWNrIHRvIG51bGwgCiBGQUlM IENhbGxpbmcgcmVtb3ZlVHJhY2sgd2l0aCBjdXJyZW50RGlyZWN0aW9uIHNlbmRyZWN2IHNob3Vs ZCBzZXQgZGlyZWN0aW9uIHRvIHJlY3Zvbmx5IGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkIChvYmpl Y3QpIG51bGwgYnV0IGdvdCAodW5kZWZpbmVkKSB1bmRlZmluZWQKIEZBSUwgQ2FsbGluZyByZW1v dmVUcmFjayB3aXRoIGN1cnJlbnREaXJlY3Rpb24gc2VuZG9ubHkgc2hvdWxkIHNldCBkaXJlY3Rp b24gdG8gaW5hY3RpdmUgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgKG9iamVjdCkgbnVsbCBidXQg Z290ICh1bmRlZmluZWQpIHVuZGVmaW5lZAogRkFJTCBDYWxsaW5nIHJlbW92ZVRyYWNrIHdpdGgg Y3VycmVudERpcmVjdGlvbiByZWN2b25seSBzaG91bGQgbm90IGNoYW5nZSBkaXJlY3Rpb24gYXNz ZXJ0X2VxdWFsczogZXhwZWN0ZWQgKG9iamVjdCkgbnVsbCBidXQgZ290ICh1bmRlZmluZWQpIHVu ZGVmaW5lZAo=