183302 2018-03-02 13:51:08 -0800 Add clang-format configuration 2021-12-23 16:41:26 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234655 InRadar P2 Normal --- 1 don.olmstead don.olmstead achristensen ap commit-queue darin koivisto lforschler mjs rniwa webkit-bug-importer oldest_to_newest 1403358 0 don.olmstead 2018-03-02 13:51:08 -0800 Clang format has a WebKit style available which seems to be mostly correct. I'm proposing we add a root .clang-format so it can be integrated into a developer's workflow. Any bugs we encounter we should open up issues on the LLVM tools repo until we're at a point where its a 100% correct. 1403359 1 334924 don.olmstead 2018-03-02 13:52:02 -0800 Created attachment 334924 Patch 1403360 2 334924 don.olmstead 2018-03-02 13:53:44 -0800 Comment on attachment 334924 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334924&action=review This file was created by running the following clang-format --dump-config -style=WebKit > .clang-format > .clang-format:68 > +IncludeCategories: > + - Regex: '^"config\.h"' > + Priority: -1 > + # The main header for a source file automatically gets category 0 > + - Regex: '.*' > + Priority: 1 > + - Regex: '^<.*\.h>' > + Priority: 2 This is the only part modified from the stock WebKit configuration. If its not present then clang-format won't keep "config.h" configs at the top. 1403367 3 334924 rniwa 2018-03-02 14:05:40 -0800 Comment on attachment 334924 Patch rs=me 1403371 4 334924 commit-queue 2018-03-02 14:13:16 -0800 Comment on attachment 334924 Patch Clearing flags on attachment: 334924 Committed r229189: <https://trac.webkit.org/changeset/229189> 1403372 5 commit-queue 2018-03-02 14:13:17 -0800 All reviewed patches have been landed. Closing bug. 1403373 6 webkit-bug-importer 2018-03-02 14:14:23 -0800 <rdar://problem/38081690> 334924 2018-03-02 13:52:02 -0800 2018-03-02 14:13:16 -0800 Patch bug-183302.diff text/plain 3853 don.olmstead ZGlmZiAtLWdpdCBhLy5jbGFuZy1mb3JtYXQgYi8uY2xhbmctZm9ybWF0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi41ZDFiYTA5MmFmMAotLS0gL2Rldi9udWxsCisrKyBi Ly5jbGFuZy1mb3JtYXQKQEAgLTAsMCArMSwxMDkgQEAKKy0tLQorTGFuZ3VhZ2U6ICAgICAgICBD cHAKKyMgQmFzZWRPblN0eWxlOiAgV2ViS2l0CitBY2Nlc3NNb2RpZmllck9mZnNldDogLTQKK0Fs aWduQWZ0ZXJPcGVuQnJhY2tldDogRG9udEFsaWduCitBbGlnbkNvbnNlY3V0aXZlQXNzaWdubWVu dHM6IGZhbHNlCitBbGlnbkNvbnNlY3V0aXZlRGVjbGFyYXRpb25zOiBmYWxzZQorQWxpZ25Fc2Nh cGVkTmV3bGluZXM6IFJpZ2h0CitBbGlnbk9wZXJhbmRzOiAgIGZhbHNlCitBbGlnblRyYWlsaW5n Q29tbWVudHM6IGZhbHNlCitBbGxvd0FsbFBhcmFtZXRlcnNPZkRlY2xhcmF0aW9uT25OZXh0TGlu ZTogdHJ1ZQorQWxsb3dTaG9ydEJsb2Nrc09uQVNpbmdsZUxpbmU6IGZhbHNlCitBbGxvd1Nob3J0 Q2FzZUxhYmVsc09uQVNpbmdsZUxpbmU6IGZhbHNlCitBbGxvd1Nob3J0RnVuY3Rpb25zT25BU2lu Z2xlTGluZTogQWxsCitBbGxvd1Nob3J0SWZTdGF0ZW1lbnRzT25BU2luZ2xlTGluZTogZmFsc2UK K0FsbG93U2hvcnRMb29wc09uQVNpbmdsZUxpbmU6IGZhbHNlCitBbHdheXNCcmVha0FmdGVyRGVm aW5pdGlvblJldHVyblR5cGU6IE5vbmUKK0Fsd2F5c0JyZWFrQWZ0ZXJSZXR1cm5UeXBlOiBOb25l CitBbHdheXNCcmVha0JlZm9yZU11bHRpbGluZVN0cmluZ3M6IGZhbHNlCitBbHdheXNCcmVha1Rl bXBsYXRlRGVjbGFyYXRpb25zOiBmYWxzZQorQmluUGFja0FyZ3VtZW50czogdHJ1ZQorQmluUGFj a1BhcmFtZXRlcnM6IHRydWUKK0JyYWNlV3JhcHBpbmc6ICAgCisgIEFmdGVyQ2xhc3M6ICAgICAg ZmFsc2UKKyAgQWZ0ZXJDb250cm9sU3RhdGVtZW50OiBmYWxzZQorICBBZnRlckVudW06ICAgICAg IGZhbHNlCisgIEFmdGVyRnVuY3Rpb246ICAgdHJ1ZQorICBBZnRlck5hbWVzcGFjZTogIGZhbHNl CisgIEFmdGVyT2JqQ0RlY2xhcmF0aW9uOiBmYWxzZQorICBBZnRlclN0cnVjdDogICAgIGZhbHNl CisgIEFmdGVyVW5pb246ICAgICAgZmFsc2UKKyAgQmVmb3JlQ2F0Y2g6ICAgICBmYWxzZQorICBC ZWZvcmVFbHNlOiAgICAgIGZhbHNlCisgIEluZGVudEJyYWNlczogICAgZmFsc2UKKyAgU3BsaXRF bXB0eUZ1bmN0aW9uOiB0cnVlCisgIFNwbGl0RW1wdHlSZWNvcmQ6IHRydWUKKyAgU3BsaXRFbXB0 eU5hbWVzcGFjZTogdHJ1ZQorQnJlYWtCZWZvcmVCaW5hcnlPcGVyYXRvcnM6IEFsbAorQnJlYWtC ZWZvcmVCcmFjZXM6IFdlYktpdAorQnJlYWtCZWZvcmVJbmhlcml0YW5jZUNvbW1hOiBmYWxzZQor QnJlYWtCZWZvcmVUZXJuYXJ5T3BlcmF0b3JzOiB0cnVlCitCcmVha0NvbnN0cnVjdG9ySW5pdGlh bGl6ZXJzQmVmb3JlQ29tbWE6IGZhbHNlCitCcmVha0NvbnN0cnVjdG9ySW5pdGlhbGl6ZXJzOiBC ZWZvcmVDb21tYQorQnJlYWtBZnRlckphdmFGaWVsZEFubm90YXRpb25zOiBmYWxzZQorQnJlYWtT dHJpbmdMaXRlcmFsczogdHJ1ZQorQ29sdW1uTGltaXQ6ICAgICAwCitDb21tZW50UHJhZ21hczog ICdeIElXWVUgcHJhZ21hOicKK0NvbXBhY3ROYW1lc3BhY2VzOiBmYWxzZQorQ29uc3RydWN0b3JJ bml0aWFsaXplckFsbE9uT25lTGluZU9yT25lUGVyTGluZTogZmFsc2UKK0NvbnN0cnVjdG9ySW5p dGlhbGl6ZXJJbmRlbnRXaWR0aDogNAorQ29udGludWF0aW9uSW5kZW50V2lkdGg6IDQKK0NwcDEx QnJhY2VkTGlzdFN0eWxlOiBmYWxzZQorRGVyaXZlUG9pbnRlckFsaWdubWVudDogZmFsc2UKK0Rp c2FibGVGb3JtYXQ6ICAgZmFsc2UKK0V4cGVyaW1lbnRhbEF1dG9EZXRlY3RCaW5QYWNraW5nOiBm YWxzZQorRml4TmFtZXNwYWNlQ29tbWVudHM6IGZhbHNlCitGb3JFYWNoTWFjcm9zOiAgIAorICAt IGZvcmVhY2gKKyAgLSBRX0ZPUkVBQ0gKKyAgLSBCT09TVF9GT1JFQUNICitJbmNsdWRlQ2F0ZWdv cmllczoKKyAgLSBSZWdleDogICAgICAgICAgICdeImNvbmZpZ1wuaCInCisgICAgUHJpb3JpdHk6 ICAgICAgICAtMQorICAjIFRoZSBtYWluIGhlYWRlciBmb3IgYSBzb3VyY2UgZmlsZSBhdXRvbWF0 aWNhbGx5IGdldHMgY2F0ZWdvcnkgMAorICAtIFJlZ2V4OiAgICAgICAgICAgJy4qJworICAgIFBy aW9yaXR5OiAgICAgICAgMQorICAtIFJlZ2V4OiAgICAgICAgICAgJ148LipcLmg+JworICAgIFBy aW9yaXR5OiAgICAgICAgMgorSW5jbHVkZUlzTWFpblJlZ2V4OiAnKFRlc3QpPyQnCitJbmRlbnRD YXNlTGFiZWxzOiBmYWxzZQorSW5kZW50V2lkdGg6ICAgICA0CitJbmRlbnRXcmFwcGVkRnVuY3Rp b25OYW1lczogZmFsc2UKK0phdmFTY3JpcHRRdW90ZXM6IExlYXZlCitKYXZhU2NyaXB0V3JhcElt cG9ydHM6IHRydWUKK0tlZXBFbXB0eUxpbmVzQXRUaGVTdGFydE9mQmxvY2tzOiB0cnVlCitNYWNy b0Jsb2NrQmVnaW46ICcnCitNYWNyb0Jsb2NrRW5kOiAgICcnCitNYXhFbXB0eUxpbmVzVG9LZWVw OiAxCitOYW1lc3BhY2VJbmRlbnRhdGlvbjogSW5uZXIKK09iakNCbG9ja0luZGVudFdpZHRoOiA0 CitPYmpDU3BhY2VBZnRlclByb3BlcnR5OiB0cnVlCitPYmpDU3BhY2VCZWZvcmVQcm90b2NvbExp c3Q6IHRydWUKK1BlbmFsdHlCcmVha0Fzc2lnbm1lbnQ6IDIKK1BlbmFsdHlCcmVha0JlZm9yZUZp cnN0Q2FsbFBhcmFtZXRlcjogMTkKK1BlbmFsdHlCcmVha0NvbW1lbnQ6IDMwMAorUGVuYWx0eUJy ZWFrRmlyc3RMZXNzTGVzczogMTIwCitQZW5hbHR5QnJlYWtTdHJpbmc6IDEwMDAKK1BlbmFsdHlF eGNlc3NDaGFyYWN0ZXI6IDEwMDAwMDAKK1BlbmFsdHlSZXR1cm5UeXBlT25JdHNPd25MaW5lOiA2 MAorUG9pbnRlckFsaWdubWVudDogTGVmdAorUmVmbG93Q29tbWVudHM6ICB0cnVlCitTb3J0SW5j bHVkZXM6ICAgIHRydWUKK1NvcnRVc2luZ0RlY2xhcmF0aW9uczogdHJ1ZQorU3BhY2VBZnRlckNT dHlsZUNhc3Q6IGZhbHNlCitTcGFjZUFmdGVyVGVtcGxhdGVLZXl3b3JkOiB0cnVlCitTcGFjZUJl Zm9yZUFzc2lnbm1lbnRPcGVyYXRvcnM6IHRydWUKK1NwYWNlQmVmb3JlUGFyZW5zOiBDb250cm9s U3RhdGVtZW50cworU3BhY2VJbkVtcHR5UGFyZW50aGVzZXM6IGZhbHNlCitTcGFjZXNCZWZvcmVU cmFpbGluZ0NvbW1lbnRzOiAxCitTcGFjZXNJbkFuZ2xlczogIGZhbHNlCitTcGFjZXNJbkNvbnRh aW5lckxpdGVyYWxzOiB0cnVlCitTcGFjZXNJbkNTdHlsZUNhc3RQYXJlbnRoZXNlczogZmFsc2UK K1NwYWNlc0luUGFyZW50aGVzZXM6IGZhbHNlCitTcGFjZXNJblNxdWFyZUJyYWNrZXRzOiBmYWxz ZQorU3RhbmRhcmQ6ICAgICAgICBDcHAxMQorVGFiV2lkdGg6ICAgICAgICA4CitVc2VUYWI6ICAg ICAgICAgIE5ldmVyCisuLi4KKwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmlu ZGV4IDM4ODM1NWViOGQzLi5kYWRiNjJkZGFkZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTAzLTAyICBEb24gT2xtc3RlYWQgIDxk b24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgQWRkIGNsYW5nLWZvcm1hdCBjb25maWd1 cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODMzMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IC5jbGFuZy1mb3JtYXQ6IEFkZGVkLgorCiAyMDE4LTAyLTI2ICBZb3VzdWtlIEtpbW90byAgPHlv dXN1a2Uua2ltb3RvQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gV2ViS2l0Ml9DLmgg c2hvdWxkIGJlIGluY2x1ZGVkIGZvciBUZXN0V2ViS2l0Cg==