183301 2018-03-02 13:31:48 -0800 Build fix after r229174 2021-05-10 09:42:49 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen ap benjamin cdumez cmarcelo commit-queue darin dbates don.olmstead ews-watchlist himanshuarya9162 Jadewyatt26 katiemolina44 lenam7865 maxpetis92 pvollan webkit-bug-importer ysuzuki oldest_to_newest 1403347 0 chris.reid 2018-03-02 13:31:48 -0800 The build fails when #if !PLATFORM(COCOA) && !OS(LINUX) && !OS(WINDOWS) is true MemoryPressureHandler::holdOff was updated to use WTF::Seconds but the MemoryPressureHandler::holdOff definition in that condition is still using unsigned. 1403348 1 334921 chris.reid 2018-03-02 13:34:47 -0800 Created attachment 334921 Patch 1403364 2 334921 commit-queue 2018-03-02 14:00:29 -0800 Comment on attachment 334921 Patch Rejecting attachment 334921 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334921, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6740411 1403380 3 chris.reid 2018-03-02 14:21:06 -0800 (In reply to WebKit Commit Bot from comment #2) > Comment on attachment 334921 [details] > Patch > > Rejecting attachment 334921 [details] from commit-queue. It looks like the commit-queue landed this patch then marked it as rejected due to a timeout 15 seconds later. The patch landed under https://trac.webkit.org/changeset/229187/webkit 1403389 4 chris.reid 2018-03-02 14:31:15 -0800 Manually closing this bug. All patches have landed. 1403390 5 webkit-bug-importer 2018-03-02 14:33:06 -0800 <rdar://problem/38082498> 334921 2018-03-02 13:34:47 -0800 2018-03-02 14:00:29 -0800 Patch 183301.diff text/plain 1432 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMWI4MDcxMGZlZTEuLjdmNWEwZWNjNmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4 LTAzLTAyICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNvbT4KKworICAgICAg ICBCdWlsZCBmaXggYWZ0ZXIgcjIyOTE3NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMzAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVXBkYXRpbmcgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpob2xkT2Zm IHRvIHVzZSBTZWNvbmRzIGluc3RlYWQgb2YgdW5zaWduZWQuCisKKyAgICAgICAgKiB3dGYvTWVt b3J5UHJlc3N1cmVIYW5kbGVyLmNwcDoKKwogMjAxOC0wMy0wMiAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIGl0IHBvc3NpYmxlIHRvIGRpc2Fi bGUgV0tQREZWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlQcmVzc3VyZUhh bmRsZXIuY3BwIGIvU291cmNlL1dURi93dGYvTWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcAppbmRl eCAwZTFkMWE2MGZlMC4uYTYwNzljMjA0ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01l bW9yeVByZXNzdXJlSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dURi93dGYvTWVtb3J5UHJlc3N1 cmVIYW5kbGVyLmNwcApAQCAtMjg2LDcgKzI4Niw3IEBAIHZvaWQgTWVtb3J5UHJlc3N1cmVIYW5k bGVyOjpSZWxpZWZMb2dnZXI6OmxvZ01lbW9yeVVzYWdlQ2hhbmdlKCkKICNpZiAhUExBVEZPUk0o Q09DT0EpICYmICFPUyhMSU5VWCkgJiYgIU9TKFdJTkRPV1MpCiB2b2lkIE1lbW9yeVByZXNzdXJl SGFuZGxlcjo6aW5zdGFsbCgpIHsgfQogdm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnVuaW5z dGFsbCgpIHsgfQotdm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OmhvbGRPZmYodW5zaWduZWQp IHsgfQordm9pZCBNZW1vcnlQcmVzc3VyZUhhbmRsZXI6OmhvbGRPZmYoU2Vjb25kcykgeyB9CiB2 b2lkIE1lbW9yeVByZXNzdXJlSGFuZGxlcjo6cmVzcG9uZFRvTWVtb3J5UHJlc3N1cmUoQ3JpdGlj YWwsIFN5bmNocm9ub3VzKSB7IH0KIHZvaWQgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpwbGF0Zm9y bVJlbGVhc2VNZW1vcnkoQ3JpdGljYWwpIHsgfQogc3RkOjpvcHRpb25hbDxNZW1vcnlQcmVzc3Vy ZUhhbmRsZXI6OlJlbGllZkxvZ2dlcjo6TWVtb3J5VXNhZ2U+IE1lbW9yeVByZXNzdXJlSGFuZGxl cjo6UmVsaWVmTG9nZ2VyOjpwbGF0Zm9ybU1lbW9yeVVzYWdlKCkgeyByZXR1cm4gc3RkOjpudWxs b3B0OyB9Cg==