18329 2008-04-06 01:10:24 -0700 REGRESSION: Assertion failure in -[WebViewFactory endOfTextMarkerRange:] when invoking the Dictionary pop-up 2008-04-08 09:52:32 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED Regression P2 Normal --- 1 mitz alice.barraclough alice.barraclough ap bdakin oldest_to_newest 76413 0 mitz 2008-04-06 01:10:24 -0700 Steps to reproduce: 1. On this page, move the mouse cursor over a word. 2. Press Command-Control-D (or whatever the keyboard shortcut for Look up in Dictionary is; see System Preferences > Keyboard & Mouse). Result: ASSERTION FAILED: range != nil (WebKit/mac/WebCoreSupport/WebViewFactory.mm:405 WebCoreTextMarker* -[WebViewFactory endOfTextMarkerRange:](WebViewFactory*, objc_selector*, WebCoreTextMarkerRange*)) Backtrace: #0 0x003b5103 in -[WebViewFactory endOfTextMarkerRange:] (self=0x3eb58a0, _cmd=0x26d7548, range=0x0) at WebKit/mac/WebCoreSupport/WebViewFactory.mm:405 #1 0x0236310b in visiblePositionForEndOfTextMarkerRange (textMarkerRange=0x0) at WebCore/page/mac/AccessibilityObjectWrapper.mm:160 #2 0x02363136 in -[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:] (self=0x17aa8c70, _cmd=0x26d77c0, textMarkerRange=0x0) at WebCore/page/mac/AccessibilityObjectWrapper.mm:575 #3 0x02366323 in -[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:] (self=0x17aa8c70, _cmd=0x94df6efc, attribute=0x19d0617c, parameter=0x17aa0220) at WebCore/page/mac/AccessibilityObjectWrapper.mm:1214 #4 0x19d0391b in DSAXGetTextOrigin () (More stack frames follow...) 76576 1 20401 alice.barraclough 2008-04-08 01:37:50 -0700 Created attachment 20401 patch 76577 2 alice.barraclough 2008-04-08 01:44:45 -0700 in AccessibilityObjectWrapper.mm, in -accessibilityAttributeValue:forParameter:, starting from the comment "// Convert values to WebCore types", we have a few lines of code that "prep" webcore equivalent values of mac-specific types. Although I'm not too fond of the idea of prepping these values in cases where they're not needed, having it all in one section makes the rest of the code easier to compare to what used to be in WebCoreAXObject.cpp, and thus easier for debugging in this transition period. 76578 3 20401 mitz 2008-04-08 01:48:48 -0700 Comment on attachment 20401 patch Please add the bug URL and title to the change log. + if (textMarker != nil) + if (textMarkerRange != nil) According to the style guidelines these should be written as + if (textMarker) + if (textMarkerRange) r=me 76579 4 mitz 2008-04-08 01:51:27 -0700 (In reply to comment #2) > in AccessibilityObjectWrapper.mm, in > -accessibilityAttributeValue:forParameter:, starting from the comment "// > Convert values to WebCore types", we have a few lines of code that "prep" > webcore equivalent values of mac-specific types. Although I'm not too fond of > the idea of prepping these values in cases where they're not needed, having it > all in one section makes the rest of the code easier to compare to what used to > be in WebCoreAXObject.cpp, and thus easier for debugging in this transition > period. Just saw this comment. Perhaps you should add a FIXME or file a bug about improving that code in the future. 76620 5 alice.barraclough 2008-04-08 09:52:32 -0700 fixed the changelog, style, and added a fixme comment. r31720 20401 2008-04-08 01:37:50 -0700 2008-04-08 01:48:48 -0700 patch patch.txt text/plain 1803 alice.barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxNzE5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDQt MDggIEFsaWNlIExpdSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL21hYy9BY2Nlc3NpYmlsaXR5T2Jq ZWN0V3JhcHBlci5tbToKKyAgICAgICAgKC1bQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNj ZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOmZvclBhcmFtZXRlcjpdKToKKyAgICAgICAgSW4gdGhl IHNlY3Rpb24gb2YgY29kZSB3aGVyZSBXZWJDb3JlLWVxdWl2YWxlbnRzIG9mIG1hYy1zcGVjaWZp YyB0eXBlcyBhcmUKKyAgICAgICAgcHJlcGFyZWQsIHNvbWUgZnVuY3Rpb25zIHdlcmVuJ3QgbWVh bnQgdG8gb3BlcmF0ZSBvbiB0aGUgZGVmYXVsdCBpbml0aWFsaXplZAorICAgICAgICB2YWx1ZXMu ICBDaGVja2luZyBmb3IgbmlsIGluIGNlcnRhaW4gcGxhY2VzIHdpbGwgYmV0dGVyIG1haW50YWlu IHRoZSBvcmlnaW5hbAorICAgICAgICBwcmUtcmVmYWN0b3JpbmcgY29kZSBwYXRoLiAKKwogMjAw OC0wNC0wOCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpJbmRleDogcGFnZS9tYWMvQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGFnZS9tYWMvQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXIubW0JKHJldmlzaW9uIDMxNjk4KQorKysgcGFnZS9tYWMvQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTEyMDksOSArMTIwOSwxMyBAQCBzdGF0 aWMgUmVuZGVyT2JqZWN0KiByZW5kZXJlckZvclZpZXcoTlNWCiAgICAgfQogICAgIAogICAgIC8v IENvbnZlcnQgdmFsdWVzIHRvIFdlYkNvcmUgdHlwZXMKLSAgICBWaXNpYmxlUG9zaXRpb24gdmlz aWJsZVBvcyA9IHZpc2libGVQb3NpdGlvbkZvclRleHRNYXJrZXIodGV4dE1hcmtlcik7CisgICAg VmlzaWJsZVBvc2l0aW9uIHZpc2libGVQb3M7CisgICAgaWYgKHRleHRNYXJrZXIgIT0gbmlsKQor ICAgICAgICB2aXNpYmxlUG9zID0gdmlzaWJsZVBvc2l0aW9uRm9yVGV4dE1hcmtlcih0ZXh0TWFy a2VyKTsKICAgICBpbnQgaW50TnVtYmVyID0gW251bWJlciBpbnRWYWx1ZV07Ci0gICAgVmlzaWJs ZVBvc2l0aW9uUmFuZ2UgdmlzaWJsZVBvc1JhbmdlID0gW3NlbGYgdmlzaWJsZVBvc2l0aW9uUmFu Z2VGb3JUZXh0TWFya2VyUmFuZ2U6dGV4dE1hcmtlclJhbmdlXTsKKyAgICBWaXNpYmxlUG9zaXRp b25SYW5nZSB2aXNpYmxlUG9zUmFuZ2U7CisgICAgaWYgKHRleHRNYXJrZXJSYW5nZSAhPSBuaWwp CisgICAgICAgIHZpc2libGVQb3NSYW5nZSA9IFtzZWxmIHZpc2libGVQb3NpdGlvblJhbmdlRm9y VGV4dE1hcmtlclJhbmdlOnRleHRNYXJrZXJSYW5nZV07CiAgICAgSW50UG9pbnQgd2ViQ29yZVBv aW50ID0gSW50UG9pbnQocG9pbnQpOwogICAgIEFjY2Vzc2liaWxpdHlPYmplY3Q6OlBsYWluVGV4 dFJhbmdlIHBsYWluVGV4dFJhbmdlID0gQWNjZXNzaWJpbGl0eU9iamVjdDo6UGxhaW5UZXh0UmFu Z2UocmFuZ2UubG9jYXRpb24sIHJhbmdlLmxlbmd0aCk7CiAK