183280 2018-03-02 01:43:02 -0800 WebDriver: Also ignore NoSuchwindow errors when waiting for navigation to complete 2018-03-05 00:32:53 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg mcatanzaro webkit-bug-importer oldest_to_newest 1403179 0 cgarcia 2018-03-02 01:43:02 -0800 We currently ignore NoSuchFrame, but navigation or previous command might have closed the window too. This is causing tests imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py::testClickingOnAButtonThatClosesAnOpenWindowDoesNotCauseTheBrowserToHang and imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py::testCanCallGetWindowHandlesAfterClosingAWindow to fail _____________________________________________________ testClickingOnAButtonThatClosesAnOpenWindowDoesNotCauseTheBrowserToHang[WebKitGTK] _____________________________________________________ driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="960616c6-b34c-42c3-b33c-16aa232e92c8")>, pages = <conftest.Pages object at 0x7ff192bc7850> def testClickingOnAButtonThatClosesAnOpenWindowDoesNotCauseTheBrowserToHang(driver, pages): pages.load("xhtmlTest.html") current = driver.current_window_handle handles = driver.window_handles driver.find_element_by_name("windowThree").click() WebDriverWait(driver, 3).until(EC.new_window_is_opened(handles)) handles = driver.window_handles handles.remove(current) driver.switch_to.window(handles[0]) > driver.find_element_by_id("close").click() current = 'page-3CA6BC92-CA3D-4F35-882D-90C881FA51F8' driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="960616c6-b34c-42c3-b33c-16aa232e92c8")> handles = ['page-AE36B12C-C5EB-400D-9107-888FFAF6F63E'] pages = <conftest.Pages object at 0x7ff192bc7850> WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py:141: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webelement.py:80: in click self._execute(Command.CLICK_ELEMENT) WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webelement.py:628: in _execute return self._parent.execute(command, params) WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webdriver.py:312: in execute self.error_handler.check_response(response) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _____________________________________________________ testClickingOnAButtonThatClosesAnOpenWindowDoesNotCauseTheBrowserToHang[WebKitGTK] _____________________________________________________ driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="960616c6-b34c-42c3-b33c-16aa232e92c8")>, pages = <conftest.Pages object at 0x7ff192bc7850> def testClickingOnAButtonThatClosesAnOpenWindowDoesNotCauseTheBrowserToHang(driver, pages): pages.load("xhtmlTest.html") current = driver.current_window_handle handles = driver.window_handles driver.find_element_by_name("windowThree").click() WebDriverWait(driver, 3).until(EC.new_window_is_opened(handles)) handles = driver.window_handles handles.remove(current) driver.switch_to.window(handles[0]) > driver.find_element_by_id("close").click() current = 'page-3CA6BC92-CA3D-4F35-882D-90C881FA51F8' driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="960616c6-b34c-42c3-b33c-16aa232e92c8")> handles = ['page-AE36B12C-C5EB-400D-9107-888FFAF6F63E'] pages = <conftest.Pages object at 0x7ff192bc7850> WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py:141: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webelement.py:80: in click self._execute(Command.CLICK_ELEMENT) WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webelement.py:628: in _execute return self._parent.execute(command, params) WebDriverTests/imported/selenium/py/selenium/webdriver/remote/webdriver.py:312: in execute self.error_handler.check_response(response) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <selenium.webdriver.remote.errorhandler.ErrorHandler object at 0x7ff192bc7dd0> response = {'status': 404, 'value': '{"value":{"error":"no such window","message":"","stacktrace":""}}'} 1403181 1 334887 cgarcia 2018-03-02 02:00:16 -0800 Created attachment 334887 Patch 1403299 2 334887 bburg 2018-03-02 10:45:36 -0800 Comment on attachment 334887 Patch r=me 1403573 3 cgarcia 2018-03-05 00:31:10 -0800 Committed r229211: <https://trac.webkit.org/changeset/229211> 1403574 4 webkit-bug-importer 2018-03-05 00:32:53 -0800 <rdar://problem/38132518> 334887 2018-03-02 02:00:16 -0800 2018-03-02 10:45:36 -0800 Patch wd-click-close-window.diff text/plain 2503 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNmMyOWMyOThjZmMuLjM1OGMxOGJhM2E4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAzLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IEFsc28gaWdub3JlIE5vU3Vj aHdpbmRvdyBlcnJvcnMgd2hlbiB3YWl0aW5nIGZvciBuYXZpZ2F0aW9uIHRvIGNvbXBsZXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMyODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBjdXJyZW50 bHkgaWdub3JlIE5vU3VjaEZyYW1lLCBidXQgbmF2aWdhdGlvbiBvciBwcmV2aW91cyBjb21tYW5k IG1pZ2h0IGhhdmUgY2xvc2VkIHRoZSB3aW5kb3cgdG9vLgorCisgICAgICAgIEZpeGVzOiBpbXBv cnRlZC9zZWxlbml1bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZlci9jb21tb24vd2luZG93X3N3 aXRjaGluZ190ZXN0cy5weTo6dGVzdENsaWNraW5nT25BQnV0dG9uVGhhdENsb3Nlc0FuT3Blbldp bmRvd0RvZXNOb3RDYXVzZVRoZUJyb3dzZXJUb0hhbmcKKyAgICAgICAgICAgICAgIGltcG9ydGVk L3NlbGVuaXVtL3B5L3Rlc3Qvc2VsZW5pdW0vd2ViZHJpdmVyL2NvbW1vbi93aW5kb3dfc3dpdGNo aW5nX3Rlc3RzLnB5Ojp0ZXN0Q2FuQ2FsbEdldFdpbmRvd0hhbmRsZXNBZnRlckNsb3NpbmdBV2lu ZG93CisKKyAgICAgICAgKiBTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6U2Vzc2lv bjo6d2FpdEZvck5hdmlnYXRpb25Ub0NvbXBsZXRlKTogSWdub3JlIE5vU3VjaFdpbmRvdyBlcnJv cnMuCisKIDIwMTgtMDItMTQgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEF1dG9tYXRpb246IGNvbWJpbmUgc2Vzc2lvbiBjb21tYW5kcyB0byByZXNpemUgYW5k IG1vdmUgdG9wLWxldmVsIGJyb3dzaW5nIGNvbnRleHRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi RHJpdmVyL1Nlc3Npb24uY3BwIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcAppbmRleCA1 ZjgxN2I2MWQxNy4uMjllNTJjMmIwZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvU2Vz c2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9TZXNzaW9uLmNwcApAQCAtMTM3OCwxMCAr MTM3OCwxNiBAQCB2b2lkIFNlc3Npb246OndhaXRGb3JOYXZpZ2F0aW9uVG9Db21wbGV0ZShGdW5j dGlvbjx2b2lkIChDb21tYW5kUmVzdWx0JiYpPiYmIGNvbQogICAgIG1faG9zdC0+c2VuZENvbW1h bmRUb0JhY2tlbmQoQVNDSUlMaXRlcmFsKCJ3YWl0Rm9yTmF2aWdhdGlvblRvQ29tcGxldGUiKSwg V1RGTW92ZShwYXJhbWV0ZXJzKSwgW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlz KSwgY29tcGxldGlvbkhhbmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oU2Vzc2lv bkhvc3Q6OkNvbW1hbmRSZXNwb25zZSYmIHJlc3BvbnNlKSB7CiAgICAgICAgIGlmIChyZXNwb25z ZS5pc0Vycm9yKSB7CiAgICAgICAgICAgICBhdXRvIHJlc3VsdCA9IENvbW1hbmRSZXN1bHQ6OmZh aWwoV1RGTW92ZShyZXNwb25zZS5yZXNwb25zZU9iamVjdCkpOwotICAgICAgICAgICAgaWYgKHJl c3VsdC5lcnJvckNvZGUoKSA9PSBDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6Ok5vU3VjaEZyYW1l KSB7CisgICAgICAgICAgICBzd2l0Y2ggKHJlc3VsdC5lcnJvckNvZGUoKSkgeworICAgICAgICAg ICAgY2FzZSBDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6Ok5vU3VjaFdpbmRvdzoKKyAgICAgICAg ICAgICAgICAvLyBXaW5kb3cgd2FzIGNsb3NlZCwgcmVzZXQgdGhlIHRvcCBsZXZlbCBicm93c2lu ZyBjb250ZXh0IGFuZCBpZ25vcmUgdGhlIGVycm9yLgorICAgICAgICAgICAgICAgIG1fdG9wbGV2 ZWxCcm93c2luZ0NvbnRleHQgPSBzdGQ6Om51bGxvcHQ7CisgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICBjYXNlIENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6Tm9TdWNoRnJhbWU6 CiAgICAgICAgICAgICAgICAgLy8gTmF2aWdhdGlvbiBkZXN0cm95ZWQgdGhlIGN1cnJlbnQgZnJh bWUsIHN3aXRjaCB0byB0b3AgbGV2ZWwgYnJvd3NpbmcgY29udGV4dCBhbmQgaWdub3JlIHRoZSBl cnJvci4KICAgICAgICAgICAgICAgICBzd2l0Y2hUb0Jyb3dzaW5nQ29udGV4dChzdGQ6Om51bGxv cHQpOwotICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAg ICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RGTW92 ZShyZXN1bHQpKTsKICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9Cg==