183278 2018-03-02 01:04:05 -0800 Automation: stale elements not detected when removed from the DOM 2018-03-05 00:29:20 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg mcatanzaro webkit-bug-importer oldest_to_newest 1403172 0 cgarcia 2018-03-02 01:04:05 -0800 We detect stale elements when the page is reloaded because the maps are recreated, but if an element is removed from the DOM for the same document we keep the nodes in the maps. We should clear stale elements before accessing the maps. This causes test imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py::testExpectedConditionStalenessOf to fail. ________________________________________________________________________ testExpectedConditionStalenessOf[WebKitGTK] _________________________________________________________________________ driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="2b612d84-8003-49e2-9fa6-6629e446a25f")>, pages = <conftest.Pages object at 0x7f731a9e8190> def testExpectedConditionStalenessOf(driver, pages): pages.load('dynamicallyModifiedPage.html') element = driver.find_element_by_id('element-to-remove') with pytest.raises(TimeoutException): WebDriverWait(driver, 0.7).until(EC.staleness_of(element)) driver.find_element_by_id('buttonDelete').click() assert 'element' == element.text > WebDriverWait(driver, 0.7).until(EC.staleness_of(element)) driver = <selenium.webdriver.webkitgtk.webdriver.WebDriver (session="2b612d84-8003-49e2-9fa6-6629e446a25f")> element = <selenium.webdriver.remote.webelement.WebElement (session="2b612d84-8003-49e2-9fa6-6629e446a25f", element="node-3C1BAE7B-915C-4AFD-995D-A1A92E529ECC")> pages = <conftest.Pages object at 0x7f731a9e8190> WebDriverTests/imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py:254: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self = <selenium.webdriver.support.wait.WebDriverWait (session="2b612d84-8003-49e2-9fa6-6629e446a25f")> method = <selenium.webdriver.support.expected_conditions.staleness_of object at 0x7f731a9e8790>, message = '' def until(self, method, message=''): """Calls the method provided with the driver as an argument until the \ return value is not False.""" screen = None stacktrace = None end_time = time.time() + self._timeout while True: try: value = method(self._driver) if value: return value except self._ignored_exceptions as exc: screen = getattr(exc, 'screen', None) stacktrace = getattr(exc, 'stacktrace', None) time.sleep(self._poll) if time.time() > end_time: break > raise TimeoutException(message, screen, stacktrace) E TimeoutException: Message: end_time = 1519977653.752561 message = '' method = <selenium.webdriver.support.expected_conditions.staleness_of object at 0x7f731a9e8790> screen = None self = <selenium.webdriver.support.wait.WebDriverWait (session="2b612d84-8003-49e2-9fa6-6629e446a25f")> stacktrace = None value = False WebDriverTests/imported/selenium/py/selenium/webdriver/support/wait.py:80: TimeoutException 1403173 1 334885 cgarcia 2018-03-02 01:06:59 -0800 Created attachment 334885 Patch 1403297 2 334885 bburg 2018-03-02 10:44:08 -0800 Comment on attachment 334885 Patch I hope we don't have 1000's of nodes or this could get expensive. It would be nice to just check the validity of the requested node, but I guess any node could be requested via script. We'd have to find the web elements after transforming JS payload to elements. Let's just keep this version unless we think it's actually causing a performance problem. I like simple and brute force when we can get away with it. r=me 1403526 3 cgarcia 2018-03-04 02:24:26 -0800 (In reply to Brian Burg from comment #2) > Comment on attachment 334885 [details] > Patch > > I hope we don't have 1000's of nodes or this could get expensive. It would > be nice to just check the validity of the requested node, but I guess any > node could be requested via script. We'd have to find the web elements after > transforming JS payload to elements. I started the patch by only checking the requested node indeed. But then I realized that the node can be queried multiple times, so we could be checking more than once. Then I thought, let's see what chromium does, and they also clear the cache on every execute_script call, so I decided to do the same. > Let's just keep this version unless we think it's actually causing a > performance problem. I like simple and brute force when we can get away with > it. Ok. > r=me Thanks 1403571 4 cgarcia 2018-03-05 00:28:54 -0800 Committed r229210: <https://trac.webkit.org/changeset/229210> 1403572 5 webkit-bug-importer 2018-03-05 00:29:20 -0800 <rdar://problem/38132475> 334885 2018-03-02 01:06:59 -0800 2018-03-02 10:44:08 -0800 Patch wd-stale-elements.diff text/plain 2665 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTNmNjIwZmI2NmMuLjJiOTI0ODAxOTM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIyIEBACisyMDE4LTAzLTAyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBBdXRvbWF0aW9uOiBzdGFsZSBlbGVtZW50cyBub3QgZGV0ZWN0ZWQg d2hlbiByZW1vdmVkIGZyb20gdGhlIERPTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMjc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2UgZGV0ZWN0IHN0YWxlIGVsZW1lbnRzIHdoZW4gdGhlIHBhZ2Ug aXMgcmVsb2FkZWQgYmVjYXVzZSB0aGUgbWFwcyBhcmUgcmVjcmVhdGVkLCBidXQgaWYgYW4gZWxl bWVudCBpcyByZW1vdmVkCisgICAgICAgIGZyb20gdGhlIERPTSBmb3IgdGhlIHNhbWUgZG9jdW1l bnQgd2Uga2VlcCB0aGUgbm9kZXMgaW4gdGhlIG1hcHMuIFdlIHNob3VsZCBjbGVhciBzdGFsZSBl bGVtZW50cyBiZWZvcmUKKyAgICAgICAgYWNjZXNzaW5nIHRoZSBtYXBzLgorCisgICAgICAgIEZp eGVzOiBpbXBvcnRlZC9zZWxlbml1bS9weS90ZXN0L3NlbGVuaXVtL3dlYmRyaXZlci9jb21tb24v d2ViZHJpdmVyd2FpdF90ZXN0cy5weTo6dGVzdEV4cGVjdGVkQ29uZGl0aW9uU3RhbGVuZXNzT2YK KworICAgICAgICAqIFdlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblBy b3h5LmpzOgorICAgICAgICAobGV0LkF1dG9tYXRpb25TZXNzaW9uUHJveHkucHJvdG90eXBlLmV2 YWx1YXRlSmF2YVNjcmlwdEZ1bmN0aW9uKTogQ2FsbCBfY2xlYXJTdGFsZU5vZGVzKCkKKyAgICAg ICAgKGxldC5BdXRvbWF0aW9uU2Vzc2lvblByb3h5LnByb3RvdHlwZS5ub2RlRm9ySWRlbnRpZmll cik6IERpdHRvLgorICAgICAgICAobGV0LkF1dG9tYXRpb25TZXNzaW9uUHJveHkucHJvdG90eXBl Ll9jbGVhclN0YWxlTm9kZXMpOiBDaGVjayBpZiBjYWNoZWQgbm9kZXMgYXJlIHN0aWxsIGluIGRv Y3VtZW50IGFuZCByZW1vdmUgdGhlbQorICAgICAgICBmcm9tIHRoZSBtYXBzIGlmIHRoZXkgYXJl bid0LgorCiAyMDE4LTAzLTAxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjI5MTUzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Np b25Qcm94eS5qcyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9t YXRpb25TZXNzaW9uUHJveHkuanMKaW5kZXggZTE0NWU3NGVkNzYuLjBiMmMwZmQ3NTIyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9u U2Vzc2lvblByb3h5LmpzCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9u L1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuanMKQEAgLTQ2LDYgKzQ2LDggQEAgbGV0IEF1dG9t YXRpb25TZXNzaW9uUHJveHkgPSBjbGFzcyBBdXRvbWF0aW9uU2Vzc2lvblByb3h5CiAgICAgICAg IGlmICh0eXBlb2YgZnVuY3Rpb25WYWx1ZSAhPT0gImZ1bmN0aW9uIikKICAgICAgICAgICAgIHRo cm93IG5ldyBUeXBlRXJyb3IoIlNjcmlwdCBkaWQgbm90IGV2YWx1YXRlIHRvIGEgZnVuY3Rpb24u Iik7CiAKKyAgICAgICAgdGhpcy5fY2xlYXJTdGFsZU5vZGVzKCk7CisKICAgICAgICAgbGV0IGFy Z3VtZW50VmFsdWVzID0gYXJndW1lbnRTdHJpbmdzLm1hcCh0aGlzLl9qc29uUGFyc2UsIHRoaXMp OwogCiAgICAgICAgIGxldCB0aW1lb3V0SWRlbnRpZmllciA9IDA7CkBAIC03MCw2ICs3Miw3IEBA IGxldCBBdXRvbWF0aW9uU2Vzc2lvblByb3h5ID0gY2xhc3MgQXV0b21hdGlvblNlc3Npb25Qcm94 eQogCiAgICAgbm9kZUZvcklkZW50aWZpZXIoaWRlbnRpZmllcikKICAgICB7CisgICAgICAgIHRo aXMuX2NsZWFyU3RhbGVOb2RlcygpOwogICAgICAgICB0cnkgewogICAgICAgICAgICAgcmV0dXJu IHRoaXMuX25vZGVGb3JJZGVudGlmaWVyKGlkZW50aWZpZXIpOwogICAgICAgICB9IGNhdGNoIChl cnJvcikgewpAQCAtMTM1LDYgKzEzOCwxNiBAQCBsZXQgQXV0b21hdGlvblNlc3Npb25Qcm94eSA9 IGNsYXNzIEF1dG9tYXRpb25TZXNzaW9uUHJveHkKIAogICAgICAgICByZXR1cm4gaWRlbnRpZmll cjsKICAgICB9CisKKyAgICBfY2xlYXJTdGFsZU5vZGVzKCkKKyAgICB7CisgICAgICAgIGZvciAo dmFyIFtub2RlLCBpZGVudGlmaWVyXSBvZiB0aGlzLl9ub2RlVG9JZE1hcCkgeworICAgICAgICAg ICAgaWYgKCFkb2N1bWVudC5jb250YWlucyhub2RlKSkgeworICAgICAgICAgICAgICAgIHRoaXMu X25vZGVUb0lkTWFwLmRlbGV0ZShub2RlKTsKKyAgICAgICAgICAgICAgICB0aGlzLl9pZFRvTm9k ZU1hcC5kZWxldGUoaWRlbnRpZmllcik7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9 CiB9OwogCiByZXR1cm4gbmV3IEF1dG9tYXRpb25TZXNzaW9uUHJveHk7Cg==