183242 2018-03-01 05:30:45 -0800 Crash when updating cache entry after validation in app that uses class A file protection 2018-03-01 09:11:39 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned beidson cdumez cgarcia commit-queue ews-watchlist oldest_to_newest 1402869 0 koivisto 2018-03-01 05:30:45 -0800 We have network process crashes with some apps when trying to update cache entry after validation: Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Subtype: unknown at 0x0000000106d70000 VM Region Info: 0x106d70000 is in 0x106d70000-0x106da0000; bytes after start: 0 bytes before end: 196607 REGION TYPE START - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL MALLOC_LARGE 0000000106d5c000-0000000106d70000 [ 80K] rw-/rwx SM=PRV ---> mapped file 0000000106d70000-0000000106da0000 [ 192K] r--/rw- SM=COW MALLOC_LARGE 0000000106da0000-0000000106db4000 [ 80K] rw-/rwx SM=PRV Thread 0 name: Dispatch queue: com.apple.main-thread Thread 0 Crashed ↩: 0 libsystem_platform.dylib 0x0000000181064a00 _platform_memmove + 48 1 WebCore 0x000000018ad73e70 WebCore::SharedBuffer::append(char const*, unsigned long) + 148 (Vector.h:159) 2 WebCore 0x000000018ad73fdc WebCore::SharedBuffer::SharedBuffer(unsigned char const*, unsigned long) + 52 (SharedBuffer.cpp:47) 3 WebKit 0x000000019157fa1c WebKit::NetworkCache::Entry::initializeBufferFromStorageRecord() const + 160 (SharedBuffer.h:59) 4 WebKit 0x000000019157faa4 WebKit::NetworkCache::Entry::buffer() const + 32 (NetworkCacheEntry.cpp:176) 5 WebKit 0x000000019157bb88 WebKit::NetworkCache::Cache::update(WebCore::ResourceRequest const&, std::__1::pair<unsigned long long, unsigned long long> const&, WebKit::NetworkCache::Entry const&, WebCore::ResourceResponse const&) + 124 (NetworkCache.cpp:477) 6 WebKit 0x00000001915cbc78 WebKit::NetworkResourceLoader::didReceiveResponse(WebCore::ResourceResponse&&) + 460 (NetworkResourceLoader.cpp:337) 7 WebKit 0x00000001915b87a0 WebKit::NetworkLoad::notifyDidReceiveResponse(WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::PolicyAction)>&&) + 88 (NetworkLoad.cpp:255) 8 WebKit 0x00000001915b0fec WebKit::NetworkDataTask::didReceiveResponse(WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::PolicyAction)>&&) + 344 (NetworkDataTask.cpp:112) 9 WebKit 0x00000001915d8714 -[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:] + 304 (NetworkSessionCocoa.mm:481) They are caused by protection class A files becoming inaccessible after device is locked. 1402870 1 koivisto 2018-03-01 05:31:13 -0800 <rdar://problem/33289058> 1402872 2 334809 koivisto 2018-03-01 05:47:38 -0800 Created attachment 334809 patch 1402916 3 334809 commit-queue 2018-03-01 09:11:38 -0800 Comment on attachment 334809 patch Clearing flags on attachment: 334809 Committed r229134: <https://trac.webkit.org/changeset/229134> 1402917 4 commit-queue 2018-03-01 09:11:39 -0800 All reviewed patches have been landed. Closing bug. 334809 2018-03-01 05:47:38 -0800 2018-03-01 09:11:38 -0800 patch cache-class-a-validation-crash.patch text/plain 2423 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjkxMzApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTAzLTAxICBBbnR0aSBLb2l2 aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB3aGVuIHVwZGF0aW5nIGNh Y2hlIGVudHJ5IGFmdGVyIHZhbGlkYXRpb24gaW4gYXBwcyB0aGF0IHVzZXMgY2xhc3MgQSBmaWxl IHByb3RlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4MzI0MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzMyODkwNTg+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB2YWxpZGF0aW5nIGEg Y2FjaGUgZW50cnksIHdlIGtlZXAgaXQgYWxpdmUgdW50aWwgd2UgZ2V0IGEgbmV0d29yayByZXNw b25zZS4gV2l0aCAzMDQgcmVzcG9uc2UKKyAgICAgICAgd2UgdGhlbiB1cGRhdGUgdGhlIGhlYWRl cnMgb2YgdGhpcyBleGlzdGluZyBlbnRyeS4gVGhpcyBhY2Nlc3NlcyB0aGUgYm9keSBkYXRhIG9m IHRoZSBlbnRyeSB3aGljaAorICAgICAgICBtYXkgYmUgYmFja2VkIGJ5IGEgbWFwcGVkIGZpbGUu IElmIHRoZSBhcHAgdXNlcyBjbGFzcyBBIHByb3RlY3Rpb24sIHVzZXIgbWlnaHQgaGF2ZSBsb2Nr ZWQKKyAgICAgICAgdGhlIGRldmljZSBhbmQgdGhlIGVudHJ5IG1pZ2h0IGhhdmUgYmVjb21lIGlu YWNjZXNzaWJsZSwgbGVhZGluZyB0byBhIGNyYXNoLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlRW50cnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3Jr Q2FjaGU6OkVudHJ5OjpzZXROZWVkc1ZhbGlkYXRpb24pOgorCisgICAgICAgIEluIGNhc2Ugb2Yg Y2xhc3MgQSBwcm90ZWN0aW9uLCBwdWxsIHRoZSBkYXRhIHRvIGEgbWVtb3J5IGJ1ZmZlciBpbW1l ZGlhdGVseSBiZWZvcmUgc3RhcnRpbmcgYSByZXZhbGlkYXRpb24gcmVxdWVzdC4KKyAgICAgICAg VGhpcyBtYWtlcyB0aGUgd2luZG93IHdoZXJlIHRoZSBmaWxlIGNvdWxkIGJlY29tZSBpbmFjY2Vz c2libGUgbXVjaCBzaG9ydGVyIChzaW5jZSBpdCBubyBsb25nZXIgZGVwZW5kcyBvbiBuZXR3b3Jr KS4KKwogMjAxOC0wMy0wMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjIxNTE0KTogW0dUS10gVUkgcHJvY2VzcyBjcmFz aCBpbiBXZWJLaXQ6OldheWxhbmRDb21wb3NpdG9yOjpTdXJmYWNlOjpmbHVzaFBlbmRpbmdGcmFt ZUNhbGxiYWNrcwpJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3 b3JrQ2FjaGVFbnRyeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVFbnRyeS5jcHAJKHJldmlzaW9uIDIyODg5MSkKKysrIFNv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlRW50cnkuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xOTUsNiArMTk1LDEzIEBAIGJvb2wgRW50cnk6Om5lZWRzVmFsaWRh dGlvbigpIGNvbnN0CiAKIHZvaWQgRW50cnk6OnNldE5lZWRzVmFsaWRhdGlvbihib29sIHZhbHVl KQogeworICAgIGlmICh2YWx1ZSkgeworICAgICAgICAvLyBWYWxpZGF0aW9uIGtlZXBzIHRoZSBl bnRyeSBhbGl2ZSB3YWl0aW5nIGZvciB0aGUgbmV0d29yayByZXNwb25zZS4gUHVsbCBkYXRhIGZy b20gYSBtYXBwZWQgZmlsZSBpbnRvIGEgYnVmZmVyIGVhcmx5CisgICAgICAgIC8vIHRvIHByb3Rl Y3QgYWdhaW5zdCBtYXAgZGlzYXBwZWFyaW5nIGR1ZSB0byBkZXZpY2UgYmVjb21pbmcgbG9ja2Vk LgorICAgICAgICAvLyBGSVhNRTogQ2FjaGUgZmlsZXMgc2hvdWxkIGJlIENsYXNzIEIvQywgb3Ig d2Ugc2hvdWRuJ3QgdXNlIG1hcHBlZCBmaWxlcyBhdCBhbGwgaW4gdGhlc2UgY2FzZXMuCisgICAg ICAgIGlmICghTmV0d29ya1Byb2Nlc3M6OnNpbmdsZXRvbigpLmNhY2hlKCktPmNhblVzZVNoYXJl ZE1lbW9yeUZvckJvZHlEYXRhKCkpCisgICAgICAgICAgICBidWZmZXIoKTsKKyAgICB9CiAgICAg bV9yZXNwb25zZS5zZXRTb3VyY2UodmFsdWUgPyBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpT b3VyY2U6OkRpc2tDYWNoZUFmdGVyVmFsaWRhdGlvbiA6IFdlYkNvcmU6OlJlc291cmNlUmVzcG9u c2U6OlNvdXJjZTo6RGlza0NhY2hlKTsKIH0KIAo=