183238 2018-02-28 18:44:49 -0800 [Curl] Linker errors in some curl files due to missing exports 2018-03-01 09:00:45 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen bfulgham commit-queue darin don.olmstead ews-watchlist galpeter pvollan webkit-bug-importer oldest_to_newest 1402814 0 chris.reid 2018-02-28 18:44:49 -0800 19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::operator= (WebCore::CurlProxySettings const&)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebProcessPool.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CurlContext::singleton()' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::setUserPass(WTF::String const&, WTF::String const&)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::isolatedCopy() const' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkProcessCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::CurlProxySettings(WebCore::CurlProxySettings::Mode)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CurlProxySettings::CurlProxySettings(WebCore::URL const&, WTF::String)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CookieJarDB::CookieJarDB(WTF::String const&)' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::CookieJarDB::~CookieJarDB()' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o" 19>Link : error : L0039: reference to undefined symbol `WebCore::NetworkStorageSession::setCookieDatabase(WTF::UniqueRef<WebCore::CookieJarDB>&&) const' in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o" 1402815 1 334794 chris.reid 2018-02-28 19:00:22 -0800 Created attachment 334794 Patch 1402816 2 chris.reid 2018-02-28 19:06:29 -0800 (In reply to Christopher Reid from comment #0) > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CurlProxySettings::operator= (WebCore::CurlProxySettings const&)' > in file "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebProcessPool.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CurlContext::singleton()' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CurlProxySettings::setUserPass(WTF::String const&, WTF::String > const&)' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkDataTaskCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CurlProxySettings::isolatedCopy() const' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\NetworkProcessCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CurlProxySettings::CurlProxySettings(WebCore::CurlProxySettings:: > Mode)' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CurlProxySettings::CurlProxySettings(WebCore::URL const&, > WTF::String)' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCoreArgumentCodersCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CookieJarDB::CookieJarDB(WTF::String const&)' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::CookieJarDB::~CookieJarDB()' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o" > 19>Link : error : L0039: reference to undefined symbol > `WebCore::NetworkStorageSession::setCookieDatabase(WTF::UniqueRef<WebCore:: > CookieJarDB>&&) const' in file > "WebKitBuild\Source\WebKit\WebKit.dir\Debug\WebCookieManagerCurl.o" I was mistaken about the CurlProxySettings errors, they don't apply to trunk. All the other errors occur. 1402907 3 334794 commit-queue 2018-03-01 08:59:48 -0800 Comment on attachment 334794 Patch Clearing flags on attachment: 334794 Committed r229132: <https://trac.webkit.org/changeset/229132> 1402908 4 commit-queue 2018-03-01 08:59:49 -0800 All reviewed patches have been landed. Closing bug. 1402909 5 webkit-bug-importer 2018-03-01 09:00:45 -0800 <rdar://problem/38028715> 334794 2018-02-28 19:00:22 -0800 2018-03-01 08:59:48 -0800 Patch 183238.diff text/plain 2419 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZDcyOTkyYzdlOS4uMTg4MDNkNjUwYmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wMi0yOCAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIExpbmtlciBlcnJvcnMgaW4gc29tZSBjdXJsIGZpbGVz IGR1ZSB0byBtaXNzaW5nIGV4cG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4MzIzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisg ICAgICAgIEFkZGluZyBXRUJDT1JFX0VYUE9SVCB0byBmdW5jdGlvbnMgbm93IHVzZWQgaW4gV2Vi S2l0LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Npb24u aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyREIuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuaDoKKwogMjAxOC0wMi0yOCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl ZHVjZSB1c2Ugb2YgTmV0d29ya2luZ0NvbnRleHQgaW4gV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Npb24uaAppbmRl eCA0ZmIzZWIyY2E0Mi4uNDQwNzZlNzNmZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Npb24uaApAQCAtMTI4LDcgKzEy OCw3IEBAIHB1YmxpYzoKIAogICAgIGNvbnN0IENvb2tpZUphckN1cmwmIGNvb2tpZVN0b3JhZ2Uo KSBjb25zdCB7IHJldHVybiBtX2Nvb2tpZVN0b3JhZ2U7IH07CiAgICAgQ29va2llSmFyREImIGNv b2tpZURhdGFiYXNlKCkgY29uc3Q7Ci0gICAgdm9pZCBzZXRDb29raWVEYXRhYmFzZShVbmlxdWVS ZWY8Q29va2llSmFyREI+JiYpIGNvbnN0OworICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0Q29v a2llRGF0YWJhc2UoVW5pcXVlUmVmPENvb2tpZUphckRCPiYmKSBjb25zdDsKIAogICAgIE5ldHdv cmtpbmdDb250ZXh0KiBjb250ZXh0KCkgY29uc3Q7CiAjZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckRCLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyREIuaAppbmRleCA1Zjk4M2IyOGE3 My4uZThlODk3NDIzOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9Db29raWVKYXJEQi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9Db29raWVKYXJEQi5oCkBAIC01Miw4ICs1Miw4IEBAIHB1YmxpYzoKICAgICBpbnQg ZGVsZXRlQ29va2llcyhjb25zdCBTdHJpbmcmIHVybCk7CiAgICAgaW50IGRlbGV0ZUFsbENvb2tp ZXMoKTsKIAotICAgIENvb2tpZUphckRCKGNvbnN0IFN0cmluZyYgZGF0YWJhc2VQYXRoKTsKLSAg ICB+Q29va2llSmFyREIoKTsKKyAgICBXRUJDT1JFX0VYUE9SVCBDb29raWVKYXJEQihjb25zdCBT dHJpbmcmIGRhdGFiYXNlUGF0aCk7CisgICAgV0VCQ09SRV9FWFBPUlQgfkNvb2tpZUphckRCKCk7 CiAKIHByaXZhdGU6CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9DdXJsQ29udGV4dC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL0N1cmxDb250ZXh0LmgKaW5kZXggZjUyYmQ1NWI1NjkuLmY0YTBmMGViMDhmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuaApA QCAtMTAzLDcgKzEwMyw3IEBAIHB1YmxpYzoKICAgICAgICAgY29uc3QgU3RyaW5nIHVybCgpIGNv bnN0OwogICAgIH07CiAKLSAgICBzdGF0aWMgQ3VybENvbnRleHQmIHNpbmdsZXRvbigpOworICAg IFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBDdXJsQ29udGV4dCYgc2luZ2xldG9uKCk7CiAKICAgICB2 aXJ0dWFsIH5DdXJsQ29udGV4dCgpOwogCg==