183232 2018-02-28 16:43:01 -0800 Layout Test accessibility/mac/accessibility-make-first-responder.html is flaky 2018-02-28 18:17:27 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=182752 InRadar P2 Normal --- 1 jlewis3 webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni ews-watchlist jcraig jdiggs lforschler n_wang rniwa samuel_white webkit-bug-importer oldest_to_newest 1402775 0 jlewis3 2018-02-28 16:43:01 -0800 The following layout test is flaky on [insert platform] accessibility/mac/accessibility-make-first-responder.html Probable cause: Failed since being added in Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Faccessibility-make-first-responder.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229106%20(3180)/results.html Diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/accessibility/mac/accessibility-make-first-responder-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/accessibility/mac/accessibility-make-first-responder-actual.txt @@ -6,7 +6,7 @@ DOM focus Window is still the first responder: true Accessibility focus -Window is still the first responder: false +Window is still the first responder: true PASS successfullyParsed is true TEST COMPLETE 1402777 1 jlewis3 2018-02-28 16:46:14 -0800 The platform is currently High Sierra Release WK2 1402793 2 334788 n_wang 2018-02-28 17:29:07 -0800 Created attachment 334788 patch fix the test 1402795 3 334788 cfleizach 2018-02-28 17:30:34 -0800 Comment on attachment 334788 patch View in context: https://bugs.webkit.org/attachment.cgi?id=334788&action=review > LayoutTests/ChangeLog:11 > + extra new line > LayoutTests/accessibility/mac/accessibility-make-first-responder.html:62 > + setTimeout( setTimeout(function() { 1402797 4 334791 n_wang 2018-02-28 17:37:43 -0800 Created attachment 334791 patch update 1402808 5 334791 commit-queue 2018-02-28 18:15:28 -0800 Comment on attachment 334791 patch Clearing flags on attachment: 334791 Committed r229118: <https://trac.webkit.org/changeset/229118> 1402809 6 commit-queue 2018-02-28 18:15:30 -0800 All reviewed patches have been landed. Closing bug. 1402811 7 webkit-bug-importer 2018-02-28 18:17:27 -0800 <rdar://problem/38010208> 334788 2018-02-28 17:29:07 -0800 2018-02-28 17:37:43 -0800 patch patch.txt text/plain 2941 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyOTExNSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAyLTI4ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgYWNjZXNzaWJpbGl0eS9tYWMvYWNj ZXNzaWJpbGl0eS1tYWtlLWZpcnN0LXJlc3BvbmRlci5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMyMzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCBpcyBmbGFreSBi ZWNhdXNlIHRoYXQgdGhlIFVJUHJvY2VzcyBtaWdodCBoYXZlIHJlY2VpdmVkIHRoZSBJUEMgbWVz c2FnZQorICAgICAgICB0byBzZXQgdGhlIGZpcnN0IHJlc3BvbmRlciBhZnRlciB3ZSBjaGVjayB0 aGUgY3VycmVudCBzdGF0ZS4gQWRkZWQgYSBkZWxheSAKKyAgICAgICAgaW4gdGhlIHRlc3QgdG8g Zml4IHRoYXQuCisKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL2FjY2Vzc2liaWxpdHkt bWFrZS1maXJzdC1yZXNwb25kZXIuaHRtbDoKKwogMjAxOC0wMi0yOCAgTmFuIFdhbmcgIDxuX3dh bmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBBT006IERpc3BhdGNoIGFjY2Vzc2libGVzZXR2 YWx1ZSBldmVudApJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYWNjZXNzaWJp bGl0eS1tYWtlLWZpcnN0LXJlc3BvbmRlci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2FjY2Vzc2liaWxpdHkvbWFjL2FjY2Vzc2liaWxpdHktbWFrZS1maXJzdC1yZXNwb25kZXIuaHRt bAkocmV2aXNpb24gMjI5MTE1KQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYWNj ZXNzaWJpbGl0eS1tYWtlLWZpcnN0LXJlc3BvbmRlci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00 MCwxMiArNDAsMTcgQEAKICAgICAgICAgdmFyIGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImlucHV0Iik7CiAgICAgICAgIGRlYnVnKCJET00gZm9jdXMiKTsKICAgICAgICAgaW5wdXQu Zm9jdXMoKTsKLSAgICAgICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChpc1dpbmRvd0ZpcnN0UmVz cG9uZGVyU2NyaXB0KCksIGZ1bmN0aW9uKHJlc3VsdCkgewotICAgICAgICAgICAgZGVidWcoIldp bmRvdyBpcyBzdGlsbCB0aGUgZmlyc3QgcmVzcG9uZGVyOiAiICsgcmVzdWx0KTsKLSAgICAgICAg ICAgIGlucHV0LmJsdXIoKTsKLSAgICAgICAgICAgIC8vIDIuIE5vdyBtYWtlIHN1cmUgYWNjZXNz aWJpbGl0eSBmb2N1cyB3aWxsIG1ha2Ugd2ViIGNvbnRlbnQgdGhlIGZpcnN0IHJlc3BvbmRlci4K LSAgICAgICAgICAgIHRlc3RBY2Nlc3NpYmlsaXR5TWFrZUZpcnN0UmVzb25kZXIoKTsKLSAgICAg ICAgfSk7CisgICAgICAgIC8vIEdpdmUgaXQgc29tZSBkZWxheSBmb3IgdGhlIElQQyB0byBoYXBw ZW4uCisgICAgICAgIHNldFRpbWVvdXQoCisgICAgICAgIGZ1bmN0aW9uKCl7IAorICAgICAgICAg ICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChpc1dpbmRvd0ZpcnN0UmVzcG9uZGVyU2NyaXB0KCks IGZ1bmN0aW9uKHJlc3VsdCkgeworICAgICAgICAgICAgICAgIGRlYnVnKCJXaW5kb3cgaXMgc3Rp bGwgdGhlIGZpcnN0IHJlc3BvbmRlcjogIiArIHJlc3VsdCk7CisgICAgICAgICAgICAgICAgaW5w dXQuYmx1cigpOworICAgICAgICAgICAgICAgIC8vIDIuIE5vdyBtYWtlIHN1cmUgYWNjZXNzaWJp bGl0eSBmb2N1cyB3aWxsIG1ha2Ugd2ViIGNvbnRlbnQgdGhlIGZpcnN0IHJlc3BvbmRlci4KKyAg ICAgICAgICAgICAgICB0ZXN0QWNjZXNzaWJpbGl0eU1ha2VGaXJzdFJlc29uZGVyKCk7CisgICAg ICAgICAgICB9KTsKKyAgICAgICAgfSwgCisgICAgICAgIDEwMCk7CiAgICAgfQogICAgIAogICAg IGZ1bmN0aW9uIHRlc3RBY2Nlc3NpYmlsaXR5TWFrZUZpcnN0UmVzb25kZXIoKSB7CkBAIC01Mywx MCArNTgsMTUgQEAKICAgICAgICAgICAgIHZhciBpbnB1dE9iaiA9IGFjY2Vzc2liaWxpdHlDb250 cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgiaW5wdXQiKTsKICAgICAgICAgICAgIGRlYnVn KCJBY2Nlc3NpYmlsaXR5IGZvY3VzIikKICAgICAgICAgICAgIGlucHV0T2JqLnRha2VGb2N1cygp OwotICAgICAgICAgICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChpc1dpbmRvd0ZpcnN0UmVzcG9u ZGVyU2NyaXB0KCksIGZ1bmN0aW9uKHJlc3VsdCkgewotICAgICAgICAgICAgICAgIGRlYnVnKCJX aW5kb3cgaXMgc3RpbGwgdGhlIGZpcnN0IHJlc3BvbmRlcjogIiArIHJlc3VsdCk7Ci0gICAgICAg ICAgICAgICAgZmluaXNoVGVzdCgpOwotICAgICAgICAgICAgfSk7CisgICAgICAgICAgICAvLyBH aXZlIGl0IHNvbWUgZGVsYXkgZm9yIHRoZSBJUEMgdG8gaGFwcGVuLgorICAgICAgICAgICAgc2V0 VGltZW91dCgKKyAgICAgICAgICAgIGZ1bmN0aW9uKCl7IAorICAgICAgICAgICAgICAgIHRlc3RS dW5uZXIucnVuVUlTY3JpcHQoaXNXaW5kb3dGaXJzdFJlc3BvbmRlclNjcmlwdCgpLCBmdW5jdGlv bihyZXN1bHQpIHsKKyAgICAgICAgICAgICAgICAgICAgZGVidWcoIldpbmRvdyBpcyBzdGlsbCB0 aGUgZmlyc3QgcmVzcG9uZGVyOiAiICsgcmVzdWx0KTsKKyAgICAgICAgICAgICAgICAgICAgZmlu aXNoVGVzdCgpOworICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgfSwKKyAgICAgICAg ICAgIDEwMCk7CiAgICAgICAgIH0KICAgICB9CiAgICAgCg== 334791 2018-02-28 17:37:43 -0800 2018-02-28 18:15:28 -0800 patch patch.txt text/plain 2892 n_wang SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyOTExNSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTAyLTI4ICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgYWNjZXNzaWJpbGl0eS9tYWMvYWNj ZXNzaWJpbGl0eS1tYWtlLWZpcnN0LXJlc3BvbmRlci5odG1sIGlzIGZsYWt5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMyMzIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdGVzdCBpcyBmbGFreSBi ZWNhdXNlIHRoYXQgdGhlIFVJUHJvY2VzcyBtaWdodCBoYXZlIHJlY2VpdmVkIHRoZSBJUEMgbWVz c2FnZQorICAgICAgICB0byBzZXQgdGhlIGZpcnN0IHJlc3BvbmRlciBhZnRlciB3ZSBjaGVjayB0 aGUgY3VycmVudCBzdGF0ZS4gQWRkZWQgYSBkZWxheSAKKyAgICAgICAgaW4gdGhlIHRlc3QgdG8g Zml4IHRoYXQuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9hY2Nlc3NpYmlsaXR5LW1h a2UtZmlyc3QtcmVzcG9uZGVyLmh0bWw6CisKIDIwMTgtMDItMjggIE5hbiBXYW5nICA8bl93YW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQU9NOiBEaXNwYXRjaCBhY2Nlc3NpYmxlc2V0dmFs dWUgZXZlbnQKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FjY2Vzc2liaWxp dHktbWFrZS1maXJzdC1yZXNwb25kZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L21hYy9hY2Nlc3NpYmlsaXR5LW1ha2UtZmlyc3QtcmVzcG9uZGVyLmh0bWwJ KHJldmlzaW9uIDIyOTExNSkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FjY2Vz c2liaWxpdHktbWFrZS1maXJzdC1yZXNwb25kZXIuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNDAs MTIgKzQwLDE1IEBACiAgICAgICAgIHZhciBpbnB1dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJpbnB1dCIpOwogICAgICAgICBkZWJ1ZygiRE9NIGZvY3VzIik7CiAgICAgICAgIGlucHV0LmZv Y3VzKCk7Ci0gICAgICAgIHRlc3RSdW5uZXIucnVuVUlTY3JpcHQoaXNXaW5kb3dGaXJzdFJlc3Bv bmRlclNjcmlwdCgpLCBmdW5jdGlvbihyZXN1bHQpIHsKLSAgICAgICAgICAgIGRlYnVnKCJXaW5k b3cgaXMgc3RpbGwgdGhlIGZpcnN0IHJlc3BvbmRlcjogIiArIHJlc3VsdCk7Ci0gICAgICAgICAg ICBpbnB1dC5ibHVyKCk7Ci0gICAgICAgICAgICAvLyAyLiBOb3cgbWFrZSBzdXJlIGFjY2Vzc2li aWxpdHkgZm9jdXMgd2lsbCBtYWtlIHdlYiBjb250ZW50IHRoZSBmaXJzdCByZXNwb25kZXIuCi0g ICAgICAgICAgICB0ZXN0QWNjZXNzaWJpbGl0eU1ha2VGaXJzdFJlc29uZGVyKCk7Ci0gICAgICAg IH0pOworICAgICAgICAvLyBHaXZlIGl0IHNvbWUgZGVsYXkgZm9yIHRoZSBJUEMgdG8gaGFwcGVu LgorICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCl7IAorICAgICAgICAgICAgdGVzdFJ1bm5l ci5ydW5VSVNjcmlwdChpc1dpbmRvd0ZpcnN0UmVzcG9uZGVyU2NyaXB0KCksIGZ1bmN0aW9uKHJl c3VsdCkgeworICAgICAgICAgICAgICAgIGRlYnVnKCJXaW5kb3cgaXMgc3RpbGwgdGhlIGZpcnN0 IHJlc3BvbmRlcjogIiArIHJlc3VsdCk7CisgICAgICAgICAgICAgICAgaW5wdXQuYmx1cigpOwor ICAgICAgICAgICAgICAgIC8vIDIuIE5vdyBtYWtlIHN1cmUgYWNjZXNzaWJpbGl0eSBmb2N1cyB3 aWxsIG1ha2Ugd2ViIGNvbnRlbnQgdGhlIGZpcnN0IHJlc3BvbmRlci4KKyAgICAgICAgICAgICAg ICB0ZXN0QWNjZXNzaWJpbGl0eU1ha2VGaXJzdFJlc29uZGVyKCk7CisgICAgICAgICAgICB9KTsK KyAgICAgICAgfSwgMTAwKTsKICAgICB9CiAgICAgCiAgICAgZnVuY3Rpb24gdGVzdEFjY2Vzc2li aWxpdHlNYWtlRmlyc3RSZXNvbmRlcigpIHsKQEAgLTUzLDEwICs1NiwxMyBAQAogICAgICAgICAg ICAgdmFyIGlucHV0T2JqID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1l bnRCeUlkKCJpbnB1dCIpOwogICAgICAgICAgICAgZGVidWcoIkFjY2Vzc2liaWxpdHkgZm9jdXMi KQogICAgICAgICAgICAgaW5wdXRPYmoudGFrZUZvY3VzKCk7Ci0gICAgICAgICAgICB0ZXN0UnVu bmVyLnJ1blVJU2NyaXB0KGlzV2luZG93Rmlyc3RSZXNwb25kZXJTY3JpcHQoKSwgZnVuY3Rpb24o cmVzdWx0KSB7Ci0gICAgICAgICAgICAgICAgZGVidWcoIldpbmRvdyBpcyBzdGlsbCB0aGUgZmly c3QgcmVzcG9uZGVyOiAiICsgcmVzdWx0KTsKLSAgICAgICAgICAgICAgICBmaW5pc2hUZXN0KCk7 Ci0gICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIC8vIEdpdmUgaXQgc29tZSBkZWxheSBmb3Ig dGhlIElQQyB0byBoYXBwZW4uCisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCl7IAor ICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIucnVuVUlTY3JpcHQoaXNXaW5kb3dGaXJzdFJlc3Bv bmRlclNjcmlwdCgpLCBmdW5jdGlvbihyZXN1bHQpIHsKKyAgICAgICAgICAgICAgICAgICAgZGVi dWcoIldpbmRvdyBpcyBzdGlsbCB0aGUgZmlyc3QgcmVzcG9uZGVyOiAiICsgcmVzdWx0KTsKKyAg ICAgICAgICAgICAgICAgICAgZmluaXNoVGVzdCgpOworICAgICAgICAgICAgICAgIH0pOworICAg ICAgICAgICAgfSwgMTAwKTsKICAgICAgICAgfQogICAgIH0KICAgICAK