183230 2018-02-28 15:57:15 -0800 Web Automation: script evaluations via WebDriver should have a user gesture indicator 2018-03-04 14:59:24 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg aestes bburg bfulgham cgarcia darin joepeck thorton webkit-bug-importer oldest_to_newest 1402756 0 bburg 2018-02-28 15:57:15 -0800 Some JS/DOM APIs only work require a user gesture indicator. Since there is no real user input when running via WebDriver, these APIs can only be tested if WebDriver code has a synthetic user gesture indicator, or explicit checks for a user gesture indicator should also allow usage iff page->isControlledByAutomation(). It would be nice to do the first approach since only one source location is needed. However, it's possible via WebDriver to evaluate "async" JavaScript which calls a completion handler some arbitrary amount of time later. The naive approach to set a user gesture indicator would only allow gesture-requiring API calls that happen synchronously. So, we need to either set a user gesture indicator using non-RAII code, or audit every single check and add || page->isControlledByAutomation() to the condition. 1402759 1 bburg 2018-02-28 15:58:58 -0800 <rdar://problem/37959739> 1402765 2 bburg 2018-02-28 16:06:52 -0800 (In reply to Brian Burg from comment #0) > Some JS/DOM APIs only work require a user gesture indicator. Since there is > no real user input when running via WebDriver, these APIs can only be tested > if WebDriver code has a synthetic user gesture indicator, or explicit checks > for a user gesture indicator should also allow usage iff > page->isControlledByAutomation(). > > It would be nice to do the first approach since only one source location is > needed. However, it's possible via WebDriver to evaluate "async" JavaScript > which calls a completion handler some arbitrary amount of time later. The > naive approach to set a user gesture indicator would only allow > gesture-requiring API calls that happen synchronously. > > So, we need to either set a user gesture indicator using non-RAII code, or > audit every single check and add || page->isControlledByAutomation() to the > condition. Actually, it seems like DOMTimer and some other async code will forward the user gesture, so maybe using the UserGestureIndicator when evaluating the JS snippet would be enough. 1403451 3 334948 bburg 2018-03-02 20:39:28 -0800 Created attachment 334948 Proposed Fix 1403549 4 bburg 2018-03-04 14:59:24 -0800 Committed r229206: <https://trac.webkit.org/changeset/229206> 334948 2018-03-02 20:39:28 -0800 2018-03-04 14:37:31 -0800 Proposed Fix bug-183230-20180302203927.patch text/plain 2351 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgyZTBmZTY5NjFkNzI4YTBm YjlhYjIzZjBkYWUzOTE3Mjg0OWU4OGQuLjE2MjhjZmI2OGI1MWVmMjg3ZmE0NzZkNzZjNjViMjU0 NmE3ZTg4MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDMtMDIgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IHNjcmlwdCBl dmFsdWF0aW9ucyB2aWEgV2ViRHJpdmVyIHNob3VsZCBoYXZlIGEgdXNlciBnZXN0dXJlIGluZGlj YXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgz MjMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNzk1OTczOT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBUElzIHRoYXQgbm9ybWFsbHkgcmVxdWly ZSBhIHVzZXIgZ2VzdHVyZSBzaG91bGQganVzdCB3b3JrIHdoZW4gdXNpbmcgdmlhIFdlYkRyaXZl ci4KKyAgICAgICAgVG8gc3VwcG9ydCBjYXNlcyB3aGVyZSB0ZXN0cyBuZWVkIHRvIHNpbXVsYXRl IHVzZXIgYWN0aW9ucyB3aXRoIEphdmFTY3JpcHQsIHVzZSBhCisgICAgICAgIGZha2UgdXNlciBn ZXN0dXJlLCBzaW1pbGFyIHRvIGhvdyAtW1dLV2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6XSBm b3JjZXMgYSB1c2VyCisgICAgICAgIGdlc3R1cmUgd2hlbiBjbGllbnRzIGV2YWx1YXRlIEphdmFT Y3JpcHQgaW4gdGhlaXIgd2ViIHZpZXcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlz IGNvdmVyZWQgYnkgVzNDIHRlc3RzIHRoYXQgdXNlIHRoZSBGdWxsc2NyZWVuIEFQSS4KKyAgICAg ICAgVGhpcyBBUEkgZG9lcyBub3RoaW5nIGlmIHRoZXJlIGlzIG5vIHVzZXIgZ2VzdHVyZTsgd2l0 aCB0aGlzIHBhdGNoLCBpdCBqdXN0IHdvcmtzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9BdXRv bWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5OjpldmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlvbik6CisK IDIwMTgtMDMtMDIgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAg ICAgICBTaGFyZSBjb21tb24gV2ViRXJyb3IgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlv blNlc3Npb25Qcm94eS5jcHAKaW5kZXggNWQwYjczYTQ5ZmU0MWI1NzM3MWFhYjc4NDU0MTAyN2Fi ZTgwMmM0Yi4uNDFmMGExNDgzZDE2OTQ4MTJiNDkyYWJkZWIxY2ZjNzRlNjU4YjliMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNl c3Npb25Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24v V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKQEAgLTI3MSw3ICsyNzEsMTAgQEAgdm9pZCBX ZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5OjpldmFsdWF0ZUphdmFTY3JpcHRGdW5jdGlvbih1aW50 NjRfdCBwYWdlSUQsIHVpbnQKICAgICAgICAgSlNWYWx1ZU1ha2VOdW1iZXIoY29udGV4dCwgY2Fs bGJhY2tUaW1lb3V0KQogICAgIH07CiAKLSAgICBjYWxsUHJvcGVydHlGdW5jdGlvbihjb250ZXh0 LCBzY3JpcHRPYmplY3QsIEFTQ0lJTGl0ZXJhbCgiZXZhbHVhdGVKYXZhU2NyaXB0RnVuY3Rpb24i KSwgV1RGX0FSUkFZX0xFTkdUSChmdW5jdGlvbkFyZ3VtZW50cyksIGZ1bmN0aW9uQXJndW1lbnRz LCAmZXhjZXB0aW9uKTsKKyAgICB7CisgICAgICAgIFdlYkNvcmU6OlVzZXJHZXN0dXJlSW5kaWNh dG9yIGdlc3R1cmVJbmRpY2F0b3IoV2ViQ29yZTo6UHJvY2Vzc2luZ1VzZXJHZXN0dXJlLCBmcmFt ZS0+Y29yZUZyYW1lKCktPmRvY3VtZW50KCkpOworICAgICAgICBjYWxsUHJvcGVydHlGdW5jdGlv bihjb250ZXh0LCBzY3JpcHRPYmplY3QsIEFTQ0lJTGl0ZXJhbCgiZXZhbHVhdGVKYXZhU2NyaXB0 RnVuY3Rpb24iKSwgV1RGX0FSUkFZX0xFTkdUSChmdW5jdGlvbkFyZ3VtZW50cyksIGZ1bmN0aW9u QXJndW1lbnRzLCAmZXhjZXB0aW9uKTsKKyAgICB9CiAKICAgICBpZiAoIWV4Y2VwdGlvbikKICAg ICAgICAgcmV0dXJuOwo=