183212 2018-02-28 06:27:45 -0800 [GStreamer] text samples no longer processed 2018-03-01 01:31:39 -0800 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia webkit-bug-importer oldest_to_newest 1402591 0 pnormand 2018-02-28 06:27:45 -0800 Inband subtitles are no longer rendered. Will attach a patch. 1402593 1 334742 pnormand 2018-02-28 06:30:23 -0800 Created attachment 334742 Patch 1402840 2 334742 calvaris 2018-02-28 23:51:56 -0800 Comment on attachment 334742 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334742&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:986 > + for (auto track : m_textTracks.values()) { Nit: you better do auto& instead. 1402847 3 pnormand 2018-03-01 01:30:14 -0800 Committed r229127: <https://trac.webkit.org/changeset/229127> 1402848 4 webkit-bug-importer 2018-03-01 01:31:39 -0800 <rdar://problem/38019193> 334742 2018-02-28 06:30:23 -0800 2018-02-28 23:51:56 -0800 Patch bug-183212-20180228143022.patch text/plain 2128 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRlZTI4NGI3NGVjNDhl M2U0OTQ4M2Y0NWZiZTk1ZTdkNjY3YTMwZS4uMTY4ZGI2NTFmMmZhMmVjNmFjNDllNzdhMWIwYmY5 NTA1OTFmNWZhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAyLTI4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSB0ZXh0IHNhbXBsZXMgbm8gbG9uZ2VyIHByb2Nlc3NlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bmV3VGV4dFNhbXBsZSk6IFJlZmVyIHRvCisgICAgICAg IHRyYWNrIHN0cmVhbSBJRCBpbnN0ZWFkIG9mIChwb3RlbnRpYWxseSkgbWFudWFsbHkgZ2VuZXJh dGVkIHRyYWNrCisgICAgICAgIElEIHN0b3JlZCBhcyBoYXNobWFwIGtleXMuCisKIDIwMTgtMDIt MjcgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAg W1dlYlZSXSBDb252ZXJ0IFZSUGxhdGZvcm1EaXNwbGF5SW5mbyBpbnRvIGEgY2xhc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggOWRkYzk4 MDVhNzYzY2UxMmRjZTBkNTYxNDk3NGNhOGM2MDgwNDc0MC4uMjA4YzhmNGEwYjY0ZWIxZGFhMmZk NmU0NjE5MzA1YWI2NjMxODZjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKQEAgLTk4MywxNiArOTgzLDE1IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpuZXdUZXh0U2FtcGxlKCkKICAgICAgICAgYm9vbCBmb3VuZCA9IEZB TFNFOwogICAgICAgICBjb25zdCBnY2hhciogaWQ7CiAgICAgICAgIGdzdF9ldmVudF9wYXJzZV9z dHJlYW1fc3RhcnQoc3RyZWFtU3RhcnRFdmVudC5nZXQoKSwgJmlkKTsKLSAgICAgICAgZm9yIChz aXplX3QgaSA9IDA7IGkgPCBtX3RleHRUcmFja3Muc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgICAg IFJlZlB0cjxJbmJhbmRUZXh0VHJhY2tQcml2YXRlR1N0cmVhbWVyPiB0cmFjayA9IG1fdGV4dFRy YWNrcy5nZXQoaWQpOwotICAgICAgICAgICAgaWYgKHRyYWNrKSB7CisgICAgICAgIGZvciAoYXV0 byB0cmFjayA6IG1fdGV4dFRyYWNrcy52YWx1ZXMoKSkgeworICAgICAgICAgICAgaWYgKCFzdHJj bXAodHJhY2stPnN0cmVhbUlkKCkudXRmOCgpLmRhdGEoKSwgaWQpKSB7CiAgICAgICAgICAgICAg ICAgdHJhY2stPmhhbmRsZVNhbXBsZShzYW1wbGUpOwogICAgICAgICAgICAgICAgIGZvdW5kID0g dHJ1ZTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQog ICAgICAgICBpZiAoIWZvdW5kKQotICAgICAgICAgICAgR1NUX1dBUk5JTkcoIkdvdCBzYW1wbGUg d2l0aCB1bmtub3duIHN0cmVhbSBJRC4iKTsKKyAgICAgICAgICAgIEdTVF9XQVJOSU5HKCJHb3Qg c2FtcGxlIHdpdGggdW5rbm93biBzdHJlYW0gSUQgJXMuIiwgaWQpOwogICAgIH0gZWxzZQogICAg ICAgICBHU1RfV0FSTklORygiVW5hYmxlIHRvIGhhbmRsZSBzYW1wbGUgd2l0aCBubyBzdHJlYW0g c3RhcnQgZXZlbnQuIik7CiB9Cg==