183160 2018-02-26 22:44:42 -0800 Avoid scheduling a new build request when there are pending builds 2018-03-04 10:02:55 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 175969 1 rniwa rniwa aakash_jain ap cdumez dean_johnson dewei_zhu rniwa slewis oldest_to_newest 1402284 0 rniwa 2018-02-26 22:44:42 -0800 For buildbot 0.9 compatibility, we shouldn't schedule a new build when there are pending build requests on a builder. 1402285 1 334673 rniwa 2018-02-26 22:52:06 -0800 Created attachment 334673 Works around buildbot 0.9 limitation 1402341 2 334673 aakash_jain 2018-02-27 08:23:28 -0800 Comment on attachment 334673 Works around buildbot 0.9 limitation Looks good. Thanks for the patch. 1402514 3 aakash_jain 2018-02-27 19:16:45 -0800 Please hold-off from committing it. This might not solve all the problem. We still need properties for pending build in order to get build-request-id. So, we might have to fix the root-cause of buildbot not providing us the properties. See https://bugs.webkit.org/show_bug.cgi?id=183194 1402546 4 rniwa 2018-02-28 01:47:02 -0800 (In reply to Aakash Jain from comment #3) > Please hold-off from committing it. This might not solve all the problem. We > still need properties for pending build in order to get build-request-id. > So, we might have to fix the root-cause of buildbot not providing us the > properties. > > See https://bugs.webkit.org/show_bug.cgi?id=183194 Oh, that's a good point. Otherwise, we won't be able to update the perf dashboard when we've scheduled a build. 1403538 5 aakash_jain 2018-03-04 10:02:55 -0800 > So, we might have to fix the root-cause of buildbot not providing us the properties. Buildbot API now provides the properties for build-requests after the fix in https://github.com/buildbot/buildbot/pull/3976 334673 2018-02-26 22:52:06 -0800 2018-02-28 01:47:44 -0800 Works around buildbot 0.9 limitation bug-183160-20180226225205.patch text/plain 4279 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTU0CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAzYzE3ZmIxNDRmZDU4YjIzYWNhYzJkY2IzMDBmNzc2YWZiNWQyMGE1Li5lYzQ4ZTBhYWEw MzljZWIxM2IyMzZkMTdlMzEyN2FlZDhiNmJmNjk0IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxOC0wMi0yNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBBdm9pZCBzY2hlZHVsaW5nIGEgbmV3IGJ1aWxkIHJlcXVl c3Qgd2hlbiB0aGVyZSBhcmUgcGVuZGluZyBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzE2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGJ1aWxkYm90IDAuOSwgdGhlcmUgaXMgbm8gbWVj aGFuaXNtIHRvIGZldGNoIHByb3BlcnRpZXMgb2YgYSBwZW5kaW5nIGJ1aWxkcy4gVGhpcyBpcyBw cm9ibGVtYXRpYyBmb3IKKyAgICAgICAgdGhlIHN5bmNpbmcgc2NyaXB0IHNpbmNlIHdlIGNhbid0 IHRlbGwgd2hldGhlciB0aGVyZSBpcyBhbnkgcGVuZGluZyBidWlsZCBmb3IgYSBnaXZlbiBidWls ZCB3b3JrZXIgb3Igbm90LgorCisgICAgICAgIFRvIHdvcmthcm91bmQgdGhpcyBwcm9ibGVtIGlu IHNob3J0IHRlcm0sIHJlbW92ZSB0aGUgYWJpbGl0eSB0byBzY2hlZHVsZSBhIG5ldyBwZW5kaW5n IGJ1aWxkIGluIGEgYnVpbGRlcgorICAgICAgICB3aGVuIHRoZXJlIGlzIGFueSBwZW5kaW5nIGJ1 aWxkIGF0IGFsbC4gVGhpcyBwcmV0dHkgbXVjaCBtYWtlcyB0aGUgc3VwcG9ydCBmb3IgbXVsdGkt d29ya2VyIGJ1aWxkZXIgdXNlbGVzcworICAgICAgICBzaW5jZSBpdCBtZWFucyBhIG5ldyBidWls ZCBpcyBvbmx5IHNjaGVkdWxlZCBvbiBhIGJ1aWxkZXIgd2hlbiB0aGVyZSBpcyBubyBwZW5kaW5n IGJ1aWxkLiBXZSBuZWVkIHRvIHJldmVydAorICAgICAgICB0aGlzIHBhdGNoIGFuZCBsYW5kIGEg YmV0dGVyIGZpeCBpZiB3ZSBldmVyIHdhbnQgdG8gdXNlIG11bHRpcGxlIHdvcmtlcnMgcGVyIGJ1 aWxkZXIgaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICAqIHRvb2xzL2pzL2J1aWxkYm90LXN5bmNl ci5qczoKKyAgICAgICAgKEJ1aWxkYm90U3luY2VyLnByb3RvdHlwZS5zY2hlZHVsZVJlcXVlc3RJ bkdyb3VwSWZBdmFpbGFibGUpOgorICAgICAgICAqIHVuaXQtdGVzdHMvYnVpbGRib3Qtc3luY2Vy LXRlc3RzLmpzOiBVcGRhdGVkIHRoZSB0ZXN0IGNhc2UuCisKIDIwMTgtMDItMDIgIEFha2FzaCBK YWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBz dWJtaXR0aW5nIGJ1aWxkIHJlcXVlc3QgdG8gQnVpbGRib3QgMC45IHNlcnZlciBpbiBCdWlsZGJv dFN5bmNlcgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xzL2pzL2J1 aWxkYm90LXN5bmNlci5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy90b29scy9qcy9idWls ZGJvdC1zeW5jZXIuanMKaW5kZXggODQwZjBhYzkyYzYyYTIxNWNhY2U1NDliOGQzZjAwZDMxNDFj Y2JkMS4uYzkwODllY2RmNTE3MjE0OTllZTIwYzllYWZhYTFlNTZmYzI1MGZlYiAxMDA2NDQKLS0t IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xzL2pzL2J1aWxkYm90LXN5bmNlci5qcwor KysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvdG9vbHMvanMvYnVpbGRib3Qtc3luY2VyLmpz CkBAIC0xNzQsMTYgKzE3NCwxNSBAQCBjbGFzcyBCdWlsZGJvdFN5bmNlciB7CiAgICAgICAgIGxl dCBoYXNQZW5kaW5nQnVpbGRzV2l0aG91dFNsYXZlTmFtZVNwZWNpZmllZCA9IGZhbHNlOwogICAg ICAgICBsZXQgdXNlZFNsYXZlcyA9IG5ldyBTZXQ7CiAgICAgICAgIGZvciAobGV0IGVudHJ5IG9m IHRoaXMuX2VudHJ5TGlzdCkgewotICAgICAgICAgICAgbGV0IGVudHJ5UHJldmVudHNOZXdSZXF1 ZXN0ID0gZW50cnkuaXNQZW5kaW5nKCk7CisgICAgICAgICAgICBpZiAoZW50cnkuaXNQZW5kaW5n KCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgICAgICAgICBpZiAoZW50cnku aXNJblByb2dyZXNzKCkpIHsKICAgICAgICAgICAgICAgICBjb25zdCByZXF1ZXN0SW5Qcm9ncmVz cyA9IEJ1aWxkUmVxdWVzdC5maW5kQnlJZChlbnRyeS5idWlsZFJlcXVlc3RJZCgpKTsKLSAgICAg ICAgICAgICAgICBpZiAoIXJlcXVlc3RJblByb2dyZXNzIHx8IHJlcXVlc3RJblByb2dyZXNzLnRl c3RHcm91cElkKCkgIT0gbmV3UmVxdWVzdC50ZXN0R3JvdXBJZCgpKQotICAgICAgICAgICAgICAg ICAgICBlbnRyeVByZXZlbnRzTmV3UmVxdWVzdCA9IHRydWU7Ci0gICAgICAgICAgICB9Ci0gICAg ICAgICAgICBpZiAoZW50cnlQcmV2ZW50c05ld1JlcXVlc3QpIHsKLSAgICAgICAgICAgICAgICBp ZiAoIWVudHJ5LnNsYXZlTmFtZSgpKQotICAgICAgICAgICAgICAgICAgICBoYXNQZW5kaW5nQnVp bGRzV2l0aG91dFNsYXZlTmFtZVNwZWNpZmllZCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgdXNl ZFNsYXZlcy5hZGQoZW50cnkuc2xhdmVOYW1lKCkpOworICAgICAgICAgICAgICAgIGlmICghcmVx dWVzdEluUHJvZ3Jlc3MgfHwgcmVxdWVzdEluUHJvZ3Jlc3MudGVzdEdyb3VwSWQoKSAhPSBuZXdS ZXF1ZXN0LnRlc3RHcm91cElkKCkpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKCFlbnRyeS5z bGF2ZU5hbWUoKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIGhhc1BlbmRpbmdCdWlsZHNXaXRo b3V0U2xhdmVOYW1lU3BlY2lmaWVkID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAgdXNlZFNs YXZlcy5hZGQoZW50cnkuc2xhdmVOYW1lKCkpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0KICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv dW5pdC10ZXN0cy9idWlsZGJvdC1zeW5jZXItdGVzdHMuanMgYi9XZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvdW5pdC10ZXN0cy9idWlsZGJvdC1zeW5jZXItdGVzdHMuanMKaW5kZXggNWEyOWUzOTBi MzQ3YjBlNjM5MTk3ZGJjN2RmMWMwOGRlZWQxNjZmYi4uZDQxMDY2ODQ2MzdkMjJkYTM4MGNiNzU3 NGEyZTU0NGU0ZjQ0MjQzZiAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Vu aXQtdGVzdHMvYnVpbGRib3Qtc3luY2VyLXRlc3RzLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy91bml0LXRlc3RzL2J1aWxkYm90LXN5bmNlci10ZXN0cy5qcwpAQCAtMTgwOCwxMyAr MTgwOCwxMyBAQCBkZXNjcmliZSgnQnVpbGRib3RTeW5jZXInLCAoKSA9PiB7CiAgICAgICAgICAg ICB9KTsKICAgICAgICAgfSk7CiAKLSAgICAgICAgaXQoJ3Nob3VsZCBzY2hlZHVsZSBhIGJ1aWxk IGlmIGJ1aWxkZXIgb25seSBoYXMgYSBwZW5kaW5nIGJ1aWxkIG9uIGEgbm9uLW1hY2hpbmcgc2xh dmUnLCAoKSA9PiB7CisgICAgICAgIGl0KCdzaG91bGQgbm90IHNjaGVkdWxlIGEgYnVpbGQgZXZl biBpZiBidWlsZGVyIG9ubHkgaGFzIGEgcGVuZGluZyBidWlsZCBvbiBhIG5vbi1tYWNoaW5nIHNs YXZlJywgKCkgPT4gewogICAgICAgICAgICAgbGV0IHN5bmNlciA9IEJ1aWxkYm90U3luY2VyLl9s b2FkQ29uZmlnKE1vY2tSZW1vdGVBUEksIHNhbXBsZWlPU0NvbmZpZygpLCBidWlsZGVyTmFtZVRv SURNYXAoKSlbMV07CiAKICAgICAgICAgICAgIHJldHVybiBwdWxsQnVpbGRib3RXaXRoQXNzZXJ0 aW9uKHN5bmNlciwgW3NhbXBsZVBlbmRpbmdCdWlsZERlcHJlY2F0ZWQoMSwgMSwgJ2Fub3RoZXIt c2xhdmUnKV0sIHt9KS50aGVuKCgpID0+IHsKICAgICAgICAgICAgICAgICBjb25zdCByZXF1ZXN0 ID0gY3JlYXRlU2FtcGxlQnVpbGRSZXF1ZXN0KE1vY2tNb2RlbHMuaXBhZCwgTW9ja01vZGVscy5z cGVlZG9tZXRlcik7CiAgICAgICAgICAgICAgICAgc3luY2VyLnNjaGVkdWxlUmVxdWVzdEluR3Jv dXBJZkF2YWlsYWJsZShyZXF1ZXN0LCBbcmVxdWVzdF0sIG51bGwpOwotICAgICAgICAgICAgICAg IGFzc2VydC5lcXVhbChyZXF1ZXN0cy5sZW5ndGgsIDEpOworICAgICAgICAgICAgICAgIGFzc2Vy dC5lcXVhbChyZXF1ZXN0cy5sZW5ndGgsIDApOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0p OwogCg==