183152 2018-02-26 15:18:54 -0800 REGRESSION(r226330): incorrectly assumes enumeration callback happens once (Requested by alexchristensen on #webkit). 2018-02-26 15:21:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 180795 1 commit-queue commit-queue achristensen bfulgham webkit-bug-importer oldest_to_newest 1402193 0 commit-queue 2018-02-26 15:18:54 -0800 https://trac.webkit.org/changeset/226330 broke the build: incorrectly assumes enumeration callback happens once (Requested by alexchristensen on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1402195 1 334651 commit-queue 2018-02-26 15:18:59 -0800 Created attachment 334651 ROLLOUT of r226330 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1402196 2 334651 commit-queue 2018-02-26 15:20:27 -0800 Comment on attachment 334651 ROLLOUT of r226330 Clearing flags on attachment: 334651 Committed r229043: <https://trac.webkit.org/changeset/229043> 1402197 3 commit-queue 2018-02-26 15:20:28 -0800 All reviewed patches have been landed. Closing bug. 1402198 4 webkit-bug-importer 2018-02-26 15:21:28 -0800 <rdar://problem/37919510> 334651 2018-02-26 15:18:59 -0800 2018-02-26 15:20:27 -0800 ROLLOUT of r226330 bug-183152-20180226181858.patch text/plain 7044 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBiMzgyZjVlN2Y4ZmEzNmNm YWU2NWMwMGQ4NGJmMGJhN2JhZTk4YWQuLmY2MzM5ZjY3YTI3NDA2YTJiYjZkM2RjNjAyY2RmY2U4 YjJlZDAyOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDItMjYgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIyMjYzMzAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODMxNTIKKworICAgICAgICBpbmNvcnJlY3RseSBhc3N1bWVzIGVudW1lcmF0 aW9uIGNhbGxiYWNrIGhhcHBlbnMgb25jZQorICAgICAgICAoUmVxdWVzdGVkIGJ5IGFsZXhjaHJp c3RlbnNlbiBvbiAjd2Via2l0KS4KKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAg ICAgICAgIlVzZSBCbG9ja1B0cnMgYW5kIGxhbWJkYXMgaW5zdGVhZCBvZiBuZXcvZGVsZXRlIHRv IHBhc3MKKyAgICAgICAgcGFyYW1ldGVycyB0byBibG9ja3MgaW4gV2ViVmlld0ltcGw6OnBlcmZv cm1EcmFnT3BlcmF0aW9uIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTgwNzk1CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNl dC8yMjYzMzAKKwogMjAxOC0wMi0yNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZWxlYXNlIGFzc2VydGlvbiBpbiBXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNl cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwu bW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQppbmRleCBi OWFmM2RkNWY3NDY3YWFjOTc0ZmI1MTZmMjE1NmUyYThlMTlkNTY5Li5iZGZhZmI3NTFlYTNjNDBi Yzg1OWQwMjJkZTZiY2YzYmRmZTc1NjQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9D b2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMzY5Miw3ICszNjkyLDcgQEAgYm9vbCBXZWJWaWV3SW1w bDo6cGVyZm9ybURyYWdPcGVyYXRpb24oaWQgPE5TRHJhZ2dpbmdJbmZvPiBkcmFnZ2luZ0luZm8p CiB7CiAgICAgV2ViQ29yZTo6SW50UG9pbnQgY2xpZW50KFttX3ZpZXcgY29udmVydFBvaW50OmRy YWdnaW5nSW5mby5kcmFnZ2luZ0xvY2F0aW9uIGZyb21WaWV3Om5pbF0pOwogICAgIFdlYkNvcmU6 OkludFBvaW50IGdsb2JhbChXZWJDb3JlOjpnbG9iYWxQb2ludChkcmFnZ2luZ0luZm8uZHJhZ2dp bmdMb2NhdGlvbiwgW21fdmlldyB3aW5kb3ddKSk7Ci0gICAgV2ViQ29yZTo6RHJhZ0RhdGEgZHJh Z0RhdGEoZHJhZ2dpbmdJbmZvLCBjbGllbnQsIGdsb2JhbCwgc3RhdGljX2Nhc3Q8V2ViQ29yZTo6 RHJhZ09wZXJhdGlvbj4oZHJhZ2dpbmdJbmZvLmRyYWdnaW5nU291cmNlT3BlcmF0aW9uTWFzayks IGFwcGxpY2F0aW9uRmxhZ3NGb3JEcmFnKG1fdmlldy5nZXRBdXRvcmVsZWFzZWQoKSwgZHJhZ2dp bmdJbmZvKSk7CisgICAgV2ViQ29yZTo6RHJhZ0RhdGEgKmRyYWdEYXRhID0gbmV3IFdlYkNvcmU6 OkRyYWdEYXRhKGRyYWdnaW5nSW5mbywgY2xpZW50LCBnbG9iYWwsIHN0YXRpY19jYXN0PFdlYkNv cmU6OkRyYWdPcGVyYXRpb24+KGRyYWdnaW5nSW5mby5kcmFnZ2luZ1NvdXJjZU9wZXJhdGlvbk1h c2spLCBhcHBsaWNhdGlvbkZsYWdzRm9yRHJhZyhtX3ZpZXcuZ2V0QXV0b3JlbGVhc2VkKCksIGRy YWdnaW5nSW5mbykpOwogCiAgICAgTlNBcnJheSAqdHlwZXMgPSBkcmFnZ2luZ0luZm8uZHJhZ2dp bmdQYXN0ZWJvYXJkLnR5cGVzOwogICAgIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSBzYW5kYm94 RXh0ZW5zaW9uSGFuZGxlOwpAQCAtMzcwMCw4ICszNzAwLDEwIEBAIGJvb2wgV2ViVmlld0ltcGw6 OnBlcmZvcm1EcmFnT3BlcmF0aW9uKGlkIDxOU0RyYWdnaW5nSW5mbz4gZHJhZ2dpbmdJbmZvKQog CiAgICAgaWYgKFt0eXBlcyBjb250YWluc09iamVjdDpXZWJDb3JlOjpsZWdhY3lGaWxlbmFtZXNQ YXN0ZWJvYXJkVHlwZSgpXSkgewogICAgICAgICBOU0FycmF5ICpmaWxlcyA9IFtkcmFnZ2luZ0lu Zm8uZHJhZ2dpbmdQYXN0ZWJvYXJkIHByb3BlcnR5TGlzdEZvclR5cGU6V2ViQ29yZTo6bGVnYWN5 RmlsZW5hbWVzUGFzdGVib2FyZFR5cGUoKV07Ci0gICAgICAgIGlmICghW2ZpbGVzIGlzS2luZE9m Q2xhc3M6W05TQXJyYXkgY2xhc3NdXSkKKyAgICAgICAgaWYgKCFbZmlsZXMgaXNLaW5kT2ZDbGFz czpbTlNBcnJheSBjbGFzc11dKSB7CisgICAgICAgICAgICBkZWxldGUgZHJhZ0RhdGE7CiAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KIAogICAgICAgICBWZWN0b3I8U3RyaW5n PiBmaWxlTmFtZXM7CiAKQEAgLTM3MTAsMzkgKzM3MTIsNDQgQEAgYm9vbCBXZWJWaWV3SW1wbDo6 cGVyZm9ybURyYWdPcGVyYXRpb24oaWQgPE5TRHJhZ2dpbmdJbmZvPiBkcmFnZ2luZ0luZm8pCiAg ICAgICAgIG1fcGFnZS0+Y3JlYXRlU2FuZGJveEV4dGVuc2lvbnNJZk5lZWRlZChmaWxlTmFtZXMs IHNhbmRib3hFeHRlbnNpb25IYW5kbGUsIHNhbmRib3hFeHRlbnNpb25Gb3JVcGxvYWQpOwogICAg IH0gZWxzZSBpZiAoIVt0eXBlcyBjb250YWluc09iamVjdDpQYXN0ZWJvYXJkVHlwZXM6OldlYkFy Y2hpdmVQYm9hcmRUeXBlXSAmJiBbdHlwZXMgY29udGFpbnNPYmplY3Q6V2ViQ29yZTo6bGVnYWN5 RmlsZXNQcm9taXNlUGFzdGVib2FyZFR5cGUoKV0pIHsKICAgICAgICAgTlNBcnJheSAqZmlsZXMg PSBbZHJhZ2dpbmdJbmZvLmRyYWdnaW5nUGFzdGVib2FyZCBwcm9wZXJ0eUxpc3RGb3JUeXBlOldl YkNvcmU6OmxlZ2FjeUZpbGVzUHJvbWlzZVBhc3RlYm9hcmRUeXBlKCldOwotICAgICAgICBpZiAo IVtmaWxlcyBpc0tpbmRPZkNsYXNzOltOU0FycmF5IGNsYXNzXV0pCisgICAgICAgIGlmICghW2Zp bGVzIGlzS2luZE9mQ2xhc3M6W05TQXJyYXkgY2xhc3NdXSkgeworICAgICAgICAgICAgZGVsZXRl IGRyYWdEYXRhOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CiAgICAgICAg IHNpemVfdCBmaWxlQ291bnQgPSBmaWxlcy5jb3VudDsKLSAgICAgICAgVmVjdG9yPFN0cmluZz4g ZmlsZU5hbWVzOworICAgICAgICBWZWN0b3I8U3RyaW5nPiAqZmlsZU5hbWVzID0gbmV3IFZlY3Rv cjxTdHJpbmc+OwogICAgICAgICBOU1VSTCAqZHJvcExvY2F0aW9uID0gW05TVVJMIGZpbGVVUkxX aXRoUGF0aDpOU1RlbXBvcmFyeURpcmVjdG9yeSgpIGlzRGlyZWN0b3J5OllFU107CiAgICAgICAg IFN0cmluZyBwYXN0ZWJvYXJkTmFtZSA9IGRyYWdnaW5nSW5mby5kcmFnZ2luZ1Bhc3RlYm9hcmQu bmFtZTsKLSAgICAgICAgW2RyYWdnaW5nSW5mbyBlbnVtZXJhdGVEcmFnZ2luZ0l0ZW1zV2l0aE9w dGlvbnM6MCBmb3JWaWV3Om1fdmlldy5nZXRBdXRvcmVsZWFzZWQoKSBjbGFzc2VzOkBbW05TRmls ZVByb21pc2VSZWNlaXZlciBjbGFzc11dIHNlYXJjaE9wdGlvbnM6QHsgfSB1c2luZ0Jsb2NrOkJs b2NrUHRyPHZvaWQgKE5TRHJhZ2dpbmdJdGVtICosIE5TSW50ZWdlciwgQk9PTCAqKT46OmZyb21D YWxsYWJsZShbdGhpcywgZmlsZU5hbWVzID0gV1RGTW92ZShmaWxlTmFtZXMpLCBkcm9wTG9jYXRp b24gPSByZXRhaW5QdHIoZHJvcExvY2F0aW9uKSwgZmlsZUNvdW50LCBkcmFnRGF0YSA9IFdURk1v dmUoZHJhZ0RhdGEpLCBwYXN0ZWJvYXJkTmFtZV0oTlNEcmFnZ2luZ0l0ZW0gKiBfX25vbm51bGwg ZHJhZ2dpbmdJdGVtLCBOU0ludGVnZXIgaWR4LCBCT09MICogX19ub25udWxsIHN0b3ApIG11dGFi bGUgeworICAgICAgICBbZHJhZ2dpbmdJbmZvIGVudW1lcmF0ZURyYWdnaW5nSXRlbXNXaXRoT3B0 aW9uczowIGZvclZpZXc6bV92aWV3LmdldEF1dG9yZWxlYXNlZCgpIGNsYXNzZXM6QFtbTlNGaWxl UHJvbWlzZVJlY2VpdmVyIGNsYXNzXV0gc2VhcmNoT3B0aW9uczpAeyB9IHVzaW5nQmxvY2s6XihO U0RyYWdnaW5nSXRlbSAqIF9fbm9ubnVsbCBkcmFnZ2luZ0l0ZW0sIE5TSW50ZWdlciBpZHgsIEJP T0wgKiBfX25vbm51bGwgc3RvcCkgewogICAgICAgICAgICAgTlNGaWxlUHJvbWlzZVJlY2VpdmVy ICppdGVtID0gZHJhZ2dpbmdJdGVtLml0ZW07CiAgICAgICAgICAgICBOU0RpY3Rpb25hcnkgKm9w dGlvbnMgPSBAeyB9OwogCiAgICAgICAgICAgICBSZXRhaW5QdHI8TlNPcGVyYXRpb25RdWV1ZT4g cXVldWUgPSBhZG9wdE5TKFtOU09wZXJhdGlvblF1ZXVlIG5ld10pOwotICAgICAgICAgICAgW2l0 ZW0gcmVjZWl2ZVByb21pc2VkRmlsZXNBdERlc3RpbmF0aW9uOmRyb3BMb2NhdGlvbi5nZXQoKSBv cHRpb25zOm9wdGlvbnMgb3BlcmF0aW9uUXVldWU6cXVldWUuZ2V0KCkgcmVhZGVyOkJsb2NrUHRy PHZvaWQoTlNVUkwgKiwgTlNFcnJvciAqKT46OmZyb21DYWxsYWJsZShbdGhpcywgZmlsZU5hbWVz ID0gV1RGTW92ZShmaWxlTmFtZXMpLCBmaWxlQ291bnQsIGRyYWdEYXRhID0gV1RGTW92ZShkcmFn RGF0YSksIHBhc3RlYm9hcmROYW1lXShOU1VSTCAqIF9Ob25udWxsIGZpbGVVUkwsIE5TRXJyb3Ig KiBfTnVsbGFibGUgZXJyb3JPck5pbCkgbXV0YWJsZSB7CisgICAgICAgICAgICBbaXRlbSByZWNl aXZlUHJvbWlzZWRGaWxlc0F0RGVzdGluYXRpb246ZHJvcExvY2F0aW9uIG9wdGlvbnM6b3B0aW9u cyBvcGVyYXRpb25RdWV1ZTpxdWV1ZS5nZXQoKSByZWFkZXI6XihOU1VSTCAqIF9Ob25udWxsIGZp bGVVUkwsIE5TRXJyb3IgKiBfTnVsbGFibGUgZXJyb3JPck5pbCkgewogICAgICAgICAgICAgICAg IGlmIChlcnJvck9yTmlsKQogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAg ICAgICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBCbG9ja1B0 cjx2b2lkKCk+Ojpmcm9tQ2FsbGFibGUoW3RoaXMsIHBhdGggPSByZXRhaW5QdHIoZmlsZVVSTC5w YXRoKSwgZmlsZU5hbWVzLCBmaWxlQ291bnQsIGRyYWdEYXRhID0gV1RGTW92ZShkcmFnRGF0YSks IHBhc3RlYm9hcmROYW1lXSgpIG11dGFibGUgewotICAgICAgICAgICAgICAgICAgICBmaWxlTmFt ZXMuYXBwZW5kKHBhdGguZ2V0KCkpOwotICAgICAgICAgICAgICAgICAgICBpZiAoZmlsZU5hbWVz LnNpemUoKSA9PSBmaWxlQ291bnQpIHsKKyAgICAgICAgICAgICAgICBkaXNwYXRjaF9hc3luYyhk aXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBbdGhpcywgcGF0aCA9IFJldGFpblB0cjxOU1N0cmlu Zz4oZmlsZVVSTC5wYXRoKSwgZmlsZU5hbWVzLCBmaWxlQ291bnQsIGRyYWdEYXRhLCBwYXN0ZWJv YXJkTmFtZV0geworICAgICAgICAgICAgICAgICAgICBmaWxlTmFtZXMtPmFwcGVuZChwYXRoLmdl dCgpKTsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGZpbGVOYW1lcy0+c2l6ZSgpID09IGZpbGVD b3VudCkgewogICAgICAgICAgICAgICAgICAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6SGFuZGxl IHNhbmRib3hFeHRlbnNpb25IYW5kbGU7CiAgICAgICAgICAgICAgICAgICAgICAgICBTYW5kYm94 RXh0ZW5zaW9uOjpIYW5kbGVBcnJheSBzYW5kYm94RXh0ZW5zaW9uRm9yVXBsb2FkOwogCi0gICAg ICAgICAgICAgICAgICAgICAgICBtX3BhZ2UtPmNyZWF0ZVNhbmRib3hFeHRlbnNpb25zSWZOZWVk ZWQoZmlsZU5hbWVzLCBzYW5kYm94RXh0ZW5zaW9uSGFuZGxlLCBzYW5kYm94RXh0ZW5zaW9uRm9y VXBsb2FkKTsKLSAgICAgICAgICAgICAgICAgICAgICAgIGRyYWdEYXRhLnNldEZpbGVOYW1lcyhm aWxlTmFtZXMpOwotICAgICAgICAgICAgICAgICAgICAgICAgbV9wYWdlLT5wZXJmb3JtRHJhZ09w ZXJhdGlvbihkcmFnRGF0YSwgcGFzdGVib2FyZE5hbWUsIFdURk1vdmUoc2FuZGJveEV4dGVuc2lv bkhhbmRsZSksIFdURk1vdmUoc2FuZGJveEV4dGVuc2lvbkZvclVwbG9hZCkpOworICAgICAgICAg ICAgICAgICAgICAgICAgbV9wYWdlLT5jcmVhdGVTYW5kYm94RXh0ZW5zaW9uc0lmTmVlZGVkKCpm aWxlTmFtZXMsIHNhbmRib3hFeHRlbnNpb25IYW5kbGUsIHNhbmRib3hFeHRlbnNpb25Gb3JVcGxv YWQpOworICAgICAgICAgICAgICAgICAgICAgICAgZHJhZ0RhdGEtPnNldEZpbGVOYW1lcygqZmls ZU5hbWVzKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fcGFnZS0+cGVyZm9ybURyYWdPcGVy YXRpb24oKmRyYWdEYXRhLCBwYXN0ZWJvYXJkTmFtZSwgV1RGTW92ZShzYW5kYm94RXh0ZW5zaW9u SGFuZGxlKSwgV1RGTW92ZShzYW5kYm94RXh0ZW5zaW9uRm9yVXBsb2FkKSk7CisgICAgICAgICAg ICAgICAgICAgICAgICBkZWxldGUgZHJhZ0RhdGE7CisgICAgICAgICAgICAgICAgICAgICAgICBk ZWxldGUgZmlsZU5hbWVzOwogICAgICAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAg fSkuZ2V0KCkpOwotICAgICAgICAgICAgfSkuZ2V0KCldOwotICAgICAgICB9KS5nZXQoKV07Cisg ICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICB9XTsKKyAgICAgICAgfV07CiAKICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgfQogCi0gICAgbV9wYWdlLT5wZXJmb3JtRHJhZ09wZXJhdGlv bihkcmFnRGF0YSwgZHJhZ2dpbmdJbmZvLmRyYWdnaW5nUGFzdGVib2FyZC5uYW1lLCBXVEZNb3Zl KHNhbmRib3hFeHRlbnNpb25IYW5kbGUpLCBXVEZNb3ZlKHNhbmRib3hFeHRlbnNpb25Gb3JVcGxv YWQpKTsKKyAgICBtX3BhZ2UtPnBlcmZvcm1EcmFnT3BlcmF0aW9uKCpkcmFnRGF0YSwgZHJhZ2dp bmdJbmZvLmRyYWdnaW5nUGFzdGVib2FyZC5uYW1lLCBXVEZNb3ZlKHNhbmRib3hFeHRlbnNpb25I YW5kbGUpLCBXVEZNb3ZlKHNhbmRib3hFeHRlbnNpb25Gb3JVcGxvYWQpKTsKKyAgICBkZWxldGUg ZHJhZ0RhdGE7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K