183142 2018-02-26 13:08:06 -0800 [Extra zoom mode] Tweak UA stylesheet to improve legibility of rendered text 2018-02-27 00:06:47 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue darin thorton webkit-bug-importer oldest_to_newest 1402151 0 wenson_hsieh 2018-02-26 13:08:06 -0800 <rdar://problem/37912966> 1402217 1 334658 wenson_hsieh 2018-02-26 16:11:38 -0800 Created attachment 334658 Patch 1402229 2 334658 wenson_hsieh 2018-02-26 17:08:52 -0800 Comment on attachment 334658 Patch Thanks for the review! 1402233 3 334658 commit-queue 2018-02-26 17:32:11 -0800 Comment on attachment 334658 Patch Clearing flags on attachment: 334658 Committed r229049: <https://trac.webkit.org/changeset/229049> 1402234 4 commit-queue 2018-02-26 17:32:13 -0800 All reviewed patches have been landed. Closing bug. 1402240 5 334658 darin 2018-02-26 18:23:22 -0800 Comment on attachment 334658 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334658&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1806 > + return "* { -webkit-text-size-adjust: auto !important; -webkit-hyphens: auto !important; }"; Should be ASCIILiteral. 1402242 6 wenson_hsieh 2018-02-26 18:48:06 -0800 Good catch! Reopening to make this adjustment. 1402244 7 334664 wenson_hsieh 2018-02-26 19:00:00 -0800 Created attachment 334664 Address review comment 1402303 8 334664 commit-queue 2018-02-27 00:06:45 -0800 Comment on attachment 334664 Address review comment Clearing flags on attachment: 334664 Committed r229056: <https://trac.webkit.org/changeset/229056> 1402304 9 commit-queue 2018-02-27 00:06:47 -0800 All reviewed patches have been landed. Closing bug. 334658 2018-02-26 16:11:38 -0800 2018-02-26 17:32:11 -0800 Patch bug-183142-20180226161137.patch text/plain 2267 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE3YzU5MTJkMmQ4OTAx MTk4ZjlkNWM1YzgxODZhNTNkOWQ3Y2E0Yi4uOWJmNGVlYzI2YjdiZTkwNDcxN2Q3OTg4ZjdjYTMx ZWVlYzE4ODU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAyLTI2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtFeHRyYSB6b29t IG1vZGVdIFR3ZWFrIFVBIHN0eWxlc2hlZXQgdG8gaW1wcm92ZSBsZWdpYmlsaXR5IG9mIHJlbmRl cmVkIHRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4MzE0MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzc5MTI5NjY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yY2UgdGV4dC1zaXplLWFkanVz dCBhbmQgaHlwaGVucyB0byBiZSBhbHdheXMgb24gaW4gRVhUUkFfWk9PTV9NT0RFLiBUbyBhY2Nv bXBsaXNoIHRoaXMsIHdlIG92ZXJyaWRlIHRoZSBleHRyYQorICAgICAgICBzdHlsZSBzaGVldCBp biBSZW5kZXJUaGVtZSB0byBpbmNsdWRlIHRoZXNlIHR3byBzdHlsZSBydWxlcy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJUaGVtZUlPUy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lSU9TOjpleHRyYURl ZmF1bHRTdHlsZVNoZWV0KToKKwogMjAxOC0wMi0yNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbRXh0cmEgem9vbSBtb2RlXSBEaXNhYmxlIGRvd25s b2FkYWJsZSBiaW5hcnkgZm9udHMgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVJT1MuaAppbmRleCA0YTA3OWY0MTUwOTQ1MWI4M2UzZTE5YmQ5NjU3MTc5MWJk ZGY3MmUwLi42NDFlNDM0YTBlOGJlYTI0NmMzYzljNzM5NzZjMjJkNzk2NThhZmUyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MuaApAQCAtMTI4LDYgKzEyOCwxMCBA QCBwcml2YXRlOgogCiAgICAgdm9pZCBwdXJnZUNhY2hlcygpIG92ZXJyaWRlOwogCisjaWYgRU5B QkxFKEVYVFJBX1pPT01fTU9ERSkKKyAgICBTdHJpbmcgZXh0cmFEZWZhdWx0U3R5bGVTaGVldCgp IGZpbmFsOworI2VuZGlmCisKICAgICBjb25zdCBDb2xvciYgc2hhZG93Q29sb3IoKSBjb25zdDsK ICAgICBGbG9hdFJlY3QgYWRkUm91bmRlZEJvcmRlckNsaXAoY29uc3QgUmVuZGVyT2JqZWN0JiBi b3gsIEdyYXBoaWNzQ29udGV4dCYsIGNvbnN0IEludFJlY3QmKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tCmluZGV4IGYwOTljMjgwM2VjYWFjMzlmNjg1MGI2 MDQ3YzJhZWZjYTUzZDcwMTYuLmQzYmM1MGFjYWY2YTMxNzI2NThjMGY0MTBkMTQyMTQ2OWVjZThh MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KQEAgLTE3 OTksNiArMTc5OSwxNSBAQCBib29sIFJlbmRlclRoZW1lSU9TOjpwYWludEF0dGFjaG1lbnQoY29u c3QgUmVuZGVyT2JqZWN0JiByZW5kZXJlciwgY29uc3QgUGFpbnRJbgogCiAjZW5kaWYgLy8gRU5B QkxFKEFUVEFDSE1FTlRfRUxFTUVOVCkKIAorI2lmIEVOQUJMRShFWFRSQV9aT09NX01PREUpCisK K1N0cmluZyBSZW5kZXJUaGVtZUlPUzo6ZXh0cmFEZWZhdWx0U3R5bGVTaGVldCgpCit7CisgICAg cmV0dXJuICIqIHsgLXdlYmtpdC10ZXh0LXNpemUtYWRqdXN0OiBhdXRvICFpbXBvcnRhbnQ7IC13 ZWJraXQtaHlwaGVuczogYXV0byAhaW1wb3J0YW50OyB9IjsKK30KKworI2VuZGlmCisKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vUExBVEZPUk0oSU9TKQo= 334664 2018-02-26 19:00:00 -0800 2018-02-27 00:06:45 -0800 Address review comment bug-183142-20180226185959.patch text/plain 1452 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjI5MDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQyMWFiM2QxODg1NjEw YTBkM2I3YWRlZjBmOTY2ZjM5MDBmYjY2Zi4uYTM1OTkwOTdmMDFmNzNlMTY5MDUyMmRlMDU0NTMy NTk2NTA5ZDQ2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTAyLTI2ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFkZHJlc3MgcG9z dC1yZXZpZXcgY29tbWVudCBhZnRlciByMjI5MDQ5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMTQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV3JhcCBhIG5ld2x5IGFkZGVkIHN0cmluZyBsaXRlcmFs IHdpdGggQVNDSUlMaXRlcmFsLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9T Lm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVJT1M6OmV4dHJhRGVmYXVsdFN0eWxl U2hlZXQpOgorCiAyMDE4LTAyLTI2ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIFtFeHRyYSB6b29tIG1vZGVdIFR3ZWFrIFVBIHN0eWxlc2hlZXQgdG8g aW1wcm92ZSBsZWdpYmlsaXR5IG9mIHJlbmRlcmVkIHRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZUlPUy5tbQppbmRleCBkM2JjNTBhY2FmNmEzMTcyNjU4YzBmNDEwZDE0 MjE0NjllY2U4YTA0Li45ZjIzMzhjZGVjZjU4NjdhZTJkNjZjODIxOWJkZjFjNWRmMWMxYjBkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tCkBAIC0xODAzLDcg KzE4MDMsNyBAQCBib29sIFJlbmRlclRoZW1lSU9TOjpwYWludEF0dGFjaG1lbnQoY29uc3QgUmVu ZGVyT2JqZWN0JiByZW5kZXJlciwgY29uc3QgUGFpbnRJbgogCiBTdHJpbmcgUmVuZGVyVGhlbWVJ T1M6OmV4dHJhRGVmYXVsdFN0eWxlU2hlZXQoKQogewotICAgIHJldHVybiAiKiB7IC13ZWJraXQt dGV4dC1zaXplLWFkanVzdDogYXV0byAhaW1wb3J0YW50OyAtd2Via2l0LWh5cGhlbnM6IGF1dG8g IWltcG9ydGFudDsgfSI7CisgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiKiB7IC13ZWJraXQtdGV4 dC1zaXplLWFkanVzdDogYXV0byAhaW1wb3J0YW50OyAtd2Via2l0LWh5cGhlbnM6IGF1dG8gIWlt cG9ydGFudDsgfSIpOwogfQogCiAjZW5kaWYK