183103 2018-02-24 15:57:48 -0800 [build.webkit.org] unit-tests fail if buildbot 0.8.6p1 is not installed locally 2018-02-25 10:39:21 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain commit-queue lforschler ossy webkit-bug-importer oldest_to_newest 1401891 0 aakash_jain 2018-02-24 15:57:48 -0800 After https://trac.webkit.org/changeset/225534/webkit added import statements, unit-tests requires that buildbot 0.8.6p1 in installed locally. If another buildbot version is installed locally, the tests fails which a confusing error like below. Traceback (most recent call last): File "./steps_unittest.py", line 12, in <module> from steps import (CheckOutSource, Run32bitJSCTests, RunAndUploadPerfTests, RunBenchmarkTests, File "/Users/aakash_jain/code1/OpenSource/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py", line 100, in <module> class CheckOutSource(source.SVN): AttributeError: 'module' object has no attribute 'SVN' Earlier webkitpy used to take care of buildbot packages in background. We stop remove these extra import statements, unless we have a better need to import these explicitly. 1401892 1 334567 aakash_jain 2018-02-24 16:02:18 -0800 Created attachment 334567 Proposed patch 1401893 2 aakash_jain 2018-02-24 16:08:35 -0800 The following code forces to use buildbot from webkitpy.thirdparty.autoinstalled : https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py#L38 So, if we import any buildbot module before executing above code, they will be directly imported from locally installed buildbot package. 1401927 3 334567 commit-queue 2018-02-25 10:38:42 -0800 Comment on attachment 334567 Proposed patch Clearing flags on attachment: 334567 Committed r228977: <https://trac.webkit.org/changeset/228977> 1401928 4 commit-queue 2018-02-25 10:38:43 -0800 All reviewed patches have been landed. Closing bug. 1401929 5 webkit-bug-importer 2018-02-25 10:39:21 -0800 <rdar://problem/37875494> 334567 2018-02-24 16:02:18 -0800 2018-02-25 10:38:42 -0800 Proposed patch remove_extra_import.patch text/plain 1527 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyODk3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE4LTAyLTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gdW5pdC10ZXN0cyBmYWlsIGlmIGJ1aWxk Ym90IDAuOC42cDEgaXMgbm90IGluc3RhbGxlZCBsb2NhbGx5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMxMDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3N0ZXBzX3VuaXR0ZXN0LnB5OiBSZW1vdmVkIGV4dHJhIGltcG9ydHMu CisKIDIwMTgtMDItMjQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgZml4IHRoZSBUZXN0V2ViS2l0QVBJIGJ1aWxkIGFmdGVyIHIy Mjg4MjUuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24g MjI4OTc2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTcsMTEgKzcsNiBAQCBpbXBv cnQgdW5pdHRlc3QKIGltcG9ydCBtYWtlX3Bhc3N3b3Jkc19qc29uCiBpbXBvcnQganNvbgogCi1m cm9tIGJ1aWxkYm90LnN0YXR1cy5idWlsZGVyIGltcG9ydCBTVUNDRVNTLCBGQUlMVVJFLCBXQVJO SU5HUywgU0tJUFBFRCwgRVhDRVBUSU9OCi1mcm9tIGJ1aWxkYm90LnN0ZXBzIGltcG9ydCBzb3Vy Y2UKLWZyb20gc3RlcHMgaW1wb3J0IChDaGVja091dFNvdXJjZSwgUnVuMzJiaXRKU0NUZXN0cywg UnVuQW5kVXBsb2FkUGVyZlRlc3RzLCBSdW5CZW5jaG1hcmtUZXN0cywKLSAgICAgICAgICAgICAg ICAgICBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLCBSdW5MTElOVENMb29wVGVzdHMsIFJ1blRlc3Qy NjJUZXN0cywgUnVuVW5pdFRlc3RzLCBSdW5XZWJLaXRUZXN0cykKLQogIyBTaG93IERlcHJpY2F0 aW9uV2FybmluZ3MgY29tZSBmcm9tIGJ1aWxkYm90IC0gaXQgaXNuJ3QgZGVmYXVsdCB3aXRoIFB5 dGhvbiAyLjcgb3IgbmV3ZXIuCiAjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTAxNjEgZm9yIGRldGFpbHMuCiBpbXBvcnQgd2FybmluZ3MK