183095 2018-02-23 14:56:00 -0800 [Curl] Cookies are not being added to the Cookie field in Request Headers 2018-02-26 12:03:43 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chris.reid webkit-unassigned achristensen annulen basuke bfulgham commit-queue darin don.olmstead ews-watchlist galpeter pvollan webkit-bug-importer youennf oldest_to_newest 1401814 0 chris.reid 2018-02-23 14:56:00 -0800 Now that libcurl is not handling cookies, we need to handle this header field ourselves. 1401847 1 334556 chris.reid 2018-02-23 17:29:20 -0800 Created attachment 334556 patch 1401849 2 334558 chris.reid 2018-02-23 17:41:05 -0800 Created attachment 334558 Patch Uploading the right patch this time 1402129 3 334558 commit-queue 2018-02-26 12:02:45 -0800 Comment on attachment 334558 Patch Clearing flags on attachment: 334558 Committed r229032: <https://trac.webkit.org/changeset/229032> 1402130 4 commit-queue 2018-02-26 12:02:47 -0800 All reviewed patches have been landed. Closing bug. 1402132 5 webkit-bug-importer 2018-02-26 12:03:43 -0800 <rdar://problem/37911198> 334556 2018-02-23 17:29:20 -0800 2018-02-23 17:41:05 -0800 patch 183051.diff text/plain 1880 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwNjM5ZDc2ZWEyNC4uOWM1ZWIwMTE2ZTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wMi0yMiAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIENvb2tpZSBEYXRhYmFzZSBmaWxlcyBhcmUgd3Jvbmdm dWxseSBnZXR0aW5nIGRlbGV0ZWQgd2hlbiB0aGUgZGF0YWJhc2UgaXMgb3BlbmVkCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMwNTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZmlsZSBzdGF0IGxv Z2ljIHdhcyBiYWNrd2FyZHMgY2F1c2luZyBhIHdyb25nZnVsIGRldGVjdGlvbiBvZiBkYXRhYmFz ZSBjb3JydXB0aW9uLgorICAgICAgICBGaXhlZCB0aGUgbG9naWMgYW5kIGFic3RyYWN0ZWQgdGhl c2UgY2FsbHMgdG8gdXNlIEZpbGVTeXN0ZW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvQ29va2llSmFyREIuY3BwOgorCiAyMDE4LTAyLTIwICBOYW4gV2FuZyAgPG5fd2FuZ0Bh cHBsZS5jb20+CiAKICAgICAgICAgQVg6IEFPTTogRGlzcGF0Y2ggYWNjZXNzaWJsZWNsaWNrIGV2 ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29v a2llSmFyREIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tp ZUphckRCLmNwcAppbmRleCA5NjU5NTg0MzllOC4uMzA3ODJiOTUyYTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJEQi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckRCLmNwcApAQCAt MTYzLDIyICsxNjMsMTggQEAgdm9pZCBDb29raWVKYXJEQjo6ZmxhZ0RhdGFiYXNlQ29ycnVwdGlv bigpCiAgICAgaWYgKGlzT25NZW1vcnkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgRklMRSog ZiA9IGZvcGVuKGdldENvcnJ1cHRpb25NYXJrZXJQYXRoKCkudXRmOCgpLmRhdGEoKSwgIndiIik7 Ci0gICAgZmNsb3NlKGYpOworICAgIGF1dG8gaGFuZGxlID0gRmlsZVN5c3RlbTo6b3BlbkZpbGUo Z2V0Q29ycnVwdGlvbk1hcmtlclBhdGgoKSwgRmlsZVN5c3RlbTo6RmlsZU9wZW5Nb2RlOjpXcml0 ZSk7CisgICAgRmlsZVN5c3RlbTo6Y2xvc2VGaWxlKGhhbmRsZSk7CiB9CiAKIGJvb2wgQ29va2ll SmFyREI6OmNoZWNrRGF0YWJhc2VDb3JydXB0aW9uQW5kUmVtb3ZlSWZOZWVkZWQoKQogewotICAg IGlmIChpc09uTWVtb3J5KCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIHN0cnVjdCBz dGF0IHN0OwotICAgIGludCByZXQgPSBzdGF0KGdldENvcnJ1cHRpb25NYXJrZXJQYXRoKCkudXRm OCgpLmRhdGEoKSwgJnN0KTsKLSAgICBpZiAoIXJldCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgIGlmICghaXNPbk1lbW9yeSgpICYmIEZpbGVTeXN0ZW06OmZpbGVFeGlzdHMoZ2V0Q29ycnVw dGlvbk1hcmtlclBhdGgoKSkpIHsKKyAgICAgICAgZGVsZXRlQWxsRGF0YWJhc2VGaWxlcygpOwor ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CiAKLSAgICBkZWxldGVBbGxEYXRhYmFzZUZpbGVz KCk7Ci0gICAgcmV0dXJuIHRydWU7CisgICAgcmV0dXJuIGZhbHNlOwogfQogCiBib29sIENvb2tp ZUphckRCOjpjaGVja1NRTGl0ZVJldHVybkNvZGUoaW50IGFjdHVhbCwgaW50IGV4cGVjdGVkKQo= 334558 2018-02-23 17:41:05 -0800 2018-02-26 12:02:45 -0800 Patch 183095.diff text/plain 3784 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MjBhYzk0MWE4Yy4uOTdmOTkzYTVmMTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wMi0yMyAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIENvb2tpZXMgYXJlIG5vdCBiZWluZyBhZGRlZCB0byB0 aGUgQ29va2llIGZpZWxkIGluIFJlcXVlc3QgSGVhZGVycworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUG9wdWxhdGluZyB0aGUgQ29va2llIHJlcXVlc3Qg aGVhZGVyIGZpZWxkIG5vdyB0aGF0IGNvb2tpZXMgYXJlIG5vIGxvbmdlciBoYW5kbGVkIGluIGxp YmN1cmwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybERh dGFiYXNlLmNwcDogUmVuYW1pbmcgdGhlIGh0dHBPbmx5IHZhcmlhYmxlIGFzIGl0cyBhY3R1YWwg dXNlIHdhc24ndCBjbGVhcgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUhhbmRsZUN1cmwuY3BwOgorCiAyMDE4LTAyLTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVyXSBNb3ZlIFJlbmRlckZ1bGxTY3Jl ZW46OmNyZWF0ZVBsYWNlaG9sZGVyIHRvIFJlbmRlclRyZWVCdWlsZGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybERhdGFiYXNl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJDdXJs RGF0YWJhc2UuY3BwCmluZGV4IGNmMzgwYzhiMjZkLi5mOGY0OTdjMzgzYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmxEYXRhYmFz ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUph ckN1cmxEYXRhYmFzZS5jcHAKQEAgLTM4LDE2ICszOCwxNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKLXN0YXRpYyBTdHJpbmcgY29va2llc0ZvclNlc3Npb24oY29uc3QgTmV0d29ya1N0b3Jh Z2VTZXNzaW9uJiBzZXNzaW9uLCBjb25zdCBVUkwmLCBjb25zdCBVUkwmIHVybCwgYm9vbCBodHRw b25seSkKK3N0YXRpYyBTdHJpbmcgY29va2llc0ZvclNlc3Npb24oY29uc3QgTmV0d29ya1N0b3Jh Z2VTZXNzaW9uJiBzZXNzaW9uLCBjb25zdCBVUkwmLCBjb25zdCBVUkwmIHVybCwgYm9vbCBmb3JI VFRQSGVhZGVyKQogewogICAgIFN0cmluZ0J1aWxkZXIgY29va2llczsKIAogICAgIENvb2tpZUph ckRCJiBjb29raWVKYXJEQiA9IHNlc3Npb24uY29va2llRGF0YWJhc2UoKTsKLSAgICBhdXRvIGlz SHR0cE9ubHkgPSAoaHR0cG9ubHkgPyBzdGQ6Om51bGxvcHQgOiBzdGQ6Om9wdGlvbmFsPGJvb2w+ IHtmYWxzZX0pOworICAgIGF1dG8gc2VhcmNoSFRUUE9ubHkgPSAoZm9ySFRUUEhlYWRlciA/IHN0 ZDo6bnVsbG9wdCA6IHN0ZDo6b3B0aW9uYWw8Ym9vbD4ge2ZhbHNlfSk7CiAgICAgYXV0byBzZWN1 cmUgPSB1cmwucHJvdG9jb2xJcygiaHR0cHMiKSA/IHN0ZDo6bnVsbG9wdCA6IHN0ZDo6b3B0aW9u YWw8Ym9vbD4ge2ZhbHNlfTsKIAogICAgIFZlY3RvcjxDb29raWU+IHJlc3VsdHM7Ci0gICAgaWYg KGNvb2tpZUphckRCLnNlYXJjaENvb2tpZXModXJsLnN0cmluZygpLCBpc0h0dHBPbmx5LCBzZWN1 cmUsIHN0ZDo6bnVsbG9wdCwgcmVzdWx0cykpIHsKKyAgICBpZiAoY29va2llSmFyREIuc2VhcmNo Q29va2llcyh1cmwuc3RyaW5nKCksIHNlYXJjaEhUVFBPbmx5LCBzZWN1cmUsIHN0ZDo6bnVsbG9w dCwgcmVzdWx0cykpIHsKICAgICAgICAgZm9yIChhdXRvIHJlc3VsdCA6IHJlc3VsdHMpIHsKICAg ICAgICAgICAgIGlmICghY29va2llcy5pc0VtcHR5KCkpCiAgICAgICAgICAgICAgICAgY29va2ll cy5hcHBlbmQoIjsgIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmwuY3BwCmluZGV4IGU3YTEzMDkzMzM0Li5i ZGEzZjM3YTFlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAKQEAgLTMzLDYgKzMzLDcgQEAKICNp ZiBVU0UoQ1VSTCkKIAogI2luY2x1ZGUgIkNvb2tpZUphckN1cmwuaCIKKyNpbmNsdWRlICJDb29r aWVzU3RyYXRlZ3kuaCIKICNpbmNsdWRlICJDcmVkZW50aWFsU3RvcmFnZS5oIgogI2luY2x1ZGUg IkN1cmxDYWNoZU1hbmFnZXIuaCIKICNpbmNsdWRlICJDdXJsQ29udGV4dC5oIgpAQCAtNDAsNiAr NDEsNyBAQAogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIKICNpbmNsdWRlICJIVFRQUGFyc2Vycy5o IgogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKKyNpbmNsdWRlICJOZXR3b3JrU3RvcmFnZVNlc3Npb24u aCIKICNpbmNsdWRlICJSZXNvdXJjZUhhbmRsZUludGVybmFsLmgiCiAjaW5jbHVkZSAiU2hhcmVk QnVmZmVyLmgiCiAjaW5jbHVkZSAiU3luY2hyb25vdXNMb2FkZXJDbGllbnQuaCIKQEAgLTEzMiw2 ICsxMzQsMTMgQEAgUmVmPEN1cmxSZXF1ZXN0PiBSZXNvdXJjZUhhbmRsZTo6Y3JlYXRlQ3VybFJl cXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQogICAgICAgICB9CiAgICAgfQogCisgICAg YXV0byYgc3RvcmFnZVNlc3Npb24gPSBOZXR3b3JrU3RvcmFnZVNlc3Npb246OmRlZmF1bHRTdG9y YWdlU2Vzc2lvbigpOworICAgIGF1dG8mIGNvb2tpZUphciA9IHN0b3JhZ2VTZXNzaW9uLmNvb2tp ZVN0b3JhZ2UoKTsKKyAgICBhdXRvIGluY2x1ZGVTZWN1cmVDb29raWVzID0gcmVxdWVzdC51cmwo KS5wcm90b2NvbElzKCJodHRwcyIpID8gSW5jbHVkZVNlY3VyZUNvb2tpZXM6OlllcyA6IEluY2x1 ZGVTZWN1cmVDb29raWVzOjpObzsKKyAgICBTdHJpbmcgY29va2llSGVhZGVyRmllbGQgPSBjb29r aWVKYXIuY29va2llUmVxdWVzdEhlYWRlckZpZWxkVmFsdWUoc3RvcmFnZVNlc3Npb24sIHJlcXVl c3QuZmlyc3RQYXJ0eUZvckNvb2tpZXMoKSwgcmVxdWVzdC51cmwoKSwgc3RkOjpudWxsb3B0LCBz dGQ6Om51bGxvcHQsIGluY2x1ZGVTZWN1cmVDb29raWVzKS5maXJzdDsKKyAgICBpZiAoIWNvb2tp ZUhlYWRlckZpZWxkLmlzRW1wdHkoKSkKKyAgICAgICAgcmVxdWVzdC5hZGRIVFRQSGVhZGVyRmll bGQoSFRUUEhlYWRlck5hbWU6OkNvb2tpZSwgY29va2llSGVhZGVyRmllbGQpOworCiAgICAgQ3Vy bFJlcXVlc3Q6OlNob3VsZFN1c3BlbmQgc2hvdWxkU3VzcGVuZCA9IGQtPm1fZGVmZXJzTG9hZGlu ZyA/IEN1cmxSZXF1ZXN0OjpTaG91bGRTdXNwZW5kOjpZZXMgOiBDdXJsUmVxdWVzdDo6U2hvdWxk U3VzcGVuZDo6Tm87CiAgICAgYXV0byBjdXJsUmVxdWVzdCA9IEN1cmxSZXF1ZXN0OjpjcmVhdGUo cmVxdWVzdCwgKmRlbGVnYXRlKCksIHNob3VsZFN1c3BlbmQsIEN1cmxSZXF1ZXN0OjpFbmFibGVN dWx0aXBhcnQ6Olllcyk7CiAgICAgCg==