<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>183093</bug_id>
          
          <creation_ts>2018-02-23 13:49:01 -0800</creation_ts>
          <short_desc>Layout Test http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html is flaky</short_desc>
          <delta_ts>2019-10-29 11:34:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Matt Lewis">jlewis3</reporter>
          <assigned_to name="Kate Cheney">katherine_cheney</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>katherine_cheney</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wilander</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1401803</commentid>
    <comment_count>0</comment_count>
    <who name="Matt Lewis">jlewis3</who>
    <bug_when>2018-02-23 13:49:01 -0800</bug_when>
    <thetext>The following layout test is a flaky timeout on macOS

http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown.html

Probable cause:

Started timing out after skipping http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html in https://trac.webkit.org/changeset/228403/webkit. This is not the first time this has happened and may have a greater fix in the works.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=http%2Ftests%2FresourceLoadStatistics%2Fprevalent-resource-unhandled-keydown.html


https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r228954%20(3106)/results.html

diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/prevalent-resource-unhandled-keydown-actual.txt
@@ -1,11 +1,4 @@
-Tests that we do not grant User Interaction credit for unhandled keypress.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 95693)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of &quot;PASS&quot; messages, followed by &quot;TEST COMPLETE&quot;.
-
-
-Simulate an unhandled user key press.
-PASS Origin did not get user interaction credit.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1402493</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-02-27 17:40:33 -0800</bug_when>
    <thetext>&lt;rdar://problem/37964600&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1408164</commentid>
    <comment_count>2</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2018-03-21 14:18:17 -0700</bug_when>
    <thetext>Skipped test in https://trac.webkit.org/r229826</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1584024</commentid>
    <comment_count>3</comment_count>
      <attachid>381968</attachid>
    <who name="Kate Cheney">katherine_cheney</who>
    <bug_when>2019-10-25 14:53:47 -0700</bug_when>
    <thetext>Created attachment 381968
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1584971</commentid>
    <comment_count>4</comment_count>
      <attachid>381968</attachid>
    <who name="John Wilander">wilander</who>
    <bug_when>2019-10-29 10:48:37 -0700</bug_when>
    <thetext>Comment on attachment 381968
Patch

Looks good under the condition that you’ll keep an eye on the bots. :)

(iOS fail is unrelated test runner crashes as far as I can see.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1585005</commentid>
    <comment_count>5</comment_count>
      <attachid>381968</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-29 11:34:12 -0700</bug_when>
    <thetext>Comment on attachment 381968
Patch

Clearing flags on attachment: 381968

Committed r251715: &lt;https://trac.webkit.org/changeset/251715&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1585006</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-10-29 11:34:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>381968</attachid>
            <date>2019-10-25 14:53:47 -0700</date>
            <delta_ts>2019-10-29 11:34:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-183093-20191025145346.patch</filename>
            <type>text/plain</type>
            <size>2934</size>
            <attacher name="Kate Cheney">katherine_cheney</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjUxNTk5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDk3NmVmMjY5MjdmN2M3M2QwNDI0
YzUxZGFkMWJjODFkYTMzMTUyZi4uZDM1MmUzYjJiNzIxOTNkNmRiMjljMmY3OTQ3NWQxNGFmZDcw
ZjE2ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTEwLTI1ICBLYXRlIENoZW5leSAgPGth
dGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IGh0dHAvdGVz
dHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9wcmV2YWxlbnQtcmVzb3VyY2UtdW5oYW5kbGVkLWtl
eWRvd24uaHRtbCBpcyBmbGFreSAoMTgzMDkzKQorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzA5Mz4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM3
OTY0NjAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEZsYWtpbmVzcyBubyBsb25nZXIgcmVwcm9kdWNpYmxlLiAKKworICAgICAgICAqIHBsYXRmb3Jt
L2lvcy9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4
cGVjdGF0aW9uczoKKwogMjAxOS0xMC0yNSAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5j
b20+CiAKICAgICAgICAgV2ViUHJvY2VzcyBzaG91bGQgdW5yZWdpc3RlciBpdHMgaW50ZXJlc3Qg
Zm9yIGEgU1dTZXJ2ZXJSZWdpc3RyYXRpb24gd2hlbiBhbGwgaXRzIGNvcnJlc3BvbmRpbmcgU2Vy
dmljZVdvcmtlclJlZ2lzdHJhdGlvbnMgYXJlIGRlc3Ryb3llZApkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y
bS9pb3MvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBmZDhmOTEyMTkzMTQwMTY5ZjYzNjA3NWRmNzA4
NTU2YjZmZWFiNDA4Li4xZjA1Y2VkNGNhNTJmMDMzYWMzYzA4ZmMwNzU1Nzg4MjUzZDc5ZjBjIDEw
MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucworKysg
Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOTg4LDkgKzk4
OCw3IEBAIGZhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtdW5pdC1vdmVyZmxvdy1hbmQtc2Ny
b2xsLWluLWRpcmVjdGlvbi5odG1sIFsgU2tpcCBdCiBodHRwL3Rlc3RzL25hdmlnYXRpb24va2V5
Ym9hcmQtZXZlbnRzLWR1cmluZy1wcm92aXNpb25hbC1uYXZpZ2F0aW9uLmh0bWwgWyBTa2lwIF0K
IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9rZXlib2FyZC1ldmVudHMtZHVyaW5nLXByb3Zpc2lvbmFs
LXN1YmZyYW1lLW5hdmlnYXRpb24uaHRtbCBbIFNraXAgXQogaHR0cC90ZXN0cy9yZXNvdXJjZUxv
YWRTdGF0aXN0aWNzL3ByZXZhbGVudC1yZXNvdXJjZS1oYW5kbGVkLWtleWRvd24uaHRtbCBbIFNr
aXAgXQotaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL3ByZXZhbGVudC1yZXNvdXJj
ZS11bmhhbmRsZWQta2V5ZG93bi5odG1sIFsgU2tpcCBdCiBodHRwL3Rlc3RzL3Jlc291cmNlTG9h
ZFN0YXRpc3RpY3MvcHJldmFsZW50LXJlc291cmNlLWhhbmRsZWQta2V5ZG93bi1kYXRhYmFzZS5o
dG1sIFsgU2tpcCBdCi1odHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcHJldmFsZW50
LXJlc291cmNlLXVuaGFuZGxlZC1rZXlkb3duLWRhdGFiYXNlLmh0bWwgWyBTa2lwIF0KIG1lZGlh
L2F1ZGlvLXBsYXliYWNrLXZvbHVtZS1jaGFuZ2VzLXdpdGgtcmVzdHJpY3Rpb25zLWFuZC11c2Vy
LWdlc3R1cmVzLmh0bWwgWyBTa2lwIF0KIG1lZGlhL2F1ZGlvLXBsYXliYWNrLXZvbHVtZS1jaGFu
Z2VzLXdpdGgtcmVzdHJpY3Rpb25zLmh0bWwgWyBTa2lwIF0KIG1lZGlhL3BpY3R1cmUtaW4tcGlj
dHVyZS1pbnRlcnJ1cHRpb24uaHRtbCBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv
cGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v
bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGY4YzE0YTg0OTY1Y2IwNTBmNzJjYjRmNmI3
YWNiZjIwOGU4MDNiZTcuLjY5MDdjODM0ZmNhMjE1YTBkY2EwOWYwNGYzMWFmMjZlNTZjMGE0MWIg
MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9u
cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAg
LTc2Nyw3ICs3NjcsNiBAQCB3ZWJraXQub3JnL2IvMTcxODM5IFsgRGVidWcgXSB0aWxlZC1kcmF3
aW5nL3Njcm9sbGluZy9zY3JvbGwtc25hcC9zY3JvbGwtc25hcC1tYQogd2Via2l0Lm9yZy9iLzE3
NzY4NyBodHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrL3Jlc291cmNlLXNpemVzLW1lbW9yeS1j
YWNoZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE3ODQ3MiBodHRwL3Rl
c3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcHJldmFsZW50LXJlc291cmNlLWhhbmRsZWQta2V5
ZG93bi5odG1sIFsgU2tpcCBdCi13ZWJraXQub3JnL2IvMTgzMDkzIGh0dHAvdGVzdHMvcmVzb3Vy
Y2VMb2FkU3RhdGlzdGljcy9wcmV2YWxlbnQtcmVzb3VyY2UtdW5oYW5kbGVkLWtleWRvd24uaHRt
bCBbIFNraXAgXQogd2Via2l0Lm9yZy9iLzE3ODQ3MiBodHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0
YXRpc3RpY3MvcHJldmFsZW50LXJlc291cmNlLXdpdGgtdXNlci1pbnRlcmFjdGlvbi10aW1lb3V0
Lmh0bWwgWyBTa2lwIF0KIAogd2Via2l0Lm9yZy9iLzE3Njg4MSBwbHVnaW5zL2pzLWZyb20tZGVz
dHJveS5odG1sIFsgUGFzcyBGYWlsdXJlIF0K
</data>

          </attachment>
      

    </bug>

</bugzilla>