183073 2018-02-22 20:42:02 -0800 [RenderTreeBuilder] Add WARN_UNUSED_RETURN to detach() 2018-02-23 06:52:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1401641 0 zalan 2018-02-22 20:42:02 -0800 to ensure we don't accidentally destroy a renderer 1401642 1 webkit-bug-importer 2018-02-22 20:42:36 -0800 <rdar://problem/37814585> 1401643 2 334503 zalan 2018-02-22 20:43:49 -0800 Created attachment 334503 Patch 1401711 3 334503 commit-queue 2018-02-23 06:52:51 -0800 Comment on attachment 334503 Patch Clearing flags on attachment: 334503 Committed r228948: <https://trac.webkit.org/changeset/228948> 1401712 4 commit-queue 2018-02-23 06:52:52 -0800 All reviewed patches have been landed. Closing bug. 334503 2018-02-22 20:43:49 -0800 2018-02-23 06:52:51 -0800 Patch bug-183073-20180222204348.patch text/plain 4537 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg1NTQ1ZDAzMzczZTkz YjMwOWFmYzY1NDYzNmY0NGYxOGE3ODNmNy4uYjY2YTU4NWY4Y2MwYTg0MTBjMGNmODhmZDE2YTgx YTc0ODY4MDU1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAyLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBBZGQgV0FSTl9VTlVTRURfUkVUVVJOIHRvIGRldGFjaCgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODMwNzMKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzM3ODE0NTg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFNvIHRoYXQgd2UgZG9uJ3QgZGVzdHJveSBhIHJlbmRlcmVyIGFjY2lkZW50YWxseS4K KworICAgICAgICAqIHJlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlckJsb2NrLmg6 CisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyUnVieS5oOgor ICAgICAgICAqIHJlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlclNWRy5oOgorCiAy MDE4LTAyLTIyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW1Jl bmRlclRyZWVCdWlsZGVyXSBSZW5hbWUgaW5zZXJ0Q2hpbGQoKSAtPiBhdHRhY2goKSwgdGFrZUNo aWxkKCkgLT4gZGV0YWNoKCkgYW5kIHJlbW92ZUFuZERlc3Ryb3koKSAtPiBkZXN0cm95KCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVp bGRlckJsb2NrLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJl ZUJ1aWxkZXJCbG9jay5oCmluZGV4IDI2MjA0MmQ5ZWQxNDY2YTM4OGE2MjIwYzNlMTA3NjAyNTBl MDUzNTkuLjY2NmNkYzUxMjVlM2ExOTAyZjEwYzgzODJlZGYxMmZiYTMxNWIwNTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlckJs b2NrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVC dWlsZGVyQmxvY2suaApAQCAtMzYsOCArMzYsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBhdHRhY2go UmVuZGVyQmxvY2smIHBhcmVudCwgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gY2hpbGQsIFJlbmRl ck9iamVjdCogYmVmb3JlQ2hpbGQpOwogICAgIHZvaWQgYXR0YWNoSWdub3JpbmdDb250aW51YXRp b24oUmVuZGVyQmxvY2smIHBhcmVudCwgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gY2hpbGQsIFJl bmRlck9iamVjdCogYmVmb3JlQ2hpbGQpOwogCi0gICAgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4g ZGV0YWNoKFJlbmRlckJsb2NrJiBwYXJlbnQsIFJlbmRlck9iamVjdCYgb2xkQ2hpbGQpOwotICAg IFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+IGRldGFjaChSZW5kZXJCbG9ja0Zsb3cmIHBhcmVudCwg UmVuZGVyT2JqZWN0JiBjaGlsZCk7CisgICAgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gZGV0YWNo KFJlbmRlckJsb2NrJiBwYXJlbnQsIFJlbmRlck9iamVjdCYgb2xkQ2hpbGQpIFdBUk5fVU5VU0VE X1JFVFVSTjsKKyAgICBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBkZXRhY2goUmVuZGVyQmxvY2tG bG93JiBwYXJlbnQsIFJlbmRlck9iamVjdCYgY2hpbGQpIFdBUk5fVU5VU0VEX1JFVFVSTjsKIAog ICAgIHZvaWQgZHJvcEFub255bW91c0JveENoaWxkKFJlbmRlckJsb2NrJiBwYXJlbnQsIFJlbmRl ckJsb2NrJiBjaGlsZCk7CiAgICAgdm9pZCBjaGlsZEJlY2FtZU5vbklubGluZShSZW5kZXJCbG9j ayYgcGFyZW50LCBSZW5kZXJFbGVtZW50JiBjaGlsZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJSdWJ5LmggYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJSdWJ5LmgKaW5kZXgg N2VjOWJmZTM1NzRjNmE0YmM1NDZlMDQ3YTcxNTg5ODIzZTVhYzU0MC4uYzE0ZjE0ZDg4MDM5NTZh ZDJiZWIwNjA2ODY3NjE5MzI5ODE3MmMxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyUnVieS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlclJ1YnkuaApAQCAtNDIsOSAr NDIsOSBAQCBwdWJsaWM6CiAgICAgUnVieShSZW5kZXJUcmVlQnVpbGRlciYpOwogCiAgICAgdm9p ZCBhdHRhY2goUmVuZGVyUnVieVJ1biYgcGFyZW50LCBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBj aGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCk7Ci0gICAgUmVuZGVyUHRyPFJlbmRlck9i amVjdD4gZGV0YWNoKFJlbmRlclJ1YnlBc0lubGluZSYgcGFyZW50LCBSZW5kZXJPYmplY3QmIGNo aWxkKTsKLSAgICBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBkZXRhY2goUmVuZGVyUnVieUFzQmxv Y2smIHBhcmVudCwgUmVuZGVyT2JqZWN0JiBjaGlsZCk7Ci0gICAgUmVuZGVyUHRyPFJlbmRlck9i amVjdD4gZGV0YWNoKFJlbmRlclJ1YnlSdW4mIHBhcmVudCwgUmVuZGVyT2JqZWN0JiBjaGlsZCk7 CisgICAgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gZGV0YWNoKFJlbmRlclJ1YnlBc0lubGluZSYg cGFyZW50LCBSZW5kZXJPYmplY3QmIGNoaWxkKSBXQVJOX1VOVVNFRF9SRVRVUk47CisgICAgUmVu ZGVyUHRyPFJlbmRlck9iamVjdD4gZGV0YWNoKFJlbmRlclJ1YnlBc0Jsb2NrJiBwYXJlbnQsIFJl bmRlck9iamVjdCYgY2hpbGQpIFdBUk5fVU5VU0VEX1JFVFVSTjsKKyAgICBSZW5kZXJQdHI8UmVu ZGVyT2JqZWN0PiBkZXRhY2goUmVuZGVyUnVieVJ1biYgcGFyZW50LCBSZW5kZXJPYmplY3QmIGNo aWxkKSBXQVJOX1VOVVNFRF9SRVRVUk47CiAKICAgICB2b2lkIG1vdmVDaGlsZHJlbihSZW5kZXJS dWJ5QmFzZSYgZnJvbSwgUmVuZGVyUnVieUJhc2UmIHRvKTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyU1ZHLmggYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJTVkcuaAppbmRl eCAxZGM5ZTMwZjM2ODA4ZDRkOTA0ZDQyYmRiNGU3YTJkMTE4MWEwY2M2Li5kOTMwY2FlZGU0YzVj YTdjZGIwYTM1YzY3OGMyNmEzYjMxOWUxODUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJTVkcuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXJTVkcuaApAQCAtNDMsMTAg KzQzLDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIGF0dGFjaChSZW5kZXJTVkdSb290JiBwYXJlbnQs IFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+IGNoaWxkLCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxk KTsKICAgICB2b2lkIGF0dGFjaChSZW5kZXJTVkdUZXh0JiBwYXJlbnQsIFJlbmRlclB0cjxSZW5k ZXJPYmplY3Q+IGNoaWxkLCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkKTsKIAotICAgIFJlbmRl clB0cjxSZW5kZXJPYmplY3Q+IGRldGFjaChSZW5kZXJTVkdUZXh0JiBwYXJlbnQsIFJlbmRlck9i amVjdCYgY2hpbGQpOwotICAgIFJlbmRlclB0cjxSZW5kZXJPYmplY3Q+IGRldGFjaChSZW5kZXJT VkdJbmxpbmUmIHBhcmVudCwgUmVuZGVyT2JqZWN0JiBjaGlsZCk7Ci0gICAgUmVuZGVyUHRyPFJl bmRlck9iamVjdD4gZGV0YWNoKFJlbmRlclNWR0NvbnRhaW5lciYgcGFyZW50LCBSZW5kZXJPYmpl Y3QmIGNoaWxkKTsKLSAgICBSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBkZXRhY2goUmVuZGVyU1ZH Um9vdCYgcGFyZW50LCBSZW5kZXJPYmplY3QmIGNoaWxkKTsKKyAgICBSZW5kZXJQdHI8UmVuZGVy T2JqZWN0PiBkZXRhY2goUmVuZGVyU1ZHVGV4dCYgcGFyZW50LCBSZW5kZXJPYmplY3QmIGNoaWxk KSBXQVJOX1VOVVNFRF9SRVRVUk47CisgICAgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gZGV0YWNo KFJlbmRlclNWR0lubGluZSYgcGFyZW50LCBSZW5kZXJPYmplY3QmIGNoaWxkKSBXQVJOX1VOVVNF RF9SRVRVUk47CisgICAgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gZGV0YWNoKFJlbmRlclNWR0Nv bnRhaW5lciYgcGFyZW50LCBSZW5kZXJPYmplY3QmIGNoaWxkKSBXQVJOX1VOVVNFRF9SRVRVUk47 CisgICAgUmVuZGVyUHRyPFJlbmRlck9iamVjdD4gZGV0YWNoKFJlbmRlclNWR1Jvb3QmIHBhcmVu dCwgUmVuZGVyT2JqZWN0JiBjaGlsZCkgV0FSTl9VTlVTRURfUkVUVVJOOwogCiBwcml2YXRlOgog ICAgIFJlbmRlclRyZWVCdWlsZGVyJiBtX2J1aWxkZXI7Cg==