183068 2018-02-22 16:39:16 -0800 Caches::m_storage should be set to null in case of error at initialization time 2018-02-26 16:04:12 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183062 InRadar P2 Normal --- 1 youennf youennf achristensen cdumez cgarcia commit-queue ews-watchlist rniwa webkit-bug-importer oldest_to_newest 1401595 0 youennf 2018-02-22 16:39:16 -0800 Not doing so will make next initialize requests be appended to the queue and never called. 1401598 1 334484 youennf 2018-02-22 16:47:49 -0800 Created attachment 334484 Patch 1401599 2 youennf 2018-02-22 16:48:11 -0800 This complements https://bugs.webkit.org/show_bug.cgi?id=183062. Tested locally by hammering the WPT service worker tests, I no longer see Cache Storage related time outs. 1401601 3 youennf 2018-02-22 16:49:05 -0800 <rdar://problem/37803485> 1402215 4 334484 commit-queue 2018-02-26 16:04:11 -0800 Comment on attachment 334484 Patch Clearing flags on attachment: 334484 Committed r229045: <https://trac.webkit.org/changeset/229045> 1402216 5 commit-queue 2018-02-26 16:04:12 -0800 All reviewed patches have been landed. Closing bug. 334484 2018-02-22 16:47:49 -0800 2018-02-26 16:04:11 -0800 Patch bug-183068-20180222164749.patch text/plain 2413 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUzZTA2YTAxZDk0N2FhNzEz N2E5MjQ4NTRlODljN2JkMjNkMzVkNGMuLmY3YzRiMDE2MzFiNTdmNDZmYmYwNjdkNjExNWJkYWZk MTM1YzhkZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDItMjIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENhY2hlczo6bV9zdG9yYWdlIHNo b3VsZCBiZSBzZXQgdG8gbnVsbCBpbiBjYXNlIG9mIGVycm9yIGF0IGluaXRpYWxpemF0aW9uIHRp bWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzA2 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGNh c2Ugb2YgZXJyb3IsIHdlIG5lZWQgdG8gc2V0IG1fc3RvcmFnZSBiYWNrIHRvIG51bGxwdHIgc28g dGhhdAorICAgICAgICBuZXh0IHRyaWVzIHRvIGluaXRpYWxpemUgaXQgd2lsbCByZXN0YXJ0IGZy b20gc2NyYXRjaC4KKyAgICAgICAgSWYgd2UgZG8gbm90IHNldCBpdCB0byBudWxscHRyLCB3ZSBl bmQgdXAgc3RvcmluZyB0aGUgaW5pdGlhbGl6ZQorICAgICAgICBjYWxsYmFjayBpbiBhIHF1ZXVl IGFuZCB0aGUgY2FsbGJhY2sgd2lsbCBuZXZlciBiZSBjYWxsZWQuCisKKyAgICAgICAgVGhpcyBp cyBkaWZmaWN1bHQgdG8gdGVzdCBhcyB3ZSBuZWVkIHRoZSBmb2xsb3dpbmcgY29uZGl0aW9uczoK KyAgICAgICAgLSB3ZSBuZWVkIHRvIGhhdmUgYW4gZXJyb3IgY2FzZSwgbGlrZSBhIGRpc2sgd3Jp dGluZyBlcnJvcgorICAgICAgICAtIHdlIG5lZWQgdGhlIHdlYiBhcHAgdG8gb3BlbiBhIGNhY2hl IGluIHR3byBkaWZmZXJlbnQgcGFnZXMvZnJhbWVzIGF0IGFib3V0IHRoZSBzYW1lIHRpbWUuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMu Y3BwOgorICAgICAgICAoV2ViS2l0OjpDYWNoZVN0b3JhZ2U6OkNhY2hlczo6aW5pdGlhbGl6ZSk6 CisKIDIwMTgtMDItMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCByZWxlYXNlIGFzc2VydHMgZm9yIHNlcnZpY2Ugd29ya2VyIGZldGNoIGFuZCBwb3N0 TWVzc2FnZSBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVzLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVzLmNwcAppbmRleCBkNDQzNDAw ODhkYTg0NjZiZTI0YTE5NGY1NTljZGY0MGFjZjdiOTA4Li42MWJhNGU2N2U4MTE0MmNlNjE3NWU0 NTkxNmNjM2VkNTM4MGUzMzUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hlcy5jcHAKKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3BwCkBAIC0x NTQsNiArMTU0LDggQEAgdm9pZCBDYWNoZXM6OmluaXRpYWxpemUoV2ViQ29yZTo6RE9NQ2FjaGVF bmdpbmU6OkNvbXBsZXRpb25DYWxsYmFjayYmIGNhbGxiYWNrKQogICAgICAgICAgICAgYXV0byBw ZW5kaW5nQ2FsbGJhY2tzID0gV1RGTW92ZShtX3BlbmRpbmdJbml0aWFsaXphdGlvbkNhbGxiYWNr cyk7CiAgICAgICAgICAgICBmb3IgKGF1dG8mIGNhbGxiYWNrIDogcGVuZGluZ0NhbGxiYWNrcykK ICAgICAgICAgICAgICAgICBjYWxsYmFjayhFcnJvcjo6V3JpdGVEaXNrKTsKKworICAgICAgICAg ICAgbV9zdG9yYWdlID0gbnVsbHB0cjsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQog CkBAIC0xNjYsNiArMTY4LDggQEAgdm9pZCBDYWNoZXM6OmluaXRpYWxpemUoV2ViQ29yZTo6RE9N Q2FjaGVFbmdpbmU6OkNvbXBsZXRpb25DYWxsYmFjayYmIGNhbGxiYWNrKQogICAgICAgICAgICAg ICAgIGF1dG8gcGVuZGluZ0NhbGxiYWNrcyA9IFdURk1vdmUobV9wZW5kaW5nSW5pdGlhbGl6YXRp b25DYWxsYmFja3MpOwogICAgICAgICAgICAgICAgIGZvciAoYXV0byYgY2FsbGJhY2sgOiBwZW5k aW5nQ2FsbGJhY2tzKQogICAgICAgICAgICAgICAgICAgICBjYWxsYmFjayhyZXN1bHQuZXJyb3Io KSk7CisKKyAgICAgICAgICAgICAgICBtX3N0b3JhZ2UgPSBudWxscHRyOwogICAgICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIG1fY2FjaGVzID0gV1RGTW92 ZShyZXN1bHQudmFsdWUoKSk7Cg==