183062 2018-02-22 13:54:33 -0800 Caches::initialize should call all pending initialization callbacks in case of error 2018-02-22 16:48:23 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183068 InRadar P2 Normal --- 1 youennf youennf achristensen cdumez cgarcia commit-queue ews-watchlist rniwa webkit-bug-importer oldest_to_newest 1401542 0 youennf 2018-02-22 13:54:33 -0800 Currently, it is only doing so for the first callback 1401545 1 334476 youennf 2018-02-22 13:58:40 -0800 Created attachment 334476 Patch 1401546 2 334477 youennf 2018-02-22 13:59:41 -0800 Created attachment 334477 Patch 1401547 3 334478 youennf 2018-02-22 14:01:00 -0800 Created attachment 334478 Patch 1401565 4 334478 commit-queue 2018-02-22 14:53:46 -0800 Comment on attachment 334478 Patch Clearing flags on attachment: 334478 Committed r228936: <https://trac.webkit.org/changeset/228936> 1401566 5 commit-queue 2018-02-22 14:53:47 -0800 All reviewed patches have been landed. Closing bug. 1401567 6 webkit-bug-importer 2018-02-22 14:54:41 -0800 <rdar://problem/37803485> 1401589 7 rniwa 2018-02-22 16:17:51 -0800 Why didn't this patch have tests? 1401590 8 youennf 2018-02-22 16:21:35 -0800 (In reply to Ryosuke Niwa from comment #7) > Why didn't this patch have tests? These errors typically happen when there is a failure to read or write from disk. We do not have a way to emulate or trigger these errors. In addition, this is time sensitive since the app needs to try opening the same Caches twice from different frames/tabs at the same time to face that issue. 334476 2018-02-22 13:58:40 -0800 2018-02-22 13:59:40 -0800 Patch bug-183062-20180222135839.patch text/plain 1988 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlOGE5MTcwMGViMTU1NDY4 OWQ5Zjc5YjNhZDA5MmFjZmI0ZGEyOGUuLjA1ZTQxMzgxZjFiZjNjOTQwOTk5MzlmNjIxODM2NmJl YWE5NTJmMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDItMjIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENhY2hlczo6aW5pdGlhbGl6ZVNp emUgc2hvdWxkIGNhbGwgYWxsIHBlbmRpbmcgaW5pdGlhbGl6YXRpb24gY2FsbGJhY2tzIGluIGNh c2UgbV9zdG9yYWdlIGlzIG51bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4MzA2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2Fj aGVzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2FjaGVTdG9yYWdlOjpDYWNoZXM6OmluaXRpYWxp emUpOgorCiAyMDE4LTAyLTIyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAog ICAgICAgICBDYWNoZVN0b3JhZ2U6OkVuZ2luZTo6Q2FjaGVzOjp3cml0ZVJlY29yZCBpcyBub3Qg YWx3YXlzIGNhbGxpbmcgdGhlIGNvbXBsZXRpb24gaGFuZGxlcgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3Bw IGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVD YWNoZXMuY3BwCmluZGV4IDMzODE4ZDY4NGNmMGE2NDdmYmZiZjc3Y2RlNzYyNDA3NzU4ZDA1OWQu LmQ0NDM0MDA4OGRhODQ2NmJlMjRhMTk0ZjU1OWNkZjQwYWNmN2I5MDggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVz LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFn ZUVuZ2luZUNhY2hlcy5jcHAKQEAgLTE1MCw2ICsxNTAsMTAgQEAgdm9pZCBDYWNoZXM6OmluaXRp YWxpemUoV2ViQ29yZTo6RE9NQ2FjaGVFbmdpbmU6OkNvbXBsZXRpb25DYWxsYmFjayYmIGNhbGxi YWNrKQogICAgIHN0b3JlT3JpZ2luKFt0aGlzLCBjYWxsYmFjayA9IFdURk1vdmUoY2FsbGJhY2sp XSAoc3RkOjpvcHRpb25hbDxFcnJvcj4mJiBlcnJvcikgbXV0YWJsZSB7CiAgICAgICAgIGlmIChl cnJvcikgewogICAgICAgICAgICAgY2FsbGJhY2soRXJyb3I6OldyaXRlRGlzayk7CisKKyAgICAg ICAgICAgIGF1dG8gcGVuZGluZ0NhbGxiYWNrcyA9IFdURk1vdmUobV9wZW5kaW5nSW5pdGlhbGl6 YXRpb25DYWxsYmFja3MpOworICAgICAgICAgICAgZm9yIChhdXRvJiBjYWxsYmFjayA6IHBlbmRp bmdDYWxsYmFja3MpCisgICAgICAgICAgICAgICAgY2FsbGJhY2soRXJyb3I6OldyaXRlRGlzayk7 CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApAQCAtMTc1LDYgKzE3OSwxMCBAQCB2 b2lkIENhY2hlczo6aW5pdGlhbGl6ZVNpemUoV2ViQ29yZTo6RE9NQ2FjaGVFbmdpbmU6OkNvbXBs ZXRpb25DYWxsYmFjayYmIGNhbGxiYQogewogICAgIGlmICghbV9zdG9yYWdlKSB7CiAgICAgICAg IGNhbGxiYWNrKEVycm9yOjpJbnRlcm5hbCk7CisKKyAgICAgICAgYXV0byBwZW5kaW5nQ2FsbGJh Y2tzID0gV1RGTW92ZShtX3BlbmRpbmdJbml0aWFsaXphdGlvbkNhbGxiYWNrcyk7CisgICAgICAg IGZvciAoYXV0byYgY2FsbGJhY2sgOiBwZW5kaW5nQ2FsbGJhY2tzKQorICAgICAgICAgICAgY2Fs bGJhY2soRXJyb3I6OkludGVybmFsKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo= 334477 2018-02-22 13:59:41 -0800 2018-02-22 14:00:58 -0800 Patch bug-183062-20180222135941.patch text/plain 2041 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlOGE5MTcwMGViMTU1NDY4 OWQ5Zjc5YjNhZDA5MmFjZmI0ZGEyOGUuLmMwNGU2MDFiM2UyYmNkYmFjNmUyMjhmNzAxMDk5ZTFj OTRiMTdjMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDItMjIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENhY2hlczo6aW5pdGlhbGl6ZSBz aG91bGQgY2FsbCBhbGwgcGVuZGluZyBpbml0aWFsaXphdGlvbiBjYWxsYmFja3MgaW4gY2FzZSBt X3N0b3JhZ2UgaXMgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTgzMDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMu Y3BwOgorICAgICAgICAoV2ViS2l0OjpDYWNoZVN0b3JhZ2U6OkNhY2hlczo6aW5pdGlhbGl6ZSk6 CisgICAgICAgIChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6Q2FjaGVzOjppbml0aWFsaXplU2l6ZSk6 CisKIDIwMTgtMDItMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIENhY2hlU3RvcmFnZTo6RW5naW5lOjpDYWNoZXM6OndyaXRlUmVjb3JkIGlzIG5vdCBhbHdh eXMgY2FsbGluZyB0aGUgY29tcGxldGlvbiBoYW5kbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hlcy5jcHAgYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hl cy5jcHAKaW5kZXggMzM4MThkNjg0Y2YwYTY0N2ZiZmJmNzdjZGU3NjI0MDc3NThkMDU5ZC4uZDQ0 MzQwMDg4ZGE4NDY2YmUyNGExOTRmNTU5Y2RmNDBhY2Y3YjkwOCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5n aW5lQ2FjaGVzLmNwcApAQCAtMTUwLDYgKzE1MCwxMCBAQCB2b2lkIENhY2hlczo6aW5pdGlhbGl6 ZShXZWJDb3JlOjpET01DYWNoZUVuZ2luZTo6Q29tcGxldGlvbkNhbGxiYWNrJiYgY2FsbGJhY2sp CiAgICAgc3RvcmVPcmlnaW4oW3RoaXMsIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldIChz dGQ6Om9wdGlvbmFsPEVycm9yPiYmIGVycm9yKSBtdXRhYmxlIHsKICAgICAgICAgaWYgKGVycm9y KSB7CiAgICAgICAgICAgICBjYWxsYmFjayhFcnJvcjo6V3JpdGVEaXNrKTsKKworICAgICAgICAg ICAgYXV0byBwZW5kaW5nQ2FsbGJhY2tzID0gV1RGTW92ZShtX3BlbmRpbmdJbml0aWFsaXphdGlv bkNhbGxiYWNrcyk7CisgICAgICAgICAgICBmb3IgKGF1dG8mIGNhbGxiYWNrIDogcGVuZGluZ0Nh bGxiYWNrcykKKyAgICAgICAgICAgICAgICBjYWxsYmFjayhFcnJvcjo6V3JpdGVEaXNrKTsKICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCkBAIC0xNzUsNiArMTc5LDEwIEBAIHZvaWQg Q2FjaGVzOjppbml0aWFsaXplU2l6ZShXZWJDb3JlOjpET01DYWNoZUVuZ2luZTo6Q29tcGxldGlv bkNhbGxiYWNrJiYgY2FsbGJhCiB7CiAgICAgaWYgKCFtX3N0b3JhZ2UpIHsKICAgICAgICAgY2Fs bGJhY2soRXJyb3I6OkludGVybmFsKTsKKworICAgICAgICBhdXRvIHBlbmRpbmdDYWxsYmFja3Mg PSBXVEZNb3ZlKG1fcGVuZGluZ0luaXRpYWxpemF0aW9uQ2FsbGJhY2tzKTsKKyAgICAgICAgZm9y IChhdXRvJiBjYWxsYmFjayA6IHBlbmRpbmdDYWxsYmFja3MpCisgICAgICAgICAgICBjYWxsYmFj ayhFcnJvcjo6SW50ZXJuYWwpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCg== 334478 2018-02-22 14:01:00 -0800 2018-02-22 14:53:46 -0800 Patch bug-183062-20180222140059.patch text/plain 2032 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4ODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlOGE5MTcwMGViMTU1NDY4 OWQ5Zjc5YjNhZDA5MmFjZmI0ZGEyOGUuLjc5YTAyNTJkYWYzZmQ0MGYwYzdiMDM0ZDcwZjRkZTEz NzdiY2I0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDItMjIgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIENhY2hlczo6aW5pdGlhbGl6ZSBz aG91bGQgY2FsbCBhbGwgcGVuZGluZyBpbml0aWFsaXphdGlvbiBjYWxsYmFja3MgaW4gY2FzZSBv ZiBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTgzMDYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3BwOgorICAg ICAgICAoV2ViS2l0OjpDYWNoZVN0b3JhZ2U6OkNhY2hlczo6aW5pdGlhbGl6ZSk6CisgICAgICAg IChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6Q2FjaGVzOjppbml0aWFsaXplU2l6ZSk6CisKIDIwMTgt MDItMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIENhY2hl U3RvcmFnZTo6RW5naW5lOjpDYWNoZXM6OndyaXRlUmVjb3JkIGlzIG5vdCBhbHdheXMgY2FsbGlu ZyB0aGUgY29tcGxldGlvbiBoYW5kbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hlcy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hlcy5jcHAKaW5k ZXggMzM4MThkNjg0Y2YwYTY0N2ZiZmJmNzdjZGU3NjI0MDc3NThkMDU5ZC4uZDQ0MzQwMDg4ZGE4 NDY2YmUyNGExOTRmNTU5Y2RmNDBhY2Y3YjkwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVz LmNwcApAQCAtMTUwLDYgKzE1MCwxMCBAQCB2b2lkIENhY2hlczo6aW5pdGlhbGl6ZShXZWJDb3Jl OjpET01DYWNoZUVuZ2luZTo6Q29tcGxldGlvbkNhbGxiYWNrJiYgY2FsbGJhY2spCiAgICAgc3Rv cmVPcmlnaW4oW3RoaXMsIGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldIChzdGQ6Om9wdGlv bmFsPEVycm9yPiYmIGVycm9yKSBtdXRhYmxlIHsKICAgICAgICAgaWYgKGVycm9yKSB7CiAgICAg ICAgICAgICBjYWxsYmFjayhFcnJvcjo6V3JpdGVEaXNrKTsKKworICAgICAgICAgICAgYXV0byBw ZW5kaW5nQ2FsbGJhY2tzID0gV1RGTW92ZShtX3BlbmRpbmdJbml0aWFsaXphdGlvbkNhbGxiYWNr cyk7CisgICAgICAgICAgICBmb3IgKGF1dG8mIGNhbGxiYWNrIDogcGVuZGluZ0NhbGxiYWNrcykK KyAgICAgICAgICAgICAgICBjYWxsYmFjayhFcnJvcjo6V3JpdGVEaXNrKTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQogCkBAIC0xNzUsNiArMTc5LDEwIEBAIHZvaWQgQ2FjaGVzOjpp bml0aWFsaXplU2l6ZShXZWJDb3JlOjpET01DYWNoZUVuZ2luZTo6Q29tcGxldGlvbkNhbGxiYWNr JiYgY2FsbGJhCiB7CiAgICAgaWYgKCFtX3N0b3JhZ2UpIHsKICAgICAgICAgY2FsbGJhY2soRXJy b3I6OkludGVybmFsKTsKKworICAgICAgICBhdXRvIHBlbmRpbmdDYWxsYmFja3MgPSBXVEZNb3Zl KG1fcGVuZGluZ0luaXRpYWxpemF0aW9uQ2FsbGJhY2tzKTsKKyAgICAgICAgZm9yIChhdXRvJiBj YWxsYmFjayA6IHBlbmRpbmdDYWxsYmFja3MpCisgICAgICAgICAgICBjYWxsYmFjayhFcnJvcjo6 SW50ZXJuYWwpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCg==