183050 2018-02-22 12:08:00 -0800 ServiceWorkerContainer::startScriptFetchForJob() fails to isolate copy the registrationKey before passing it to the main thread 2018-02-22 14:23:20 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson commit-queue rniwa webkit-bug-importer youennf oldest_to_newest 1401495 0 cdumez 2018-02-22 12:08:00 -0800 ServiceWorkerContainer::startScriptFetchForJob() fails to isolate copy the registrationKey before passing it to the main thread. 1401496 1 webkit-bug-importer 2018-02-22 12:08:32 -0800 <rdar://problem/37796881> 1401497 2 334462 cdumez 2018-02-22 12:11:30 -0800 Created attachment 334462 Patch 1401499 3 334463 cdumez 2018-02-22 12:14:11 -0800 Created attachment 334463 Patch 1401530 4 334463 cdumez 2018-02-22 13:40:48 -0800 Comment on attachment 334463 Patch Clearing flags on attachment: 334463 Committed r228931: <https://trac.webkit.org/changeset/228931> 1401531 5 cdumez 2018-02-22 13:40:49 -0800 All reviewed patches have been landed. Closing bug. 334462 2018-02-22 12:11:30 -0800 2018-02-22 12:14:10 -0800 Patch bug-183050-20180222121130.patch text/plain 2333 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUwODliYTcxNjE4ZDFj YzhhZDFjMGYzNGY2Njc0YmFiNmUzZjBiNy4uZTc4OWI4M2VjODJiYmY1MmNmMmU0Zjk3N2I3Yzc5 NDZhZWEzNmE0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTAyLTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlckNvbnRh aW5lcjo6c3RhcnRTY3JpcHRGZXRjaEZvckpvYigpIGZhaWxzIHRvIGlzb2xhdGUgY29weSB0aGUg cmVnaXN0cmF0aW9uS2V5IGJlZm9yZSBwYXNzaW5nIGl0IHRvIHRoZSBtYWluIHRocmVhZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMDUwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zNzc5Njg4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDcmVhdGUgYW4gaXNvbGF0ZWQgY29weSBvZiB0aGUgcmVn aXN0cmF0aW9uS2V5IGJlZm9yZSBwYXNzaW5nIGl0IHRvIHRoZSBtYWluIHRocmVhZCBpbgorICAg ICAgICBTZXJ2aWNlV29ya2VyQ29udGFpbmVyOjpzdGFydFNjcmlwdEZldGNoRm9ySm9iKCkuCisK KyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckNvbnRhaW5lci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTZXJ2aWNlV29ya2VyQ29udGFpbmVyOjpzdGFydFNjcmlwdEZldGNo Rm9ySm9iKToKKwogMjAxOC0wMi0yMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIFNlcnZpY2VXb3JrZXJDb250YWluZXI6OnNjaGVkdWxlSm9iKCkgZmFpbHMgdG8g aXNvbGF0ZSBjb3B5IHRoZSBqb2JEYXRhIGJlZm9yZSBwYXNzaW5nIGl0IHRvIHRoZSBtYWluIHRo cmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VX b3JrZXJDb250YWluZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZp Y2VXb3JrZXJDb250YWluZXIuY3BwCmluZGV4IDE5OWJlNDE3ZGRkYzA3YmExZTg3MGI3NWE2MWQ3 MmI0MGYwZTYyMjkuLjJlNmU5Y2RmM2E3Y2QxYTIzYjI2MWQwNmI2YzZlM2YwYWYyZDViYmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyQ29u dGFpbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdv cmtlckNvbnRhaW5lci5jcHAKQEAgLTQ4Nyw3ICs0ODcsNyBAQCB2b2lkIFNlcnZpY2VXb3JrZXJD b250YWluZXI6OnN0YXJ0U2NyaXB0RmV0Y2hGb3JKb2IoU2VydmljZVdvcmtlckpvYiYgam9iLCBG ZXRjaAogICAgIGF1dG8qIGNvbnRleHQgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7CiAgICAg aWYgKCFjb250ZXh0KSB7CiAgICAgICAgIExPR19FUlJPUigiU2VydmljZVdvcmtlckNvbnRhaW5l cjo6am9iUmVzb2x2ZWRXaXRoUmVnaXN0cmF0aW9uIGNhbGxlZCBidXQgdGhlIGNvbnRhaW5lcidz IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgaXMgZ29uZSIpOwotICAgICAgICBjYWxsT25NYWluVGhy ZWFkKFtjb25uZWN0aW9uID0gbV9zd0Nvbm5lY3Rpb24sIGpvYklkZW50aWZpZXIgPSBqb2IuaWRl bnRpZmllcigpLCByZWdpc3RyYXRpb25LZXkgPSBqb2IuZGF0YSgpLnJlZ2lzdHJhdGlvbktleSgp LCBzY3JpcHRVUkwgPSBqb2IuZGF0YSgpLnNjcmlwdFVSTC5pc29sYXRlZENvcHkoKV0geworICAg ICAgICBjYWxsT25NYWluVGhyZWFkKFtjb25uZWN0aW9uID0gbV9zd0Nvbm5lY3Rpb24sIGpvYklk ZW50aWZpZXIgPSBqb2IuaWRlbnRpZmllcigpLCByZWdpc3RyYXRpb25LZXkgPSBqb2IuZGF0YSgp LnJlZ2lzdHJhdGlvbktleSgpLmlzb2xhdGVkQ29weSgpLCBzY3JpcHRVUkwgPSBqb2IuZGF0YSgp LnNjcmlwdFVSTC5pc29sYXRlZENvcHkoKV0gewogICAgICAgICAgICAgY29ubmVjdGlvbi0+ZmFp bGVkRmV0Y2hpbmdTY3JpcHQoam9iSWRlbnRpZmllciwgcmVnaXN0cmF0aW9uS2V5LCB7IGVycm9y RG9tYWluV2ViS2l0SW50ZXJuYWwsIDAsIHNjcmlwdFVSTCwgQVNDSUlMaXRlcmFsKCJBdHRlbXB0 IHRvIGZldGNoIHNlcnZpY2Ugd29ya2VyIHNjcmlwdCB3aXRoIG5vIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQiKSB9KTsKICAgICAgICAgfSk7CiAgICAgICAgIGpvYkRpZEZpbmlzaChqb2IpOwo= 334463 2018-02-22 12:14:11 -0800 2018-02-22 13:40:48 -0800 Patch bug-183050-20180222121411.patch text/plain 4041 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUwODliYTcxNjE4ZDFj YzhhZDFjMGYzNGY2Njc0YmFiNmUzZjBiNy4uZjUzODk0NzU0YmVkZDEyODIzNjEzZjA4NjRhM2U3 MzU5MGJmNDZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTAyLTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlckNvbnRh aW5lcjo6c3RhcnRTY3JpcHRGZXRjaEZvckpvYigpIGZhaWxzIHRvIGlzb2xhdGUgY29weSB0aGUg cmVnaXN0cmF0aW9uS2V5IGJlZm9yZSBwYXNzaW5nIGl0IHRvIHRoZSBtYWluIHRocmVhZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMDUwCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zNzc5Njg4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDcmVhdGUgYW4gaXNvbGF0ZWQgY29weSBvZiB0aGUgcmVn aXN0cmF0aW9uS2V5IGJlZm9yZSBwYXNzaW5nIGl0IHRvIHRoZSBtYWluIHRocmVhZCBpbiBTZXJ2 aWNlV29ya2VyQ29udGFpbmVyJ3MKKyAgICAgICAgc3RhcnRTY3JpcHRGZXRjaEZvckpvYigpIC8g am9iRmluaXNoZWRMb2FkaW5nU2NyaXB0KCkgLyBqb2JGYWlsZWRMb2FkaW5nU2NyaXB0KCkuCisK KyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckNvbnRhaW5lci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTZXJ2aWNlV29ya2VyQ29udGFpbmVyOjpzdGFydFNjcmlwdEZldGNo Rm9ySm9iKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJDb250YWluZXI6OmpvYkZp bmlzaGVkTG9hZGluZ1NjcmlwdCk6CisgICAgICAgIChXZWJDb3JlOjpTZXJ2aWNlV29ya2VyQ29u dGFpbmVyOjpqb2JGYWlsZWRMb2FkaW5nU2NyaXB0KToKKwogMjAxOC0wMi0yMiAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFNlcnZpY2VXb3JrZXJDb250YWluZXI6 OnNjaGVkdWxlSm9iKCkgZmFpbHMgdG8gaXNvbGF0ZSBjb3B5IHRoZSBqb2JEYXRhIGJlZm9yZSBw YXNzaW5nIGl0IHRvIHRoZSBtYWluIHRocmVhZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJDb250YWluZXIuY3BwCmluZGV4IDE5OWJl NDE3ZGRkYzA3YmExZTg3MGI3NWE2MWQ3MmI0MGYwZTYyMjkuLjEwNzdhYTZmMzBmM2NkZTRlODI1 OTFkODFlZTE1MzcyOGRjYmUxY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv c2VydmljZS9TZXJ2aWNlV29ya2VyQ29udGFpbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlckNvbnRhaW5lci5jcHAKQEAgLTQ4Nyw3ICs0ODcs NyBAQCB2b2lkIFNlcnZpY2VXb3JrZXJDb250YWluZXI6OnN0YXJ0U2NyaXB0RmV0Y2hGb3JKb2Io U2VydmljZVdvcmtlckpvYiYgam9iLCBGZXRjaAogICAgIGF1dG8qIGNvbnRleHQgPSBzY3JpcHRF eGVjdXRpb25Db250ZXh0KCk7CiAgICAgaWYgKCFjb250ZXh0KSB7CiAgICAgICAgIExPR19FUlJP UigiU2VydmljZVdvcmtlckNvbnRhaW5lcjo6am9iUmVzb2x2ZWRXaXRoUmVnaXN0cmF0aW9uIGNh bGxlZCBidXQgdGhlIGNvbnRhaW5lcidzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgaXMgZ29uZSIp OwotICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtjb25uZWN0aW9uID0gbV9zd0Nvbm5lY3Rpb24s IGpvYklkZW50aWZpZXIgPSBqb2IuaWRlbnRpZmllcigpLCByZWdpc3RyYXRpb25LZXkgPSBqb2Iu ZGF0YSgpLnJlZ2lzdHJhdGlvbktleSgpLCBzY3JpcHRVUkwgPSBqb2IuZGF0YSgpLnNjcmlwdFVS TC5pc29sYXRlZENvcHkoKV0geworICAgICAgICBjYWxsT25NYWluVGhyZWFkKFtjb25uZWN0aW9u ID0gbV9zd0Nvbm5lY3Rpb24sIGpvYklkZW50aWZpZXIgPSBqb2IuaWRlbnRpZmllcigpLCByZWdp c3RyYXRpb25LZXkgPSBqb2IuZGF0YSgpLnJlZ2lzdHJhdGlvbktleSgpLmlzb2xhdGVkQ29weSgp LCBzY3JpcHRVUkwgPSBqb2IuZGF0YSgpLnNjcmlwdFVSTC5pc29sYXRlZENvcHkoKV0gewogICAg ICAgICAgICAgY29ubmVjdGlvbi0+ZmFpbGVkRmV0Y2hpbmdTY3JpcHQoam9iSWRlbnRpZmllciwg cmVnaXN0cmF0aW9uS2V5LCB7IGVycm9yRG9tYWluV2ViS2l0SW50ZXJuYWwsIDAsIHNjcmlwdFVS TCwgQVNDSUlMaXRlcmFsKCJBdHRlbXB0IHRvIGZldGNoIHNlcnZpY2Ugd29ya2VyIHNjcmlwdCB3 aXRoIG5vIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQiKSB9KTsKICAgICAgICAgfSk7CiAgICAgICAg IGpvYkRpZEZpbmlzaChqb2IpOwpAQCAtNTA1LDcgKzUwNSw3IEBAIHZvaWQgU2VydmljZVdvcmtl ckNvbnRhaW5lcjo6am9iRmluaXNoZWRMb2FkaW5nU2NyaXB0KFNlcnZpY2VXb3JrZXJKb2ImIGpv YiwgY29uCiAKICAgICBDT05UQUlORVJfUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiam9iRmluaXNo ZWRMb2FkaW5nU2NyaXB0OiBTdWNjZXNzZnVseSBmaW5pc2hlZCBmZXRjaGluZyBzY3JpcHQgZm9y IGpvYiAlbGx1Iiwgam9iLmlkZW50aWZpZXIoKS50b1VJbnQ2NCgpKTsKIAotICAgIGNhbGxPbk1h aW5UaHJlYWQoW2Nvbm5lY3Rpb24gPSBtX3N3Q29ubmVjdGlvbiwgam9iRGF0YUlkZW50aWZpZXIg PSBqb2IuZGF0YSgpLmlkZW50aWZpZXIoKSwgcmVnaXN0cmF0aW9uS2V5ID0gam9iLmRhdGEoKS5y ZWdpc3RyYXRpb25LZXkoKSwgc2NyaXB0ID0gc2NyaXB0Lmlzb2xhdGVkQ29weSgpLCBjb250ZW50 U2VjdXJpdHlQb2xpY3kgPSBjb250ZW50U2VjdXJpdHlQb2xpY3kuaXNvbGF0ZWRDb3B5KCldIHsK KyAgICBjYWxsT25NYWluVGhyZWFkKFtjb25uZWN0aW9uID0gbV9zd0Nvbm5lY3Rpb24sIGpvYkRh dGFJZGVudGlmaWVyID0gam9iLmRhdGEoKS5pZGVudGlmaWVyKCksIHJlZ2lzdHJhdGlvbktleSA9 IGpvYi5kYXRhKCkucmVnaXN0cmF0aW9uS2V5KCkuaXNvbGF0ZWRDb3B5KCksIHNjcmlwdCA9IHNj cmlwdC5pc29sYXRlZENvcHkoKSwgY29udGVudFNlY3VyaXR5UG9saWN5ID0gY29udGVudFNlY3Vy aXR5UG9saWN5Lmlzb2xhdGVkQ29weSgpXSB7CiAgICAgICAgIGNvbm5lY3Rpb24tPmZpbmlzaEZl dGNoaW5nU2NyaXB0SW5TZXJ2ZXIoeyBqb2JEYXRhSWRlbnRpZmllciwgcmVnaXN0cmF0aW9uS2V5 LCBzY3JpcHQsIGNvbnRlbnRTZWN1cml0eVBvbGljeSwgeyB9IH0pOwogICAgIH0pOwogfQpAQCAt NTIyLDcgKzUyMiw3IEBAIHZvaWQgU2VydmljZVdvcmtlckNvbnRhaW5lcjo6am9iRmFpbGVkTG9h ZGluZ1NjcmlwdChTZXJ2aWNlV29ya2VySm9iJiBqb2IsIGNvbnN0CiAgICAgaWYgKGV4Y2VwdGlv biAmJiBqb2IucHJvbWlzZSgpKQogICAgICAgICBqb2IucHJvbWlzZSgpLT5yZWplY3QoKmV4Y2Vw dGlvbik7CiAKLSAgICBjYWxsT25NYWluVGhyZWFkKFtjb25uZWN0aW9uID0gbV9zd0Nvbm5lY3Rp b24sIGpvYklkZW50aWZpZXIgPSBqb2IuaWRlbnRpZmllcigpLCByZWdpc3RyYXRpb25LZXkgPSBq b2IuZGF0YSgpLnJlZ2lzdHJhdGlvbktleSgpLCBlcnJvciA9IGVycm9yLmlzb2xhdGVkQ29weSgp XSB7CisgICAgY2FsbE9uTWFpblRocmVhZChbY29ubmVjdGlvbiA9IG1fc3dDb25uZWN0aW9uLCBq b2JJZGVudGlmaWVyID0gam9iLmlkZW50aWZpZXIoKSwgcmVnaXN0cmF0aW9uS2V5ID0gam9iLmRh dGEoKS5yZWdpc3RyYXRpb25LZXkoKS5pc29sYXRlZENvcHkoKSwgZXJyb3IgPSBlcnJvci5pc29s YXRlZENvcHkoKV0gewogICAgICAgICBjb25uZWN0aW9uLT5mYWlsZWRGZXRjaGluZ1NjcmlwdChq b2JJZGVudGlmaWVyLCByZWdpc3RyYXRpb25LZXksIGVycm9yKTsKICAgICB9KTsKIH0K